* [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info
@ 2017-02-14 14:48 Vladimir Sementsov-Ogievskiy
2017-02-14 15:05 ` Fam Zheng
2017-02-14 17:18 ` [Qemu-devel] " John Snow
0 siblings, 2 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2017-02-14 14:48 UTC (permalink / raw)
To: qemu-block, qemu-devel
Cc: mreitz, kwolf, jcody, jsnow, famz, den, vsementsov, stefanha
Currently backup to nbd target is broken, as nbd doesn't have
.bdrv_get_info realization.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
Hi all!
Since commit
commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
Author: John Snow <jsnow@redhat.com>
Date: Thu Feb 25 15:58:30 2016 -0500
block/backup: avoid copying less than full target clusters
backup to nbd target is broken, we have "Couldn't determine the cluster size of
the target image".
Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
But until it is not realized, we need allow backup to nbd target due to backward
compatibility.
Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
Which behavior should be default: to fail backup or to use default cluster size?
block/backup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index ea38733..095a390 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -638,7 +638,10 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
* backup cluster size is smaller than the target cluster size. Even for
* targets with a backing file, try to avoid COW if possible. */
ret = bdrv_get_info(target, &bdi);
- if (ret < 0 && !target->backing) {
+ if (ret == -ENOTSUP) {
+ /* Cluster size is not defined */
+ job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
+ } else if (ret < 0 && !target->backing) {
error_setg_errno(errp, -ret,
"Couldn't determine the cluster size of the target image, "
"which has no backing file");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info
2017-02-14 14:48 [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
@ 2017-02-14 15:05 ` Fam Zheng
2017-02-14 15:08 ` Denis V. Lunev
2017-02-14 19:35 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-02-14 17:18 ` [Qemu-devel] " John Snow
1 sibling, 2 replies; 5+ messages in thread
From: Fam Zheng @ 2017-02-14 15:05 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-block, qemu-devel, mreitz, kwolf, jcody, jsnow, den, stefanha
On Tue, 02/14 17:48, Vladimir Sementsov-Ogievskiy wrote:
> Currently backup to nbd target is broken, as nbd doesn't have
> .bdrv_get_info realization.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hi all!
>
> Since commit
>
> commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
> Author: John Snow <jsnow@redhat.com>
> Date: Thu Feb 25 15:58:30 2016 -0500
>
> block/backup: avoid copying less than full target clusters
>
> backup to nbd target is broken, we have "Couldn't determine the cluster size of
> the target image".
>
> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
> But until it is not realized, we need allow backup to nbd target due to backward
> compatibility.
>
> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
> Which behavior should be default: to fail backup or to use default cluster size?
>
> block/backup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/block/backup.c b/block/backup.c
> index ea38733..095a390 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -638,7 +638,10 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
> * backup cluster size is smaller than the target cluster size. Even for
> * targets with a backing file, try to avoid COW if possible. */
> ret = bdrv_get_info(target, &bdi);
> - if (ret < 0 && !target->backing) {
> + if (ret == -ENOTSUP) {
> + /* Cluster size is not defined */
> + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
> + } else if (ret < 0 && !target->backing) {
> error_setg_errno(errp, -ret,
> "Couldn't determine the cluster size of the target image, "
> "which has no backing file");
> --
> 1.8.3.1
>
Target not having .bdrv_get_info means 'some sane assumptions are okay' to me, so
Reviewed-by: Fam Zheng <famz@redhat.com>
(But we are going to have a .bdrv_get_info after NBD_OPT_INFO, right?)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info
2017-02-14 15:05 ` Fam Zheng
@ 2017-02-14 15:08 ` Denis V. Lunev
2017-02-14 19:35 ` [Qemu-devel] [Qemu-block] " Eric Blake
1 sibling, 0 replies; 5+ messages in thread
From: Denis V. Lunev @ 2017-02-14 15:08 UTC (permalink / raw)
To: Fam Zheng, Vladimir Sementsov-Ogievskiy
Cc: qemu-block, qemu-devel, mreitz, kwolf, jcody, jsnow, stefanha
On 02/14/2017 06:05 PM, Fam Zheng wrote:
> On Tue, 02/14 17:48, Vladimir Sementsov-Ogievskiy wrote:
>> Currently backup to nbd target is broken, as nbd doesn't have
>> .bdrv_get_info realization.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>
>> Hi all!
>>
>> Since commit
>>
>> commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
>> Author: John Snow <jsnow@redhat.com>
>> Date: Thu Feb 25 15:58:30 2016 -0500
>>
>> block/backup: avoid copying less than full target clusters
>>
>> backup to nbd target is broken, we have "Couldn't determine the cluster size of
>> the target image".
>>
>> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
>> But until it is not realized, we need allow backup to nbd target due to backward
>> compatibility.
>>
>> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
>> Which behavior should be default: to fail backup or to use default cluster size?
>>
>> block/backup.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/backup.c b/block/backup.c
>> index ea38733..095a390 100644
>> --- a/block/backup.c
>> +++ b/block/backup.c
>> @@ -638,7 +638,10 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
>> * backup cluster size is smaller than the target cluster size. Even for
>> * targets with a backing file, try to avoid COW if possible. */
>> ret = bdrv_get_info(target, &bdi);
>> - if (ret < 0 && !target->backing) {
>> + if (ret == -ENOTSUP) {
>> + /* Cluster size is not defined */
>> + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
>> + } else if (ret < 0 && !target->backing) {
>> error_setg_errno(errp, -ret,
>> "Couldn't determine the cluster size of the target image, "
>> "which has no backing file");
>> --
>> 1.8.3.1
>>
> Target not having .bdrv_get_info means 'some sane assumptions are okay' to me, so
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
>
> (But we are going to have a .bdrv_get_info after NBD_OPT_INFO, right?)
>
yes, sooner or later :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info
2017-02-14 14:48 [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
2017-02-14 15:05 ` Fam Zheng
@ 2017-02-14 17:18 ` John Snow
1 sibling, 0 replies; 5+ messages in thread
From: John Snow @ 2017-02-14 17:18 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-block, qemu-devel
Cc: kwolf, famz, jcody, mreitz, stefanha, den
On 02/14/2017 09:48 AM, Vladimir Sementsov-Ogievskiy wrote:
> Currently backup to nbd target is broken, as nbd doesn't have
> .bdrv_get_info realization.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hi all!
>
> Since commit
>
> commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
> Author: John Snow <jsnow@redhat.com>
> Date: Thu Feb 25 15:58:30 2016 -0500
>
> block/backup: avoid copying less than full target clusters
>
Tch.
> backup to nbd target is broken, we have "Couldn't determine the cluster size of
> the target image".
>
> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
> But until it is not realized, we need allow backup to nbd target due to backward
> compatibility.
>
> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
> Which behavior should be default: to fail backup or to use default cluster size?
>
> block/backup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/block/backup.c b/block/backup.c
> index ea38733..095a390 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -638,7 +638,10 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
> * backup cluster size is smaller than the target cluster size. Even for
> * targets with a backing file, try to avoid COW if possible. */
> ret = bdrv_get_info(target, &bdi);
> - if (ret < 0 && !target->backing) {
> + if (ret == -ENOTSUP) {
> + /* Cluster size is not defined */
> + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
I realize this is necessary for backwards compatibility, but perhaps we
need a warning message that explains why this backup *may* not be usable
in the incremental/top cases.
(I think none/full should be ok?)
> + } else if (ret < 0 && !target->backing) {
> error_setg_errno(errp, -ret,
> "Couldn't determine the cluster size of the target image, "
> "which has no backing file");
>
--
—js
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] backup: allow target without .bdrv_get_info
2017-02-14 15:05 ` Fam Zheng
2017-02-14 15:08 ` Denis V. Lunev
@ 2017-02-14 19:35 ` Eric Blake
1 sibling, 0 replies; 5+ messages in thread
From: Eric Blake @ 2017-02-14 19:35 UTC (permalink / raw)
To: Fam Zheng, Vladimir Sementsov-Ogievskiy
Cc: kwolf, qemu-block, qemu-devel, mreitz, stefanha, den
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 02/14/2017 09:05 AM, Fam Zheng wrote:
>> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
>> But until it is not realized, we need allow backup to nbd target due to backward
>> compatibility.
>>
>> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
>> Which behavior should be default: to fail backup or to use default cluster size?
>>
>
> Target not having .bdrv_get_info means 'some sane assumptions are okay' to me, so
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
>
> (But we are going to have a .bdrv_get_info after NBD_OPT_INFO, right?)
Yes. I'm reposting that series today.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-14 19:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 14:48 [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
2017-02-14 15:05 ` Fam Zheng
2017-02-14 15:08 ` Denis V. Lunev
2017-02-14 19:35 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-02-14 17:18 ` [Qemu-devel] " John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.