All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: c8sectpfe: no need to check return value of debugfs_create functions
@ 2019-11-07  8:52 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-07  8:52 UTC (permalink / raw)
  To: Patrice Chotard, Mauro Carvalho Chehab
  Cc: linux-arm-kernel, linux-media, linux-kernel

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 .../sti/c8sectpfe/c8sectpfe-debugfs.c         | 26 +++----------------
 1 file changed, 3 insertions(+), 23 deletions(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
index 8f0ddcbeed9d..301fa10f419b 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
@@ -225,36 +225,16 @@ static const struct debugfs_reg32 fei_sys_regs[] = {
 
 void c8sectpfe_debugfs_init(struct c8sectpfei *fei)
 {
-	struct dentry		*root;
-	struct dentry		*file;
-
-	root = debugfs_create_dir("c8sectpfe", NULL);
-	if (!root)
-		goto err;
-
-	fei->root = root;
-
 	fei->regset =  devm_kzalloc(fei->dev, sizeof(*fei->regset), GFP_KERNEL);
 	if (!fei->regset)
-		goto err;
+		return;
 
 	fei->regset->regs = fei_sys_regs;
 	fei->regset->nregs = ARRAY_SIZE(fei_sys_regs);
 	fei->regset->base = fei->io;
 
-	file = debugfs_create_regset32("registers", S_IRUGO, root,
-				fei->regset);
-	if (!file) {
-		dev_err(fei->dev,
-			"%s not able to create 'registers' debugfs\n"
-			, __func__);
-		goto err;
-	}
-
-	return;
-
-err:
-	debugfs_remove_recursive(root);
+	fei->root = debugfs_create_dir("c8sectpfe", NULL);
+	debugfs_create_regset32("registers", S_IRUGO, fei->root, fei->regset);
 }
 
 void c8sectpfe_debugfs_exit(struct c8sectpfei *fei)
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] media: c8sectpfe: no need to check return value of debugfs_create functions
@ 2019-11-07  8:52 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-07  8:52 UTC (permalink / raw)
  To: Patrice Chotard, Mauro Carvalho Chehab
  Cc: linux-kernel, linux-arm-kernel, linux-media

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 .../sti/c8sectpfe/c8sectpfe-debugfs.c         | 26 +++----------------
 1 file changed, 3 insertions(+), 23 deletions(-)

diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
index 8f0ddcbeed9d..301fa10f419b 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
@@ -225,36 +225,16 @@ static const struct debugfs_reg32 fei_sys_regs[] = {
 
 void c8sectpfe_debugfs_init(struct c8sectpfei *fei)
 {
-	struct dentry		*root;
-	struct dentry		*file;
-
-	root = debugfs_create_dir("c8sectpfe", NULL);
-	if (!root)
-		goto err;
-
-	fei->root = root;
-
 	fei->regset =  devm_kzalloc(fei->dev, sizeof(*fei->regset), GFP_KERNEL);
 	if (!fei->regset)
-		goto err;
+		return;
 
 	fei->regset->regs = fei_sys_regs;
 	fei->regset->nregs = ARRAY_SIZE(fei_sys_regs);
 	fei->regset->base = fei->io;
 
-	file = debugfs_create_regset32("registers", S_IRUGO, root,
-				fei->regset);
-	if (!file) {
-		dev_err(fei->dev,
-			"%s not able to create 'registers' debugfs\n"
-			, __func__);
-		goto err;
-	}
-
-	return;
-
-err:
-	debugfs_remove_recursive(root);
+	fei->root = debugfs_create_dir("c8sectpfe", NULL);
+	debugfs_create_regset32("registers", S_IRUGO, fei->root, fei->regset);
 }
 
 void c8sectpfe_debugfs_exit(struct c8sectpfei *fei)
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: c8sectpfe: no need to check return value of debugfs_create functions
  2019-11-07  8:52 ` Greg Kroah-Hartman
@ 2019-11-07  9:58   ` Patrice CHOTARD
  -1 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2019-11-07  9:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Mauro Carvalho Chehab
  Cc: linux-arm-kernel, linux-media, linux-kernel

Hi

On 11/7/19 9:52 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  .../sti/c8sectpfe/c8sectpfe-debugfs.c         | 26 +++----------------
>  1 file changed, 3 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> index 8f0ddcbeed9d..301fa10f419b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> @@ -225,36 +225,16 @@ static const struct debugfs_reg32 fei_sys_regs[] = {
>  
>  void c8sectpfe_debugfs_init(struct c8sectpfei *fei)
>  {
> -	struct dentry		*root;
> -	struct dentry		*file;
> -
> -	root = debugfs_create_dir("c8sectpfe", NULL);
> -	if (!root)
> -		goto err;
> -
> -	fei->root = root;
> -
>  	fei->regset =  devm_kzalloc(fei->dev, sizeof(*fei->regset), GFP_KERNEL);
>  	if (!fei->regset)
> -		goto err;
> +		return;
>  
>  	fei->regset->regs = fei_sys_regs;
>  	fei->regset->nregs = ARRAY_SIZE(fei_sys_regs);
>  	fei->regset->base = fei->io;
>  
> -	file = debugfs_create_regset32("registers", S_IRUGO, root,
> -				fei->regset);
> -	if (!file) {
> -		dev_err(fei->dev,
> -			"%s not able to create 'registers' debugfs\n"
> -			, __func__);
> -		goto err;
> -	}
> -
> -	return;
> -
> -err:
> -	debugfs_remove_recursive(root);
> +	fei->root = debugfs_create_dir("c8sectpfe", NULL);
> +	debugfs_create_regset32("registers", S_IRUGO, fei->root, fei->regset);
>  }
>  
>  void c8sectpfe_debugfs_exit(struct c8sectpfei *fei)

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] media: c8sectpfe: no need to check return value of debugfs_create functions
@ 2019-11-07  9:58   ` Patrice CHOTARD
  0 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2019-11-07  9:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Mauro Carvalho Chehab
  Cc: linux-kernel, linux-arm-kernel, linux-media

Hi

On 11/7/19 9:52 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  .../sti/c8sectpfe/c8sectpfe-debugfs.c         | 26 +++----------------
>  1 file changed, 3 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> index 8f0ddcbeed9d..301fa10f419b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> @@ -225,36 +225,16 @@ static const struct debugfs_reg32 fei_sys_regs[] = {
>  
>  void c8sectpfe_debugfs_init(struct c8sectpfei *fei)
>  {
> -	struct dentry		*root;
> -	struct dentry		*file;
> -
> -	root = debugfs_create_dir("c8sectpfe", NULL);
> -	if (!root)
> -		goto err;
> -
> -	fei->root = root;
> -
>  	fei->regset =  devm_kzalloc(fei->dev, sizeof(*fei->regset), GFP_KERNEL);
>  	if (!fei->regset)
> -		goto err;
> +		return;
>  
>  	fei->regset->regs = fei_sys_regs;
>  	fei->regset->nregs = ARRAY_SIZE(fei_sys_regs);
>  	fei->regset->base = fei->io;
>  
> -	file = debugfs_create_regset32("registers", S_IRUGO, root,
> -				fei->regset);
> -	if (!file) {
> -		dev_err(fei->dev,
> -			"%s not able to create 'registers' debugfs\n"
> -			, __func__);
> -		goto err;
> -	}
> -
> -	return;
> -
> -err:
> -	debugfs_remove_recursive(root);
> +	fei->root = debugfs_create_dir("c8sectpfe", NULL);
> +	debugfs_create_regset32("registers", S_IRUGO, fei->root, fei->regset);
>  }
>  
>  void c8sectpfe_debugfs_exit(struct c8sectpfei *fei)

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-07  9:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07  8:52 [PATCH] media: c8sectpfe: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-11-07  8:52 ` Greg Kroah-Hartman
2019-11-07  9:58 ` Patrice CHOTARD
2019-11-07  9:58   ` Patrice CHOTARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.