Re: [Buildroot] [PATCH] configs/qemu_ppc64le_powernv8: use linux kernel 5.17.7 and binutils 2.36.1

Re: [Buildroot] [PATCH] configs/qemu_ppc64le_powernv8: use linux kernel 5.17.7 and binutils 2.36.1

[Romain Naour]

Hello,

Le 14/05/2022 à 07:53, Cédric Le Goater a écrit :
> ppc64 or powernv Linux defconfig fail to build with gcc 11 and/or
> binutils 2.37 [1] :
> 
>   CC      kernel/kexec_file.o
>   Cannot find symbol for section 10: .text.unlikely.
>   kernel/kexec_file.o: failed
> 
> Patches have been sent upstream and should reach Linux 5.18. Until
> then, bump kernel version to the latest supported in buildroot and
> limit binutils to 2.36.1 which doesn't raise the issue.
> 
> [1] https://github.com/linuxppc/issues/issues/388

This also fixes qemu ppc64 defconfigs test in gitlab:
https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793891
https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793892
https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793893

> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  configs/qemu_ppc64le_powernv8_defconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/qemu_ppc64le_powernv8_defconfig b/configs/qemu_ppc64le_powernv8_defconfig
> index a784695ddf06..8de4cf5189b5 100644
> --- a/configs/qemu_ppc64le_powernv8_defconfig
> +++ b/configs/qemu_ppc64le_powernv8_defconfig
> @@ -3,6 +3,7 @@ BR2_powerpc64le=y
>  BR2_powerpc_power8=y
>  
>  # System
> +BR2_BINUTILS_VERSION_2_36_X=y

Have you considered adding the patch in board/qemu/ppc64-*/patches/linux instead
of downgrading binutils version?

Other ppc64 defconfig doesn't seems to trigger this issue:
freescale_t1040d4rdb_defconfig:BR2_powerpc64=y
freescale_t2080_qds_rdb_defconfig:BR2_powerpc64=y
qemu_ppc64_e5500_defconfig:BR2_powerpc64=y

Best regards,
Romain


>  BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>  BR2_SYSTEM_DHCP="eth0"
>  
> @@ -15,12 +16,12 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh"
>  BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"
>  
>  # Linux headers same as kernel
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_17=y
>  
>  # Kernel
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.18"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.17.7"
>  BR2_LINUX_KERNEL_DEFCONFIG="powernv"
>  BR2_LINUX_KERNEL_VMLINUX=y
>  

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/qemu_ppc64le_powernv8: use linux kernel 5.17.7 and binutils 2.36.1

[Romain Naour]

Hello,

Le 14/05/2022 à 15:46, Cédric Le Goater a écrit :
> On 5/14/22 14:36, Romain Naour wrote:
>> Hello,
>>
>> Le 14/05/2022 à 07:53, Cédric Le Goater a écrit :
>>> ppc64 or powernv Linux defconfig fail to build with gcc 11 and/or
>>> binutils 2.37 [1] :
>>>
>>>    CC      kernel/kexec_file.o
>>>    Cannot find symbol for section 10: .text.unlikely.
>>>    kernel/kexec_file.o: failed
>>>
>>> Patches have been sent upstream and should reach Linux 5.18. Until
>>> then, bump kernel version to the latest supported in buildroot and
>>> limit binutils to 2.36.1 which doesn't raise the issue.
>>>
>>> [1] https://github.com/linuxppc/issues/issues/388
>>
>> This also fixes qemu ppc64 defconfigs test in gitlab:
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793891
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793892
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/2445793893
> 
> yes pseries should be impacted also.
> 
>>
>>>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>>   configs/qemu_ppc64le_powernv8_defconfig | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configs/qemu_ppc64le_powernv8_defconfig
>>> b/configs/qemu_ppc64le_powernv8_defconfig
>>> index a784695ddf06..8de4cf5189b5 100644
>>> --- a/configs/qemu_ppc64le_powernv8_defconfig
>>> +++ b/configs/qemu_ppc64le_powernv8_defconfig
>>> @@ -3,6 +3,7 @@ BR2_powerpc64le=y
>>>   BR2_powerpc_power8=y
>>>     # System
>>> +BR2_BINUTILS_VERSION_2_36_X=y
>>
>> Have you considered adding the patch in board/qemu/ppc64-*/patches/linux instead
>> of downgrading binutils version?
> 
> yes, I tried but the second patch failed to apply. I can backport
> if this is a preferred option, and send a v2.

It fail to apply on the kernel 5.15 or the 5.17?
I guess you tried to backport the patch on the 5.17 and you had some conflicts.
Since It's not a easy backport, I'm ok to fix the binutils version for ppc64
defconfigs until it's fixed in upcoming kernels.

Best regards,
Romain

> 
> Thanks,
> 
> C.
> 
> 
>> Other ppc64 defconfig doesn't seems to trigger this issue:
>> freescale_t1040d4rdb_defconfig:BR2_powerpc64=y
>> freescale_t2080_qds_rdb_defconfig:BR2_powerpc64=y
>> qemu_ppc64_e5500_defconfig:BR2_powerpc64=y
>>
>> Best regards,
>> Romain
>>
>>
>>>   BR2_TARGET_GENERIC_GETTY_PORT="hvc0"
>>>   BR2_SYSTEM_DHCP="eth0"
>>>   @@ -15,12 +16,12 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh"
>>>   BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"
>>>     # Linux headers same as kernel
>>> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_17=y
>>>     # Kernel
>>>   BR2_LINUX_KERNEL=y
>>>   BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>>> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.18"
>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.17.7"
>>>   BR2_LINUX_KERNEL_DEFCONFIG="powernv"
>>>   BR2_LINUX_KERNEL_VMLINUX=y
>>>   
>>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/qemu_ppc64le_powernv8: use linux kernel 5.17.7 and binutils 2.36.1

[Romain Naour]

Hello Cédric,

Le 14/05/2022 à 18:49, Cédric Le Goater a écrit :
> Hello Romain,
> 
>>>> Have you considered adding the patch in board/qemu/ppc64-*/patches/linux
>>>> instead
>>>> of downgrading binutils version?
>>>
>>> yes, I tried but the second patch failed to apply. I can backport
>>> if this is a preferred option, and send a v2.
>>
>> It fail to apply on the kernel 5.15 or the 5.17?
> 
> on 5.17.
> 
>> I guess you tried to backport the patch on the 5.17 and you had some conflicts.
> 
> They are in the ftrace subsystem :
> 
>   https://lore.kernel.org/lkml/20220428184212.18fbf438@gandalf.local.home/T/
> 
> patch 1 applies but patch 2 needs some care. These have not been merged yet
> and that's another reason to be careful.
> 
>> Since It's not a easy backport, I'm ok to fix the binutils version for ppc64
>> defconfigs until it's fixed in upcoming kernels.
> 
> That might be the safest solution for now.

Ok with this solution.

It seems you are not subscribed to the Buildroot mailing list. Your patches
doesn't appear in patchwork [1]

Please, subscribe and resend your patch.

[1] http://patchwork.ozlabs.org/project/buildroot/list

Best regards,
Romain

> 
> Thanks,
> 
> C.
>  

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot