From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: <f.fainelli@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>,
<linux-kernel@vger.kernel.org>,
<linux-rpi-kernel@lists.infradead.org>,
Will Deacon <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH for-next] arm64: defconfig: Set bcm2835-dma as built-in
Date: Fri, 24 Jan 2020 20:07:51 +0200 [thread overview]
Message-ID: <e29e23fd-cb60-56b9-e53d-ecbafc12bf8c@ti.com> (raw)
In-Reply-To: <C043QOCZ7SMB.2XXX2ESS1ZJ98@linux-9qgx>
Hi Nicolas,
On 1/24/20 4:47 PM, Nicolas Saenz Julienne wrote:
>> If you need MMC rootfs then the DMA needs to be built in or have initrd
>> with the modules.
>> The driver expects to have DMA channel and it is going to wait for it to
>> appear unless the request fails.
>>
>> Without moving the DMA as built in and removing the deferred probe
>> handling form the MMC driver, one can just remove the DMA support from
>> the mmc-bcm2835 as it is not used at all.
>
> Oh sorry, I meant to ask if the 'Fixes:' tag was really needed.
Complements: or Needed-for: would be better, but with the Fixed tag this
patch would be picked in case the dma_request_chan() conversion patch
gets backported for stable.
> The
> patch itself is very much needed since not everyone uses initrds in the
> RPi world, and we want to keep being compatible as much as possible with
> older device-trees.
Sure. Just checked on my RPi with libreELEC that at least they have the
DMA built in, I assume other distros do the same.
It would be great if this patch would make it to linux-next as soon as
it is possible for sure.
>> I wonder why this is not signaled by automated boot testing, if any
>> exists for bcm2835>
> Actually now that you mention it, it's failing since today here:
> https://kernelci.org/boot/bcm2837-rpi-3-b/
Oh, so you can even have a bug report to back this patch ;)
- Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: f.fainelli@gmail.com, Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH for-next] arm64: defconfig: Set bcm2835-dma as built-in
Date: Fri, 24 Jan 2020 20:07:51 +0200 [thread overview]
Message-ID: <e29e23fd-cb60-56b9-e53d-ecbafc12bf8c@ti.com> (raw)
In-Reply-To: <C043QOCZ7SMB.2XXX2ESS1ZJ98@linux-9qgx>
Hi Nicolas,
On 1/24/20 4:47 PM, Nicolas Saenz Julienne wrote:
>> If you need MMC rootfs then the DMA needs to be built in or have initrd
>> with the modules.
>> The driver expects to have DMA channel and it is going to wait for it to
>> appear unless the request fails.
>>
>> Without moving the DMA as built in and removing the deferred probe
>> handling form the MMC driver, one can just remove the DMA support from
>> the mmc-bcm2835 as it is not used at all.
>
> Oh sorry, I meant to ask if the 'Fixes:' tag was really needed.
Complements: or Needed-for: would be better, but with the Fixed tag this
patch would be picked in case the dma_request_chan() conversion patch
gets backported for stable.
> The
> patch itself is very much needed since not everyone uses initrds in the
> RPi world, and we want to keep being compatible as much as possible with
> older device-trees.
Sure. Just checked on my RPi with libreELEC that at least they have the
DMA built in, I assume other distros do the same.
It would be great if this patch would make it to linux-next as soon as
it is possible for sure.
>> I wonder why this is not signaled by automated boot testing, if any
>> exists for bcm2835>
> Actually now that you mention it, it's failing since today here:
> https://kernelci.org/boot/bcm2837-rpi-3-b/
Oh, so you can even have a bug report to back this patch ;)
- Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-24 18:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 11:17 [PATCH for-next] arm64: defconfig: Set bcm2835-dma as built-in Nicolas Saenz Julienne
2020-01-24 11:17 ` Nicolas Saenz Julienne
2020-01-24 11:31 ` Peter Ujfalusi
2020-01-24 11:31 ` Peter Ujfalusi
2020-01-24 11:51 ` Nicolas Saenz Julienne
2020-01-24 11:51 ` Nicolas Saenz Julienne
2020-01-24 12:05 ` Peter Ujfalusi
2020-01-24 12:05 ` Peter Ujfalusi
2020-01-24 14:47 ` Nicolas Saenz Julienne
2020-01-24 14:47 ` Nicolas Saenz Julienne
2020-01-24 18:07 ` Peter Ujfalusi [this message]
2020-01-24 18:07 ` Peter Ujfalusi
2020-01-29 0:50 ` Florian Fainelli
2020-01-29 0:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29e23fd-cb60-56b9-e53d-ecbafc12bf8c@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.