From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Krzysztof Kozlowski <krzk@kernel.org>, Adam Ford <aford173@gmail.com> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>, linux-mmc <linux-mmc@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Adam Ford-BE <aford@beaconembedded.com>, Haibo Chen <haibo.chen@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, arm-soc <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/5] arm64: dts: imx8mp: Enable HS400-ES Date: Mon, 28 Mar 2022 15:42:08 +0200 [thread overview] Message-ID: <e2a3e6c0-d98c-7417-31bd-5f674c9c32b4@pengutronix.de> (raw) In-Reply-To: <37da40fe-6e85-af40-756b-d022fe2559aa@kernel.org> On 28.03.22 15:14, Krzysztof Kozlowski wrote: > On 28/03/2022 15:07, Ahmad Fatoum wrote: >> On 28.03.22 14:56, Krzysztof Kozlowski wrote: >>> You could also add two cases: >>> 1. three compatibles, deprecated: True, >>> 2. two compatibles, without imx7d. >>> >>> Existing DTS stays with three compatibles for two years and later gets >>> converted to two compatibles. New DTS should use two compatibles. >>> >>> It's quite a lot of churn, but would make in the long term bindings >>> correct and also not break other users/projects. >> >> I don't see why we need to deprecate the old binding. New SoCs >> can be imx8mm-usdhc compatible from the beginning and need not >> care about the old binding. Existing SoCs can just remain imx7d-usdhc >> compatible as they are now. >> >> I don't see what the deprecation accomplishes. > > It avoids to have too many entries of imx8mm (imx8mm alone, > imx8mm+imx7d, imx8xx+imx8mm+imx7d). I see. I assume use of deprecated binding will be reported on a dtbs_check? If so, the expectation is that downstream projects run dtbs_check on their imported Linux DT repository, see the deprecation warning and extend their drivers to comply with it. Some time later upstream will remove the deprecated binding and adjust the device trees. This works for me. Cheers, Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Krzysztof Kozlowski <krzk@kernel.org>, Adam Ford <aford173@gmail.com> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>, linux-mmc <linux-mmc@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Adam Ford-BE <aford@beaconembedded.com>, Haibo Chen <haibo.chen@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, arm-soc <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/5] arm64: dts: imx8mp: Enable HS400-ES Date: Mon, 28 Mar 2022 15:42:08 +0200 [thread overview] Message-ID: <e2a3e6c0-d98c-7417-31bd-5f674c9c32b4@pengutronix.de> (raw) In-Reply-To: <37da40fe-6e85-af40-756b-d022fe2559aa@kernel.org> On 28.03.22 15:14, Krzysztof Kozlowski wrote: > On 28/03/2022 15:07, Ahmad Fatoum wrote: >> On 28.03.22 14:56, Krzysztof Kozlowski wrote: >>> You could also add two cases: >>> 1. three compatibles, deprecated: True, >>> 2. two compatibles, without imx7d. >>> >>> Existing DTS stays with three compatibles for two years and later gets >>> converted to two compatibles. New DTS should use two compatibles. >>> >>> It's quite a lot of churn, but would make in the long term bindings >>> correct and also not break other users/projects. >> >> I don't see why we need to deprecate the old binding. New SoCs >> can be imx8mm-usdhc compatible from the beginning and need not >> care about the old binding. Existing SoCs can just remain imx7d-usdhc >> compatible as they are now. >> >> I don't see what the deprecation accomplishes. > > It avoids to have too many entries of imx8mm (imx8mm alone, > imx8mm+imx7d, imx8xx+imx8mm+imx7d). I see. I assume use of deprecated binding will be reported on a dtbs_check? If so, the expectation is that downstream projects run dtbs_check on their imported Linux DT repository, see the deprecation warning and extend their drivers to comply with it. Some time later upstream will remove the deprecated binding and adjust the device trees. This works for me. Cheers, Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-28 13:42 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-27 12:38 [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford 2022-03-27 12:38 ` Adam Ford 2022-03-27 12:38 ` [PATCH 2/5] arm64: dts: imx8mn: Enable HS400-ES Adam Ford 2022-03-27 12:38 ` Adam Ford 2022-03-27 12:38 ` [PATCH 3/5] arm64: dts: imx8mp: " Adam Ford 2022-03-27 12:38 ` Adam Ford 2022-03-28 7:20 ` Ahmad Fatoum 2022-03-28 7:20 ` Ahmad Fatoum 2022-03-28 10:47 ` Adam Ford 2022-03-28 10:47 ` Adam Ford 2022-03-28 11:09 ` Ahmad Fatoum 2022-03-28 11:09 ` Ahmad Fatoum 2022-03-28 11:49 ` Krzysztof Kozlowski 2022-03-28 11:49 ` Krzysztof Kozlowski 2022-03-28 12:45 ` Adam Ford 2022-03-28 12:45 ` Adam Ford 2022-03-28 12:56 ` Krzysztof Kozlowski 2022-03-28 12:56 ` Krzysztof Kozlowski 2022-03-28 13:06 ` Adam Ford 2022-03-28 13:06 ` Adam Ford 2022-03-28 13:12 ` Ahmad Fatoum 2022-03-28 13:12 ` Ahmad Fatoum 2022-03-28 13:15 ` Krzysztof Kozlowski 2022-03-28 13:15 ` Krzysztof Kozlowski 2022-03-28 13:17 ` Krzysztof Kozlowski 2022-03-28 13:17 ` Krzysztof Kozlowski 2022-03-28 13:07 ` Ahmad Fatoum 2022-03-28 13:07 ` Ahmad Fatoum 2022-03-28 13:14 ` Krzysztof Kozlowski 2022-03-28 13:14 ` Krzysztof Kozlowski 2022-03-28 13:42 ` Ahmad Fatoum [this message] 2022-03-28 13:42 ` Ahmad Fatoum 2022-03-28 17:35 ` Krzysztof Kozlowski 2022-03-28 17:35 ` Krzysztof Kozlowski 2022-03-27 12:38 ` [PATCH 4/5] arm64: dts: imx8qxp: Remove imx7d-usdhc compatible fallback Adam Ford 2022-03-27 12:38 ` Adam Ford 2022-03-27 12:38 ` [PATCH 5/5] arm64: dts: imx8qm: Remove fsl,imx7d-usdhc " Adam Ford 2022-03-27 12:38 ` [PATCH 5/5] arm64: dts: imx8qm: Remove fsl, imx7d-usdhc " Adam Ford 2022-03-27 19:26 ` [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Krzysztof Kozlowski 2022-03-27 19:26 ` Krzysztof Kozlowski 2022-03-31 13:04 ` Ulf Hansson 2022-03-31 13:04 ` Ulf Hansson 2022-03-31 16:00 ` Adam Ford 2022-03-31 16:00 ` Adam Ford
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e2a3e6c0-d98c-7417-31bd-5f674c9c32b4@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=aford173@gmail.com \ --cc=aford@beaconembedded.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=haibo.chen@nxp.com \ --cc=kernel@pengutronix.de \ --cc=krzk+dt@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.