[PATCH] systemd: work-around ppc gold linker error

[PATCH] systemd: work-around ppc gold linker error

[Randy MacLeod]

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 .../systemd/systemd/systemd-drop-gold-use-bfd.patch           | 11 +++++++++++
 meta/recipes-core/systemd/systemd_232.bb                      |  2 ++
 2 files changed, 13 insertions(+)
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch

diff --git a/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
new file mode 100644
index 0000000..eac2199
--- /dev/null
+++ b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
@@ -0,0 +1,11 @@
+--- a/configure.ac
++++ b/configure.ac
+@@ -260,7 +260,7 @@
+         -Wl,-z,relro \
+         -Wl,-z,now \
+         -pie \
+-        -Wl,-fuse-ld=gold])
++        -Wl,-fuse-ld=bfd])
+ AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags")
+ 
+ AC_CHECK_SIZEOF(pid_t)
diff --git a/meta/recipes-core/systemd/systemd_232.bb b/meta/recipes-core/systemd/systemd_232.bb
index 1007360..1ce9dc1 100644
--- a/meta/recipes-core/systemd/systemd_232.bb
+++ b/meta/recipes-core/systemd/systemd_232.bb
@@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\
 "
 SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
 
+SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch"
+
 PACKAGECONFIG ??= "xz \
                    ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
-- 
2.7.4

Re: [PATCH] systemd: work-around ppc gold linker error

[Khem Raj]

On Tue, Jun 20, 2017 at 10:28 PM, Randy MacLeod
<Randy.MacLeod@windriver.com> wrote:
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>  .../systemd/systemd/systemd-drop-gold-use-bfd.patch           | 11 +++++++++++
>  meta/recipes-core/systemd/systemd_232.bb                      |  2 ++
>  2 files changed, 13 insertions(+)
>  create mode 100644 meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
>
> diff --git a/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
> new file mode 100644
> index 0000000..eac2199
> --- /dev/null
> +++ b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
> @@ -0,0 +1,11 @@
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -260,7 +260,7 @@
> +         -Wl,-z,relro \
> +         -Wl,-z,now \
> +         -pie \
> +-        -Wl,-fuse-ld=gold])
> ++        -Wl,-fuse-ld=bfd])
> + AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags")
> +
> + AC_CHECK_SIZEOF(pid_t)

may be a sed expression in do_configure_prepend is better

> diff --git a/meta/recipes-core/systemd/systemd_232.bb b/meta/recipes-core/systemd/systemd_232.bb
> index 1007360..1ce9dc1 100644
> --- a/meta/recipes-core/systemd/systemd_232.bb
> +++ b/meta/recipes-core/systemd/systemd_232.bb
> @@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\
>  "
>  SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
>
> +SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch"

is it specific to qemu alone ? if its generic across ppc then this is not
right override. Infact you should also describe what the problem is in detail
here.

> +
>  PACKAGECONFIG ??= "xz \
>                     ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] systemd: work-around ppc gold linker error

[Randy MacLeod]

On 2017-06-20 10:41 PM, Khem Raj wrote:
> On Tue, Jun 20, 2017 at 10:28 PM, Randy MacLeod
> <Randy.MacLeod@windriver.com> wrote:
>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> ---
>>   .../systemd/systemd/systemd-drop-gold-use-bfd.patch           | 11 +++++++++++
>>   meta/recipes-core/systemd/systemd_232.bb                      |  2 ++
>>   2 files changed, 13 insertions(+)
>>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
>>
>> diff --git a/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
>> new file mode 100644
>> index 0000000..eac2199
>> --- /dev/null
>> +++ b/meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
>> @@ -0,0 +1,11 @@
>> +--- a/configure.ac
>> ++++ b/configure.ac
>> +@@ -260,7 +260,7 @@
>> +         -Wl,-z,relro \
>> +         -Wl,-z,now \
>> +         -pie \
>> +-        -Wl,-fuse-ld=gold])
>> ++        -Wl,-fuse-ld=bfd])
>> + AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags")
>> +
>> + AC_CHECK_SIZEOF(pid_t)
> 
> may be a sed expression in do_configure_prepend is better

Maybe?... hmmm.

I could do but this works and is intended to be reverted once
the proper fix is merged so unless you or someone else insists
and explains why it's better to do it in configure_prepend,
I'll leave it as is.
> 
>> diff --git a/meta/recipes-core/systemd/systemd_232.bb b/meta/recipes-core/systemd/systemd_232.bb
>> index 1007360..1ce9dc1 100644
>> --- a/meta/recipes-core/systemd/systemd_232.bb
>> +++ b/meta/recipes-core/systemd/systemd_232.bb
>> @@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\
>>   "
>>   SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
>>
>> +SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch"
> 
> is it specific to qemu alone ? 

Probably not. I'll figure out a better pattern for v2.

> if its generic across ppc then this is not
> right override. Infact you should also describe what the problem is in detail
> here.

Right. I'll do that in v2.

Meanwhile, some details are here for those interested:
	https://bugzilla.yoctoproject.org/show_bug.cgi?id=11696

Thanks for the review.

../Randy

> 
>> +
>>   PACKAGECONFIG ??= "xz \
>>                      ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \
>>                      ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5

✗ patchtest: failure for systemd: work-around ppc gold linker error

[Patchwork]

== Series Details ==

Series: systemd: work-around ppc gold linker error
Revision: 1
URL   : https://patchwork.openembedded.org/series/7390/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] 
  Suggested fix    Add Upstream-Status: <status> to the header of meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue             A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence] 
  Suggested fix    Sign off the added patch file (meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe