All of lore.kernel.org
 help / color / mirror / Atom feed
* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  8:39 ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  8:39 UTC (permalink / raw)
  To: Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, Matthias Brugger, Chunfeng Yun, Roger Quadros,
	linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek

The phys has already been initialized when add primary hcd,
including usb2 phys and usb3 phys also if exist, so needn't
re-parse "phys" property again.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/core/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5a92d8f..777036a 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
 		}
 	}
 
-	if (!hcd->skip_phy_initialization) {
+	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
 		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
 		if (IS_ERR(hcd->phy_roothub)) {
 			retval = PTR_ERR(hcd->phy_roothub);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  8:39 ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  8:39 UTC (permalink / raw)
  To: Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, Matthias Brugger, Chunfeng Yun, Roger Quadros,
	linux-kernel, linux-arm-kernel, linux-usb, linux-mediatek

The phys has already been initialized when add primary hcd,
including usb2 phys and usb3 phys also if exist, so needn't
re-parse "phys" property again.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/core/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5a92d8f..777036a 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
 		}
 	}
 
-	if (!hcd->skip_phy_initialization) {
+	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
 		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
 		if (IS_ERR(hcd->phy_roothub)) {
 			retval = PTR_ERR(hcd->phy_roothub);

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  8:39 ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  8:39 UTC (permalink / raw)
  To: Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Chunfeng Yun,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Matthias Brugger,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Roger Quadros

The phys has already been initialized when add primary hcd,
including usb2 phys and usb3 phys also if exist, so needn't
re-parse "phys" property again.

Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 drivers/usb/core/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5a92d8f..777036a 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
 		}
 	}
 
-	if (!hcd->skip_phy_initialization) {
+	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
 		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
 		if (IS_ERR(hcd->phy_roothub)) {
 			retval = PTR_ERR(hcd->phy_roothub);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  8:39 ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  8:39 UTC (permalink / raw)
  To: linux-arm-kernel

The phys has already been initialized when add primary hcd,
including usb2 phys and usb3 phys also if exist, so needn't
re-parse "phys" property again.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/core/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5a92d8f..777036a 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
 		}
 	}
 
-	if (!hcd->skip_phy_initialization) {
+	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
 		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
 		if (IS_ERR(hcd->phy_roothub)) {
 			retval = PTR_ERR(hcd->phy_roothub);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:01   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22  9:01 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from version 1?

Always put that below the --- line like the kernel documentation asks
you to do.

v3?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:01   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22  9:01 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from version 1?

Always put that below the --- line like the kernel documentation asks
you to do.

v3?

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:01   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22  9:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from version 1?

Always put that below the --- line like the kernel documentation asks
you to do.

v3?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:21     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  9:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

hi, 
On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  drivers/usb/core/hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What changed from version 1?
V1: skip phys initialization when add shared HCD by setting
xhci->shared_hcd->skip_phy_initialization=1;
for both xhci-plat.c & xhci-mtk.c files.

V2: fix it in hcd.c suggested by Roger
> 
> Always put that below the --- line like the kernel documentation asks
> you to do.
> 
> v3?
> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:21     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  9:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

hi, 
On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  drivers/usb/core/hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What changed from version 1?
V1: skip phys initialization when add shared HCD by setting
xhci->shared_hcd->skip_phy_initialization=1;
for both xhci-plat.c & xhci-mtk.c files.

V2: fix it in hcd.c suggested by Roger
> 
> Always put that below the --- line like the kernel documentation asks
> you to do.
> 
> v3?
> 
> thanks,
> 
> greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:21     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  9:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

hi, 
On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  drivers/usb/core/hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What changed from version 1?
V1: skip phys initialization when add shared HCD by setting
xhci->shared_hcd->skip_phy_initialization=1;
for both xhci-plat.c & xhci-mtk.c files.

V2: fix it in hcd.c suggested by Roger
> 
> Always put that below the --- line like the kernel documentation asks
> you to do.
> 
> v3?
> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22  9:21     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-22  9:21 UTC (permalink / raw)
  To: linux-arm-kernel

hi, 
On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  drivers/usb/core/hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What changed from version 1?
V1: skip phys initialization when add shared HCD by setting
xhci->shared_hcd->skip_phy_initialization=1;
for both xhci-plat.c & xhci-mtk.c files.

V2: fix it in hcd.c suggested by Roger
> 
> Always put that below the --- line like the kernel documentation asks
> you to do.
> 
> v3?
> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:00       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:00 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote:
> hi, 
> On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > > The phys has already been initialized when add primary hcd,
> > > including usb2 phys and usb3 phys also if exist, so needn't
> > > re-parse "phys" property again.
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > ---
> > >  drivers/usb/core/hcd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What changed from version 1?
> V1: skip phys initialization when add shared HCD by setting
> xhci->shared_hcd->skip_phy_initialization=1;
> for both xhci-plat.c & xhci-mtk.c files.
> 
> V2: fix it in hcd.c suggested by Roger

Please put it in the patch itself, resend v3 with this info.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:00       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:00 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote:
> hi, 
> On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > > The phys has already been initialized when add primary hcd,
> > > including usb2 phys and usb3 phys also if exist, so needn't
> > > re-parse "phys" property again.
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > ---
> > >  drivers/usb/core/hcd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What changed from version 1?
> V1: skip phys initialization when add shared HCD by setting
> xhci->shared_hcd->skip_phy_initialization=1;
> for both xhci-plat.c & xhci-mtk.c files.
> 
> V2: fix it in hcd.c suggested by Roger

Please put it in the patch itself, resend v3 with this info.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:00       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote:
> hi, 
> On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote:
> > > The phys has already been initialized when add primary hcd,
> > > including usb2 phys and usb3 phys also if exist, so needn't
> > > re-parse "phys" property again.
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > ---
> > >  drivers/usb/core/hcd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What changed from version 1?
> V1: skip phys initialization when add shared HCD by setting
> xhci->shared_hcd->skip_phy_initialization=1;
> for both xhci-plat.c & xhci-mtk.c files.
> 
> V2: fix it in hcd.c suggested by Roger

Please put it in the patch itself, resend v3 with this info.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:29   ` Roger Quadros
  0 siblings, 0 replies; 25+ messages in thread
From: Roger Quadros @ 2018-03-22 12:29 UTC (permalink / raw)
  To: Chunfeng Yun, Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, Matthias Brugger, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek

On 22/03/18 14:12, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> V3:
>     add the following info about v1 & v2 suggested by Greg
> V2:
>     fix it in hcd.c suggested by Roger
> V1:
>     skip phys initialization when add shared HCD by setting
>     xhci->shared_hcd->skip_phy_initialization=1;
>     for both xhci-plat.c & xhci-mtk.c files.
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 5a92d8f..777036a 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>  		}
>  	}
>  
> -	if (!hcd->skip_phy_initialization) {
> +	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
>  		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
>  		if (IS_ERR(hcd->phy_roothub)) {
>  			retval = PTR_ERR(hcd->phy_roothub);
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:29   ` Roger Quadros
  0 siblings, 0 replies; 25+ messages in thread
From: Roger Quadros @ 2018-03-22 12:29 UTC (permalink / raw)
  To: Chunfeng Yun, Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, Matthias Brugger, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek

On 22/03/18 14:12, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> V3:
>     add the following info about v1 & v2 suggested by Greg
> V2:
>     fix it in hcd.c suggested by Roger
> V1:
>     skip phys initialization when add shared HCD by setting
>     xhci->shared_hcd->skip_phy_initialization=1;
>     for both xhci-plat.c & xhci-mtk.c files.
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 5a92d8f..777036a 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>  		}
>  	}
>  
> -	if (!hcd->skip_phy_initialization) {
> +	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
>  		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
>  		if (IS_ERR(hcd->phy_roothub)) {
>  			retval = PTR_ERR(hcd->phy_roothub);
>

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:29   ` Roger Quadros
  0 siblings, 0 replies; 25+ messages in thread
From: Roger Quadros @ 2018-03-22 12:29 UTC (permalink / raw)
  To: Chunfeng Yun, Martin Blumenstingl, Greg Kroah-Hartman
  Cc: Mathias Nyman, linux-usb, linux-kernel, linux-mediatek,
	Matthias Brugger, linux-arm-kernel

On 22/03/18 14:12, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> V3:
>     add the following info about v1 & v2 suggested by Greg
> V2:
>     fix it in hcd.c suggested by Roger
> V1:
>     skip phys initialization when add shared HCD by setting
>     xhci->shared_hcd->skip_phy_initialization=1;
>     for both xhci-plat.c & xhci-mtk.c files.
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 5a92d8f..777036a 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>  		}
>  	}
>  
> -	if (!hcd->skip_phy_initialization) {
> +	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
>  		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
>  		if (IS_ERR(hcd->phy_roothub)) {
>  			retval = PTR_ERR(hcd->phy_roothub);
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:29   ` Roger Quadros
  0 siblings, 0 replies; 25+ messages in thread
From: Roger Quadros @ 2018-03-22 12:29 UTC (permalink / raw)
  To: linux-arm-kernel

On 22/03/18 14:12, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> V3:
>     add the following info about v1 & v2 suggested by Greg
> V2:
>     fix it in hcd.c suggested by Roger
> V1:
>     skip phys initialization when add shared HCD by setting
>     xhci->shared_hcd->skip_phy_initialization=1;
>     for both xhci-plat.c & xhci-mtk.c files.
> ---
>  drivers/usb/core/hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 5a92d8f..777036a 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2757,7 +2757,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>  		}
>  	}
>  
> -	if (!hcd->skip_phy_initialization) {
> +	if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
>  		hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev);
>  		if (IS_ERR(hcd->phy_roothub)) {
>  			retval = PTR_ERR(hcd->phy_roothub);
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:53   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:53 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.

Wait, why does the subject say "xhci", when this is in USB core code?

I'll go edit that by hand...

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:53   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:53 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.

Wait, why does the subject say "xhci", when this is in USB core code?

I'll go edit that by hand...
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-22 12:53   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-22 12:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> The phys has already been initialized when add primary hcd,
> including usb2 phys and usb3 phys also if exist, so needn't
> re-parse "phys" property again.

Wait, why does the subject say "xhci", when this is in USB core code?

I'll go edit that by hand...

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-23  3:20     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-23  3:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> 
> Wait, why does the subject say "xhci", when this is in USB core code?
> 
> I'll go edit that by hand...
Thanks



^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next,v2] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-23  3:20     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-23  3:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> 
> Wait, why does the subject say "xhci", when this is in USB core code?
> 
> I'll go edit that by hand...
Thanks
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-23  3:20     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-23  3:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Martin Blumenstingl, Mathias Nyman, Matthias Brugger,
	Roger Quadros, linux-kernel, linux-arm-kernel, linux-usb,
	linux-mediatek

On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> 
> Wait, why does the subject say "xhci", when this is in USB core code?
> 
> I'll go edit that by hand...
Thanks

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd
@ 2018-03-23  3:20     ` Chunfeng Yun
  0 siblings, 0 replies; 25+ messages in thread
From: Chunfeng Yun @ 2018-03-23  3:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote:
> > The phys has already been initialized when add primary hcd,
> > including usb2 phys and usb3 phys also if exist, so needn't
> > re-parse "phys" property again.
> 
> Wait, why does the subject say "xhci", when this is in USB core code?
> 
> I'll go edit that by hand...
Thanks

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2018-03-23  3:20 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22  8:39 [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd Chunfeng Yun
2018-03-22  8:39 ` Chunfeng Yun
2018-03-22  8:39 ` Chunfeng Yun
2018-03-22  8:39 ` [usb-next,v2] " Chunfeng Yun
2018-03-22  9:01 ` [usb-next, v2 PATCH] " Greg Kroah-Hartman
2018-03-22  9:01   ` Greg Kroah-Hartman
2018-03-22  9:01   ` [usb-next,v2] " Greg Kroah-Hartman
2018-03-22  9:21   ` [usb-next, v2 PATCH] " Chunfeng Yun
2018-03-22  9:21     ` Chunfeng Yun
2018-03-22  9:21     ` Chunfeng Yun
2018-03-22  9:21     ` [usb-next,v2] " Chunfeng Yun
2018-03-22 12:00     ` [usb-next, v2 PATCH] " Greg Kroah-Hartman
2018-03-22 12:00       ` Greg Kroah-Hartman
2018-03-22 12:00       ` [usb-next,v2] " Greg Kroah-Hartman
2018-03-22 12:29 ` [usb-next, v3 PATCH] " Roger Quadros
2018-03-22 12:29   ` Roger Quadros
2018-03-22 12:29   ` Roger Quadros
2018-03-22 12:29   ` [usb-next,v2] " Roger Quadros
2018-03-22 12:53 ` [usb-next, v3 PATCH] " Greg Kroah-Hartman
2018-03-22 12:53   ` Greg Kroah-Hartman
2018-03-22 12:53   ` [usb-next,v2] " Greg Kroah-Hartman
2018-03-23  3:20   ` [usb-next, v3 PATCH] " Chunfeng Yun
2018-03-23  3:20     ` Chunfeng Yun
2018-03-23  3:20     ` Chunfeng Yun
2018-03-23  3:20     ` [usb-next,v2] " Chunfeng Yun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.