All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dongsu Park <dongsu.park@profitbricks.com>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, Kent Overstreet <kmo@daterainc.com>,
	Ming Lin <mlin@minggr.net>,
	Dongsu Park <dongsu.park@profitbricks.com>,
	Neil Brown <neilb@suse.de>,
	linux-raid@vger.kernel.org
Subject: [RFC PATCH 13/17] md/raid5: get rid of bio_fits_rdev()
Date: Mon, 22 Dec 2014 12:48:40 +0100	[thread overview]
Message-ID: <e35d37b66d621c51f2eb24ff024291bd1d53422e.1419241597.git.dongsu.park@profitbricks.com> (raw)
In-Reply-To: <b7767767957ca758ac492e94dfb320bea4f52dd7.1419241597.git.dongsu.park@profitbricks.com>
In-Reply-To: <cover.1419241597.git.dongsu.park@profitbricks.com>

From: Kent Overstreet <kmo@daterainc.com>

Remove bio_fits_rdev() completely, because ->merge_bvec_fn() has now
gone. There's no point in calling bio_fits_rdev() only for ensuring
aligned read from rdev.

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park <dongsu.park@profitbricks.com>
Cc: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
---
 drivers/md/raid5.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index c1b0d52..40e464c 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4218,25 +4218,6 @@ static void raid5_align_endio(struct bio *bi, int error)
 	add_bio_to_retry(raid_bi, conf);
 }
 
-static int bio_fits_rdev(struct bio *bi)
-{
-	struct request_queue *q = bdev_get_queue(bi->bi_bdev);
-
-	if (bio_sectors(bi) > queue_max_sectors(q))
-		return 0;
-	blk_recount_segments(q, bi);
-	if (bi->bi_phys_segments > queue_max_segments(q))
-		return 0;
-
-	if (q->merge_bvec_fn)
-		/* it's too hard to apply the merge_bvec_fn at this stage,
-		 * just just give up
-		 */
-		return 0;
-
-	return 1;
-}
-
 static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio)
 {
 	struct r5conf *conf = mddev->private;
@@ -4290,11 +4271,9 @@ static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio)
 		align_bi->bi_bdev =  rdev->bdev;
 		__clear_bit(BIO_SEG_VALID, &align_bi->bi_flags);
 
-		if (!bio_fits_rdev(align_bi) ||
-		    is_badblock(rdev, align_bi->bi_iter.bi_sector,
+		if (is_badblock(rdev, align_bi->bi_iter.bi_sector,
 				bio_sectors(align_bi),
 				&first_bad, &bad_sectors)) {
-			/* too big in some way, or has a known bad block */
 			bio_put(align_bi);
 			rdev_dec_pending(rdev, mddev);
 			return 0;
-- 
2.1.0

  reply	other threads:[~2014-12-22 11:48 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22 11:48 [RFC PATCH 00/17] simplify block layer based on immutable biovecs Dongsu Park
2014-12-22 11:48 ` [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios Dongsu Park
2014-12-22 11:48   ` [RFC PATCH 02/17] block: simplify bio_add_page() Dongsu Park
2014-12-22 11:48     ` [RFC PATCH 03/17] block: simplify issueing discard, write_same, zeroout Dongsu Park
2014-12-22 11:48       ` [RFC PATCH 04/17] bcache: clean up hacks around bio_split_pool Dongsu Park
2014-12-22 11:48         ` [RFC PATCH 05/17] btrfs: remove bio splitting and merge_bvec_fn() calls Dongsu Park
2014-12-22 11:48           ` [RFC PATCH 06/17] btrfs: make use of immutable biovecs Dongsu Park
2014-12-22 11:48             ` [RFC PATCH 07/17] block: replace sg_iovec with iov_iter Dongsu Park
2014-12-22 11:48               ` [RFC PATCH 08/17] block: refactor __bio_copy_iov() Dongsu Park
2014-12-22 11:48                 ` [RFC PATCH 09/17] block: refactor iov_count_pages() from bio_{copy,map}_user_iov() Dongsu Park
2014-12-22 11:48                   ` [RFC PATCH 10/17] block: refactor bio_get_user_pages() from __bio_map_user_iov() Dongsu Park
2014-12-22 11:48                     ` [RFC PATCH 11/17] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Dongsu Park
2014-12-22 11:48                       ` [RFC PATCH 12/17] md/raid10: make sync_request_write() call bio_copy_data() Dongsu Park
2014-12-22 11:48                         ` Dongsu Park [this message]
2014-12-22 11:48                           ` [RFC PATCH 14/17] block: kill merge_bvec_fn() completely Dongsu Park
2014-12-22 11:48                             ` [RFC PATCH 15/17] fs: use helper bio_add_page() instead of open coding on bi_io_vec Dongsu Park
2014-12-22 11:48                               ` [RFC PATCH 16/17] fs: convert buffer head etc. to use immutable biovecs API Dongsu Park
2014-12-22 11:48                                 ` [RFC PATCH 17/17] Documentation: update notes in biovecs about arbitrarily sized bios Dongsu Park
2014-12-23 10:52                                   ` Christoph Hellwig
2014-12-23 12:34                                     ` Dongsu Park
2014-12-23 10:51                                 ` [RFC PATCH 16/17] fs: convert buffer head etc. to use immutable biovecs API Christoph Hellwig
2014-12-23 12:33                                   ` Dongsu Park
2014-12-22 15:22                               ` [RFC PATCH 15/17] fs: use helper bio_add_page() instead of open coding on bi_io_vec Dave Kleikamp
2014-12-22 15:22                                 ` Dave Kleikamp
2014-12-23 10:48                         ` [RFC PATCH 12/17] md/raid10: make sync_request_write() call bio_copy_data() Christoph Hellwig
2014-12-23 12:31                           ` Dongsu Park
2014-12-23 10:45                 ` [RFC PATCH 08/17] block: refactor __bio_copy_iov() Christoph Hellwig
2014-12-23 12:24                   ` Dongsu Park
2014-12-23 10:44               ` [RFC PATCH 07/17] block: replace sg_iovec with iov_iter Christoph Hellwig
2014-12-23 12:18                 ` Dongsu Park
2014-12-27 15:03                   ` Christoph Hellwig
2014-12-23 10:35             ` [RFC PATCH 06/17] btrfs: make use of immutable biovecs Christoph Hellwig
2014-12-23 12:09               ` Dongsu Park
     [not found]           ` <e4b7b017eaa81784889ebb2a4e6a7d4366adf13a.1419241597.git.dongsu.park@profit bricks.com>
2014-12-23 14:44             ` [RFC PATCH 05/17] btrfs: remove bio splitting and merge_bvec_fn() calls Chris Mason
2014-12-23 10:23       ` [RFC PATCH 03/17] block: simplify issueing discard, write_same, zeroout Christoph Hellwig
2014-12-23 10:22     ` [RFC PATCH 02/17] block: simplify bio_add_page() Christoph Hellwig
2014-12-23 11:46       ` Dongsu Park
2014-12-23 10:16   ` [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios Christoph Hellwig
2014-12-23 11:41     ` Dongsu Park
2014-12-27 15:02       ` Christoph Hellwig
2014-12-23 19:14   ` Geoff Levand
2014-12-24 10:37     ` Dongsu Park
2014-12-25  6:09   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e35d37b66d621c51f2eb24ff024291bd1d53422e.1419241597.git.dongsu.park@profitbricks.com \
    --to=dongsu.park@profitbricks.com \
    --cc=axboe@kernel.dk \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mlin@minggr.net \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.