* Re: [PATCH] media: budget-core: Improve exception handling in budget_register()
@ 2020-06-03 18:24 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-06-03 18:24 UTC (permalink / raw)
To: Chuhong Yuan, linux-media
Cc: linux-kernel, kernel-janitors, Mauro Carvalho Chehab
> Add the missed undo functions for error handling to fix it.
…
> +++ b/drivers/media/pci/ttpci/budget-core.c
> @@ -369,20 +369,25 @@ static int budget_register(struct budget *budget)
…
> return 0;
> +
+err:
> + dvb_dmxdev_release(&budget->dmxdev);
> + dvb_dmx_release(&budget->demux);
> + return ret;
> }
…
Perhaps use the label “release_dmxdev” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: budget-core: Improve exception handling in budget_register()
@ 2020-06-03 18:24 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-06-03 18:24 UTC (permalink / raw)
To: Chuhong Yuan, linux-media
Cc: linux-kernel, kernel-janitors, Mauro Carvalho Chehab
> Add the missed undo functions for error handling to fix it.
…
> +++ b/drivers/media/pci/ttpci/budget-core.c
> @@ -369,20 +369,25 @@ static int budget_register(struct budget *budget)
…
> return 0;
> +
+err:
> + dvb_dmxdev_release(&budget->dmxdev);
> + dvb_dmx_release(&budget->demux);
> + return ret;
> }
…
Perhaps use the label “release_dmxdev” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 18:24 [PATCH] media: budget-core: Improve exception handling in budget_register() Markus Elfring
2020-06-03 18:24 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.