[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[Stefan Roese]

Without this U-Boot specific property, booting on Armada XP theadorable
fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
not scanned, so the UART node is missing (and others).

I'm not adding this property in an *u-boot.dtsi file, since there is
none matching the generic rules for all files including this dtsi
file. So to not miss any of the boards using this dtsi file, I'm
adding it to this file directly, which makes the Linux merge a less
easy unforunately.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Chris Packham <judge.packham@gmail.com>
Cc: Marek Behún <marek.behun@nic.cz>
---
 arch/arm/dts/armada-370-xp.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/armada-370-xp.dtsi b/arch/arm/dts/armada-370-xp.dtsi
index e4c35d4e98..50fc0be9f7 100644
--- a/arch/arm/dts/armada-370-xp.dtsi
+++ b/arch/arm/dts/armada-370-xp.dtsi
@@ -102,6 +102,7 @@
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
+			u-boot,dm-pre-reloc;
 
 			rtc: rtc at 10300 {
 				compatible = "marvell,orion-rtc";
-- 
2.21.0

[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[Chris Packham]

On Fri, 10 May 2019, 11:34 PM Stefan Roese, <sr@denx.de> wrote:

> Without this U-Boot specific property, booting on Armada XP theadorable
> fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
> not scanned, so the UART node is missing (and others).
>
> I'm not adding this property in an *u-boot.dtsi file, since there is
> none matching the generic rules for all files including this dtsi
> file. So to not miss any of the boards using this dtsi file, I'm
> adding it to this file directly, which makes the Linux merge a less
> easy unforunately.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Chris Packham <judge.packham@gmail.com>
> Cc: Marek Behún <marek.behun@nic.cz>
>

Thanks. Is this a regression from my last sync? The only Armada XP like
platform I had access to was msys and that doesn't use SPL (yet).

Reviewed-by: Chris Packham <judge.packham@gmail.com>

---
>  arch/arm/dts/armada-370-xp.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/armada-370-xp.dtsi
> b/arch/arm/dts/armada-370-xp.dtsi
> index e4c35d4e98..50fc0be9f7 100644
> --- a/arch/arm/dts/armada-370-xp.dtsi
> +++ b/arch/arm/dts/armada-370-xp.dtsi
> @@ -102,6 +102,7 @@
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
> +                       u-boot,dm-pre-reloc;
>
>                         rtc: rtc at 10300 {
>                                 compatible = "marvell,orion-rtc";
> --
> 2.21.0
>
>

[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[Stefan Roese]

On 11.05.19 02:09, Chris Packham wrote:
> 
> 
> On Fri, 10 May 2019, 11:34 PM Stefan Roese, <sr at denx.de <mailto:sr@denx.de>> wrote:
> 
>     Without this U-Boot specific property, booting on Armada XP theadorable
>     fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
>     not scanned, so the UART node is missing (and others).
> 
>     I'm not adding this property in an *u-boot.dtsi file, since there is
>     none matching the generic rules for all files including this dtsi
>     file. So to not miss any of the boards using this dtsi file, I'm
>     adding it to this file directly, which makes the Linux merge a less
>     easy unforunately.
> 
>     Signed-off-by: Stefan Roese <sr at denx.de <mailto:sr@denx.de>>
>     Cc: Chris Packham <judge.packham at gmail.com <mailto:judge.packham@gmail.com>>
>     Cc: Marek Behún <marek.behun at nic.cz <mailto:marek.behun@nic.cz>>
> 
> 
> Thanks. Is this a regression from my last sync? The only Armada XP
> like platform I had access to was msys and that doesn't use SPL (yet).

I'm not 100% sure if its only a regression caused by your DT sync or
also by this patch:

c7a88dae "dm: remove pre reloc properties in SPL and TPL device tree"

I stopped debugging at some point, once I had the node enabled in the
SPL DT again.
  
> Reviewed-by: Chris Packham <judge.packham at gmail.com <mailto:judge.packham@gmail.com>>

Thanks,
Stefan

[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[Chris Packham]

On Sun, May 12, 2019 at 10:09 PM Stefan Roese <sr@denx.de> wrote:
>
> On 11.05.19 02:09, Chris Packham wrote:
> >
> >
> > On Fri, 10 May 2019, 11:34 PM Stefan Roese, <sr at denx.de <mailto:sr@denx.de>> wrote:
> >
> >     Without this U-Boot specific property, booting on Armada XP theadorable
> >     fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
> >     not scanned, so the UART node is missing (and others).
> >
> >     I'm not adding this property in an *u-boot.dtsi file, since there is
> >     none matching the generic rules for all files including this dtsi
> >     file. So to not miss any of the boards using this dtsi file, I'm
> >     adding it to this file directly, which makes the Linux merge a less
> >     easy unforunately.
> >
> >     Signed-off-by: Stefan Roese <sr at denx.de <mailto:sr@denx.de>>
> >     Cc: Chris Packham <judge.packham at gmail.com <mailto:judge.packham@gmail.com>>
> >     Cc: Marek Behún <marek.behun at nic.cz <mailto:marek.behun@nic.cz>>
> >
> >
> > Thanks. Is this a regression from my last sync? The only Armada XP
> > like platform I had access to was msys and that doesn't use SPL (yet).
>
> I'm not 100% sure if its only a regression caused by your DT sync or
> also by this patch:
>
> c7a88dae "dm: remove pre reloc properties in SPL and TPL device tree"
>
> I stopped debugging at some point, once I had the node enabled in the
> SPL DT again.
>
> > Reviewed-by: Chris Packham <judge.packham at gmail.com <mailto:judge.packham@gmail.com>>

^^^ Gah, this is from the gmail app on my tablet it seems intent on
linkifying things now. This has been known to make the patchwork
client spew html into the patch when you download it.

[U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

[Stefan Roese]

On 10.05.19 13:34, Stefan Roese wrote:
> Without this U-Boot specific property, booting on Armada XP theadorable
> fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
> not scanned, so the UART node is missing (and others).
> 
> I'm not adding this property in an *u-boot.dtsi file, since there is
> none matching the generic rules for all files including this dtsi
> file. So to not miss any of the boards using this dtsi file, I'm
> adding it to this file directly, which makes the Linux merge a less
> easy unforunately.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Chris Packham <judge.packham@gmail.com>
> Cc: Marek Behún <marek.behun@nic.cz>

Applied to u-boot-marvell/master.

Thanks,
Stefan