From: Marek Vasut <marex@denx.de>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Lucas Stach <l.stach@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-imx@nxp.com
Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control
Date: Wed, 15 Jun 2022 17:08:28 +0200 [thread overview]
Message-ID: <e37f811e-8a3e-74aa-8685-34b224bc1c22@denx.de> (raw)
In-Reply-To: <Yqns7VcHZ81A0dFL@abelvesa>
On 6/15/22 16:30, Abel Vesa wrote:
[...]
>> +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
>> +{
>> + struct clk_imx8mp_audiomix_priv *priv;
>> + struct device *dev = &pdev->dev;
>> + struct resource *res;
>> + void __iomem *base;
>> + struct clk_hw *hw;
>> + int i;
>> +
>> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>> + if (!priv)
>> + return -ENOMEM;
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + base = devm_ioremap_resource(dev, res);
>> + if (IS_ERR(base))
>> + return PTR_ERR(base);
>> +
>
> Hmm, the audiomix blk-ctl driver uses the PD for this device.
> That is not going to work.
What is not going to work. Can you elaborate on your concerns ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-15 15:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 20:41 [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Marek Vasut
2022-05-04 20:41 ` [PATCH 2/4] dt-bindings: clock: " Marek Vasut
2022-05-04 20:41 ` Marek Vasut
2022-05-16 23:59 ` Rob Herring
2022-05-16 23:59 ` Rob Herring
2022-05-04 20:41 ` [PATCH 3/4] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Marek Vasut
2022-05-04 20:41 ` [PATCH 4/4] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2022-06-15 14:30 ` [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Abel Vesa
2022-06-15 15:08 ` Marek Vasut [this message]
2022-06-15 15:47 ` Abel Vesa
2022-06-15 15:56 ` Abel Vesa
2022-06-15 21:48 ` Marek Vasut
2022-06-16 2:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37f811e-8a3e-74aa-8685-34b224bc1c22@denx.de \
--to=marex@denx.de \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.