* [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload
@ 2022-09-23 7:35 Nirmoy Das
2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das
` (7 more replies)
0 siblings, 8 replies; 21+ messages in thread
From: Nirmoy Das @ 2022-09-23 7:35 UTC (permalink / raw)
To: intel-gfx; +Cc: chris.p.wilson, matthew.auld
i915_gem_drain_freed_objects() might not be enough to
free all the objects and RCU delayed work might get
scheduled after the i915 device struct gets freed.
Call i915_gem_drain_workqueue() to catch all RCU delayed work.
Suggested-by: Chris Wilson <chris.p.wilson@intel.com>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 88df9a35e0fe..7541028caebd 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv)
void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
{
- i915_gem_drain_freed_objects(dev_priv);
+ i915_gem_drain_workqueue(dev_priv);
GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
--
2.37.3
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das @ 2022-09-23 7:35 ` Nirmoy Das 2022-09-27 7:43 ` Andrzej Hajda 2022-09-23 8:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload Patchwork ` (6 subsequent siblings) 7 siblings, 1 reply; 21+ messages in thread From: Nirmoy Das @ 2022-09-23 7:35 UTC (permalink / raw) To: intel-gfx; +Cc: chris.p.wilson, matthew.auld i915_gem_drain_workqueue() call i915_gem_drain_freed_objects() so no need to call that again. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 -- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7541028caebd..55d605c0c55d 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1236,8 +1236,6 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv) /* Flush any outstanding unpin_work. */ i915_gem_drain_workqueue(dev_priv); - - i915_gem_drain_freed_objects(dev_priv); } void i915_gem_driver_release(struct drm_i915_private *dev_priv) diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c index fff11c90f1fa..f6a7c0bd2955 100644 --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c @@ -67,7 +67,6 @@ static void mock_device_release(struct drm_device *dev) intel_gt_driver_remove(to_gt(i915)); i915_gem_drain_workqueue(i915); - i915_gem_drain_freed_objects(i915); mock_fini_ggtt(to_gt(i915)->ggtt); destroy_workqueue(i915->wq); -- 2.37.3 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects 2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das @ 2022-09-27 7:43 ` Andrzej Hajda 0 siblings, 0 replies; 21+ messages in thread From: Andrzej Hajda @ 2022-09-27 7:43 UTC (permalink / raw) To: Nirmoy Das, intel-gfx; +Cc: matthew.auld, chris.p.wilson On 23.09.2022 09:35, Nirmoy Das wrote: > i915_gem_drain_workqueue() call i915_gem_drain_freed_objects() > so no need to call that again. > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > drivers/gpu/drm/i915/i915_gem.c | 2 -- > drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 7541028caebd..55d605c0c55d 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1236,8 +1236,6 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv) > > /* Flush any outstanding unpin_work. */ > i915_gem_drain_workqueue(dev_priv); > - > - i915_gem_drain_freed_objects(dev_priv); > } > > void i915_gem_driver_release(struct drm_i915_private *dev_priv) > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > index fff11c90f1fa..f6a7c0bd2955 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > @@ -67,7 +67,6 @@ static void mock_device_release(struct drm_device *dev) > intel_gt_driver_remove(to_gt(i915)); > > i915_gem_drain_workqueue(i915); > - i915_gem_drain_freed_objects(i915); > > mock_fini_ggtt(to_gt(i915)->ggtt); > destroy_workqueue(i915->wq); ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das 2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das @ 2022-09-23 8:42 ` Patchwork 2022-09-23 19:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork ` (5 subsequent siblings) 7 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2022-09-23 8:42 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6355 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171 -> Patchwork_108944v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/index.html Participating hosts (44 -> 42) ------------------------------ Missing (2): fi-hsw-4770 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_108944v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gt_heartbeat: - fi-bxt-dsi: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@hangcheck: - fi-hsw-g3258: [PASS][3] -> [INCOMPLETE][4] ([i915#3303] / [i915#4785]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html * igt@runner@aborted: - fi-hsw-g3258: NOTRUN -> [FAIL][5] ([fdo#109271] / [i915#4312]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-hsw-g3258/igt@runner@aborted.html #### Possible fixes #### * igt@gem_ctx_create@basic-files: - {fi-tgl-mst}: [DMESG-WARN][6] -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-tgl-mst/igt@gem_ctx_create@basic-files.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-tgl-mst/igt@gem_ctx_create@basic-files.html * igt@gem_exec_suspend@basic-s0@smem: - {bat-rplp-1}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@lmem0: - {bat-dg2-11}: [DMESG-WARN][10] ([i915#6816]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html * igt@gem_exec_suspend@basic-s3@smem: - {bat-adlm-1}: [DMESG-WARN][12] ([i915#2867]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/bat-adlm-1/igt@gem_exec_suspend@basic-s3@smem.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/bat-adlm-1/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@gt_pm: - {fi-tgl-mst}: [DMESG-FAIL][14] ([i915#3987]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-tgl-mst/igt@i915_selftest@live@gt_pm.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-tgl-mst/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@hugepages: - {bat-rpls-1}: [DMESG-WARN][16] ([i915#5278]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/bat-rpls-1/igt@i915_selftest@live@hugepages.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/bat-rpls-1/igt@i915_selftest@live@hugepages.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: - fi-bsw-kefka: [FAIL][18] ([i915#6298]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html #### Warnings #### * igt@runner@aborted: - fi-kbl-soraka: [FAIL][20] ([i915#6641] / [i915#6894]) -> [FAIL][21] ([i915#6641]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/fi-kbl-soraka/igt@runner@aborted.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/fi-kbl-soraka/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 [i915#6641]: https://gitlab.freedesktop.org/drm/intel/issues/6641 [i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816 [i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818 [i915#6894]: https://gitlab.freedesktop.org/drm/intel/issues/6894 Build changes ------------- * Linux: CI_DRM_12171 -> Patchwork_108944v1 CI-20190529: 20190529 CI_DRM_12171: 37f64f22c82d8003c6509dd8e4928ee0348bd27f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6662: dcb1d7a8822e62935f4fe3f2e6a04caaee669369 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108944v1: 37f64f22c82d8003c6509dd8e4928ee0348bd27f @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits e22588840979 drm/i915: remove excessive i915_gem_drain_freed_objects 407da27e4982 drm/i915: Fix a potential UAF at device unload == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/index.html [-- Attachment #2: Type: text/html, Size: 7165 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix a potential UAF at device unload 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das 2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das 2022-09-23 8:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload Patchwork @ 2022-09-23 19:50 ` Patchwork 2022-09-26 20:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) Patchwork ` (4 subsequent siblings) 7 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2022-09-23 19:50 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 19498 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload URL : https://patchwork.freedesktop.org/series/108944/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12171_full -> Patchwork_108944v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_108944v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_108944v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_108944v1_full: ### IGT changes ### #### Possible regressions #### * igt@gem_eio@hibernate: - shard-snb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-snb7/igt@gem_eio@hibernate.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-snb2/igt@gem_eio@hibernate.html Known issues ------------ Here are the changes found in Patchwork_108944v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_buddy@all: - shard-iclb: NOTRUN -> [SKIP][3] ([i915#6433]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@drm_buddy@all.html * igt@gem_exec_balancer@parallel-contexts: - shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525]) +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@gem_exec_balancer@parallel-contexts.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][6] -> [FAIL][7] ([i915#2846]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk5/igt@gem_exec_fair@basic-deadline.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk1/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][8] -> [FAIL][9] ([i915#2842]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html - shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_lmem_swapping@parallel-random-verify-ccs: - shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +3 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl6/igt@gem_lmem_swapping@parallel-random-verify-ccs.html * igt@gem_pxp@reject-modify-context-protection-off-1: - shard-iclb: NOTRUN -> [SKIP][13] ([i915#4270]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@gem_pxp@reject-modify-context-protection-off-1.html * igt@gem_render_copy@linear-to-vebox-y-tiled: - shard-iclb: NOTRUN -> [SKIP][14] ([i915#768]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@gem_render_copy@linear-to-vebox-y-tiled.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl2/igt@i915_suspend@sysfs-reader.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl2/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@y-tiled-8bpp-rotate-270: - shard-iclb: NOTRUN -> [SKIP][17] ([fdo#110725] / [fdo#111614]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886]) +6 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs: - shard-iclb: NOTRUN -> [SKIP][19] ([fdo#109278]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html * igt@kms_chamelium@vga-hpd-after-suspend: - shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl2/igt@kms_chamelium@vga-hpd-after-suspend.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - shard-iclb: NOTRUN -> [SKIP][21] ([i915#4103]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [PASS][22] -> [FAIL][23] ([i915#2346]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_flip@2x-nonexisting-fb: - shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271]) +133 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl8/igt@kms_flip@2x-nonexisting-fb.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#79]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html * igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][27] ([i915#3555]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][28] ([i915#2587] / [i915#2672]) +2 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][29] ([i915#2672]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-iclb: [PASS][30] -> [FAIL][31] ([i915#1888] / [i915#2546]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render: - shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109280]) +2 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][33] ([fdo#108145] / [i915#265]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_psr2_su@page_flip-p010: - shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#658]) +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl6/igt@kms_psr2_su@page_flip-p010.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#2437]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl1/igt@kms_writeback@writeback-pixel-formats.html * igt@perf@polling-parameterized: - shard-glk: [PASS][38] -> [FAIL][39] ([i915#5639]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk1/igt@perf@polling-parameterized.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk8/igt@perf@polling-parameterized.html * igt@sysfs_clients@split-10: - shard-iclb: NOTRUN -> [SKIP][40] ([i915#2994]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@sysfs_clients@split-10.html #### Possible fixes #### * igt@gem_eio@reset-stress: - shard-tglb: [FAIL][41] ([i915#5784]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-tglb2/igt@gem_eio@reset-stress.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-tglb7/igt@gem_eio@reset-stress.html * igt@gem_exec_balancer@parallel-keep-in-fence: - shard-iclb: [SKIP][43] ([i915#4525]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb1/igt@gem_exec_balancer@parallel-keep-in-fence.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-glk: [FAIL][45] ([i915#2842]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-glk6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][47] ([i915#2842]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-iclb: [INCOMPLETE][49] -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb7/igt@i915_pm_rpm@system-suspend-execbuf.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb6/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@i915_pm_rps@engine-order: - shard-apl: [FAIL][51] ([i915#6537]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl7/igt@i915_pm_rps@engine-order.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl7/igt@i915_pm_rps@engine-order.html * igt@i915_selftest@live@hangcheck: - shard-tglb: [DMESG-WARN][53] ([i915#5591]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-tglb1/igt@i915_selftest@live@hangcheck.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-tglb3/igt@i915_selftest@live@hangcheck.html * igt@kms_ccs@pipe-b-random-ccs-data-yf_tiled_ccs: - shard-apl: [DMESG-WARN][55] ([i915#62]) -> [PASS][56] +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl8/igt@kms_ccs@pipe-b-random-ccs-data-yf_tiled_ccs.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl6/igt@kms_ccs@pipe-b-random-ccs-data-yf_tiled_ccs.html * igt@kms_flip@flip-vs-suspend-interruptible@b-edp1: - shard-tglb: [DMESG-WARN][57] ([i915#2411] / [i915#2867]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-tglb2/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_gtt.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-apl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +4 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Warnings #### * igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1: - shard-apl: [DMESG-WARN][63] ([i915#62]) -> [DMESG-WARN][64] ([i915#180]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-apl8/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-apl6/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf: - shard-iclb: [SKIP][65] ([i915#2920]) -> [SKIP][66] ([i915#658]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12171/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_12171 -> Patchwork_108944v1 CI-20190529: 20190529 CI_DRM_12171: 37f64f22c82d8003c6509dd8e4928ee0348bd27f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6662: dcb1d7a8822e62935f4fe3f2e6a04caaee669369 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108944v1: 37f64f22c82d8003c6509dd8e4928ee0348bd27f @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v1/index.html [-- Attachment #2: Type: text/html, Size: 20792 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das ` (2 preceding siblings ...) 2022-09-23 19:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2022-09-26 20:48 ` Patchwork 2022-09-27 5:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2022-09-26 20:48 UTC (permalink / raw) To: Das, Nirmoy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 10017 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_108944v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/index.html Participating hosts (46 -> 44) ------------------------------ Additional (1): fi-rkl-11600 Missing (3): fi-hsw-4770 fi-icl-u2 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_108944v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@gem_lmem_swapping@basic.html * igt@gem_tiled_pread_basic: - fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#3282]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3012]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html * igt@i915_suspend@basic-s3-without-i915: - fi-rkl-11600: NOTRUN -> [INCOMPLETE][5] ([i915#5982]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_chamelium@hdmi-edid-read: - fi-rkl-11600: NOTRUN -> [SKIP][6] ([fdo#111827]) +7 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#4103]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions: - fi-bsw-kefka: [PASS][8] -> [FAIL][9] ([i915#6298]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html * igt@kms_force_connector_basic@force-load-detect: - fi-rkl-11600: NOTRUN -> [SKIP][10] ([fdo#109285] / [i915#4098]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@primary_page_flip: - fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#1072]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@kms_psr@primary_page_flip.html * igt@kms_setmode@basic-clone-single-crtc: - fi-rkl-11600: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#4098]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-read: - fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@prime_vgem@basic-read.html * igt@prime_vgem@basic-userptr: - fi-rkl-11600: NOTRUN -> [SKIP][14] ([fdo#109295] / [i915#3301] / [i915#3708]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-rkl-11600/igt@prime_vgem@basic-userptr.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][15] ([i915#4312]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-bdw-5557u/igt@runner@aborted.html #### Possible fixes #### * igt@gem_ringfill@basic-all: - {bat-dg2-9}: [FAIL][16] ([i915#5886]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-dg2-9/igt@gem_ringfill@basic-all.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/bat-dg2-9/igt@gem_ringfill@basic-all.html * igt@i915_selftest@live@late_gt_pm: - fi-cfl-8109u: [DMESG-WARN][18] ([i915#5904]) -> [PASS][19] +30 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html * igt@i915_selftest@live@requests: - {bat-rpls-1}: [INCOMPLETE][20] ([i915#4983] / [i915#6257] / [i915#6380]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rpls-1/igt@i915_selftest@live@requests.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/bat-rpls-1/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@slpc: - {bat-rplp-1}: [DMESG-FAIL][22] -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rplp-1/igt@i915_selftest@live@slpc.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/bat-rplp-1/igt@i915_selftest@live@slpc.html * igt@i915_suspend@basic-s2idle-without-i915: - fi-cfl-8109u: [DMESG-WARN][24] ([i915#5904] / [i915#62]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [DMESG-FAIL][26] ([i915#62]) -> [PASS][27] +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1: - fi-cfl-8109u: [DMESG-WARN][28] ([i915#62]) -> [PASS][29] +10 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2: - {bat-dg2-11}: [FAIL][30] ([i915#6818]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278 [i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828 [i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886 [i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904 [i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 [i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380 [i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816 [i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818 Build changes ------------- * Linux: CI_DRM_12185 -> Patchwork_108944v2 CI-20190529: 20190529 CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108944v2: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits ad5216cc79be drm/i915: remove excessive i915_gem_drain_freed_objects 6d3f750b643b drm/i915: Fix a potential UAF at device unload == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/index.html [-- Attachment #2: Type: text/html, Size: 11239 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das ` (3 preceding siblings ...) 2022-09-26 20:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) Patchwork @ 2022-09-27 5:49 ` Patchwork 2022-09-27 7:43 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Andrzej Hajda ` (2 subsequent siblings) 7 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2022-09-27 5:49 UTC (permalink / raw) To: Das, Nirmoy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 25748 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_108944v2_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (12 -> 12) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_108944v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@display-3x: - shard-iclb: NOTRUN -> [SKIP][1] ([i915#1839]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@feature_discovery@display-3x.html * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [PASS][2] -> [SKIP][3] ([i915#4525]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_capture@capture-recoverable: - shard-iclb: NOTRUN -> [SKIP][4] ([i915#6344]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_exec_capture@capture-recoverable.html * igt@gem_exec_fair@basic-none@vcs1: - shard-iclb: NOTRUN -> [FAIL][5] ([i915#2842]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][8] -> [FAIL][9] ([i915#2842]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-iclb: NOTRUN -> [SKIP][10] ([i915#2190]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@verify-ccs: - shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@gem_lmem_swapping@verify-ccs.html * igt@gem_pxp@create-regular-context-2: - shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271]) +11 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@gem_pxp@create-regular-context-2.html * igt@gem_pxp@reject-modify-context-protection-on: - shard-iclb: NOTRUN -> [SKIP][13] ([i915#4270]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_pxp@reject-modify-context-protection-on.html * igt@gem_render_copy@yf-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][14] ([i915#768]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_render_copy@yf-tiled-to-vebox-linear.html * igt@gen3_render_tiledy_blits: - shard-iclb: NOTRUN -> [SKIP][15] ([fdo#109289]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gen3_render_tiledy_blits.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#5566] / [i915#716]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl7/igt@gen9_exec_parse@allowed-single.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@bb-start-out: - shard-iclb: NOTRUN -> [SKIP][18] ([i915#2856]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gen9_exec_parse@bb-start-out.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][20] -> [DMESG-WARN][21] ([i915#180]) +3 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1: - shard-glk: [PASS][22] -> [FAIL][23] ([i915#2521]) +2 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk3/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk6/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-iclb: NOTRUN -> [SKIP][24] ([i915#5286]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@y-tiled-32bpp-rotate-180: - shard-glk: [PASS][25] -> [DMESG-FAIL][26] ([i915#118] / [i915#1888] / [i915#5138]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk1/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][27] ([fdo#110723]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109278] / [i915#3886]) +4 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs: - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278]) +5 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html * igt@kms_color_chamelium@ctm-negative: - shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +2 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_color_chamelium@ctm-negative.html * igt@kms_cursor_crc@cursor-offscreen-512x170: - shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109279] / [i915#3359]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_cursor_crc@cursor-offscreen-512x170.html * igt@kms_cursor_crc@cursor-sliding-512x170: - shard-iclb: NOTRUN -> [SKIP][32] ([i915#3359]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_cursor_crc@cursor-sliding-512x170.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#1982] / [i915#62]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-busy-flip: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109274]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_flip@2x-busy-flip.html * igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][36] -> [FAIL][37] ([i915#2122]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk2/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][38] ([i915#2587] / [i915#2672]) +7 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][39] ([i915#2672]) +6 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode: - shard-apl: [PASS][40] -> [DMESG-WARN][41] ([i915#62]) +6 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][42] ([i915#3555]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109280]) +8 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1: - shard-iclb: NOTRUN -> [SKIP][44] ([i915#5176]) +2 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1: - shard-iclb: NOTRUN -> [SKIP][45] ([i915#5235]) +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [PASS][46] -> [SKIP][47] ([i915#5235]) +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr2_su@page_flip-xrgb8888: - shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109642] / [fdo#111068] / [i915#658]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_psr2_su@page_flip-xrgb8888.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109441]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-iclb: [PASS][52] -> [SKIP][53] ([i915#5519]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb8/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@perf_pmu@event-wait@rcs0: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#112283]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@perf_pmu@event-wait@rcs0.html #### Possible fixes #### * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglb: [FAIL][55] ([i915#6268]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_exec_balancer@parallel-keep-in-fence: - shard-iclb: [SKIP][57] ([i915#4525]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][59] ([i915#2846]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/igt@gem_exec_fair@basic-deadline.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk5/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][61] ([i915#2842]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb5/igt@gem_exec_fair@basic-none-share@rcs0.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-glk: [FAIL][63] ([i915#2842]) -> [PASS][64] +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/igt@gem_exec_fair@basic-none-vip@rcs0.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [FAIL][65] ([i915#2842]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_suspend@basic-s3@smem: - shard-apl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@gem_exec_suspend@basic-s3@smem.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_exec_whisper@basic-contexts-forked: - shard-iclb: [INCOMPLETE][69] ([i915#6453]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb7/igt@gem_exec_whisper@basic-contexts-forked.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb4/igt@gem_exec_whisper@basic-contexts-forked.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][71] ([i915#2190]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@gem_huc_copy@huc-copy.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-tglb1/igt@gem_huc_copy@huc-copy.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [SKIP][73] ([i915#4281]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1: - shard-iclb: [SKIP][75] ([i915#5176]) -> [PASS][76] +2 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [SKIP][77] ([i915#5235]) -> [PASS][78] +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb5/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb6/igt@kms_psr@psr2_primary_blt.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@kms_psr@psr2_primary_blt.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [FAIL][81] ([i915#6117]) -> [SKIP][82] ([i915#4525]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb4/igt@gem_exec_balancer@parallel-ordering.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][83] ([i915#588]) -> [SKIP][84] ([i915#658]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][85] ([fdo#111068] / [i915#658]) -> [SKIP][86] ([i915#2920]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@kms_psr2_sf@cursor-plane-update-sf.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-move-continuous-sf: - shard-iclb: [SKIP][87] ([i915#2920]) -> [SKIP][88] ([i915#658]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area: - shard-iclb: [SKIP][89] ([i915#2920]) -> [SKIP][90] ([fdo#111068] / [i915#658]) +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html * igt@kms_psr2_su@page_flip-nv12: - shard-iclb: [SKIP][91] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][92] ([i915#5939]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html * igt@kms_psr2_su@page_flip-p010: - shard-iclb: [FAIL][93] ([i915#5939]) -> [SKIP][94] ([fdo#109642] / [fdo#111068] / [i915#658]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-iclb1/igt@kms_psr2_su@page_flip-p010.html * igt@runner@aborted: - shard-apl: ([FAIL][95], [FAIL][96], [FAIL][97]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@runner@aborted.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@runner@aborted.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl2/igt@runner@aborted.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl3/igt@runner@aborted.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl6/igt@runner@aborted.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl8/igt@runner@aborted.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl8/igt@runner@aborted.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/shard-apl7/igt@runner@aborted.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588 [i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768 Build changes ------------- * Linux: CI_DRM_12185 -> Patchwork_108944v2 CI-20190529: 20190529 CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108944v2: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108944v2/index.html [-- Attachment #2: Type: text/html, Size: 30900 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das ` (4 preceding siblings ...) 2022-09-27 5:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2022-09-27 7:43 ` Andrzej Hajda 2022-09-29 11:32 ` Andi Shyti 2022-10-21 16:34 ` Ville Syrjälä 7 siblings, 0 replies; 21+ messages in thread From: Andrzej Hajda @ 2022-09-27 7:43 UTC (permalink / raw) To: Nirmoy Das, intel-gfx; +Cc: matthew.auld, chris.p.wilson On 23.09.2022 09:35, Nirmoy Das wrote: > i915_gem_drain_freed_objects() might not be enough to > free all the objects and RCU delayed work might get > scheduled after the i915 device struct gets freed. > > Call i915_gem_drain_workqueue() to catch all RCU delayed work. > > Suggested-by: Chris Wilson <chris.p.wilson@intel.com> > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 88df9a35e0fe..7541028caebd 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) > > void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) > { > - i915_gem_drain_freed_objects(dev_priv); > + i915_gem_drain_workqueue(dev_priv); > GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); > GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das ` (5 preceding siblings ...) 2022-09-27 7:43 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Andrzej Hajda @ 2022-09-29 11:32 ` Andi Shyti 2022-09-29 11:36 ` Das, Nirmoy 2022-10-21 16:34 ` Ville Syrjälä 7 siblings, 1 reply; 21+ messages in thread From: Andi Shyti @ 2022-09-29 11:32 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx, matthew.auld, chris.p.wilson Hi Nirmoy, On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: > i915_gem_drain_freed_objects() might not be enough to > free all the objects and RCU delayed work might get > scheduled after the i915 device struct gets freed. > > Call i915_gem_drain_workqueue() to catch all RCU delayed work. > > Suggested-by: Chris Wilson <chris.p.wilson@intel.com> > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> pushed to drm-intel-gt-next Thanks, Andi ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-29 11:32 ` Andi Shyti @ 2022-09-29 11:36 ` Das, Nirmoy 0 siblings, 0 replies; 21+ messages in thread From: Das, Nirmoy @ 2022-09-29 11:36 UTC (permalink / raw) To: intel-gfx On 9/29/2022 1:32 PM, Andi Shyti wrote: > Hi Nirmoy, > > On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: >> i915_gem_drain_freed_objects() might not be enough to >> free all the objects and RCU delayed work might get >> scheduled after the i915 device struct gets freed. >> >> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >> >> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > pushed to drm-intel-gt-next Thanks, Andi! > > Thanks, > Andi ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das ` (6 preceding siblings ...) 2022-09-29 11:32 ` Andi Shyti @ 2022-10-21 16:34 ` Ville Syrjälä 2022-10-24 8:08 ` Das, Nirmoy 7 siblings, 1 reply; 21+ messages in thread From: Ville Syrjälä @ 2022-10-21 16:34 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx, matthew.auld, chris.p.wilson On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: > i915_gem_drain_freed_objects() might not be enough to > free all the objects and RCU delayed work might get > scheduled after the i915 device struct gets freed. > > Call i915_gem_drain_workqueue() to catch all RCU delayed work. shard-snb is stil hitting the mm.shrink_count WARNn reliably, and things go downhill after that. > > Suggested-by: Chris Wilson <chris.p.wilson@intel.com> > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 88df9a35e0fe..7541028caebd 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) > > void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) > { > - i915_gem_drain_freed_objects(dev_priv); > + i915_gem_drain_workqueue(dev_priv); > GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); > GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); > -- > 2.37.3 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-10-21 16:34 ` Ville Syrjälä @ 2022-10-24 8:08 ` Das, Nirmoy 2022-11-02 17:55 ` Ville Syrjälä 0 siblings, 1 reply; 21+ messages in thread From: Das, Nirmoy @ 2022-10-24 8:08 UTC (permalink / raw) To: Ville Syrjälä, Nirmoy Das Cc: intel-gfx, matthew.auld, chris.p.wilson On 10/21/2022 6:34 PM, Ville Syrjälä wrote: > On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: >> i915_gem_drain_freed_objects() might not be enough to >> free all the objects and RCU delayed work might get >> scheduled after the i915 device struct gets freed. >> >> Call i915_gem_drain_workqueue() to catch all RCU delayed work. > shard-snb is stil hitting the mm.shrink_count WARNn reliably, > and things go downhill after that. Looks better now again. Going to look into that. Thanks, Nirmoy > >> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >> --- >> drivers/gpu/drm/i915/i915_gem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c >> index 88df9a35e0fe..7541028caebd 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) >> >> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >> { >> - i915_gem_drain_freed_objects(dev_priv); >> + i915_gem_drain_workqueue(dev_priv); >> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >> -- >> 2.37.3 ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-10-24 8:08 ` Das, Nirmoy @ 2022-11-02 17:55 ` Ville Syrjälä 2022-11-02 18:37 ` Das, Nirmoy 0 siblings, 1 reply; 21+ messages in thread From: Ville Syrjälä @ 2022-11-02 17:55 UTC (permalink / raw) To: Das, Nirmoy; +Cc: intel-gfx, matthew.auld, chris.p.wilson, Nirmoy Das On Mon, Oct 24, 2022 at 10:08:29AM +0200, Das, Nirmoy wrote: > > On 10/21/2022 6:34 PM, Ville Syrjälä wrote: > > On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: > >> i915_gem_drain_freed_objects() might not be enough to > >> free all the objects and RCU delayed work might get > >> scheduled after the i915 device struct gets freed. > >> > >> Call i915_gem_drain_workqueue() to catch all RCU delayed work. > > shard-snb is stil hitting the mm.shrink_count WARNn reliably, > > and things go downhill after that. > > > Looks better now again. Going to look into that. Looks to be still hitting it occasionally in module reload tests: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7033/shard-snb5/igt@i915_module_load@reload.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7035/shard-snb7/igt@perf_pmu@module-unload.html > > > Thanks, > > Nirmoy > > > > >> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> > >> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > >> --- > >> drivers/gpu/drm/i915/i915_gem.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > >> index 88df9a35e0fe..7541028caebd 100644 > >> --- a/drivers/gpu/drm/i915/i915_gem.c > >> +++ b/drivers/gpu/drm/i915/i915_gem.c > >> @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) > >> > >> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) > >> { > >> - i915_gem_drain_freed_objects(dev_priv); > >> + i915_gem_drain_workqueue(dev_priv); > >> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); > >> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > >> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); > >> -- > >> 2.37.3 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-11-02 17:55 ` Ville Syrjälä @ 2022-11-02 18:37 ` Das, Nirmoy 0 siblings, 0 replies; 21+ messages in thread From: Das, Nirmoy @ 2022-11-02 18:37 UTC (permalink / raw) To: Ville Syrjälä, Das, Nirmoy Cc: intel-gfx, matthew.auld, chris.p.wilson Hi Ville, On 11/2/2022 6:55 PM, Ville Syrjälä wrote: > On Mon, Oct 24, 2022 at 10:08:29AM +0200, Das, Nirmoy wrote: >> On 10/21/2022 6:34 PM, Ville Syrjälä wrote: >>> On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: >>>> i915_gem_drain_freed_objects() might not be enough to >>>> free all the objects and RCU delayed work might get >>>> scheduled after the i915 device struct gets freed. >>>> >>>> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >>> shard-snb is stil hitting the mm.shrink_count WARNn reliably, >>> and things go downhill after that. >> >> Looks better now again. Going to look into that. > Looks to be still hitting it occasionally in module reload tests: > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7033/shard-snb5/igt@i915_module_load@reload.html > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7035/shard-snb7/igt@perf_pmu@module-unload.html There are no snb in RIl so I ran this test on tgl-u for 6+ hours without any reproduction. Not sure why snb is so special here. May be we need your previous patch as well ? I will be on vacation from next week so unfortunately I won't be able work on it for few weeks. Regards, Nirmoy > >> >> Thanks, >> >> Nirmoy >> >>>> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >>>> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >>>> --- >>>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c >>>> index 88df9a35e0fe..7541028caebd 100644 >>>> --- a/drivers/gpu/drm/i915/i915_gem.c >>>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>>> @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) >>>> >>>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >>>> { >>>> - i915_gem_drain_freed_objects(dev_priv); >>>> + i915_gem_drain_workqueue(dev_priv); >>>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >>>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >>>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >>>> -- >>>> 2.37.3 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload @ 2022-09-08 20:07 Nirmoy Das 2022-09-09 8:55 ` Tvrtko Ursulin 0 siblings, 1 reply; 21+ messages in thread From: Nirmoy Das @ 2022-09-08 20:07 UTC (permalink / raw) To: intel-gfx; +Cc: matthew.auld i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call i915_gem_drain_workqueue() to catch all RCU delayed work. Suggested-by: Chris Wilson <chris.p.wilson@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 0f49ec9d494a..e8a053eaaa89 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) { - i915_gem_drain_freed_objects(dev_priv); + i915_gem_drain_workqueue(dev_priv); GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); -- 2.37.3 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-08 20:07 Nirmoy Das @ 2022-09-09 8:55 ` Tvrtko Ursulin 2022-09-21 15:53 ` Das, Nirmoy 0 siblings, 1 reply; 21+ messages in thread From: Tvrtko Ursulin @ 2022-09-09 8:55 UTC (permalink / raw) To: Nirmoy Das, intel-gfx; +Cc: matthew.auld On 08/09/2022 21:07, Nirmoy Das wrote: > i915_gem_drain_freed_objects() might not be enough to > free all the objects and RCU delayed work might get > scheduled after the i915 device struct gets freed. > > Call i915_gem_drain_workqueue() to catch all RCU delayed work. > > Suggested-by: Chris Wilson <chris.p.wilson@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 0f49ec9d494a..e8a053eaaa89 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv) > > void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) > { > - i915_gem_drain_freed_objects(dev_priv); > + i915_gem_drain_workqueue(dev_priv); > GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); > GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); Help me spot the place where RCU free worker schedules itself back to free more objects - if I got the rationale here right? Regards, Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-09 8:55 ` Tvrtko Ursulin @ 2022-09-21 15:53 ` Das, Nirmoy 2022-09-22 9:37 ` Tvrtko Ursulin 0 siblings, 1 reply; 21+ messages in thread From: Das, Nirmoy @ 2022-09-21 15:53 UTC (permalink / raw) To: Tvrtko Ursulin, Nirmoy Das, intel-gfx; +Cc: matthew.auld, Chris Wilson On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: > > On 08/09/2022 21:07, Nirmoy Das wrote: >> i915_gem_drain_freed_objects() might not be enough to >> free all the objects and RCU delayed work might get >> scheduled after the i915 device struct gets freed. >> >> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >> >> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >> --- >> drivers/gpu/drm/i915/i915_gem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_gem.c >> b/drivers/gpu/drm/i915/i915_gem.c >> index 0f49ec9d494a..e8a053eaaa89 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct >> drm_i915_private *dev_priv) >> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >> { >> - i915_gem_drain_freed_objects(dev_priv); >> + i915_gem_drain_workqueue(dev_priv); >> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); > > > Help me spot the place where RCU free worker schedules itself back to > free more objects - if I got the rationale here right? (Sorry for late reply, was on leave last week.) I had to clarify this with Chris. So when driver frees a obj, it does dma_resv_fini() which will drop reference for all the fences in it and a fence might reference to an object and upon release of that fence can trigger a release reference to an object. Regards, Nirmoy > > Regards, > > Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-21 15:53 ` Das, Nirmoy @ 2022-09-22 9:37 ` Tvrtko Ursulin 2022-09-22 12:11 ` Das, Nirmoy 0 siblings, 1 reply; 21+ messages in thread From: Tvrtko Ursulin @ 2022-09-22 9:37 UTC (permalink / raw) To: Das, Nirmoy, Nirmoy Das, intel-gfx; +Cc: matthew.auld, Chris Wilson On 21/09/2022 16:53, Das, Nirmoy wrote: > > On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: >> >> On 08/09/2022 21:07, Nirmoy Das wrote: >>> i915_gem_drain_freed_objects() might not be enough to >>> free all the objects and RCU delayed work might get >>> scheduled after the i915 device struct gets freed. >>> >>> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >>> >>> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >>> --- >>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_gem.c >>> b/drivers/gpu/drm/i915/i915_gem.c >>> index 0f49ec9d494a..e8a053eaaa89 100644 >>> --- a/drivers/gpu/drm/i915/i915_gem.c >>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>> @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct >>> drm_i915_private *dev_priv) >>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >>> { >>> - i915_gem_drain_freed_objects(dev_priv); >>> + i915_gem_drain_workqueue(dev_priv); >>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >> >> >> Help me spot the place where RCU free worker schedules itself back to >> free more objects - if I got the rationale here right? > (Sorry for late reply, was on leave last week.) > > I had to clarify this with Chris. So when driver frees a obj, it does > dma_resv_fini() which will drop reference > > for all the fences in it and a fence might reference to an object and > upon release of that fence can trigger a release reference to an object. Hmm I couldn't find that in code but never mind. It's just a stronger version of the same flushing and it's not on a path where speed matters so feel free to go with it. Regards, Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-22 9:37 ` Tvrtko Ursulin @ 2022-09-22 12:11 ` Das, Nirmoy 2022-09-22 12:28 ` Tvrtko Ursulin 0 siblings, 1 reply; 21+ messages in thread From: Das, Nirmoy @ 2022-09-22 12:11 UTC (permalink / raw) To: Tvrtko Ursulin, Das, Nirmoy, intel-gfx; +Cc: matthew.auld, Chris Wilson On 9/22/2022 11:37 AM, Tvrtko Ursulin wrote: > > On 21/09/2022 16:53, Das, Nirmoy wrote: >> >> On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: >>> >>> On 08/09/2022 21:07, Nirmoy Das wrote: >>>> i915_gem_drain_freed_objects() might not be enough to >>>> free all the objects and RCU delayed work might get >>>> scheduled after the i915 device struct gets freed. >>>> >>>> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >>>> >>>> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >>>> --- >>>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c >>>> b/drivers/gpu/drm/i915/i915_gem.c >>>> index 0f49ec9d494a..e8a053eaaa89 100644 >>>> --- a/drivers/gpu/drm/i915/i915_gem.c >>>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>>> @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct >>>> drm_i915_private *dev_priv) >>>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >>>> { >>>> - i915_gem_drain_freed_objects(dev_priv); >>>> + i915_gem_drain_workqueue(dev_priv); >>>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >>>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >>>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >>> >>> >>> Help me spot the place where RCU free worker schedules itself back >>> to free more objects - if I got the rationale here right? >> (Sorry for late reply, was on leave last week.) >> >> I had to clarify this with Chris. So when driver frees a obj, it does >> dma_resv_fini() which will drop reference >> >> for all the fences in it and a fence might reference to an object >> and upon release of that fence can trigger a release reference to an >> object. > > Hmm I couldn't find that in code but never mind. It's just a stronger > version of the same flushing and it's not on a path where speed > matters so feel free to go with it. Can I get a Ack from you for this, Tvrtko ? Thanks, Nirmoy > > Regards, > > Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-22 12:11 ` Das, Nirmoy @ 2022-09-22 12:28 ` Tvrtko Ursulin 2022-09-22 12:32 ` Das, Nirmoy 0 siblings, 1 reply; 21+ messages in thread From: Tvrtko Ursulin @ 2022-09-22 12:28 UTC (permalink / raw) To: Das, Nirmoy, Das, Nirmoy, intel-gfx; +Cc: matthew.auld, Chris Wilson On 22/09/2022 13:11, Das, Nirmoy wrote: > > On 9/22/2022 11:37 AM, Tvrtko Ursulin wrote: >> >> On 21/09/2022 16:53, Das, Nirmoy wrote: >>> >>> On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: >>>> >>>> On 08/09/2022 21:07, Nirmoy Das wrote: >>>>> i915_gem_drain_freed_objects() might not be enough to >>>>> free all the objects and RCU delayed work might get >>>>> scheduled after the i915 device struct gets freed. >>>>> >>>>> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >>>>> >>>>> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >>>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >>>>> --- >>>>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c >>>>> b/drivers/gpu/drm/i915/i915_gem.c >>>>> index 0f49ec9d494a..e8a053eaaa89 100644 >>>>> --- a/drivers/gpu/drm/i915/i915_gem.c >>>>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>>>> @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct >>>>> drm_i915_private *dev_priv) >>>>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >>>>> { >>>>> - i915_gem_drain_freed_objects(dev_priv); >>>>> + i915_gem_drain_workqueue(dev_priv); >>>>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >>>>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >>>>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >>>> >>>> >>>> Help me spot the place where RCU free worker schedules itself back >>>> to free more objects - if I got the rationale here right? >>> (Sorry for late reply, was on leave last week.) >>> >>> I had to clarify this with Chris. So when driver frees a obj, it does >>> dma_resv_fini() which will drop reference >>> >>> for all the fences in it and a fence might reference to an object >>> and upon release of that fence can trigger a release reference to an >>> object. >> >> Hmm I couldn't find that in code but never mind. It's just a stronger >> version of the same flushing and it's not on a path where speed >> matters so feel free to go with it. > > > Can I get a Ack from you for this, Tvrtko ? Sorry yes, forgot to be explicit. Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload 2022-09-22 12:28 ` Tvrtko Ursulin @ 2022-09-22 12:32 ` Das, Nirmoy 0 siblings, 0 replies; 21+ messages in thread From: Das, Nirmoy @ 2022-09-22 12:32 UTC (permalink / raw) To: Tvrtko Ursulin, Das, Nirmoy, intel-gfx; +Cc: matthew.auld, Chris Wilson On 9/22/2022 2:28 PM, Tvrtko Ursulin wrote: > > On 22/09/2022 13:11, Das, Nirmoy wrote: >> >> On 9/22/2022 11:37 AM, Tvrtko Ursulin wrote: >>> >>> On 21/09/2022 16:53, Das, Nirmoy wrote: >>>> >>>> On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: >>>>> >>>>> On 08/09/2022 21:07, Nirmoy Das wrote: >>>>>> i915_gem_drain_freed_objects() might not be enough to >>>>>> free all the objects and RCU delayed work might get >>>>>> scheduled after the i915 device struct gets freed. >>>>>> >>>>>> Call i915_gem_drain_workqueue() to catch all RCU delayed work. >>>>>> >>>>>> Suggested-by: Chris Wilson <chris.p.wilson@intel.com> >>>>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >>>>>> --- >>>>>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c >>>>>> b/drivers/gpu/drm/i915/i915_gem.c >>>>>> index 0f49ec9d494a..e8a053eaaa89 100644 >>>>>> --- a/drivers/gpu/drm/i915/i915_gem.c >>>>>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>>>>> @@ -1254,7 +1254,7 @@ void i915_gem_init_early(struct >>>>>> drm_i915_private *dev_priv) >>>>>> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv) >>>>>> { >>>>>> - i915_gem_drain_freed_objects(dev_priv); >>>>>> + i915_gem_drain_workqueue(dev_priv); >>>>>> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list)); >>>>>> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); >>>>>> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count); >>>>> >>>>> >>>>> Help me spot the place where RCU free worker schedules itself back >>>>> to free more objects - if I got the rationale here right? >>>> (Sorry for late reply, was on leave last week.) >>>> >>>> I had to clarify this with Chris. So when driver frees a obj, it >>>> does dma_resv_fini() which will drop reference >>>> >>>> for all the fences in it and a fence might reference to an object >>>> and upon release of that fence can trigger a release reference to >>>> an object. >>> >>> Hmm I couldn't find that in code but never mind. It's just a >>> stronger version of the same flushing and it's not on a path where >>> speed matters so feel free to go with it. >> >> >> Can I get a Ack from you for this, Tvrtko ? > > Sorry yes, forgot to be explicit. > > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks a lot. I will rebase and send again. Nirmoy > > Regards, > > Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2022-11-02 18:37 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das 2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das 2022-09-27 7:43 ` Andrzej Hajda 2022-09-23 8:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload Patchwork 2022-09-23 19:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-09-26 20:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) Patchwork 2022-09-27 5:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-09-27 7:43 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Andrzej Hajda 2022-09-29 11:32 ` Andi Shyti 2022-09-29 11:36 ` Das, Nirmoy 2022-10-21 16:34 ` Ville Syrjälä 2022-10-24 8:08 ` Das, Nirmoy 2022-11-02 17:55 ` Ville Syrjälä 2022-11-02 18:37 ` Das, Nirmoy -- strict thread matches above, loose matches on Subject: below -- 2022-09-08 20:07 Nirmoy Das 2022-09-09 8:55 ` Tvrtko Ursulin 2022-09-21 15:53 ` Das, Nirmoy 2022-09-22 9:37 ` Tvrtko Ursulin 2022-09-22 12:11 ` Das, Nirmoy 2022-09-22 12:28 ` Tvrtko Ursulin 2022-09-22 12:32 ` Das, Nirmoy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.