* RFC: deprecate mkfs.xfs protofile functionality
@ 2018-12-20 14:34 Eric Sandeen
2018-12-20 16:02 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2018-12-20 14:34 UTC (permalink / raw)
To: linux-xfs
I'd like to deprecate and eventually remove the protofile functionality
in mkfs.xfs, because it's not well tested code which is really a special
snowflake in the codebase that adds complexity. And as far as I know,
nobody uses it.
If I'm wrong though, speak up now. Is anybody using protofiles?
(If you don't know what a protofile is, then you're not using it.
And let's not turn this into a "well I could think of a way to use it"
discussion, because it's been there for a couple decades and if you're
not using it /yet/ ... unless there really is some new usecase on the
horizon which would clearly depend on it.)
Thanks,
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: RFC: deprecate mkfs.xfs protofile functionality
2018-12-20 14:34 RFC: deprecate mkfs.xfs protofile functionality Eric Sandeen
@ 2018-12-20 16:02 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2018-12-20 16:02 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Dec 20, 2018 at 08:34:25AM -0600, Eric Sandeen wrote:
> I'd like to deprecate and eventually remove the protofile functionality
> in mkfs.xfs, because it's not well tested code which is really a special
> snowflake in the codebase that adds complexity. And as far as I know,
> nobody uses it.
It also would seem to barf out corrupt long format symlinks on v5
filesystems, as I discovered while cleaning up mkfs and repair
yesterday.
> If I'm wrong though, speak up now. Is anybody using protofiles?
>
> (If you don't know what a protofile is, then you're not using it.
> And let's not turn this into a "well I could think of a way to use it"
> discussion, because it's been there for a couple decades and if you're
> not using it /yet/ ... unless there really is some new usecase on the
> horizon which would clearly depend on it.)
I'd rather have a mkfs feature that copies everything under a given path
into a newly formatted filesystem, and even then only if there's an
especially good reason why mount/cp/umount cannot be done.
So I say nuke the protofiles in xfsprogs 5.0. :P
--D
> Thanks,
> -Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-20 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 14:34 RFC: deprecate mkfs.xfs protofile functionality Eric Sandeen
2018-12-20 16:02 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.