All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Joe Perches <joe@perches.com>, tomi.valkeinen@ti.com
Cc: plagnioj@jcrosoft.com, linux-fbdev@vger.kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function
Date: Fri, 29 Jul 2016 12:53:44 +0200	[thread overview]
Message-ID: <e3dcc9f7-711a-5073-38a1-3cdc5596bfb0@suse.cz> (raw)
In-Reply-To: <1469462669.1900.181.camel@perches.com>

On 07/25/2016, 06:04 PM, Joe Perches wrote:
> On Mon, 2016-07-25 at 17:24 +0200, Jiri Slaby wrote:
>> MDA_ADDR is one of those macros which could be an inline function. So
>> convert MDA_ADDR to mda_addr.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>>  drivers/video/console/mdacon.c | 19 +++++++++++--------
>>  1 file changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c
>> index 814606bd26d1..24fe55134eb5 100644
>> --- a/drivers/video/console/mdacon.c
>> +++ b/drivers/video/console/mdacon.c
>> @@ -420,17 +420,20 @@ static void mdacon_invert_region(struct vc_data *c, u16 *p, int count)
>>  	}
>>  }
>>  
>> -#define MDA_ADDR(x, y)  (mda_vram_base + (y)*mda_num_columns + (x))
>> +static inline u16 *mda_addr(unsigned int x, unsigned int y)
> 
> Are you sure about the unsigned?
> All of the changed use are taking int

Yeah, they are really absolute x and y coordinates.

thanks,
-- 
js
suse labs

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jslaby@suse.cz>
To: Joe Perches <joe@perches.com>, tomi.valkeinen@ti.com
Cc: plagnioj@jcrosoft.com, linux-fbdev@vger.kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function
Date: Fri, 29 Jul 2016 10:53:44 +0000	[thread overview]
Message-ID: <e3dcc9f7-711a-5073-38a1-3cdc5596bfb0@suse.cz> (raw)
In-Reply-To: <1469462669.1900.181.camel@perches.com>

On 07/25/2016, 06:04 PM, Joe Perches wrote:
> On Mon, 2016-07-25 at 17:24 +0200, Jiri Slaby wrote:
>> MDA_ADDR is one of those macros which could be an inline function. So
>> convert MDA_ADDR to mda_addr.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>>  drivers/video/console/mdacon.c | 19 +++++++++++--------
>>  1 file changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c
>> index 814606bd26d1..24fe55134eb5 100644
>> --- a/drivers/video/console/mdacon.c
>> +++ b/drivers/video/console/mdacon.c
>> @@ -420,17 +420,20 @@ static void mdacon_invert_region(struct vc_data *c, u16 *p, int count)
>>  	}
>>  }
>>  
>> -#define MDA_ADDR(x, y)  (mda_vram_base + (y)*mda_num_columns + (x))
>> +static inline u16 *mda_addr(unsigned int x, unsigned int y)
> 
> Are you sure about the unsigned?
> All of the changed use are taking int

Yeah, they are really absolute x and y coordinates.

thanks,
-- 
js
suse labs

  reply	other threads:[~2016-07-29 10:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 15:24 [PATCH 1/3] mdacon: align code in mda_detect properly Jiri Slaby
2016-07-25 15:24 ` Jiri Slaby
2016-07-25 15:24 ` [PATCH 2/3] mdacon: make mda_vram_base u16 * Jiri Slaby
2016-07-25 15:24   ` Jiri Slaby
2016-07-25 15:24 ` [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function Jiri Slaby
2016-07-25 15:24   ` Jiri Slaby
2016-07-25 16:04   ` Joe Perches
2016-07-25 16:04     ` Joe Perches
2016-07-29 10:53     ` Jiri Slaby [this message]
2016-07-29 10:53       ` Jiri Slaby
2017-05-12  8:08 [PATCH 1/3] mdacon: align code in mda_detect properly Jiri Slaby
2017-05-12  8:08 ` [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function Jiri Slaby
2017-05-12  8:08   ` Jiri Slaby
2017-05-12  8:08   ` Jiri Slaby
     [not found]   ` <CGME20170614132927epcas1p311aa2291f0d36ce0691955287c9af3a2@epcas1p3.samsung.com>
2017-06-14 13:29     ` Bartlomiej Zolnierkiewicz
2017-06-14 13:29       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3dcc9f7-711a-5073-38a1-3cdc5596bfb0@suse.cz \
    --to=jslaby@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.