* [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-06 17:42 ` Rob Herring
0 siblings, 0 replies; 18+ messages in thread
From: Rob Herring @ 2021-12-06 17:42 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, Roger Quadros
Cc: devicetree, Thierry Reding, linux-mtd, linux-kernel
With 'unevaluatedProperties' support implemented, the TI GPMC example
has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
Add the missing definition for 'rb-gpios'.
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
index beb26b9bcfb2..1c280f52baa0 100644
--- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
+++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
@@ -53,6 +53,11 @@ properties:
enum: [8, 16]
default: 8
+ rb-gpios:
+ description:
+ GPIO connection to R/B signal from NAND chip
+ maxItems: 1
+
patternProperties:
"@[0-9a-f]+$":
$ref: "/schemas/mtd/partitions/partition.yaml"
--
2.32.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-06 17:42 ` Rob Herring
@ 2021-12-07 8:36 ` Thierry Reding
-1 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2021-12-07 8:36 UTC (permalink / raw)
To: Rob Herring
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, Roger Quadros, devicetree, linux-mtd,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, Dec 06, 2021 at 11:42:09AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-07 8:36 ` Thierry Reding
0 siblings, 0 replies; 18+ messages in thread
From: Thierry Reding @ 2021-12-07 8:36 UTC (permalink / raw)
To: Rob Herring
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, Roger Quadros, devicetree, linux-mtd,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]
On Mon, Dec 06, 2021 at 11:42:09AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-06 17:42 ` Rob Herring
@ 2021-12-07 12:47 ` Roger Quadros
-1 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-07 12:47 UTC (permalink / raw)
To: Rob Herring, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tony Lindgren
Cc: devicetree, Thierry Reding, linux-mtd, linux-kernel
On 06/12/2021 19:42, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-07 12:47 ` Roger Quadros
0 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-07 12:47 UTC (permalink / raw)
To: Rob Herring, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tony Lindgren
Cc: devicetree, Thierry Reding, linux-mtd, linux-kernel
On 06/12/2021 19:42, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-06 17:42 ` Rob Herring
@ 2021-12-09 9:42 ` Miquel Raynal
-1 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 9:42 UTC (permalink / raw)
To: Rob Herring
Cc: Richard Weinberger, Vignesh Raghavendra, Tony Lindgren,
Roger Quadros, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Rob,
robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in nand-controller.yaml. I seems like the
real problem is that this file does not refer to it. Can you update the
fix?
While at it you might also want to drop the rb-gpios property from
ingenic,nand.yaml, which also defines it a second time.
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> index beb26b9bcfb2..1c280f52baa0 100644
> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> @@ -53,6 +53,11 @@ properties:
> enum: [8, 16]
> default: 8
>
> + rb-gpios:
> + description:
> + GPIO connection to R/B signal from NAND chip
> + maxItems: 1
> +
> patternProperties:
> "@[0-9a-f]+$":
> $ref: "/schemas/mtd/partitions/partition.yaml"
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 9:42 ` Miquel Raynal
0 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 9:42 UTC (permalink / raw)
To: Rob Herring
Cc: Richard Weinberger, Vignesh Raghavendra, Tony Lindgren,
Roger Quadros, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Rob,
robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in nand-controller.yaml. I seems like the
real problem is that this file does not refer to it. Can you update the
fix?
While at it you might also want to drop the rb-gpios property from
ingenic,nand.yaml, which also defines it a second time.
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> index beb26b9bcfb2..1c280f52baa0 100644
> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> @@ -53,6 +53,11 @@ properties:
> enum: [8, 16]
> default: 8
>
> + rb-gpios:
> + description:
> + GPIO connection to R/B signal from NAND chip
> + maxItems: 1
> +
> patternProperties:
> "@[0-9a-f]+$":
> $ref: "/schemas/mtd/partitions/partition.yaml"
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-09 9:42 ` Miquel Raynal
@ 2021-12-09 10:08 ` Roger Quadros
-1 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-09 10:08 UTC (permalink / raw)
To: Miquel Raynal, Rob Herring
Cc: Richard Weinberger, Vignesh Raghavendra, Tony Lindgren,
devicetree, Thierry Reding, linux-mtd, linux-kernel
Hi Miquel,
On 09/12/2021 11:42, Miquel Raynal wrote:
> Hi Rob,
>
> robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
>
>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>> has a warning:
>>
>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>>
>> Add the missing definition for 'rb-gpios'.
>
> rb-gpios is already defined in nand-controller.yaml. I seems like the
> real problem is that this file does not refer to it. Can you update the
> fix?
I don't think we can refer to nand-controller.yaml right now as we are not
fully compatible with it yet. Please see examples below.
ti,gpmc-nand example:
nand@0,0 {
compatible = "ti,omap2-nand";
reg = <0 0 4>; /* device IO registers */
interrupt-parent = <&gpmc>;
interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
<1 IRQ_TYPE_NONE>; /* termcount */
ti,nand-xfer-type = "prefetch-dma";
ti,nand-ecc-opt = "bch16";
ti,elm-id = <&elm>;
#address-cells = <1>;
#size-cells = <1>;
/* NAND generic properties */
nand-bus-width = <8>;
rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
/* GPMC properties*/
gpmc,device-width = <1>;
partition@0 {
label = "NAND.SPL";
reg = <0x00000000 0x00040000>;
};
partition@1 {
label = "NAND.SPL.backup1";
reg = <0x00040000 0x00040000>;
};
};
nand-controller example:
nand-controller {
#address-cells = <1>;
#size-cells = <0>;
cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
/* controller specific properties */
nand@0 {
reg = <0>; /* Native CS */
nand-use-soft-ecc-engine;
nand-ecc-algo = "bch";
/* controller specific properties */
};
nand@1 {
reg = <1>; /* GPIO CS */
};
};
>
> While at it you might also want to drop the rb-gpios property from
> ingenic,nand.yaml, which also defines it a second time.
>
>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Roger Quadros <rogerq@kernel.org>
>> Cc: linux-mtd@lists.infradead.org
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> index beb26b9bcfb2..1c280f52baa0 100644
>> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> @@ -53,6 +53,11 @@ properties:
>> enum: [8, 16]
>> default: 8
>>
>> + rb-gpios:
>> + description:
>> + GPIO connection to R/B signal from NAND chip
>> + maxItems: 1
>> +
>> patternProperties:
>> "@[0-9a-f]+$":
>> $ref: "/schemas/mtd/partitions/partition.yaml"
>
> Thanks,
> Miquèl
>
cheers,
-roger
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 10:08 ` Roger Quadros
0 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-09 10:08 UTC (permalink / raw)
To: Miquel Raynal, Rob Herring
Cc: Richard Weinberger, Vignesh Raghavendra, Tony Lindgren,
devicetree, Thierry Reding, linux-mtd, linux-kernel
Hi Miquel,
On 09/12/2021 11:42, Miquel Raynal wrote:
> Hi Rob,
>
> robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
>
>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>> has a warning:
>>
>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>>
>> Add the missing definition for 'rb-gpios'.
>
> rb-gpios is already defined in nand-controller.yaml. I seems like the
> real problem is that this file does not refer to it. Can you update the
> fix?
I don't think we can refer to nand-controller.yaml right now as we are not
fully compatible with it yet. Please see examples below.
ti,gpmc-nand example:
nand@0,0 {
compatible = "ti,omap2-nand";
reg = <0 0 4>; /* device IO registers */
interrupt-parent = <&gpmc>;
interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
<1 IRQ_TYPE_NONE>; /* termcount */
ti,nand-xfer-type = "prefetch-dma";
ti,nand-ecc-opt = "bch16";
ti,elm-id = <&elm>;
#address-cells = <1>;
#size-cells = <1>;
/* NAND generic properties */
nand-bus-width = <8>;
rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
/* GPMC properties*/
gpmc,device-width = <1>;
partition@0 {
label = "NAND.SPL";
reg = <0x00000000 0x00040000>;
};
partition@1 {
label = "NAND.SPL.backup1";
reg = <0x00040000 0x00040000>;
};
};
nand-controller example:
nand-controller {
#address-cells = <1>;
#size-cells = <0>;
cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
/* controller specific properties */
nand@0 {
reg = <0>; /* Native CS */
nand-use-soft-ecc-engine;
nand-ecc-algo = "bch";
/* controller specific properties */
};
nand@1 {
reg = <1>; /* GPIO CS */
};
};
>
> While at it you might also want to drop the rb-gpios property from
> ingenic,nand.yaml, which also defines it a second time.
>
>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Roger Quadros <rogerq@kernel.org>
>> Cc: linux-mtd@lists.infradead.org
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> index beb26b9bcfb2..1c280f52baa0 100644
>> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>> @@ -53,6 +53,11 @@ properties:
>> enum: [8, 16]
>> default: 8
>>
>> + rb-gpios:
>> + description:
>> + GPIO connection to R/B signal from NAND chip
>> + maxItems: 1
>> +
>> patternProperties:
>> "@[0-9a-f]+$":
>> $ref: "/schemas/mtd/partitions/partition.yaml"
>
> Thanks,
> Miquèl
>
cheers,
-roger
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-09 10:08 ` Roger Quadros
@ 2021-12-09 10:40 ` Miquel Raynal
-1 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 10:40 UTC (permalink / raw)
To: Roger Quadros
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Roger,
rogerq@kernel.org wrote on Thu, 9 Dec 2021 12:08:07 +0200:
> Hi Miquel,
>
> On 09/12/2021 11:42, Miquel Raynal wrote:
> > Hi Rob,
> >
> > robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
> >
> >> With 'unevaluatedProperties' support implemented, the TI GPMC example
> >> has a warning:
> >>
> >> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
> >>
> >> Add the missing definition for 'rb-gpios'.
> >
> > rb-gpios is already defined in nand-controller.yaml. I seems like the
> > real problem is that this file does not refer to it. Can you update the
> > fix?
>
> I don't think we can refer to nand-controller.yaml right now as we are not
> fully compatible with it yet. Please see examples below.
This is a *very* wrong way of defining a NAND setup. I will take the
patch to silence the warning, but please convert this representation to
the 'new' one. I believe on the driver side it should not be too
complicated to support having a few of these properties moved to a NAND
chip subnode and still support the below binding. Just be very clear
that if the legacy bindings are used, only a single chip is supported.
> ti,gpmc-nand example:
>
> nand@0,0 {
> compatible = "ti,omap2-nand";
> reg = <0 0 4>; /* device IO registers */
> interrupt-parent = <&gpmc>;
> interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
> <1 IRQ_TYPE_NONE>; /* termcount */
> ti,nand-xfer-type = "prefetch-dma";
> ti,nand-ecc-opt = "bch16";
> ti,elm-id = <&elm>;
> #address-cells = <1>;
> #size-cells = <1>;
>
> /* NAND generic properties */
> nand-bus-width = <8>;
> rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
>
> /* GPMC properties*/
> gpmc,device-width = <1>;
>
> partition@0 {
> label = "NAND.SPL";
> reg = <0x00000000 0x00040000>;
> };
> partition@1 {
> label = "NAND.SPL.backup1";
> reg = <0x00040000 0x00040000>;
> };
> };
>
>
> nand-controller example:
>
> nand-controller {
> #address-cells = <1>;
> #size-cells = <0>;
> cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
>
> /* controller specific properties */
>
> nand@0 {
> reg = <0>; /* Native CS */
> nand-use-soft-ecc-engine;
> nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
>
> nand@1 {
> reg = <1>; /* GPIO CS */
> };
> };
>
>
> >
> > While at it you might also want to drop the rb-gpios property from
> > ingenic,nand.yaml, which also defines it a second time.
> >
> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> >> Cc: Tony Lindgren <tony@atomide.com>
> >> Cc: Roger Quadros <rogerq@kernel.org>
> >> Cc: linux-mtd@lists.infradead.org
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> ---
> >> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> index beb26b9bcfb2..1c280f52baa0 100644
> >> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> @@ -53,6 +53,11 @@ properties:
> >> enum: [8, 16]
> >> default: 8
> >>
> >> + rb-gpios:
> >> + description:
> >> + GPIO connection to R/B signal from NAND chip
> >> + maxItems: 1
> >> +
> >> patternProperties:
> >> "@[0-9a-f]+$":
> >> $ref: "/schemas/mtd/partitions/partition.yaml"
> >
> > Thanks,
> > Miquèl
> >
>
> cheers,
> -roger
>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 10:40 ` Miquel Raynal
0 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 10:40 UTC (permalink / raw)
To: Roger Quadros
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Roger,
rogerq@kernel.org wrote on Thu, 9 Dec 2021 12:08:07 +0200:
> Hi Miquel,
>
> On 09/12/2021 11:42, Miquel Raynal wrote:
> > Hi Rob,
> >
> > robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
> >
> >> With 'unevaluatedProperties' support implemented, the TI GPMC example
> >> has a warning:
> >>
> >> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
> >>
> >> Add the missing definition for 'rb-gpios'.
> >
> > rb-gpios is already defined in nand-controller.yaml. I seems like the
> > real problem is that this file does not refer to it. Can you update the
> > fix?
>
> I don't think we can refer to nand-controller.yaml right now as we are not
> fully compatible with it yet. Please see examples below.
This is a *very* wrong way of defining a NAND setup. I will take the
patch to silence the warning, but please convert this representation to
the 'new' one. I believe on the driver side it should not be too
complicated to support having a few of these properties moved to a NAND
chip subnode and still support the below binding. Just be very clear
that if the legacy bindings are used, only a single chip is supported.
> ti,gpmc-nand example:
>
> nand@0,0 {
> compatible = "ti,omap2-nand";
> reg = <0 0 4>; /* device IO registers */
> interrupt-parent = <&gpmc>;
> interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
> <1 IRQ_TYPE_NONE>; /* termcount */
> ti,nand-xfer-type = "prefetch-dma";
> ti,nand-ecc-opt = "bch16";
> ti,elm-id = <&elm>;
> #address-cells = <1>;
> #size-cells = <1>;
>
> /* NAND generic properties */
> nand-bus-width = <8>;
> rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
>
> /* GPMC properties*/
> gpmc,device-width = <1>;
>
> partition@0 {
> label = "NAND.SPL";
> reg = <0x00000000 0x00040000>;
> };
> partition@1 {
> label = "NAND.SPL.backup1";
> reg = <0x00040000 0x00040000>;
> };
> };
>
>
> nand-controller example:
>
> nand-controller {
> #address-cells = <1>;
> #size-cells = <0>;
> cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
>
> /* controller specific properties */
>
> nand@0 {
> reg = <0>; /* Native CS */
> nand-use-soft-ecc-engine;
> nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
>
> nand@1 {
> reg = <1>; /* GPIO CS */
> };
> };
>
>
> >
> > While at it you might also want to drop the rb-gpios property from
> > ingenic,nand.yaml, which also defines it a second time.
> >
> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> >> Cc: Tony Lindgren <tony@atomide.com>
> >> Cc: Roger Quadros <rogerq@kernel.org>
> >> Cc: linux-mtd@lists.infradead.org
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> ---
> >> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> index beb26b9bcfb2..1c280f52baa0 100644
> >> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
> >> @@ -53,6 +53,11 @@ properties:
> >> enum: [8, 16]
> >> default: 8
> >>
> >> + rb-gpios:
> >> + description:
> >> + GPIO connection to R/B signal from NAND chip
> >> + maxItems: 1
> >> +
> >> patternProperties:
> >> "@[0-9a-f]+$":
> >> $ref: "/schemas/mtd/partitions/partition.yaml"
> >
> > Thanks,
> > Miquèl
> >
>
> cheers,
> -roger
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-09 10:40 ` Miquel Raynal
@ 2021-12-09 12:11 ` Roger Quadros
-1 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-09 12:11 UTC (permalink / raw)
To: Miquel Raynal
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Miquel,
On 09/12/2021 12:40, Miquel Raynal wrote:
> Hi Roger,
>
> rogerq@kernel.org wrote on Thu, 9 Dec 2021 12:08:07 +0200:
>
>> Hi Miquel,
>>
>> On 09/12/2021 11:42, Miquel Raynal wrote:
>>> Hi Rob,
>>>
>>> robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
>>>
>>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>>> has a warning:
>>>>
>>>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>>>>
>>>> Add the missing definition for 'rb-gpios'.
>>>
>>> rb-gpios is already defined in nand-controller.yaml. I seems like the
>>> real problem is that this file does not refer to it. Can you update the
>>> fix?
>>
>> I don't think we can refer to nand-controller.yaml right now as we are not
>> fully compatible with it yet. Please see examples below.
>
> This is a *very* wrong way of defining a NAND setup. I will take the
> patch to silence the warning, but please convert this representation to
Thanks!
> the 'new' one. I believe on the driver side it should not be too
> complicated to support having a few of these properties moved to a NAND
> chip subnode and still support the below binding. Just be very clear
> that if the legacy bindings are used, only a single chip is supported.
I agree with you. It has been that way since ages. I will look at cleaning
it up whenever possible for me. I think we will have to support the old
bindings as well as the new one going forward as many legacy platforms
are using it.
cheers,
-roger
>
>> ti,gpmc-nand example:
>>
>> nand@0,0 {
>> compatible = "ti,omap2-nand";
>> reg = <0 0 4>; /* device IO registers */
>> interrupt-parent = <&gpmc>;
>> interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
>> <1 IRQ_TYPE_NONE>; /* termcount */
>> ti,nand-xfer-type = "prefetch-dma";
>> ti,nand-ecc-opt = "bch16";
>> ti,elm-id = <&elm>;
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>> /* NAND generic properties */
>> nand-bus-width = <8>;
>> rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
>>
>> /* GPMC properties*/
>> gpmc,device-width = <1>;
>>
>> partition@0 {
>> label = "NAND.SPL";
>> reg = <0x00000000 0x00040000>;
>> };
>> partition@1 {
>> label = "NAND.SPL.backup1";
>> reg = <0x00040000 0x00040000>;
>> };
>> };
>>
>>
>> nand-controller example:
>>
>> nand-controller {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
>>
>> /* controller specific properties */
>>
>> nand@0 {
>> reg = <0>; /* Native CS */
>> nand-use-soft-ecc-engine;
>> nand-ecc-algo = "bch";
>>
>> /* controller specific properties */
>> };
>>
>> nand@1 {
>> reg = <1>; /* GPIO CS */
>> };
>> };
>>
>>
>>>
>>> While at it you might also want to drop the rb-gpios property from
>>> ingenic,nand.yaml, which also defines it a second time.
>>>
>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>> Cc: Tony Lindgren <tony@atomide.com>
>>>> Cc: Roger Quadros <rogerq@kernel.org>
>>>> Cc: linux-mtd@lists.infradead.org
>>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>>> ---
>>>> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> index beb26b9bcfb2..1c280f52baa0 100644
>>>> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> @@ -53,6 +53,11 @@ properties:
>>>> enum: [8, 16]
>>>> default: 8
>>>>
>>>> + rb-gpios:
>>>> + description:
>>>> + GPIO connection to R/B signal from NAND chip
>>>> + maxItems: 1
>>>> +
>>>> patternProperties:
>>>> "@[0-9a-f]+$":
>>>> $ref: "/schemas/mtd/partitions/partition.yaml"
>>>
>>> Thanks,
>>> Miquèl
>>>
>>
>> cheers,
>> -roger
>>
>
> Thanks,
> Miquèl
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 12:11 ` Roger Quadros
0 siblings, 0 replies; 18+ messages in thread
From: Roger Quadros @ 2021-12-09 12:11 UTC (permalink / raw)
To: Miquel Raynal
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Miquel,
On 09/12/2021 12:40, Miquel Raynal wrote:
> Hi Roger,
>
> rogerq@kernel.org wrote on Thu, 9 Dec 2021 12:08:07 +0200:
>
>> Hi Miquel,
>>
>> On 09/12/2021 11:42, Miquel Raynal wrote:
>>> Hi Rob,
>>>
>>> robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
>>>
>>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>>> has a warning:
>>>>
>>>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>>>>
>>>> Add the missing definition for 'rb-gpios'.
>>>
>>> rb-gpios is already defined in nand-controller.yaml. I seems like the
>>> real problem is that this file does not refer to it. Can you update the
>>> fix?
>>
>> I don't think we can refer to nand-controller.yaml right now as we are not
>> fully compatible with it yet. Please see examples below.
>
> This is a *very* wrong way of defining a NAND setup. I will take the
> patch to silence the warning, but please convert this representation to
Thanks!
> the 'new' one. I believe on the driver side it should not be too
> complicated to support having a few of these properties moved to a NAND
> chip subnode and still support the below binding. Just be very clear
> that if the legacy bindings are used, only a single chip is supported.
I agree with you. It has been that way since ages. I will look at cleaning
it up whenever possible for me. I think we will have to support the old
bindings as well as the new one going forward as many legacy platforms
are using it.
cheers,
-roger
>
>> ti,gpmc-nand example:
>>
>> nand@0,0 {
>> compatible = "ti,omap2-nand";
>> reg = <0 0 4>; /* device IO registers */
>> interrupt-parent = <&gpmc>;
>> interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
>> <1 IRQ_TYPE_NONE>; /* termcount */
>> ti,nand-xfer-type = "prefetch-dma";
>> ti,nand-ecc-opt = "bch16";
>> ti,elm-id = <&elm>;
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>> /* NAND generic properties */
>> nand-bus-width = <8>;
>> rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
>>
>> /* GPMC properties*/
>> gpmc,device-width = <1>;
>>
>> partition@0 {
>> label = "NAND.SPL";
>> reg = <0x00000000 0x00040000>;
>> };
>> partition@1 {
>> label = "NAND.SPL.backup1";
>> reg = <0x00040000 0x00040000>;
>> };
>> };
>>
>>
>> nand-controller example:
>>
>> nand-controller {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
>>
>> /* controller specific properties */
>>
>> nand@0 {
>> reg = <0>; /* Native CS */
>> nand-use-soft-ecc-engine;
>> nand-ecc-algo = "bch";
>>
>> /* controller specific properties */
>> };
>>
>> nand@1 {
>> reg = <1>; /* GPIO CS */
>> };
>> };
>>
>>
>>>
>>> While at it you might also want to drop the rb-gpios property from
>>> ingenic,nand.yaml, which also defines it a second time.
>>>
>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>> Cc: Tony Lindgren <tony@atomide.com>
>>>> Cc: Roger Quadros <rogerq@kernel.org>
>>>> Cc: linux-mtd@lists.infradead.org
>>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>>> ---
>>>> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> index beb26b9bcfb2..1c280f52baa0 100644
>>>> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
>>>> @@ -53,6 +53,11 @@ properties:
>>>> enum: [8, 16]
>>>> default: 8
>>>>
>>>> + rb-gpios:
>>>> + description:
>>>> + GPIO connection to R/B signal from NAND chip
>>>> + maxItems: 1
>>>> +
>>>> patternProperties:
>>>> "@[0-9a-f]+$":
>>>> $ref: "/schemas/mtd/partitions/partition.yaml"
>>>
>>> Thanks,
>>> Miquèl
>>>
>>
>> cheers,
>> -roger
>>
>
> Thanks,
> Miquèl
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-09 12:11 ` Roger Quadros
@ 2021-12-09 12:37 ` Miquel Raynal
-1 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 12:37 UTC (permalink / raw)
To: Roger Quadros
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Roger,
> >>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
> >>>> has a warning:
> >>>>
> >>>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
> >>>>
> >>>> Add the missing definition for 'rb-gpios'.
> >>>
> >>> rb-gpios is already defined in nand-controller.yaml. I seems like the
> >>> real problem is that this file does not refer to it. Can you update the
> >>> fix?
> >>
> >> I don't think we can refer to nand-controller.yaml right now as we are not
> >> fully compatible with it yet. Please see examples below.
> >
> > This is a *very* wrong way of defining a NAND setup. I will take the
> > patch to silence the warning, but please convert this representation to
>
> Thanks!
>
> > the 'new' one. I believe on the driver side it should not be too
> > complicated to support having a few of these properties moved to a NAND
> > chip subnode and still support the below binding. Just be very clear
> > that if the legacy bindings are used, only a single chip is supported.
>
> I agree with you. It has been that way since ages. I will look at cleaning
> it up whenever possible for me. I think we will have to support the old
> bindings as well as the new one going forward as many legacy platforms
> are using it.
Yes of course, this is even a primary requirement.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 12:37 ` Miquel Raynal
0 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 12:37 UTC (permalink / raw)
To: Roger Quadros
Cc: Rob Herring, Richard Weinberger, Vignesh Raghavendra,
Tony Lindgren, devicetree, Thierry Reding, linux-mtd,
linux-kernel
Hi Roger,
> >>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
> >>>> has a warning:
> >>>>
> >>>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
> >>>>
> >>>> Add the missing definition for 'rb-gpios'.
> >>>
> >>> rb-gpios is already defined in nand-controller.yaml. I seems like the
> >>> real problem is that this file does not refer to it. Can you update the
> >>> fix?
> >>
> >> I don't think we can refer to nand-controller.yaml right now as we are not
> >> fully compatible with it yet. Please see examples below.
> >
> > This is a *very* wrong way of defining a NAND setup. I will take the
> > patch to silence the warning, but please convert this representation to
>
> Thanks!
>
> > the 'new' one. I believe on the driver side it should not be too
> > complicated to support having a few of these properties moved to a NAND
> > chip subnode and still support the below binding. Just be very clear
> > that if the legacy bindings are used, only a single chip is supported.
>
> I agree with you. It has been that way since ages. I will look at cleaning
> it up whenever possible for me. I think we will have to support the old
> bindings as well as the new one going forward as many legacy platforms
> are using it.
Yes of course, this is even a primary requirement.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
2021-12-06 17:42 ` Rob Herring
@ 2021-12-09 16:50 ` Miquel Raynal
-1 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 16:50 UTC (permalink / raw)
To: Rob Herring, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tony Lindgren, Roger Quadros
Cc: devicetree, Thierry Reding, linux-mtd, linux-kernel
On Mon, 2021-12-06 at 17:42:09 UTC, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
@ 2021-12-09 16:50 ` Miquel Raynal
0 siblings, 0 replies; 18+ messages in thread
From: Miquel Raynal @ 2021-12-09 16:50 UTC (permalink / raw)
To: Rob Herring, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tony Lindgren, Roger Quadros
Cc: devicetree, Thierry Reding, linux-mtd, linux-kernel
On Mon, 2021-12-06 at 17:42:09 UTC, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
>
> Add the missing definition for 'rb-gpios'.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 18+ messages in thread