From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Christophe Leroy <christophe.leroy@csgroup.eu>, <arnd@arndb.de>, <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, <rostedt@goodmis.org>, <mingo@redhat.com>, <davem@davemloft.net>, <ast@kernel.org>, <ryabinin.a.a@gmail.com>, <akpm@linux-foundation.org> Cc: <bpf@vger.kernel.org>, <paulus@samba.org> Subject: Re: [PATCH v3 9/9] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Date: Wed, 29 Sep 2021 09:14:30 +0800 [thread overview] Message-ID: <e4042e21-1952-582c-99a3-88742ed5f82a@huawei.com> (raw) In-Reply-To: <c5895fa8-ed3d-74c7-1d71-4d90dee9ea4b@csgroup.eu> On 2021/9/29 1:51, Christophe Leroy wrote: > > > Le 26/09/2021 à 09:20, Kefeng Wang a écrit : >> Use is_kernel_text() and is_kernel_inittext() helper to simplify code, >> also drop etext, _stext, _sinittext, _einittext declaration which >> already declared in section.h. >> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: linuxppc-dev@lists.ozlabs.org >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> arch/powerpc/mm/pgtable_32.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c >> index dcf5ecca19d9..13c798308c2e 100644 >> --- a/arch/powerpc/mm/pgtable_32.c >> +++ b/arch/powerpc/mm/pgtable_32.c >> @@ -33,8 +33,6 @@ >> #include <mm/mmu_decl.h> >> -extern char etext[], _stext[], _sinittext[], _einittext[]; >> - >> static u8 early_fixmap_pagetable[FIXMAP_PTE_SIZE] __page_aligned_data; >> notrace void __init early_ioremap_init(void) >> @@ -104,14 +102,13 @@ static void __init __mapin_ram_chunk(unsigned >> long offset, unsigned long top) >> { >> unsigned long v, s; >> phys_addr_t p; >> - int ktext; >> + bool ktext; >> s = offset; >> v = PAGE_OFFSET + s; >> p = memstart_addr + s; >> for (; s < top; s += PAGE_SIZE) { >> - ktext = ((char *)v >= _stext && (char *)v < etext) || >> - ((char *)v >= _sinittext && (char *)v < _einittext); >> + ktext = (is_kernel_text(v) || is_kernel_inittext(v)); > > I think we could use core_kernel_next() instead. Indead. oops, sorry for the build error, will update, thanks. > > Build failure on mpc885_ads_defconfig > > arch/powerpc/mm/pgtable_32.c: In function '__mapin_ram_chunk': > arch/powerpc/mm/pgtable_32.c:111:26: error: implicit declaration of > function 'is_kernel_text'; did you mean 'is_kernel_inittext'? > [-Werror=implicit-function-declaration] > 111 | ktext = (is_kernel_text(v) || > is_kernel_inittext(v)); > | ^~~~~~~~~~~~~~ > | is_kernel_inittext > cc1: all warnings being treated as errors > make[2]: *** [scripts/Makefile.build:277: arch/powerpc/mm/pgtable_32.o] > Error 1 > make[1]: *** [scripts/Makefile.build:540: arch/powerpc/mm] Error 2 > make: *** [Makefile:1868: arch/powerpc] Error 2 > > > .
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Christophe Leroy <christophe.leroy@csgroup.eu>, <arnd@arndb.de>, <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, <rostedt@goodmis.org>, <mingo@redhat.com>, <davem@davemloft.net>, <ast@kernel.org>, <ryabinin.a.a@gmail.com>, <akpm@linux-foundation.org> Cc: bpf@vger.kernel.org, paulus@samba.org Subject: Re: [PATCH v3 9/9] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Date: Wed, 29 Sep 2021 09:14:30 +0800 [thread overview] Message-ID: <e4042e21-1952-582c-99a3-88742ed5f82a@huawei.com> (raw) In-Reply-To: <c5895fa8-ed3d-74c7-1d71-4d90dee9ea4b@csgroup.eu> On 2021/9/29 1:51, Christophe Leroy wrote: > > > Le 26/09/2021 à 09:20, Kefeng Wang a écrit : >> Use is_kernel_text() and is_kernel_inittext() helper to simplify code, >> also drop etext, _stext, _sinittext, _einittext declaration which >> already declared in section.h. >> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: linuxppc-dev@lists.ozlabs.org >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> arch/powerpc/mm/pgtable_32.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c >> index dcf5ecca19d9..13c798308c2e 100644 >> --- a/arch/powerpc/mm/pgtable_32.c >> +++ b/arch/powerpc/mm/pgtable_32.c >> @@ -33,8 +33,6 @@ >> #include <mm/mmu_decl.h> >> -extern char etext[], _stext[], _sinittext[], _einittext[]; >> - >> static u8 early_fixmap_pagetable[FIXMAP_PTE_SIZE] __page_aligned_data; >> notrace void __init early_ioremap_init(void) >> @@ -104,14 +102,13 @@ static void __init __mapin_ram_chunk(unsigned >> long offset, unsigned long top) >> { >> unsigned long v, s; >> phys_addr_t p; >> - int ktext; >> + bool ktext; >> s = offset; >> v = PAGE_OFFSET + s; >> p = memstart_addr + s; >> for (; s < top; s += PAGE_SIZE) { >> - ktext = ((char *)v >= _stext && (char *)v < etext) || >> - ((char *)v >= _sinittext && (char *)v < _einittext); >> + ktext = (is_kernel_text(v) || is_kernel_inittext(v)); > > I think we could use core_kernel_next() instead. Indead. oops, sorry for the build error, will update, thanks. > > Build failure on mpc885_ads_defconfig > > arch/powerpc/mm/pgtable_32.c: In function '__mapin_ram_chunk': > arch/powerpc/mm/pgtable_32.c:111:26: error: implicit declaration of > function 'is_kernel_text'; did you mean 'is_kernel_inittext'? > [-Werror=implicit-function-declaration] > 111 | ktext = (is_kernel_text(v) || > is_kernel_inittext(v)); > | ^~~~~~~~~~~~~~ > | is_kernel_inittext > cc1: all warnings being treated as errors > make[2]: *** [scripts/Makefile.build:277: arch/powerpc/mm/pgtable_32.o] > Error 1 > make[1]: *** [scripts/Makefile.build:540: arch/powerpc/mm] Error 2 > make: *** [Makefile:1868: arch/powerpc] Error 2 > > > .
next prev parent reply other threads:[~2021-09-29 1:14 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-26 7:20 [PATCH v3 0/9] sections: Unify kernel sections range check and use Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 1/9] kallsyms: Remove arch specific text and data check Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 2/9] kallsyms: Fix address-checks for kernel related range Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 3/9] sections: Move and rename core_kernel_data() to is_kernel_core_data() Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 4/9] sections: Move is_kernel_inittext() into sections.h Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 5/9] x86: mm: Rename __is_kernel_text() to is_x86_32_kernel_text() Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 6/9] sections: Provide internal __is_kernel() and __is_kernel_text() helper Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 7/9] mm: kasan: Use is_kernel() helper Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 8/9] extable: Use is_kernel_text() helper Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-26 7:20 ` [PATCH v3 9/9] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Kefeng Wang 2021-09-26 7:20 ` Kefeng Wang 2021-09-28 17:51 ` Christophe Leroy 2021-09-29 1:14 ` Kefeng Wang [this message] 2021-09-29 1:14 ` Kefeng Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e4042e21-1952-582c-99a3-88742ed5f82a@huawei.com \ --to=wangkefeng.wang@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=christophe.leroy@csgroup.eu \ --cc=davem@davemloft.net \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@redhat.com \ --cc=paulus@samba.org \ --cc=rostedt@goodmis.org \ --cc=ryabinin.a.a@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.