* [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
@ 2018-07-25 6:06 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-07-25 5:58 UTC (permalink / raw)
To: Alexey Kuznetsov, Hideaki YOSHIFUJI, Hangbin Liu
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warnings:
net/ipv4/igmp.c:1391:6: warning:
symbol '__ip_mc_inc_group' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/ipv4/igmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 598333b..c9f8d46 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
/*
* A socket has joined a multicast group on device dev.
*/
-void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode)
+static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr,
+ unsigned int mode)
{
struct ip_mc_list *im;
#ifdef CONFIG_IP_MULTICAST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
@ 2018-07-25 6:06 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-07-25 6:06 UTC (permalink / raw)
To: Alexey Kuznetsov, Hideaki YOSHIFUJI, Hangbin Liu
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warnings:
net/ipv4/igmp.c:1391:6: warning:
symbol '__ip_mc_inc_group' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/ipv4/igmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 598333b..c9f8d46 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
/*
* A socket has joined a multicast group on device dev.
*/
-void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode)
+static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr,
+ unsigned int mode)
{
struct ip_mc_list *im;
#ifdef CONFIG_IP_MULTICAST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
2018-07-25 6:06 ` Wei Yongjun
@ 2018-07-25 13:19 ` Eric Dumazet
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2018-07-25 13:19 UTC (permalink / raw)
To: Wei Yongjun, Alexey Kuznetsov, Hideaki YOSHIFUJI, Hangbin Liu
Cc: netdev, kernel-janitors
On 07/24/2018 11:06 PM, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> net/ipv4/igmp.c:1391:6: warning:
> symbol '__ip_mc_inc_group' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/ipv4/igmp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 598333b..c9f8d46 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
> /*
> * A socket has joined a multicast group on device dev.
> */
> -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode)
> +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr,
> + unsigned int mode)
> {
> struct ip_mc_list *im;
> #ifdef CONFIG_IP_MULTICAST
>
This should target net tree
Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group")
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
@ 2018-07-25 13:19 ` Eric Dumazet
0 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2018-07-25 13:19 UTC (permalink / raw)
To: Wei Yongjun, Alexey Kuznetsov, Hideaki YOSHIFUJI, Hangbin Liu
Cc: netdev, kernel-janitors
On 07/24/2018 11:06 PM, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> net/ipv4/igmp.c:1391:6: warning:
> symbol '__ip_mc_inc_group' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/ipv4/igmp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 598333b..c9f8d46 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
> /*
> * A socket has joined a multicast group on device dev.
> */
> -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode)
> +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr,
> + unsigned int mode)
> {
> struct ip_mc_list *im;
> #ifdef CONFIG_IP_MULTICAST
>
This should target net tree
Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group")
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
2018-07-25 6:06 ` Wei Yongjun
@ 2018-07-25 23:38 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-07-25 23:38 UTC (permalink / raw)
To: weiyongjun1; +Cc: kuznet, yoshfuji, liuhangbin, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 25 Jul 2018 06:06:13 +0000
> Fixes the following sparse warnings:
>
> net/ipv4/igmp.c:1391:6: warning:
> symbol '__ip_mc_inc_group' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to 'net'.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static
@ 2018-07-25 23:38 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-07-25 23:38 UTC (permalink / raw)
To: weiyongjun1; +Cc: kuznet, yoshfuji, liuhangbin, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 25 Jul 2018 06:06:13 +0000
> Fixes the following sparse warnings:
>
> net/ipv4/igmp.c:1391:6: warning:
> symbol '__ip_mc_inc_group' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to 'net'.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-26 0:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 5:58 [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static Wei Yongjun
2018-07-25 6:06 ` Wei Yongjun
2018-07-25 13:19 ` Eric Dumazet
2018-07-25 13:19 ` Eric Dumazet
2018-07-25 23:38 ` David Miller
2018-07-25 23:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.