* [MPTCP] Re: [MPTCP][PATCH v7 mptcp-next 00/11] RM_ADDR: remove a list of addrs
@ 2021-02-10 19:42 Mat Martineau
0 siblings, 0 replies; 2+ messages in thread
From: Mat Martineau @ 2021-02-10 19:42 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2766 bytes --]
On Wed, 10 Feb 2021, Geliang Tang wrote:
> v7:
> - only changed the selftests.
> - add patch 9 and 10 from patchset "move to next addr and testcases".
> - drop "invalid addresses flush" in in patch 11, move it to patchset
> "move to next addr and testcases"
> - tag: export/20210209T062213
Geliang -
Thanks for reposting with the test changes. Self tests pass here and I
reviewed the pcaps and debug logs too, looks good for the export branch.
Mat
>
> v6:
> - add "rm_list->nr = 1" in patch 1.
> - apply: tag export/20210209T062213 + patchset "move to next addr and
> testcases" v3.
>
> v5:
> - use struct mptcp_rm_list instead of the ids array.
> - simplify mptcp_pm_remove_addrs_and_subflows.
> - apply: tag export/20210207T062839 + patchset "move to next addr and
> testcases".
>
> v4:
> - use MAX_ADDR_ID as the default value in the rm_ids array.
> - keep the free_list and pass it to mptcp_nl_remove_addrs_list.
> - handle remove anno_addrs and subflows in one function.
>
> v3:
> - avoid looping twice in mptcp_write_options
> - drop nr in mptcp_get_rm_ids_nr
> - use rm_ids[0] in patch 1 and patch 3
> - separate pm.rm_ids for incoming and outgoing
> - tag: export/20210131T062218
>
> v2:
> - use an array of ids instead of a u64 map
> - drop "mptcp: update the netlink event for rm_addr" in v1
> - tag: export/20210131T062218
>
> This patchset added the removing a list of addresses support for
> RM_ADDR. It addressed issue #140.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/140
>
> Geliang Tang (11):
> mptcp: add rm_list in mptcp_out_options
> mptcp: add rm_list_tx in mptcp_pm_data
> mptcp: add rm_list in mptcp_options_received
> mptcp: add rm_list_rx in mptcp_pm_data
> mptcp: remove multi addresses in PM
> mptcp: remove multi subflows in PM
> mptcp: remove multi addresses and subflows in PM
> mptcp: remove a list of addrs when flushing
> selftests: mptcp: add invert argument for chk_rm_nr
> selftests: mptcp: set addr id for removing testcases
> selftests: mptcp: add testcases for removing addrs
>
> include/net/mptcp.h | 9 +-
> net/mptcp/options.c | 49 +++++--
> net/mptcp/pm.c | 29 ++--
> net/mptcp/pm_netlink.c | 138 +++++++++++++-----
> net/mptcp/protocol.h | 17 ++-
> .../testing/selftests/net/mptcp/mptcp_join.sh | 82 ++++++++---
> 6 files changed, 233 insertions(+), 91 deletions(-)
>
> --
> 2.29.2
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org
>
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v7 mptcp-next 00/11] RM_ADDR: remove a list of addrs
@ 2021-02-11 15:34 Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2021-02-11 15:34 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]
Hi Geliang, Mat,
On 10/02/2021 20:42, Mat Martineau wrote:
> On Wed, 10 Feb 2021, Geliang Tang wrote:
>
>> v7:
>> - only changed the selftests.
>> - add patch 9 and 10 from patchset "move to next addr and testcases".
>> - drop "invalid addresses flush" in in patch 11, move it to patchset
>> "move to next addr and testcases"
>> - tag: export/20210209T062213
>
> Geliang -
>
> Thanks for reposting with the test changes. Self tests pass here and I
> reviewed the pcaps and debug logs too, looks good for the export branch.
Thank you for the patches and reviews!
Just applied in our tree with Mat's RvB and 2 small typos fixed in the
commit messages and reported by "checkpatch.pl --codespell"
- 1c96937632b9: mptcp: add rm_list in mptcp_out_options
- 3fdf49c516da: mptcp: add rm_list_tx in mptcp_pm_data
- 7aee779e6946: mptcp: add rm_list in mptcp_options_received
- 3edb9adea339: mptcp: add rm_list_rx in mptcp_pm_data
- 6eed48ec95a3: mptcp: remove multi addresses in PM
- b2144a3313f8: mptcp: remove multi subflows in PM
- 125ef24bb692: mptcp: remove multi addresses and subflows in PM
- bb2f562e7c86: mptcp: remove a list of addrs when flushing
- 0a0186b2d7b2: selftests: mptcp: add invert argument for chk_rm_nr
- 12f49b51c3de: selftests: mptcp: set addr id for removing testcases
- 9373d5c3f215: selftests: mptcp: add testcases for removing addrs
- Results: 312a753c50d7..d5fb4935cee8
Tests + export are in progress!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-11 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 19:42 [MPTCP] Re: [MPTCP][PATCH v7 mptcp-next 00/11] RM_ADDR: remove a list of addrs Mat Martineau
2021-02-11 15:34 Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.