From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Cc: konrad.wilk@oracle.com, sstabellini@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()
Date: Tue, 23 Apr 2019 10:20:10 -0400 [thread overview]
Message-ID: <e49eed35-6cf5-77d9-ba59-e1e021cece83@oracle.com> (raw)
In-Reply-To: <20190423105457.17502-2-jgross@suse.com>
On 4/23/19 6:54 AM, Juergen Gross wrote:
> The condition in xen_swiotlb_free_coherent() for deciding whether to
> call xen_destroy_contiguous_region() is wrong: in case the region to
> be freed is not contiguous calling xen_destroy_contiguous_region() is
> the wrong thing to do: it would result in inconsistent mappings of
> multiple PFNs to the same MFN. This will lead to various strange
> crashes or data corruption.
>
> Instead of calling xen_destroy_contiguous_region() in that case a
> warning should be issued as that situation should never occur.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Juergen Gross <jgross-IBi9RG/b67k@public.gmane.org>,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()
Date: Tue, 23 Apr 2019 10:20:10 -0400 [thread overview]
Message-ID: <e49eed35-6cf5-77d9-ba59-e1e021cece83@oracle.com> (raw)
In-Reply-To: <20190423105457.17502-2-jgross-IBi9RG/b67k@public.gmane.org>
On 4/23/19 6:54 AM, Juergen Gross wrote:
> The condition in xen_swiotlb_free_coherent() for deciding whether to
> call xen_destroy_contiguous_region() is wrong: in case the region to
> be freed is not contiguous calling xen_destroy_contiguous_region() is
> the wrong thing to do: it would result in inconsistent mappings of
> multiple PFNs to the same MFN. This will lead to various strange
> crashes or data corruption.
>
> Instead of calling xen_destroy_contiguous_region() in that case a
> warning should be issued as that situation should never occur.
>
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Juergen Gross <jgross-IBi9RG/b67k@public.gmane.org>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Cc: sstabellini@kernel.org, stable@vger.kernel.org, konrad.wilk@oracle.com
Subject: Re: [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()
Date: Tue, 23 Apr 2019 10:20:10 -0400 [thread overview]
Message-ID: <e49eed35-6cf5-77d9-ba59-e1e021cece83@oracle.com> (raw)
Message-ID: <20190423142010.TOipkI83I4tia08lS0jq_2ut8dt4fOGVMH4lbTdbF6U@z> (raw)
In-Reply-To: <20190423105457.17502-2-jgross@suse.com>
On 4/23/19 6:54 AM, Juergen Gross wrote:
> The condition in xen_swiotlb_free_coherent() for deciding whether to
> call xen_destroy_contiguous_region() is wrong: in case the region to
> be freed is not contiguous calling xen_destroy_contiguous_region() is
> the wrong thing to do: it would result in inconsistent mappings of
> multiple PFNs to the same MFN. This will lead to various strange
> crashes or data corruption.
>
> Instead of calling xen_destroy_contiguous_region() in that case a
> warning should be issued as that situation should never occur.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Cc: sstabellini@kernel.org, stable@vger.kernel.org, konrad.wilk@oracle.com
Subject: Re: [Xen-devel] [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()
Date: Tue, 23 Apr 2019 10:20:10 -0400 [thread overview]
Message-ID: <e49eed35-6cf5-77d9-ba59-e1e021cece83@oracle.com> (raw)
In-Reply-To: <20190423105457.17502-2-jgross@suse.com>
On 4/23/19 6:54 AM, Juergen Gross wrote:
> The condition in xen_swiotlb_free_coherent() for deciding whether to
> call xen_destroy_contiguous_region() is wrong: in case the region to
> be freed is not contiguous calling xen_destroy_contiguous_region() is
> the wrong thing to do: it would result in inconsistent mappings of
> multiple PFNs to the same MFN. This will lead to various strange
> crashes or data corruption.
>
> Instead of calling xen_destroy_contiguous_region() in that case a
> warning should be issued as that situation should never occur.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-23 14:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 10:54 [PATCH 0/3] xen/swiotlb: fix an issue and improve swiotlb-xen Juergen Gross
2019-04-23 10:54 ` [Xen-devel] " Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 10:54 ` [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region() Juergen Gross
2019-04-23 10:54 ` [Xen-devel] " Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 14:20 ` Boris Ostrovsky [this message]
2019-04-23 14:20 ` [Xen-devel] " Boris Ostrovsky
2019-04-23 14:20 ` Boris Ostrovsky
2019-04-23 14:20 ` Boris Ostrovsky
2019-04-23 14:20 ` Boris Ostrovsky
2019-04-25 8:53 ` [Xen-devel] " Jan Beulich
2019-04-25 8:53 ` Jan Beulich
2019-04-25 8:53 ` Jan Beulich
2019-04-25 8:53 ` Jan Beulich
2019-04-23 10:54 ` Juergen Gross
2019-04-23 10:54 ` [PATCH 2/3] xen/swiotlb: simplify range_straddles_page_boundary() Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 10:54 ` [Xen-devel] " Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 14:25 ` Boris Ostrovsky
2019-04-23 14:25 ` [Xen-devel] " Boris Ostrovsky
2019-04-23 14:25 ` Boris Ostrovsky
2019-04-23 14:25 ` Boris Ostrovsky
2019-04-23 14:25 ` Boris Ostrovsky
2019-04-23 10:54 ` [PATCH 3/3] xen/swiotlb: remember having called xen_create_contiguous_region() Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 10:54 ` [Xen-devel] " Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 10:54 ` Juergen Gross
2019-04-23 14:31 ` Boris Ostrovsky
2019-04-23 14:31 ` [Xen-devel] " Boris Ostrovsky
2019-04-23 14:31 ` Boris Ostrovsky
2019-04-23 14:31 ` Boris Ostrovsky
2019-04-23 14:31 ` Boris Ostrovsky
2019-04-23 17:05 ` Stefano Stabellini
2019-04-23 17:05 ` Stefano Stabellini
2019-04-23 17:05 ` [Xen-devel] " Stefano Stabellini
2019-04-23 17:05 ` Stefano Stabellini
2019-04-23 18:36 ` Juergen Gross
2019-04-23 18:36 ` [Xen-devel] " Juergen Gross
2019-04-23 18:36 ` Juergen Gross
2019-04-25 9:01 ` Jan Beulich
2019-04-25 9:01 ` [Xen-devel] " Jan Beulich
2019-04-25 9:01 ` Jan Beulich
2019-04-25 9:01 ` Jan Beulich
2019-04-25 9:01 ` Jan Beulich
2019-04-23 18:36 ` Juergen Gross
2019-04-25 8:55 [PATCH 1/3] xen/swiotlb: fix condition for calling xen_destroy_contiguous_region() Juergen Gross
2019-04-25 9:03 Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e49eed35-6cf5-77d9-ba59-e1e021cece83@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.