All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Manivannan Sadhasivam
	<manivannanece23-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4] iio:temperature: Add support for TI TMP007 sensor
Date: Sat, 14 Jan 2017 10:48:19 +0000	[thread overview]
Message-ID: <e4e7129b-94b8-1f38-ee53-c447ab041b80@kernel.org> (raw)
In-Reply-To: <20170110053603.n6ihrg3r6z4244g5@rob-hp-laptop>

On 10/01/17 05:36, Rob Herring wrote:
> On Mon, Jan 09, 2017 at 08:25:26AM +0530, Manivannan Sadhasivam wrote:
>> This patch adds support for TI TMP007 - 16 bit IR thermopile sensor with integrated Math engine.
>> Sensor takes care of calculating the object temperature with the help of calibrated constants stored in non-volatile memory,
>> thereby reducing the calculation overhead.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannanece23-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>
>> Changes since v3:
>>
>> 1. Removed caching of status register
>> 2. Modified comments for data validity
>> 3. Added possible address combinations in dTree bindings file
>>
>>  .../devicetree/bindings/iio/temperature/tmp007.txt |  27 ++
> 
> This could be documented under trivial-devices.txt, but doesn't hurt to 
> have it here.
> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks as ever Rob - I don't say that often enough!

Anyhow, nice little driver. Applied to the togreg branch of iio.git and
pushed out as testing for the autobuilders to see if they can find anything
we missed.

Was a bit messy going in with some fuzz, but superficially looks fine.

Thanks,

Jonathan
> 
>>  drivers/iio/temperature/Kconfig                    |  10 +
>>  drivers/iio/temperature/Makefile                   |   1 +
>>  drivers/iio/temperature/tmp007.c                   | 345 +++++++++++++++++++++
>>  4 files changed, 383 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/tmp007.txt
>>  create mode 100644 drivers/iio/temperature/tmp007.c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>,
	Manivannan Sadhasivam <manivannanece23@gmail.com>
Cc: pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4] iio:temperature: Add support for TI TMP007 sensor
Date: Sat, 14 Jan 2017 10:48:19 +0000	[thread overview]
Message-ID: <e4e7129b-94b8-1f38-ee53-c447ab041b80@kernel.org> (raw)
In-Reply-To: <20170110053603.n6ihrg3r6z4244g5@rob-hp-laptop>

On 10/01/17 05:36, Rob Herring wrote:
> On Mon, Jan 09, 2017 at 08:25:26AM +0530, Manivannan Sadhasivam wrote:
>> This patch adds support for TI TMP007 - 16 bit IR thermopile sensor with integrated Math engine.
>> Sensor takes care of calculating the object temperature with the help of calibrated constants stored in non-volatile memory,
>> thereby reducing the calculation overhead.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannanece23@gmail.com>
>> ---
>>
>> Changes since v3:
>>
>> 1. Removed caching of status register
>> 2. Modified comments for data validity
>> 3. Added possible address combinations in dTree bindings file
>>
>>  .../devicetree/bindings/iio/temperature/tmp007.txt |  27 ++
> 
> This could be documented under trivial-devices.txt, but doesn't hurt to 
> have it here.
> 
> Acked-by: Rob Herring <robh@kernel.org>
Thanks as ever Rob - I don't say that often enough!

Anyhow, nice little driver. Applied to the togreg branch of iio.git and
pushed out as testing for the autobuilders to see if they can find anything
we missed.

Was a bit messy going in with some fuzz, but superficially looks fine.

Thanks,

Jonathan
> 
>>  drivers/iio/temperature/Kconfig                    |  10 +
>>  drivers/iio/temperature/Makefile                   |   1 +
>>  drivers/iio/temperature/tmp007.c                   | 345 +++++++++++++++++++++
>>  4 files changed, 383 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/tmp007.txt
>>  create mode 100644 drivers/iio/temperature/tmp007.c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2017-01-14 10:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09  2:55 [PATCH v4] iio:temperature: Add support for TI TMP007 sensor Manivannan Sadhasivam
2017-01-09  2:55 ` Manivannan Sadhasivam
     [not found] ` <20170109025526.GA9601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-10  5:36   ` Rob Herring
2017-01-10  5:36     ` Rob Herring
2017-01-14 10:48     ` Jonathan Cameron [this message]
2017-01-14 10:48       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4e7129b-94b8-1f38-ee53-c447ab041b80@kernel.org \
    --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=manivannanece23-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.