Re: [PATCH v2 00/33] locking/atomic: convert all architectures to ARCH_ATOMIC

From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"will@kernel.org" <will@kernel.org>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"bcain@codeaurora.org" <bcain@codeaurora.org>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"chris@zankel.net" <chris@zankel.net>,
	"dalias@libc.org" <dalias@libc.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"deanbo422@gmail.com" <deanbo422@gmail.com>,
	"deller@gmx.de" <deller@gmx.de>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"gerg@linux-m68k.org" <gerg@linux-m68k.org>,
	"green.hu@gmail.com" <green.hu@gmail.com>,
	"guoren@kernel.org" <guoren@kernel.org>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"James.Bottomley@hansenpartnership.com" 
	<James.Bottomley@hansenpartnership.com>,
	"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
	"jonas@southpole.se" <jonas@southpole.se>,
	"ley.foon.tan@intel.com" <ley.foon.tan@intel.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"monstr@monstr.eu" <monstr@monstr.eu>,
	"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
	"nickhu@andestech.com" <nickhu@andestech.com>,
	"palmerdabbelt@google.com" <palmerdabbelt@google.com>,
	"paulus@samba.org" <paulus@samba.org>,
	"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"shorne@gmail.com" <shorne@gmail.com>,
	"stefan.kristiansson@saunalahti.fi" 
	<stefan.kristiansson@saunalahti.fi>,
	"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
	"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
	arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v2 00/33] locking/atomic: convert all architectures to ARCH_ATOMIC
Date: Mon, 28 Jun 2021 22:21:01 +0000	[thread overview]
Message-ID: <e500f4e2-d9bf-9374-c2fc-8fcf1ad43d57@synopsys.com> (raw)
In-Reply-To: <YNpJnzqg0yySeEE7@hirez.programming.kicks-ass.net>

On 6/28/21 3:13 PM, Peter Zijlstra wrote:
> On Mon, Jun 28, 2021 at 02:22:15PM -0700, Randy Dunlap wrote:
>> However, something in arch/arc/ did look suspicious so I decided to
>> try an ARC allmodconfig build, where I did see a few errors FYI:
>>
>>
>>    CC      drivers/iommu/io-pgtable-arm.o
>> In file included from ../include/linux/atomic.h:80,
>>                   from ../drivers/iommu/io-pgtable-arm.c:12:
>> ../drivers/iommu/io-pgtable-arm.c: In function 'arm_lpae_install_table':
>> ../include/linux/atomic-arch-fallback.h:60:32: error: implicit declaration of function 'arch_cmpxchg64'; did you mean 'arch_cmpxchg'? [-Werror=implicit-function-declaration]
>>     60 | #define arch_cmpxchg64_relaxed arch_cmpxchg64
>>        |                                ^~~~~~~~~~~~~~
>> ../include/asm-generic/atomic-instrumented.h:1261:2: note: in expansion of macro 'arch_cmpxchg64_relaxed'
>>   1261 |  arch_cmpxchg64_relaxed(__ai_ptr, __VA_ARGS__); \
>>        |  ^~~~~~~~~~~~~~~~~~~~~~
>> ../drivers/iommu/io-pgtable-arm.c:320:8: note: in expansion of macro 'cmpxchg64_relaxed'
>>    320 |  old = cmpxchg64_relaxed(ptep, curr, new);
>>        |        ^~~~~~~~~~~~~~~~~
> 0day also reported something like that. We found that this was a
> pre-existing error, and Mark's patches only changed the error, it never
> successfully build.
>
> cmpxchg64 is an optional feature for 32bit architectures, one that ARMv7
> does provide, and uses, for it's iommu bits. Building the ARM iommu
> drivers on ARC seem somewhat daft but is a result of that COMPILE_TEST
> config.

Out of my ARC64 work, I have a boat-load of changes piled up in this 
area. Once Mark's changes hit mainline I can send those out for review 
and we can also consider adding cmpxchg64 for 32-bit ARC.

-Vineet