All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl
@ 2021-07-23 13:26 Michael Nosthoff via buildroot
  2021-07-23 13:34 ` Michael Nosthoff via buildroot
  2021-07-24  7:53 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2021-07-23 13:26 UTC (permalink / raw)
  To: buildroot; +Cc: Michael Nosthoff, Marcin Bis

when compiling with mesh support and musl toolchain the build fails
due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.

Patch submitted upstream:
https://lore.kernel.org/linux-bluetooth/20210723081039.30396-1-bluez@heine.tech

Fixes:
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 ...-tools-mesh-cfgtest-include-limits.h.patch | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch

diff --git a/package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch b/package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch
new file mode 100644
index 0000000000..8f40a94873
--- /dev/null
+++ b/package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch
@@ -0,0 +1,32 @@
+From 5158827fded7cb4daf550a5956aff0c74f6c38fc Mon Sep 17 00:00:00 2001
+From: Michael Nosthoff <bluez@heine.tech>
+Date: Thu, 22 Jul 2021 21:36:13 +0200
+Subject: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
+
+mesh-cfgtest.c uses PATH_MAX so it should include limits.h.
+
+fixes compilation error when enabling mesh support with musl-based
+toolchains observed in buildroot autobuilders.
+
+http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
+http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/
+
+---
+ tools/mesh-cfgtest.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
+index fa0474faa..116ab7f16 100644
+--- a/tools/mesh-cfgtest.c
++++ b/tools/mesh-cfgtest.c
+@@ -21,6 +21,7 @@
+ #include <ftw.h>
+ #include <getopt.h>
+ #include <libgen.h>
++#include <limits.h>
+ #include <signal.h>
+ #include <stdio.h>
+ #include <time.h>
+-- 
+2.32.0
+
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl
  2021-07-23 13:26 [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl Michael Nosthoff via buildroot
@ 2021-07-23 13:34 ` Michael Nosthoff via buildroot
  2021-07-24  7:53 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2021-07-23 13:34 UTC (permalink / raw)
  To: buildroot

On 23.07.21 15:26, Michael Nosthoff via buildroot wrote:
> when compiling with mesh support and musl toolchain the build fails
> due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.
>
> Patch submitted upstream:
> https://lore.kernel.org/linux-bluetooth/20210723081039.30396-1-bluez@heine.tech
>
> Fixes:
> http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
> http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---

Forgot to add a changelog.

v2 just has an updated description (patch and commit) because I mixed up 
PATH_MAX and MAX_PATH...

Regards,
Michael

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl
  2021-07-23 13:26 [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl Michael Nosthoff via buildroot
  2021-07-23 13:34 ` Michael Nosthoff via buildroot
@ 2021-07-24  7:53 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-07-24  7:53 UTC (permalink / raw)
  To: Michael Nosthoff via buildroot; +Cc: Michael Nosthoff, Marcin Bis, buildroot

On Fri, 23 Jul 2021 15:26:46 +0200
Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:

> when compiling with mesh support and musl toolchain the build fails
> due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.
> 
> Patch submitted upstream:
> https://lore.kernel.org/linux-bluetooth/20210723081039.30396-1-bluez@heine.tech
> 
> Fixes:
> http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
> http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  ...-tools-mesh-cfgtest-include-limits.h.patch | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-24  7:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 13:26 [Buildroot] [PATCH v2] package/bluez5_utils: fix mesh build with musl Michael Nosthoff via buildroot
2021-07-23 13:34 ` Michael Nosthoff via buildroot
2021-07-24  7:53 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.