* [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686
@ 2019-03-09 16:48 BALATON Zoltan
2019-03-11 13:34 ` Paolo Bonzini
2019-03-11 14:54 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: BALATON Zoltan @ 2019-03-09 16:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini
Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
dependency on these in Kconfig to fix this.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/isa/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 57e09a0cb8..e092da3fc3 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -36,6 +36,8 @@ config VT82C686
select ACPI_SMBUS
select SERIAL_ISA
select FDC
+ select APM
+ select ACPI_X86
config SMC37C669
bool
--
2.13.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686
2019-03-09 16:48 [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686 BALATON Zoltan
@ 2019-03-11 13:34 ` Paolo Bonzini
2019-03-11 14:54 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-03-11 13:34 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel
On 09/03/19 17:48, BALATON Zoltan wrote:
> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
> dependency on these in Kconfig to fix this.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 57e09a0cb8..e092da3fc3 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -36,6 +36,8 @@ config VT82C686
> select ACPI_SMBUS
> select SERIAL_ISA
> select FDC
> + select APM
> + select ACPI_X86
>
> config SMC37C669
> bool
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686
2019-03-09 16:48 [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686 BALATON Zoltan
2019-03-11 13:34 ` Paolo Bonzini
@ 2019-03-11 14:54 ` Philippe Mathieu-Daudé
2019-03-11 16:33 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-11 14:54 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
On 3/9/19 5:48 PM, BALATON Zoltan wrote:
> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
> dependency on these in Kconfig to fix this.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 57e09a0cb8..e092da3fc3 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -36,6 +36,8 @@ config VT82C686
> select ACPI_SMBUS
> select SERIAL_ISA
> select FDC
> + select APM
Correct, I missed this one.
> + select ACPI_X86
NACK it does require ACPI but not X86.
ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series,
but I might have to include this in my 'Kconfig PIIX' series.
>
> config SMC37C669
> bool
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686
2019-03-11 14:54 ` Philippe Mathieu-Daudé
@ 2019-03-11 16:33 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-03-11 16:33 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
On 11/03/19 15:54, Philippe Mathieu-Daudé wrote:
> On 3/9/19 5:48 PM, BALATON Zoltan wrote:
>> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
>> dependency on these in Kconfig to fix this.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/isa/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index 57e09a0cb8..e092da3fc3 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -36,6 +36,8 @@ config VT82C686
>> select ACPI_SMBUS
>> select SERIAL_ISA
>> select FDC
>> + select APM
>
> Correct, I missed this one.
>
>> + select ACPI_X86
>
> NACK it does require ACPI but not X86.
>
> ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series,
> but I might have to include this in my 'Kconfig PIIX' series.
>
>>
>> config SMC37C669
>> bool
>>
Oh, I thought this was a build fix. But since MIPS does select these,
I've unqueued this patch and I'll let the maintainers pick Philippe's
series.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-11 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09 16:48 [Qemu-devel] [PATCH] isa: Add APM and ACPI dependencies for VT82C686 BALATON Zoltan
2019-03-11 13:34 ` Paolo Bonzini
2019-03-11 14:54 ` Philippe Mathieu-Daudé
2019-03-11 16:33 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.