* [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
@ 2020-02-12 20:36 Philippe Mathieu-Daudé
2020-02-13 20:28 ` Wainer dos Santos Moschetta
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-12 20:36 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, KONRAD Frederic, Philippe Mathieu-Daudé,
Fabien Chouteau, Cleber Rosa
The www.helenos.org server is slow and downloading the Leon3 binary
takes too long [*]. Do not include this test in the default suite.
Similarly to commit 471c97a69b:
Currently the Avocado framework does not distinct the time spent
downloading assets vs. the time spent running a test. With big
assets (like a full VM image) the tests likely fail.
This is a limitation known by the Avocado team.
Until this issue get fixed, do not run this tests automatically.
Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
environment variable.
[*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Add missing staged hunk...
---
tests/acceptance/machine_sparc_leon3.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
index f77e210ccb..27e4717a51 100644
--- a/tests/acceptance/machine_sparc_leon3.py
+++ b/tests/acceptance/machine_sparc_leon3.py
@@ -5,6 +5,9 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
+import os
+
+from avocado import skipUnless
from avocado_qemu import Test
from avocado_qemu import wait_for_console_pattern
@@ -13,6 +16,7 @@ class Leon3Machine(Test):
timeout = 60
+ @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
def test_leon3_helenos_uimage(self):
"""
:avocado: tags=arch:sparc
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
2020-02-12 20:36 [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default Philippe Mathieu-Daudé
@ 2020-02-13 20:28 ` Wainer dos Santos Moschetta
2020-02-17 11:51 ` KONRAD Frederic
2020-03-29 19:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 5+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-02-13 20:28 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: KONRAD Frederic, Alex Bennée, Fabien Chouteau, Cleber Rosa
On 2/12/20 6:36 PM, Philippe Mathieu-Daudé wrote:
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
> tests/acceptance/machine_sparc_leon3.py | 4 ++++
> 1 file changed, 4 insertions(+)
LGTM.
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> +import os
> +
> +from avocado import skipUnless
> from avocado_qemu import Test
> from avocado_qemu import wait_for_console_pattern
>
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>
> timeout = 60
>
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_leon3_helenos_uimage(self):
> """
> :avocado: tags=arch:sparc
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
2020-02-12 20:36 [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default Philippe Mathieu-Daudé
2020-02-13 20:28 ` Wainer dos Santos Moschetta
@ 2020-02-17 11:51 ` KONRAD Frederic
2020-03-29 19:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 5+ messages in thread
From: KONRAD Frederic @ 2020-02-17 11:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Alex Bennée, Fabien Chouteau, Cleber Rosa
Le 2/12/20 à 9:36 PM, Philippe Mathieu-Daudé a écrit :
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
> tests/acceptance/machine_sparc_leon3.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> +import os
> +
> +from avocado import skipUnless
> from avocado_qemu import Test
> from avocado_qemu import wait_for_console_pattern
>
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>
> timeout = 60
>
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_leon3_helenos_uimage(self):
> """
> :avocado: tags=arch:sparc
>
Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>
Thanks Philippe!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
2020-02-12 20:36 [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default Philippe Mathieu-Daudé
2020-02-13 20:28 ` Wainer dos Santos Moschetta
2020-02-17 11:51 ` KONRAD Frederic
@ 2020-03-29 19:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-29 19:40 UTC (permalink / raw)
To: qemu-devel, Eduardo Habkost
Cc: KONRAD Frederic, Alex Bennée, Fabien Chouteau, Cleber Rosa
I just noticed I forgot to Cc Eduardo when posting this :S
Eduardo, do you want me to prepare a pullreq for rc1 with this patch and
Oksana other fix?
On 2/12/20 9:36 PM, Philippe Mathieu-Daudé wrote:
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
> tests/acceptance/machine_sparc_leon3.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> +import os
> +
> +from avocado import skipUnless
> from avocado_qemu import Test
> from avocado_qemu import wait_for_console_pattern
>
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>
> timeout = 60
>
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_leon3_helenos_uimage(self):
> """
> :avocado: tags=arch:sparc
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
@ 2020-02-12 20:36 Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-12 20:36 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, KONRAD Frederic, Philippe Mathieu-Daudé,
Fabien Chouteau, Cleber Rosa
The www.helenos.org server is slow and downloading the Leon3 binary
takes too long [*]. Do not include this test in the default suite.
Similarly to commit 471c97a69b:
Currently the Avocado framework does not distinct the time spent
downloading assets vs. the time spent running a test. With big
assets (like a full VM image) the tests likely fail.
This is a limitation known by the Avocado team.
Until this issue get fixed, do not run this tests automatically.
Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
environment variable.
[*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Add missing staged hunk...
---
tests/acceptance/machine_sparc_leon3.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
index f77e210ccb..27e4717a51 100644
--- a/tests/acceptance/machine_sparc_leon3.py
+++ b/tests/acceptance/machine_sparc_leon3.py
@@ -5,6 +5,9 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
+import os
+
+from avocado import skipUnless
from avocado_qemu import Test
from avocado_qemu import wait_for_console_pattern
@@ -13,6 +16,7 @@ class Leon3Machine(Test):
timeout = 60
+ @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
def test_leon3_helenos_uimage(self):
"""
:avocado: tags=arch:sparc
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-29 19:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 20:36 [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default Philippe Mathieu-Daudé
2020-02-13 20:28 ` Wainer dos Santos Moschetta
2020-02-17 11:51 ` KONRAD Frederic
2020-03-29 19:40 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2020-02-12 20:36 Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.