Re: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address

From: Aaron Ma <aaron.ma@canonical.com>
To: Hayes Wang <hayeswang@realtek.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	Henning Schild <henning.schild@siemens.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Andrew Lunn <andrew@lunn.ch>, Oliver Neukum <oneukum@suse.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"tiwai@suse.de" <tiwai@suse.de>
Subject: Re: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address
Date: Thu, 27 Jan 2022 16:13:24 +0800	[thread overview]
Message-ID: <e52f8155-61a8-0cea-b96c-a05b83cdfff9@canonical.com> (raw)
In-Reply-To: <5b94f064bd5c48589ea856f68ac0e930@realtek.com>

On 1/27/22 16:06, Hayes Wang wrote:
> I don't think the feature of MAC passthrough address is maintained
> by Realtek. Especially, there is no uniform way about it. The
> different companies have to maintain their own ways by themselves.
> 
> Realtek could provide the method of finding out the specific device
> for Lenovo. You could check USB OCP 0xD81F bit 3. For example,
> 
> 	ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
> 	if (tp->version == RTL_VER_09 && (ocp_data & BIT(3))) {
> 		/* This is the RTL8153B for Lenovo. */
> 	}
> 

May I use the code from Realtek Outbox driver to implement the MAPT?

If so, allow me to write a patch and send here to review.

Thanks,
Aaron

> Best Regards,
> Hayes