From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-mm@kvack.org>, <kvm-ppc@vger.kernel.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Paul Mackerras <paulus@ozlabs.org>,
Ben Skeggs <bskeggs@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] ext4/xfs: add page refcount helper
Date: Mon, 28 Sep 2020 15:20:48 -0700 [thread overview]
Message-ID: <e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com> (raw)
In-Reply-To: <20200926063539.GA3540@lst.de>
On 9/25/20 11:35 PM, Christoph Hellwig wrote:
> On Fri, Sep 25, 2020 at 01:44:41PM -0700, Ralph Campbell wrote:
>> error = ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1,
>> + dax_layout_is_idle_page(page),
>> TASK_INTERRUPTIBLE, 0, 0,
>> ext4_wait_dax_page(ei));
>
>> +++ b/fs/xfs/xfs_file.c
>> @@ -750,7 +750,7 @@ xfs_break_dax_layouts(
>>
>> *retry = true;
>> return ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE,
>> + dax_layout_is_idle_page(page), TASK_INTERRUPTIBLE,
>> 0, 0, xfs_wait_dax_page(inode));
>> }
>
> I still think a litte helper macro would be nice here:
>
> #define dax_wait_page(_inode, _page, _wait_cb) \
> ___wait_var_event(&(_page)->_refcount, \
> atomic_read(&(_page)->_refcount) == 1, \
> TASK_INTERRUPTIBLE, dax_layout_is_idle_page(_page), \
> TASK_INTERRUPTIBLE, 0, 0, _wait_cb(_inode));
OK, I'll add it in v3.
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Campbell <rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Yang Shi
<yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>,
Zi Yan <ziy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Alistair Popple <apopple-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bharata B Rao <bharata-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
Paul Mackerras <paulus-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Jason Gunthorpe <jgg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Kirill A . Shutemov"
<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] ext4/xfs: add page refcount helper
Date: Mon, 28 Sep 2020 15:20:48 -0700 [thread overview]
Message-ID: <e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com> (raw)
In-Reply-To: <20200926063539.GA3540-jcswGhMUV9g@public.gmane.org>
On 9/25/20 11:35 PM, Christoph Hellwig wrote:
> On Fri, Sep 25, 2020 at 01:44:41PM -0700, Ralph Campbell wrote:
>> error = ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1,
>> + dax_layout_is_idle_page(page),
>> TASK_INTERRUPTIBLE, 0, 0,
>> ext4_wait_dax_page(ei));
>
>> +++ b/fs/xfs/xfs_file.c
>> @@ -750,7 +750,7 @@ xfs_break_dax_layouts(
>>
>> *retry = true;
>> return ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE,
>> + dax_layout_is_idle_page(page), TASK_INTERRUPTIBLE,
>> 0, 0, xfs_wait_dax_page(inode));
>> }
>
> I still think a litte helper macro would be nice here:
>
> #define dax_wait_page(_inode, _page, _wait_cb) \
> ___wait_var_event(&(_page)->_refcount, \
> atomic_read(&(_page)->_refcount) == 1, \
> TASK_INTERRUPTIBLE, dax_layout_is_idle_page(_page), \
> TASK_INTERRUPTIBLE, 0, 0, _wait_cb(_inode));
OK, I'll add it in v3.
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mm@kvack.org, kvm-ppc@vger.kernel.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Paul Mackerras <paulus@ozlabs.org>,
Ben Skeggs <bskeggs@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] ext4/xfs: add page refcount helper
Date: Mon, 28 Sep 2020 22:20:48 +0000 [thread overview]
Message-ID: <e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com> (raw)
In-Reply-To: <20200926063539.GA3540@lst.de>
On 9/25/20 11:35 PM, Christoph Hellwig wrote:
> On Fri, Sep 25, 2020 at 01:44:41PM -0700, Ralph Campbell wrote:
>> error = ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) = 1,
>> + dax_layout_is_idle_page(page),
>> TASK_INTERRUPTIBLE, 0, 0,
>> ext4_wait_dax_page(ei));
>
>> +++ b/fs/xfs/xfs_file.c
>> @@ -750,7 +750,7 @@ xfs_break_dax_layouts(
>>
>> *retry = true;
>> return ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) = 1, TASK_INTERRUPTIBLE,
>> + dax_layout_is_idle_page(page), TASK_INTERRUPTIBLE,
>> 0, 0, xfs_wait_dax_page(inode));
>> }
>
> I still think a litte helper macro would be nice here:
>
> #define dax_wait_page(_inode, _page, _wait_cb) \
> ___wait_var_event(&(_page)->_refcount, \
> atomic_read(&(_page)->_refcount) = 1, \
> TASK_INTERRUPTIBLE, dax_layout_is_idle_page(_page), \
> TASK_INTERRUPTIBLE, 0, 0, _wait_cb(_inode));
OK, I'll add it in v3.
next prev parent reply other threads:[~2020-09-28 23:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 20:44 [RFC PATCH v2 0/2] mm: remove extra ZONE_DEVICE struct page refcount Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-25 20:44 ` [PATCH 1/2] ext4/xfs: add page refcount helper Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-25 20:51 ` Dan Williams
2020-09-25 20:51 ` Dan Williams
2020-09-25 20:51 ` Dan Williams
2020-09-25 21:17 ` Ralph Campbell
2020-09-25 21:17 ` Ralph Campbell
2020-09-25 21:17 ` Ralph Campbell
2020-09-26 6:35 ` Christoph Hellwig
2020-09-26 6:35 ` Christoph Hellwig
2020-09-28 22:20 ` Ralph Campbell [this message]
2020-09-28 22:20 ` Ralph Campbell
2020-09-28 22:20 ` Ralph Campbell
2020-09-25 20:44 ` [PATCH 2/2] mm: remove extra ZONE_DEVICE struct page refcount Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-25 20:44 ` Ralph Campbell
2020-09-26 6:41 ` Christoph Hellwig
2020-09-26 6:41 ` Christoph Hellwig
2020-09-28 22:29 ` Ralph Campbell
2020-09-28 22:29 ` Ralph Campbell
2020-09-28 22:29 ` Ralph Campbell
2020-09-29 2:59 ` Bharata B Rao
2020-09-29 3:11 ` Bharata B Rao
2020-09-29 2:59 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@ozlabs.org \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.