* [PATCH] watchdog: it87_wdt: remove useless function
@ 2021-04-13 9:34 Jiapeng Chong
2021-04-13 15:01 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-13 9:34 UTC (permalink / raw)
To: wim; +Cc: linux, linux-watchdog, linux-kernel, Jiapeng Chong
Fix the following clang warning:
drivers/watchdog/it87_wdt.c:155:20: warning: unused function
'superio_outw' [-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/watchdog/it87_wdt.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
index 2b48318..bb11229 100644
--- a/drivers/watchdog/it87_wdt.c
+++ b/drivers/watchdog/it87_wdt.c
@@ -152,14 +152,6 @@ static inline int superio_inw(int reg)
return val;
}
-static inline void superio_outw(int val, int reg)
-{
- outb(reg++, REG);
- outb(val >> 8, VAL);
- outb(reg, REG);
- outb(val, VAL);
-}
-
/* Internal function, should be called after superio_select(GPIO) */
static void _wdt_update_timeout(unsigned int t)
{
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: it87_wdt: remove useless function
2021-04-13 9:34 [PATCH] watchdog: it87_wdt: remove useless function Jiapeng Chong
@ 2021-04-13 15:01 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-04-13 15:01 UTC (permalink / raw)
To: Jiapeng Chong, wim; +Cc: linux-watchdog, linux-kernel
On 4/13/21 2:34 AM, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/watchdog/it87_wdt.c:155:20: warning: unused function
> 'superio_outw' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it87_wdt.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index 2b48318..bb11229 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -152,14 +152,6 @@ static inline int superio_inw(int reg)
> return val;
> }
>
> -static inline void superio_outw(int val, int reg)
> -{
> - outb(reg++, REG);
> - outb(val >> 8, VAL);
> - outb(reg, REG);
> - outb(val, VAL);
> -}
> -
> /* Internal function, should be called after superio_select(GPIO) */
> static void _wdt_update_timeout(unsigned int t)
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 9:34 [PATCH] watchdog: it87_wdt: remove useless function Jiapeng Chong
2021-04-13 15:01 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.