All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Kees Cook <keescook@chromium.org>,
	cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Mon, 22 Jun 2020 15:16:23 +0300	[thread overview]
Message-ID: <e57c419b-a64a-55a1-be7a-8f45edaea3bf@linux.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006212255140.2501@hadrien>

What do you think about removing duplicates warning from the rule?

I mean this kind of warnings: "WARNING: same array_size (line {p1[0].line})"

As for now, I think it's better to not disturb developers with this kind
of things.

Thanks,
Denis

>> +@as_dup@
>> +expression subE1 <= as.E1;
>> +expression subE2 <= as.E2;
>> +expression as.E1, as.E2, E3;
>> +assignment operator aop;
>> +position p1, p2;
>> +@@
>> +
>> +* array_size(E1, E2)@p1
>> +  ... when != \(E1\|E2\|subE1\|subE2\) aop E3
>> +      when != &\(E1\|E2\|subE1\|subE2\)
>> +* array_size(E1, E2)@p2
>> +
>> +@script:python depends on report@
>> +p1 << as_dup.p1;
>> +p2 << as_dup.p2;
>> +@@
>> +
>> +coccilib.report.print_report(p2[0],
>> +f"WARNING: same array_size (line {p1[0].line})")
>> +
>> +@script:python depends on org@
>> +p1 << as_dup.p1;
>> +p2 << as_dup.p2;
>> +@@
>> +
>> +coccilib.org.print_todo(p2[0],
>> +f"WARNING: same array_size (line {p1[0].line})")
>> +


WARNING: multiple messages have this Message-ID (diff)
From: Denis Efremov <efremov@linux.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Mon, 22 Jun 2020 15:16:23 +0300	[thread overview]
Message-ID: <e57c419b-a64a-55a1-be7a-8f45edaea3bf@linux.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006212255140.2501@hadrien>

What do you think about removing duplicates warning from the rule?

I mean this kind of warnings: "WARNING: same array_size (line {p1[0].line})"

As for now, I think it's better to not disturb developers with this kind
of things.

Thanks,
Denis

>> +@as_dup@
>> +expression subE1 <= as.E1;
>> +expression subE2 <= as.E2;
>> +expression as.E1, as.E2, E3;
>> +assignment operator aop;
>> +position p1, p2;
>> +@@
>> +
>> +* array_size(E1, E2)@p1
>> +  ... when != \(E1\|E2\|subE1\|subE2\) aop E3
>> +      when != &\(E1\|E2\|subE1\|subE2\)
>> +* array_size(E1, E2)@p2
>> +
>> +@script:python depends on report@
>> +p1 << as_dup.p1;
>> +p2 << as_dup.p2;
>> +@@
>> +
>> +coccilib.report.print_report(p2[0],
>> +f"WARNING: same array_size (line {p1[0].line})")
>> +
>> +@script:python depends on org@
>> +p1 << as_dup.p1;
>> +p2 << as_dup.p2;
>> +@@
>> +
>> +coccilib.org.print_todo(p2[0],
>> +f"WARNING: same array_size (line {p1[0].line})")
>> +

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2020-06-22 12:15 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 10:20 [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks Denis Efremov
2020-06-15 10:20 ` [Cocci] " Denis Efremov
2020-06-15 18:23 ` Kees Cook
2020-06-15 18:23   ` [Cocci] " Kees Cook
2020-06-15 18:35   ` Denis Efremov
2020-06-15 18:35     ` [Cocci] " Denis Efremov
2020-06-15 18:46     ` Gustavo A. R. Silva
2020-06-15 18:46       ` Gustavo A. R. Silva
2020-06-17  9:32       ` Denis Efremov
2020-06-17  9:32         ` Denis Efremov
2020-06-17 10:55       ` Denis Efremov
2020-06-17 10:55         ` Denis Efremov
2020-06-17 20:08         ` Julia Lawall
2020-06-17 20:08           ` Julia Lawall
2020-06-17 20:15           ` Julia Lawall
2020-06-17 20:15             ` Julia Lawall
2020-06-17 18:15 ` Kees Cook
2020-06-17 18:15   ` [Cocci] " Kees Cook
2020-06-17 18:54   ` Julia Lawall
2020-06-17 18:54     ` Julia Lawall
2020-06-18 19:52     ` Kees Cook
2020-06-18 19:52       ` Kees Cook
2020-06-18 19:56       ` Julia Lawall
2020-06-18 19:56         ` Julia Lawall
2020-06-18 20:48         ` Kees Cook
2020-06-18 20:48           ` Kees Cook
2020-06-18 21:08           ` Julia Lawall
2020-06-18 21:08             ` Julia Lawall
2020-06-17 20:30 ` Julia Lawall
2020-06-17 20:30   ` Julia Lawall
2020-06-17 20:50   ` Denis Efremov
2020-06-17 20:50     ` Denis Efremov
2020-06-17 20:52     ` Julia Lawall
2020-06-17 20:52       ` Julia Lawall
2020-06-18 10:23 ` [PATCH v2] " Denis Efremov
2020-06-18 10:23   ` [Cocci] " Denis Efremov
2020-06-19 13:13 ` [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks Denis Efremov
2020-06-19 13:13   ` [Cocci] " Denis Efremov
2020-06-21 20:53   ` Julia Lawall
2020-06-21 20:53     ` Julia Lawall
2020-06-21 20:56   ` Julia Lawall
2020-06-21 20:56     ` Julia Lawall
2020-06-22 12:12     ` Denis Efremov
2020-06-22 12:12       ` Denis Efremov
2020-06-22 12:16     ` Denis Efremov [this message]
2020-06-22 12:16       ` Denis Efremov
2020-06-22 12:19       ` Julia Lawall
2020-06-22 12:19         ` Julia Lawall
2020-06-22 22:10 ` [PATCH v4] " Denis Efremov
2020-06-22 22:10   ` [Cocci] " Denis Efremov
2020-06-24 19:42   ` Julia Lawall
2020-06-24 19:42     ` [Cocci] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e57c419b-a64a-55a1-be7a-8f45edaea3bf@linux.com \
    --to=efremov@linux.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@inria.fr \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.