pull-request: iwlwifi-fixes for v5.5 2020-01-11

pull-request: iwlwifi-fixes for v5.5 2020-01-11

[Luca Coelho]

[-- Attachment #1: Type: text/plain, Size: 4681 bytes --]

Hi Kalle,

Here's the first batch of fixes intended for v5.5.  This includes the
last 2 patchsets I sent plus Mehmet's revert that I sent separately. 
More details about the contents in the tag description.

I pushed this to my pending branch and I got results from kbuildbot for
the first series, but not to
the second one yet.

Please let me know if there are any issues.

Cheers,
Luca.


The following changes since commit 33328bfab892d676920abb440d41fbf4b16c2717:

  MAINTAINERS: change Gruszka's email address (2019-12-19 14:54:51 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-kalle-2020-01-11

for you to fetch changes up to 205608749e1ef394f513888091e613c5bfccbcca:

  Revert "iwlwifi: mvm: fix scan config command size" (2019-12-30 15:43:40 +0200)

----------------------------------------------------------------
First batch of fixes intended for v5.5

* Don't send the PPAG command when PPAG is disabled, since it can
  cause problems;
* A few fixes for a HW bug;
* A fix for RS offload;
* A fix for 3168 devices where the NVM tables where the wrong tables
  were being read.
* Fix a couple of potential memory leaks in TXQ code;
* Disable L0S states in all hardware since our hardware doesn't
  officially support them anymore (and older versions of the hardware
  had instability in these states);
* Remove lar_disable parameter since it has been causing issues for
  some people who erroneously disable it;
* Force the debug monitor HW to stop also when debug is disabled,
  since it sometimes stays on and prevents low system power states;

----------------------------------------------------------------
Gil Adam (1):
      iwlwifi: don't send PPAG command if disabled

Haim Dreyfuss (1):
      iwlwifi: Don't ignore the cap field upon mcc update

Johannes Berg (8):
      iwlwifi: pcie: move page tracking into get_page_hdr()
      iwlwifi: pcie: work around DMA hardware bug
      iwlwifi: pcie: detect the DMA bug and warn if it happens
      iwlwifi: pcie: allocate smaller dev_cmd for TX headers
      iwlwifi: mvm: report TX rate to mac80211 directly for RS offload
      iwlwifi: pcie: extend hardware workaround to context-info
      iwlwifi: mvm: fix SKB leak on invalid queue
      iwlwifi: mvm: fix potential SKB leak on TXQ TX

Luca Coelho (6):
      iwlwifi: fix TLV fragment allocation loop
      iwlwifi: mvm: fix NVM check for 3168 devices
      iwlwifi: pcie: rename L0S_ENABLED bit to L0S_DISABLED
      iwlwifi: pcie: always disable L0S states
      iwlwifi: remove lar_disable module parameter
      iwlwifi: fw: make pos static in iwl_sar_get_ewrd_table() loop

Mehmet Akif Tasova (1):
      Revert "iwlwifi: mvm: fix scan config command size"

Shahar S Matityahu (1):
      iwlwifi: dbg: force stop the debug monitor HW

 drivers/net/wireless/intel/iwlwifi/dvm/tx.c         |   3 +-
 drivers/net/wireless/intel/iwlwifi/fw/acpi.c        |  10 ++---
 drivers/net/wireless/intel/iwlwifi/fw/dbg.c         |   7 +---
 drivers/net/wireless/intel/iwlwifi/iwl-csr.h        |   2 +-
 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c    |   9 ++++-
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c        |   3 --
 drivers/net/wireless/intel/iwlwifi/iwl-modparams.h  |   2 -
 drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c  |  61 +++++++++++++++++++++++++----
 drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.h  |   9 +++--
 drivers/net/wireless/intel/iwlwifi/iwl-trans.c      |  10 ++---
 drivers/net/wireless/intel/iwlwifi/iwl-trans.h      |  26 ++++++++++---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c         |   8 +++-
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c   | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 drivers/net/wireless/intel/iwlwifi/mvm/mvm.h        |   7 +---
 drivers/net/wireless/intel/iwlwifi/mvm/nvm.c        |  12 ++----
 drivers/net/wireless/intel/iwlwifi/mvm/scan.c       |   2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c         |  21 ++++------
 drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info.c |  45 +++++++++++++++++++--
 drivers/net/wireless/intel/iwlwifi/pcie/internal.h  |  19 +++++++--
 drivers/net/wireless/intel/iwlwifi/pcie/trans.c     |  47 +++++++++++++---------
 drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c   | 208 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------
 drivers/net/wireless/intel/iwlwifi/pcie/tx.c        |  68 ++++++++++++++++++++++----------
 22 files changed, 566 insertions(+), 170 deletions(-)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: pull-request: iwlwifi-fixes for v5.5 2020-01-11

[Kalle Valo]

Luca Coelho <luca@coelho.fi> writes:

> Here's the first batch of fixes intended for v5.5.  This includes the
> last 2 patchsets I sent plus Mehmet's revert that I sent separately. 
> More details about the contents in the tag description.
>
> I pushed this to my pending branch and I got results from kbuildbot for
> the first series, but not to
> the second one yet.
>
> Please let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 33328bfab892d676920abb440d41fbf4b16c2717:
>
>   MAINTAINERS: change Gruszka's email address (2019-12-19 14:54:51 +0200)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-kalle-2020-01-11
>
> for you to fetch changes up to 205608749e1ef394f513888091e613c5bfccbcca:
>
>   Revert "iwlwifi: mvm: fix scan config command size" (2019-12-30 15:43:40 +0200)
>
> ----------------------------------------------------------------
> First batch of fixes intended for v5.5
>
> * Don't send the PPAG command when PPAG is disabled, since it can
>   cause problems;
> * A few fixes for a HW bug;
> * A fix for RS offload;
> * A fix for 3168 devices where the NVM tables where the wrong tables
>   were being read.
> * Fix a couple of potential memory leaks in TXQ code;
> * Disable L0S states in all hardware since our hardware doesn't
>   officially support them anymore (and older versions of the hardware
>   had instability in these states);
> * Remove lar_disable parameter since it has been causing issues for
>   some people who erroneously disable it;
> * Force the debug monitor HW to stop also when debug is disabled,
>   since it sometimes stays on and prevents low system power states;
>
> ----------------------------------------------------------------

This looks like a very questionable pull request for -rc release,
especially at this late stage of the cycle as risk of regressions
increases. I think quite of few these should have gone to -next. I
pulled it anyway as there's not much time left for v5.5, but please tune
down the number of patches going to -rc releases in the future just to
the most important, preferably user reported, issues.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches