* [PATCH 0/2] staging: vboxvideo: Remove chekpatch issues
@ 2018-10-25 19:40 Shayenne da Luz Moura
2018-10-26 10:34 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Shayenne da Luz Moura @ 2018-10-25 19:40 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hans de Goede, Michael Thayer
Cc: devel, linux-kernel, outreachy-kernel
This series cleans the following checkpatch.pl issues:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
CHECK: Avoid using bool structure members because of possible alignment issues
Shayenne da Luz Moura (2):
staging: vboxvideo: Change uint32_t to u32
staging: vboxvideo: Use unsigned int instead bool
drivers/staging/vboxvideo/vbox_drv.h | 14 +++++++-------
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
drivers/staging/vboxvideo/vboxvideo_guest.h | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/2] staging: vboxvideo: Remove chekpatch issues
2018-10-25 19:40 [PATCH 0/2] staging: vboxvideo: Remove chekpatch issues Shayenne da Luz Moura
@ 2018-10-26 10:34 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-10-26 10:34 UTC (permalink / raw)
To: Shayenne da Luz Moura, Greg Kroah-Hartman, Michael Thayer
Cc: devel, linux-kernel, outreachy-kernel
Hi,
On 25-10-18 21:40, Shayenne da Luz Moura wrote:
> This series cleans the following checkpatch.pl issues:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> CHECK: Avoid using bool structure members because of possible alignment issues
>
> Shayenne da Luz Moura (2):
> staging: vboxvideo: Change uint32_t to u32
> staging: vboxvideo: Use unsigned int instead bool
Why am I receiving only the cover letter of this series? Please resend
so that I get all the patches.
Also at least the first patch is wrong, the drm headers use uint32_t
in the prototype definition of the callback functions we are defining,
so the vboxvideo code should use the same even if the compiler does not
warn about the callback implementation having different parameter types
in this case.
Regards,
Hans
>
> drivers/staging/vboxvideo/vbox_drv.h | 14 +++++++-------
> drivers/staging/vboxvideo/vbox_mode.c | 2 +-
> drivers/staging/vboxvideo/vboxvideo_guest.h | 2 +-
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-26 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 19:40 [PATCH 0/2] staging: vboxvideo: Remove chekpatch issues Shayenne da Luz Moura
2018-10-26 10:34 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.