All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release()
@ 2020-05-22  9:08 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-22  9:08 UTC (permalink / raw)
  To: Peng Hao, linux-mmc; +Cc: linux-kernel, Chaotian Jing, Ulf Hansson

> This is caused by dereferencing 'rpmb' after put_device().

I suggest to improve also this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151

How do you think about a wording variant like the following?

   The data structure member “rpmb->md” was passed to a call of
   the function “mmc_blk_put” after a call of the function “put_device”.
   Reorder these function calls to keep the data accesses consistent.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-22  9:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22  9:08 [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release() Markus Elfring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.