* [PATCH] ipv6: correct comments about fib6_node sernum
@ 2021-08-23 3:49 zhang kai
2021-08-24 4:21 ` David Ahern
2021-08-24 9:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: zhang kai @ 2021-08-23 3:49 UTC (permalink / raw)
To: davem; +Cc: yoshfuji, dsahern, kuba, netdev, linux-kernel, zhang kai
correct comments in set and get fn_sernum
Signed-off-by: zhang kai <zhangkaiheb@126.com>
---
include/net/ip6_fib.h | 4 ++--
net/ipv6/ip6_fib.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index 15b7fbe6b..c412dde4d 100644
--- a/include/net/ip6_fib.h
+++ b/include/net/ip6_fib.h
@@ -267,7 +267,7 @@ static inline bool fib6_check_expired(const struct fib6_info *f6i)
return false;
}
-/* Function to safely get fn->sernum for passed in rt
+/* Function to safely get fn->fn_sernum for passed in rt
* and store result in passed in cookie.
* Return true if we can get cookie safely
* Return false if not
@@ -282,7 +282,7 @@ static inline bool fib6_get_cookie_safe(const struct fib6_info *f6i,
if (fn) {
*cookie = fn->fn_sernum;
- /* pairs with smp_wmb() in fib6_update_sernum_upto_root() */
+ /* pairs with smp_wmb() in __fib6_update_sernum_upto_root() */
smp_rmb();
status = true;
}
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 679699e95..4d7b93baa 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1340,7 +1340,7 @@ static void __fib6_update_sernum_upto_root(struct fib6_info *rt,
struct fib6_node *fn = rcu_dereference_protected(rt->fib6_node,
lockdep_is_held(&rt->fib6_table->tb6_lock));
- /* paired with smp_rmb() in rt6_get_cookie_safe() */
+ /* paired with smp_rmb() in fib6_get_cookie_safe() */
smp_wmb();
while (fn) {
fn->fn_sernum = sernum;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: correct comments about fib6_node sernum
2021-08-23 3:49 [PATCH] ipv6: correct comments about fib6_node sernum zhang kai
@ 2021-08-24 4:21 ` David Ahern
2021-08-24 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2021-08-24 4:21 UTC (permalink / raw)
To: zhang kai, davem; +Cc: yoshfuji, dsahern, kuba, netdev, linux-kernel
On 8/22/21 9:49 PM, zhang kai wrote:
> correct comments in set and get fn_sernum
>
> Signed-off-by: zhang kai <zhangkaiheb@126.com>
> ---
> include/net/ip6_fib.h | 4 ++--
> net/ipv6/ip6_fib.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: correct comments about fib6_node sernum
2021-08-23 3:49 [PATCH] ipv6: correct comments about fib6_node sernum zhang kai
2021-08-24 4:21 ` David Ahern
@ 2021-08-24 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-24 9:10 UTC (permalink / raw)
To: zhang kai; +Cc: davem, yoshfuji, dsahern, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 23 Aug 2021 11:49:00 +0800 you wrote:
> correct comments in set and get fn_sernum
>
> Signed-off-by: zhang kai <zhangkaiheb@126.com>
> ---
> include/net/ip6_fib.h | 4 ++--
> net/ipv6/ip6_fib.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- ipv6: correct comments about fib6_node sernum
https://git.kernel.org/netdev/net/c/446e7f218b76
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-24 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 3:49 [PATCH] ipv6: correct comments about fib6_node sernum zhang kai
2021-08-24 4:21 ` David Ahern
2021-08-24 9:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.