linux-next: build failure after merge of the hid tree

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (x86_64
modules_install (on an allmodconfig build)) failed like this:

depmod: ERROR: Cycle detected: hid -> usbhid -> hid
depmod: ERROR: Found 2 modules in dependency cycles!

I could not easily figure out what caused this (it may not be the hid
tree, but probably is), so all I could do was leave it broken.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Thu, 27 May 2021, Stephen Rothwell wrote:

> After merging the hid tree, today's linux-next build (x86_64
> modules_install (on an allmodconfig build)) failed like this:
> 
> depmod: ERROR: Cycle detected: hid -> usbhid -> hid
> depmod: ERROR: Found 2 modules in dependency cycles!
> 
> I could not easily figure out what caused this (it may not be the hid
> tree, but probably is), so all I could do was leave it broken.

This is caused by Hans' patches (CCed). I will be dropping those today, as 
the proper fix needs a bit more of rework.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: linux-next: build failure after merge of the hid tree

[Hans de Goede]

Hi,

On 5/27/21 10:14 AM, Jiri Kosina wrote:
> On Thu, 27 May 2021, Stephen Rothwell wrote:
> 
>> After merging the hid tree, today's linux-next build (x86_64
>> modules_install (on an allmodconfig build)) failed like this:
>>
>> depmod: ERROR: Cycle detected: hid -> usbhid -> hid
>> depmod: ERROR: Found 2 modules in dependency cycles!
>>
>> I could not easily figure out what caused this (it may not be the hid
>> tree, but probably is), so all I could do was leave it broken.
> 
> This is caused by Hans' patches (CCed). I will be dropping those today, as 
> the proper fix needs a bit more of rework.

Ack, sorry about the trouble these patches are causing.

Regards,

Hans

Re: linux-next: build failure after merge of the hid tree

[Naresh Kamboju]

FYI,

On Thu, 27 May 2021 at 13:56, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 5/27/21 10:14 AM, Jiri Kosina wrote:
> > On Thu, 27 May 2021, Stephen Rothwell wrote:
> >
> >> After merging the hid tree, today's linux-next build (x86_64
> >> modules_install (on an allmodconfig build)) failed like this:
> >>
> >> depmod: ERROR: Cycle detected: hid -> usbhid -> hid
> >> depmod: ERROR: Found 2 modules in dependency cycles!

LKFT build system also found two types of build errors while building for arm
on today's Linux next-20210527 tag.

1)
arm-linux-gnueabihf-ld: drivers/hid/hid-core.o: in function `hid_is_usb_device':
hid-core.c:(.text+0x1f4): undefined reference to `usb_hid_driver'
make[1]: *** [/builds/linux/Makefile:1252: vmlinux] Error 1


2)
INSTALL_MOD_PATH=/home/tuxbuild/.cache/tuxmake/builds/current/modinstall
depmod: ERROR: Cycle detected: hid -> usbhid -> hid
depmod: ERROR: Found 2 modules in dependency cycles!
make[1]: *** [/builds/linux/Makefile:1875: modules_install] Error 1


> >>
> >> I could not easily figure out what caused this (it may not be the hid
> >> tree, but probably is), so all I could do was leave it broken.
> >
> > This is caused by Hans' patches (CCed). I will be dropping those today, as
> > the proper fix needs a bit more of rework.
>
> Ack, sorry about the trouble these patches are causing.

Thanks for investigating the root cause.

- Naresh

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Thu, 27 May 2021, Hans de Goede wrote:

> >> After merging the hid tree, today's linux-next build (x86_64
> >> modules_install (on an allmodconfig build)) failed like this:
> >>
> >> depmod: ERROR: Cycle detected: hid -> usbhid -> hid
> >> depmod: ERROR: Found 2 modules in dependency cycles!
> >>
> >> I could not easily figure out what caused this (it may not be the hid
> >> tree, but probably is), so all I could do was leave it broken.
> > 
> > This is caused by Hans' patches (CCed). I will be dropping those today, as 
> > the proper fix needs a bit more of rework.
> 
> Ack, sorry about the trouble these patches are causing.

for-next has now been rebased with the three relevant commits removed.

Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/hid/i2c-hid/i2c-hid-core.c: In function 'i2c_hid_set_power':
drivers/hid/i2c-hid/i2c-hid-core.c:410:1: error: label 'set_pwr_exit' defined but not used [-Werror=unused-label]
  410 | set_pwr_exit:
      | ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  7d6f065de37c ("HID: i2c-hid: Use address probe to wake on resume")

I have used the hid tree from next-20240506 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Kenny Levinsen]

On 5/7/24 3:06 AM, Stephen Rothwell wrote:
> drivers/hid/i2c-hid/i2c-hid-core.c: In function 'i2c_hid_set_power':
> drivers/hid/i2c-hid/i2c-hid-core.c:410:1: error: label 'set_pwr_exit' defined but not used [-Werror=unused-label]
>    410 | set_pwr_exit:
>        | ^~~~~~~~~~~~
> cc1: all warnings being treated as errors


Apologies, I did not realize that I had missed -Werror on my kernel 
builder. I have posted the fix[0] to the input mailing list and made 
sure I have -Werror enabled for future patch work.

[0]: 
https://patchwork.kernel.org/project/linux-input/patch/20240507063656.2892-1-kl@kl.wtf/

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `hid_bpf_input_report':
(.text+0x1c75181): undefined reference to `hid_input_report'

Caused by commit

  9be50ac30a83 ("HID: bpf: allow to inject HID event from BPF")

I have used the hid tree from next-20240410 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Benjamin Tissoires]

On Apr 11 2024, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> x86_64-linux-gnu-ld: vmlinux.o: in function `hid_bpf_input_report':
> (.text+0x1c75181): undefined reference to `hid_input_report'
> 
> Caused by commit
> 
>   9be50ac30a83 ("HID: bpf: allow to inject HID event from BPF")
> 
> I have used the hid tree from next-20240410 for today.

Sorry for that. It should be fixed by:
https://lore.kernel.org/linux-input/20240411-fix-hid-bpf-v1-1-4ae913031a8c@kernel.org/T/#u

If no one complains about it today, I'll append it to the HID for-next branch.

Cheers,
Benjamin

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/hid/amd-sfh-hid/amd_sfh_pcie.c: In function 'amd_mp2_pci_probe':
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c:413:21: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpu_hwid'?
  413 |                 if (boot_cpu_data.x86 >= 0x1A)
      |                     ^~~~~~~~~~~~~
      |                     boot_cpu_hwid

Caused by commit

  6296562f30b1 ("HID: amd_sfh: Extend MP2 register access to SFH")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/hid/hid-nintendo.c:1514:29: error: redefinition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
 1514 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:295:29: note: previous definition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT' with type 'short unsigned int'
  295 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  669abca7b767 ("HID: nintendo: Fix unused-const-variable compiler warning")

interacting with commit

  92cdfba40155 ("HID: nintendo: fix unused const warning")

I have used the hid tree from next-20220722 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Mon, 25 Jul 2022, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/hid/hid-nintendo.c:1514:29: error: redefinition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
>  1514 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-nintendo.c:295:29: note: previous definition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT' with type 'short unsigned int'
>   295 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   669abca7b767 ("HID: nintendo: Fix unused-const-variable compiler warning")
> 
> interacting with commit
> 
>   92cdfba40155 ("HID: nintendo: fix unused const warning")
> 
> I have used the hid tree from next-20220722 for today.

My fault, I forgot that this was actually already fixed before by Daniel.

Dropped for now from for-next. Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi Jiri,

On Mon, 25 Jul 2022 11:42:26 +0200 (CEST) Jiri Kosina <jikos@kernel.org> wrote:
>
> My fault, I forgot that this was actually already fixed before by Daniel.
> 
> Dropped for now from for-next. Thanks,

I am still getting the error.  Forgot to push?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (sparc defconfig)
failed like this:

hid-chicony.c:(.text+0x4): undefined reference to `usb_hid_driver'
hid-chicony.c:(.text+0xc): undefined reference to `usb_hid_driver'

Caused by commit

  93020953d0fa ("HID: check for valid USB device for many HID drivers")

I have marked CONFIG_HID_CHICONY as BROKEN for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Greg Kroah-Hartman]

On Fri, Dec 03, 2021 at 06:01:24PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hid tree, today's linux-next build (sparc defconfig)
> failed like this:
> 
> hid-chicony.c:(.text+0x4): undefined reference to `usb_hid_driver'
> hid-chicony.c:(.text+0xc): undefined reference to `usb_hid_driver'
> 
> Caused by commit
> 
>   93020953d0fa ("HID: check for valid USB device for many HID drivers")
> 
> I have marked CONFIG_HID_CHICONY as BROKEN for now.

Patch for this is at:
	https://lore.kernel.org/r/20211203075927.2829218-1-gregkh@linuxfoundation.org

Looks like 0-day found another dependancy as well, in the prodikeys
hid driver, will send out a patch for that too...

thanks,

greg k-h

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: drivers/hid/hid-lg-g15.o: in function `.lg_g15_probe':
hid-lg-g15.c:(.text+0x1a1c): undefined reference to `.devm_led_classdev_register_ext'
ld: hid-lg-g15.c:(.text+0x1c68): undefined reference to `.devm_led_classdev_register_ext'

Caused by commit

  3a0275384c27 ("HID: Add driver for Logitech gaming keyboards (G15, G15 v2)")

For this build, CONFIG_HID_LOGITECH=y and CONFIG_LEDS_CLASS=m.

I have used the hid tree from next-20191003 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Hans de Goede]

Hi Stephen, Jiri,

On 10/4/19 2:28 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ld: drivers/hid/hid-lg-g15.o: in function `.lg_g15_probe':
> hid-lg-g15.c:(.text+0x1a1c): undefined reference to `.devm_led_classdev_register_ext'
> ld: hid-lg-g15.c:(.text+0x1c68): undefined reference to `.devm_led_classdev_register_ext'
> 
> Caused by commit
> 
>    3a0275384c27 ("HID: Add driver for Logitech gaming keyboards (G15, G15 v2)")
> 
> For this build, CONFIG_HID_LOGITECH=y and CONFIG_LEDS_CLASS=m.

My bad, thank you for reporting this. I will try to come up with a fix for this
today.

Regards,

Hans

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

Hi Jiri,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/hid/i2c-hid/i2c-hid.c: In function 'i2c_hid_start':
drivers/hid/i2c-hid/i2c-hid.c:773:19: error: 'struct i2c_hid' has no member named 'irq'
   disable_irq(ihid->irq);
                   ^
drivers/hid/i2c-hid/i2c-hid.c:777:18: error: 'struct i2c_hid' has no member named 'irq'
   enable_irq(ihid->irq);
                  ^

Caused by commit

  de3c99488609 ("HID: i2c-hid: Disable IRQ before freeing buffers")

interacting with commit

  ba18a9314a94 ("Revert "HID: i2c-hid: Add support for ACPI GPIO interrupts"")

from earlier in the same tree!

I have used the hid tree from next-20161209 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Mon, 12 Dec 2016, Stephen Rothwell wrote:

> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/hid/i2c-hid/i2c-hid.c: In function 'i2c_hid_start':
> drivers/hid/i2c-hid/i2c-hid.c:773:19: error: 'struct i2c_hid' has no member named 'irq'
>    disable_irq(ihid->irq);
>                    ^
> drivers/hid/i2c-hid/i2c-hid.c:777:18: error: 'struct i2c_hid' has no member named 'irq'
>    enable_irq(ihid->irq);
>                   ^
> 
> Caused by commit
> 
>   de3c99488609 ("HID: i2c-hid: Disable IRQ before freeing buffers")
> 
> interacting with commit
> 
>   ba18a9314a94 ("Revert "HID: i2c-hid: Add support for ACPI GPIO interrupts"")
> 
> from earlier in the same tree!
> 
> I have used the hid tree from next-20161209 for today.

I've now pushed out fixed for-next branch. Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/hid/Kconfig:698: unexpected 'endif' within menu block
drivers/hid/Kconfig:702: unexpected 'endmenu' within if block
drivers/Kconfig:151: 'endmenu' in different file than 'menu'
drivers/hid/Kconfig:79: location of the 'menu'
arch/powerpc/kvm/Kconfig:153: syntax error
drivers/Kconfig:1: missing end statement for this entry

Caused by bad merge 8494746044bf ("Merge branch 'roccat' into
for-next").  This added a second copy of

menu "Special HID drivers"

I have used the hid tree from next-20120628 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Fri, 29 Jun 2012, Stephen Rothwell wrote:

> After merging the hid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/hid/Kconfig:698: unexpected 'endif' within menu block
> drivers/hid/Kconfig:702: unexpected 'endmenu' within if block
> drivers/Kconfig:151: 'endmenu' in different file than 'menu'
> drivers/hid/Kconfig:79: location of the 'menu'
> arch/powerpc/kvm/Kconfig:153: syntax error
> drivers/Kconfig:1: missing end statement for this entry
> 
> Caused by bad merge 8494746044bf ("Merge branch 'roccat' into
> for-next").  This added a second copy of
> 
> menu "Special HID drivers"
> 
> I have used the hid tree from next-20120628 for today.

Thanks for reporting this, Stephen; I have mismerged the branch. Just 
pushed out fixed branch, so all should be okay now.

Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/hid/Kconfig:37: syntax error
drivers/hid/Kconfig:36: invalid option

Caused by commit 7e69ba7caeb0 ("HID: introduce proper dependency of
HID_BATTERY on POWER_SUPPLY").

I am sure that this "==" v. "=" in Kconfig files was discussed last
week ... :-(

I have used the hid tree from next-20111216 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Mon, 19 Dec 2011, Stephen Rothwell wrote:

> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/hid/Kconfig:37: syntax error
> drivers/hid/Kconfig:36: invalid option
> 
> Caused by commit 7e69ba7caeb0 ("HID: introduce proper dependency of
> HID_BATTERY on POWER_SUPPLY").
> 
> I am sure that this "==" v. "=" in Kconfig files was discussed last
> week ... :-(

How pathetic I am ... it was initially me who noticed that this is not 
going to work, just to do the very same mistake shortly afterwards.

Sorry about that. I have now pushed fixed branch.

-- 
Jiri Kosina
SUSE Labs

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/hid/hid-input.c: In function 'hidinput_hid_event':
drivers/hid/hid-input.c:865:6: error: 'struct hid_device' has no member named 'battery_val'
drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member named 'battery_min'
drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member named 'battery_max'

Caused by commit 4f5ca836bef3 ("HID: hid-input: add support for HID
devices reporting Battery Strength").  Those members are only defined when
CONFIG_HID_BATTERY_STRENGTH is set.

I have used the hid tree from next-20111128 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Jeremy Fitzhardinge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 11/28/2011 05:00 PM, Stephen Rothwell wrote:
> Hi Jiri,
>
> After merging the hid tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/hid/hid-input.c: In function 'hidinput_hid_event':
> drivers/hid/hid-input.c:865:6: error: 'struct hid_device' has no member
named 'battery_val'
> drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member
named 'battery_min'
> drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member
named 'battery_max'
>
> Caused by commit 4f5ca836bef3 ("HID: hid-input: add support for HID
> devices reporting Battery Strength"). Those members are only defined when
> CONFIG_HID_BATTERY_STRENGTH is set.
>
> I have used the hid tree from next-20111128 for today.

Oh, sorry about that.  Is this sufficient?

Subject: [PATCH] hid-input: fix compile for !HID_BATTERY_STRENGTH

As reported by Stephen Rothwell:
drivers/hid/hid-input.c: In function 'hidinput_hid_event':
drivers/hid/hid-input.c:865:6: error: 'struct hid_device' has no member
named 'battery_val'
drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member
named 'battery_min'
drivers/hid/hid-input.c:866:3: error: 'struct hid_device' has no member
named 'battery_max'

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 83afb86..d9cadb3 100644
- --- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -861,12 +861,14 @@ void hidinput_hid_event(struct hid_device *hid,
struct hid_field *field, struct
 
     input = field->hidinput->input;
 
+#ifdef CONFIG_HID_BATTERY_STRENGTH
     if (usage->hid == HID_DC_BATTERYSTRENGTH) {
         hid->battery_val = value;
         hid_dbg(hid, "battery value is %d (range %d-%d)\n",
             value, hid->battery_min, hid->battery_max);
         return;
     }
+#endif
 
     if (!usage->type)
         return;

    J
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEkBAEBCgAGBQJO1DXKAAoJEAUkni6MUg7H2/wIPAk0oHGVawNScWJdJXMhMVca
ApxAr1h2v5kgIzRlihkpOiK3opft/GzBYh54HHd4nPdC5D4KAmuOXeX2+fwVgIEG
SlrwsGU4J9n9uH/e3qgJf2aANcWH+bQwqL58ZyLE0Yo+N3dBzDNaNGd8Gygw8jk+
mGtsMAfjIwe5vDLmsIED1+hqGNUL8/vt+TnCcpNVWUdrUtCT7dpDifcoeblO/qrs
5hWbpf+AOek7UEoHQ0qAbRLi8A1FcoMs20mHiSpkfVn2d2gUYUYZRjeW66xwuKB7
Q9iYEoOEszj+07nkHvS8VZZFMIXKsBOvkDVrktQtgDTZzI71axbgKPK8UESjjH4U
uMPpWmv8yA==
=2NZE
-----END PGP SIGNATURE-----

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

make[3]: *** No rule to make target `drivers/hid/hid-speedlink.c', needed by `drivers/hid/hid-speedlink.o'.  Stop.

Caused by commit b5eb65d64f91 ("HID: Add driver to fix Speedlink VAD
Cezanne support").

I have used the hid tree from next-20110607 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Stefan Kriwanek]

Hi Jiri,

I can only guess that this has to do with my patch not made by `git --diff` but simply `diff -up /dev/null/linux-2.6.39-speedlink/drivers/hid/hid-speedlink.c`

--- /dev/null	2011-05-27 13:53:55.863652998 +0200
+++ linux-2.6.39-speedlink/drivers/hid/hid-speedlink.c	2011-05-27 18:00:34.719863577 +0200

I am sorry if I caused the disturbance. However, after reading Documentation/SubmittitingPatches etc. I didn't know of any special measure to undertake when adding new files - If so, maybe one should consider updating the documention?.

Regards,
Stefan

Am 08.06.2011 05:03, schrieb Stephen Rothwell:
> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> make[3]: *** No rule to make target `drivers/hid/hid-speedlink.c', needed by `drivers/hid/hid-speedlink.o'.  Stop.
> 
> Caused by commit b5eb65d64f91 ("HID: Add driver to fix Speedlink VAD
> Cezanne support").
> 
> I have used the hid tree from next-20110607 for today.

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Wed, 8 Jun 2011, Stefan Kriwanek wrote:

> Hi Jiri,
> 
> I can only guess that this has to do with my patch not made by `git 
> --diff` but simply `diff -up 
> /dev/null/linux-2.6.39-speedlink/drivers/hid/hid-speedlink.c`
> 
> --- /dev/null	2011-05-27 13:53:55.863652998 +0200
> +++ linux-2.6.39-speedlink/drivers/hid/hid-speedlink.c	2011-05-27 18:00:34.719863577 +0200
> 
> I am sorry if I caused the disturbance. However, after reading 
> Documentation/SubmittitingPatches etc. I didn't know of any special 
> measure to undertake when adding new files - If so, maybe one should 
> consider updating the documention?.

Bah, no need to be sorry, it's my fault. Forgot to do 'git add' after I 
have resolved the conflict.

Fixed now in my tree and pushed out.

-- 
Jiri Kosina
SUSE Labs

linux-next: build failure after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

samples/hidraw/hid-example.c: In function 'main':
samples/hidraw/hid-example.c:103: warning: implicit declaration of function 'HIDIOCSFEATURE'
samples/hidraw/hid-example.c:111: warning: implicit declaration of function 'HIDIOCGFEATURE'
tmp/ccK96SHd.o: In function `main':
hid-example.c:(.text+0x205): undefined reference to `HIDIOCSFEATURE'
hid-example.c:(.text+0x23e): undefined reference to `HIDIOCGFEATURE'

Caused by commit c54ea4918c2b ("HID: Documentation for hidraw").  I can
only assume that linux/hidraw.h is being included from /usr/include and
not the kernel tree being built?

I have used the hid tree from next-20110406 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the hid tree

[Alan Ott]

On 04/06/2011 09:06 PM, Stephen Rothwell wrote:
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> samples/hidraw/hid-example.c: In function 'main':
> samples/hidraw/hid-example.c:103: warning: implicit declaration of function 'HIDIOCSFEATURE'
> samples/hidraw/hid-example.c:111: warning: implicit declaration of function 'HIDIOCGFEATURE'
> tmp/ccK96SHd.o: In function `main':
> hid-example.c:(.text+0x205): undefined reference to `HIDIOCSFEATURE'
> hid-example.c:(.text+0x23e): undefined reference to `HIDIOCGFEATURE'
>
> Caused by commit c54ea4918c2b ("HID: Documentation for hidraw").  I can
> only assume that linux/hidraw.h is being included from /usr/include and
> not the kernel tree being built?

Hi Stephen,

That sounds like a reasonable explanation. What's the right way to do
this? I suppose I had incorrectly assumed that the include path would be
set by the build system to the kernel tree being built. The other
samples seem to do the same thing (simply #including whatever they
need), and don't seem to do anything special with include paths to make
it use the current tree.

Maybe Randy can shed some light.

Sorry for the bother,

Alan.

Re: linux-next: build failure after merge of the hid tree

[Jiri Kosina]

On Thu, 7 Apr 2011, Stephen Rothwell wrote:

> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> samples/hidraw/hid-example.c: In function 'main':
> samples/hidraw/hid-example.c:103: warning: implicit declaration of function 'HIDIOCSFEATURE'
> samples/hidraw/hid-example.c:111: warning: implicit declaration of function 'HIDIOCGFEATURE'
> tmp/ccK96SHd.o: In function `main':
> hid-example.c:(.text+0x205): undefined reference to `HIDIOCSFEATURE'
> hid-example.c:(.text+0x23e): undefined reference to `HIDIOCGFEATURE'
> 
> Caused by commit c54ea4918c2b ("HID: Documentation for hidraw").  I can
> only assume that linux/hidraw.h is being included from /usr/include and
> not the kernel tree being built?
> 
> I have used the hid tree from next-20110406 for today.

OK, I have introduced the patch below to the branch now. I am not proud of 
it, but I don't see other option currently. Will remove it after some 
time.



From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] HID: hidraw: fix samples miscompilation

On systems where userspace doesn't have new hidraw.h populated to
/usr/include, the hidraw sample won't compile as it's missing the new
ioctl defitions.

Introduce temporary ugly workaround to define the ioctls "manually"
in such cases, just to avoid miscompilation in allmodconfig cases.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 samples/hidraw/hid-example.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/samples/hidraw/hid-example.c b/samples/hidraw/hid-example.c
index 40e3d62..816e2dc 100644
--- a/samples/hidraw/hid-example.c
+++ b/samples/hidraw/hid-example.c
@@ -14,6 +14,17 @@
 #include <linux/input.h>
 #include <linux/hidraw.h>
 
+/*
+ * Ugly hack to work around failing compilation on systems that don't
+ * yet populate new version of hidraw.h to userspace.
+ *
+ * If you need this, please have your distro update the kernel headers.
+ */
+#ifndef HIDIOCSFEATURE
+#define HIDIOCSFEATURE(len)    _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x06, len)
+#define HIDIOCGFEATURE(len)    _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x07, len)
+#endif
+
 /* Unix */
 #include <sys/ioctl.h>
 #include <sys/types.h>
-- 
1.7.3.1