* [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt
@ 2019-10-21 18:32 Chris Wilson
2019-10-21 18:32 ` [PATCH 2/2] drm/i915: Remove pm park/unpark notifications Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2019-10-21 18:32 UTC (permalink / raw)
To: intel-gfx
Currently even though i915_vma_parked() operates on a per-gt struct, it
is called from a global pm notify. This oddity was only because the long
term plan is to decouple the vma cache from the pm notification, but
right now the oddity stands out like a sore thumb!
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c | 1 -
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 +
drivers/gpu/drm/i915/i915_vma.c | 32 +++++++++++++-------------
drivers/gpu/drm/i915/i915_vma.h | 2 +-
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
index 7987b54fb1f5..2aa7e9be088f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
@@ -23,7 +23,6 @@ static int pm_notifier(struct notifier_block *nb,
break;
case INTEL_GT_PARK:
- i915_vma_parked(i915);
break;
}
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index b866d5b1eee0..fde5112b6650 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -71,6 +71,7 @@ static int __gt_park(struct intel_wakeref *wf)
pm_notify(gt, INTEL_GT_PARK);
intel_gt_park_requests(gt);
+ i915_vma_parked(gt);
i915_pmu_gt_parked(i915);
if (INTEL_GEN(i915) >= 6)
gen6_rps_idle(i915);
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index e90c4d0af8fd..d733bcf262f0 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -106,7 +106,7 @@ vma_create(struct drm_i915_gem_object *obj,
struct rb_node *rb, **p;
/* The aliasing_ppgtt should never be used directly! */
- GEM_BUG_ON(vm == &vm->i915->ggtt.alias->vm);
+ GEM_BUG_ON(vm == &vm->gt->ggtt->alias->vm);
vma = i915_vma_alloc();
if (vma == NULL)
@@ -412,7 +412,7 @@ void __iomem *i915_vma_pin_iomap(struct i915_vma *vma)
int err;
/* Access through the GTT requires the device to be awake. */
- assert_rpm_wakelock_held(&vma->vm->i915->runtime_pm);
+ assert_rpm_wakelock_held(vma->vm->gt->uncore->rpm);
if (GEM_WARN_ON(!i915_vma_is_map_and_fenceable(vma))) {
err = -ENODEV;
goto err;
@@ -945,7 +945,7 @@ int i915_vma_pin(struct i915_vma *vma, u64 size, u64 alignment, u64 flags)
void i915_vma_close(struct i915_vma *vma)
{
- struct drm_i915_private *i915 = vma->vm->i915;
+ struct intel_gt *gt = vma->vm->gt;
unsigned long flags;
GEM_BUG_ON(i915_vma_is_closed(vma));
@@ -962,18 +962,18 @@ void i915_vma_close(struct i915_vma *vma)
* causing us to rebind the VMA once more. This ends up being a lot
* of wasted work for the steady state.
*/
- spin_lock_irqsave(&i915->gt.closed_lock, flags);
- list_add(&vma->closed_link, &i915->gt.closed_vma);
- spin_unlock_irqrestore(&i915->gt.closed_lock, flags);
+ spin_lock_irqsave(>->closed_lock, flags);
+ list_add(&vma->closed_link, >->closed_vma);
+ spin_unlock_irqrestore(>->closed_lock, flags);
}
static void __i915_vma_remove_closed(struct i915_vma *vma)
{
- struct drm_i915_private *i915 = vma->vm->i915;
+ struct intel_gt *gt = vma->vm->gt;
- spin_lock_irq(&i915->gt.closed_lock);
+ spin_lock_irq(>->closed_lock);
list_del_init(&vma->closed_link);
- spin_unlock_irq(&i915->gt.closed_lock);
+ spin_unlock_irq(>->closed_lock);
}
void i915_vma_reopen(struct i915_vma *vma)
@@ -1009,12 +1009,12 @@ void i915_vma_destroy(struct i915_vma *vma)
i915_vma_free(vma);
}
-void i915_vma_parked(struct drm_i915_private *i915)
+void i915_vma_parked(struct intel_gt *gt)
{
struct i915_vma *vma, *next;
- spin_lock_irq(&i915->gt.closed_lock);
- list_for_each_entry_safe(vma, next, &i915->gt.closed_vma, closed_link) {
+ spin_lock_irq(>->closed_lock);
+ list_for_each_entry_safe(vma, next, >->closed_vma, closed_link) {
struct drm_i915_gem_object *obj = vma->obj;
struct i915_address_space *vm = vma->vm;
@@ -1028,7 +1028,7 @@ void i915_vma_parked(struct drm_i915_private *i915)
obj = NULL;
}
- spin_unlock_irq(&i915->gt.closed_lock);
+ spin_unlock_irq(>->closed_lock);
if (obj) {
i915_vma_destroy(vma);
@@ -1038,11 +1038,11 @@ void i915_vma_parked(struct drm_i915_private *i915)
i915_vm_close(vm);
/* Restart after dropping lock */
- spin_lock_irq(&i915->gt.closed_lock);
- next = list_first_entry(&i915->gt.closed_vma,
+ spin_lock_irq(>->closed_lock);
+ next = list_first_entry(>->closed_vma,
typeof(*next), closed_link);
}
- spin_unlock_irq(&i915->gt.closed_lock);
+ spin_unlock_irq(>->closed_lock);
}
static void __i915_vma_iounmap(struct i915_vma *vma)
diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
index 858908e3d1cc..465932813bc5 100644
--- a/drivers/gpu/drm/i915/i915_vma.h
+++ b/drivers/gpu/drm/i915/i915_vma.h
@@ -462,7 +462,7 @@ i915_vma_unpin_fence(struct i915_vma *vma)
__i915_vma_unpin_fence(vma);
}
-void i915_vma_parked(struct drm_i915_private *i915);
+void i915_vma_parked(struct intel_gt *gt);
#define for_each_until(cond) if (cond) break; else
--
2.24.0.rc0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/i915: Remove pm park/unpark notifications
2019-10-21 18:32 [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Chris Wilson
@ 2019-10-21 18:32 ` Chris Wilson
2019-10-21 19:10 ` Tvrtko Ursulin
2019-10-21 19:09 ` [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Tvrtko Ursulin
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-10-21 18:32 UTC (permalink / raw)
To: intel-gfx
With the last user, i915_vma_parked(), retired, there are no more users
of the per-gt pm notifications and we can remove the unused
infrastructure.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c | 25 ------------------------
drivers/gpu/drm/i915/gem/i915_gem_pm.h | 2 --
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 10 ----------
drivers/gpu/drm/i915/gt/intel_gt_pm.h | 5 -----
drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 --
drivers/gpu/drm/i915/i915_gem.c | 1 -
6 files changed, 45 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
index 2aa7e9be088f..ee3279c76566 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
@@ -11,24 +11,6 @@
#include "i915_drv.h"
-static int pm_notifier(struct notifier_block *nb,
- unsigned long action,
- void *data)
-{
- struct drm_i915_private *i915 =
- container_of(nb, typeof(*i915), gem.pm_notifier);
-
- switch (action) {
- case INTEL_GT_UNPARK:
- break;
-
- case INTEL_GT_PARK:
- break;
- }
-
- return NOTIFY_OK;
-}
-
static bool switch_to_kernel_context_sync(struct intel_gt *gt)
{
bool result = !intel_gt_is_wedged(gt);
@@ -206,10 +188,3 @@ void i915_gem_resume(struct drm_i915_private *i915)
}
goto out_unlock;
}
-
-void i915_gem_init__pm(struct drm_i915_private *i915)
-{
- i915->gem.pm_notifier.notifier_call = pm_notifier;
- blocking_notifier_chain_register(&i915->gt.pm_notifications,
- &i915->gem.pm_notifier);
-}
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.h b/drivers/gpu/drm/i915/gem/i915_gem_pm.h
index 6f7d5d11ac3b..a017572778d5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pm.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.h
@@ -12,8 +12,6 @@
struct drm_i915_private;
struct work_struct;
-void i915_gem_init__pm(struct drm_i915_private *i915);
-
bool i915_gem_load_power_context(struct drm_i915_private *i915);
void i915_gem_resume(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index fde5112b6650..427aded512f2 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -16,11 +16,6 @@
#include "intel_rc6.h"
#include "intel_wakeref.h"
-static void pm_notify(struct intel_gt *gt, int state)
-{
- blocking_notifier_call_chain(>->pm_notifications, state, gt->i915);
-}
-
static int __gt_unpark(struct intel_wakeref *wf)
{
struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
@@ -55,8 +50,6 @@ static int __gt_unpark(struct intel_wakeref *wf)
intel_gt_queue_hangcheck(gt);
intel_gt_unpark_requests(gt);
- pm_notify(gt, INTEL_GT_UNPARK);
-
return 0;
}
@@ -68,7 +61,6 @@ static int __gt_park(struct intel_wakeref *wf)
GEM_TRACE("\n");
- pm_notify(gt, INTEL_GT_PARK);
intel_gt_park_requests(gt);
i915_vma_parked(gt);
@@ -96,8 +88,6 @@ static const struct intel_wakeref_ops wf_ops = {
void intel_gt_pm_init_early(struct intel_gt *gt)
{
intel_wakeref_init(>->wakeref, gt->uncore->rpm, &wf_ops);
-
- BLOCKING_INIT_NOTIFIER_HEAD(>->pm_notifications);
}
void intel_gt_pm_init(struct intel_gt *gt)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
index 997770d3a968..0ed87da4bb68 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
@@ -12,11 +12,6 @@
#include "intel_gt_types.h"
#include "intel_wakeref.h"
-enum {
- INTEL_GT_UNPARK,
- INTEL_GT_PARK,
-};
-
static inline bool intel_gt_pm_is_awake(const struct intel_gt *gt)
{
return intel_wakeref_is_active(>->wakeref);
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
index ae4aaf75ac78..980973e66e7f 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
@@ -83,8 +83,6 @@ struct intel_gt {
struct intel_llc llc;
struct intel_rc6 rc6;
- struct blocking_notifier_head pm_notifications;
-
ktime_t last_init_time;
struct i915_vma *scratch;
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a2ba123f7b31..39cb0e246a88 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1435,7 +1435,6 @@ static void i915_gem_init__mm(struct drm_i915_private *i915)
void i915_gem_init_early(struct drm_i915_private *dev_priv)
{
i915_gem_init__mm(dev_priv);
- i915_gem_init__pm(dev_priv);
spin_lock_init(&dev_priv->fb_tracking.lock);
}
--
2.24.0.rc0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt
2019-10-21 18:32 [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Chris Wilson
2019-10-21 18:32 ` [PATCH 2/2] drm/i915: Remove pm park/unpark notifications Chris Wilson
@ 2019-10-21 19:09 ` Tvrtko Ursulin
2019-10-21 20:06 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-10-22 2:21 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2019-10-21 19:09 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 21/10/2019 19:32, Chris Wilson wrote:
> Currently even though i915_vma_parked() operates on a per-gt struct, it
> is called from a global pm notify. This oddity was only because the long
> term plan is to decouple the vma cache from the pm notification, but
> right now the oddity stands out like a sore thumb!
>
> Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_pm.c | 1 -
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 +
> drivers/gpu/drm/i915/i915_vma.c | 32 +++++++++++++-------------
> drivers/gpu/drm/i915/i915_vma.h | 2 +-
> 4 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> index 7987b54fb1f5..2aa7e9be088f 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> @@ -23,7 +23,6 @@ static int pm_notifier(struct notifier_block *nb,
> break;
>
> case INTEL_GT_PARK:
> - i915_vma_parked(i915);
> break;
> }
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index b866d5b1eee0..fde5112b6650 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -71,6 +71,7 @@ static int __gt_park(struct intel_wakeref *wf)
> pm_notify(gt, INTEL_GT_PARK);
> intel_gt_park_requests(gt);
>
> + i915_vma_parked(gt);
> i915_pmu_gt_parked(i915);
> if (INTEL_GEN(i915) >= 6)
> gen6_rps_idle(i915);
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index e90c4d0af8fd..d733bcf262f0 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -106,7 +106,7 @@ vma_create(struct drm_i915_gem_object *obj,
> struct rb_node *rb, **p;
>
> /* The aliasing_ppgtt should never be used directly! */
> - GEM_BUG_ON(vm == &vm->i915->ggtt.alias->vm);
> + GEM_BUG_ON(vm == &vm->gt->ggtt->alias->vm);
>
> vma = i915_vma_alloc();
> if (vma == NULL)
> @@ -412,7 +412,7 @@ void __iomem *i915_vma_pin_iomap(struct i915_vma *vma)
> int err;
>
> /* Access through the GTT requires the device to be awake. */
> - assert_rpm_wakelock_held(&vma->vm->i915->runtime_pm);
> + assert_rpm_wakelock_held(vma->vm->gt->uncore->rpm);
> if (GEM_WARN_ON(!i915_vma_is_map_and_fenceable(vma))) {
> err = -ENODEV;
> goto err;
> @@ -945,7 +945,7 @@ int i915_vma_pin(struct i915_vma *vma, u64 size, u64 alignment, u64 flags)
>
> void i915_vma_close(struct i915_vma *vma)
> {
> - struct drm_i915_private *i915 = vma->vm->i915;
> + struct intel_gt *gt = vma->vm->gt;
> unsigned long flags;
>
> GEM_BUG_ON(i915_vma_is_closed(vma));
> @@ -962,18 +962,18 @@ void i915_vma_close(struct i915_vma *vma)
> * causing us to rebind the VMA once more. This ends up being a lot
> * of wasted work for the steady state.
> */
> - spin_lock_irqsave(&i915->gt.closed_lock, flags);
> - list_add(&vma->closed_link, &i915->gt.closed_vma);
> - spin_unlock_irqrestore(&i915->gt.closed_lock, flags);
> + spin_lock_irqsave(>->closed_lock, flags);
> + list_add(&vma->closed_link, >->closed_vma);
> + spin_unlock_irqrestore(>->closed_lock, flags);
> }
>
> static void __i915_vma_remove_closed(struct i915_vma *vma)
> {
> - struct drm_i915_private *i915 = vma->vm->i915;
> + struct intel_gt *gt = vma->vm->gt;
>
> - spin_lock_irq(&i915->gt.closed_lock);
> + spin_lock_irq(>->closed_lock);
> list_del_init(&vma->closed_link);
> - spin_unlock_irq(&i915->gt.closed_lock);
> + spin_unlock_irq(>->closed_lock);
> }
>
> void i915_vma_reopen(struct i915_vma *vma)
> @@ -1009,12 +1009,12 @@ void i915_vma_destroy(struct i915_vma *vma)
> i915_vma_free(vma);
> }
>
> -void i915_vma_parked(struct drm_i915_private *i915)
> +void i915_vma_parked(struct intel_gt *gt)
> {
> struct i915_vma *vma, *next;
>
> - spin_lock_irq(&i915->gt.closed_lock);
> - list_for_each_entry_safe(vma, next, &i915->gt.closed_vma, closed_link) {
> + spin_lock_irq(>->closed_lock);
> + list_for_each_entry_safe(vma, next, >->closed_vma, closed_link) {
> struct drm_i915_gem_object *obj = vma->obj;
> struct i915_address_space *vm = vma->vm;
>
> @@ -1028,7 +1028,7 @@ void i915_vma_parked(struct drm_i915_private *i915)
> obj = NULL;
> }
>
> - spin_unlock_irq(&i915->gt.closed_lock);
> + spin_unlock_irq(>->closed_lock);
>
> if (obj) {
> i915_vma_destroy(vma);
> @@ -1038,11 +1038,11 @@ void i915_vma_parked(struct drm_i915_private *i915)
> i915_vm_close(vm);
>
> /* Restart after dropping lock */
> - spin_lock_irq(&i915->gt.closed_lock);
> - next = list_first_entry(&i915->gt.closed_vma,
> + spin_lock_irq(>->closed_lock);
> + next = list_first_entry(>->closed_vma,
> typeof(*next), closed_link);
> }
> - spin_unlock_irq(&i915->gt.closed_lock);
> + spin_unlock_irq(>->closed_lock);
> }
>
> static void __i915_vma_iounmap(struct i915_vma *vma)
> diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
> index 858908e3d1cc..465932813bc5 100644
> --- a/drivers/gpu/drm/i915/i915_vma.h
> +++ b/drivers/gpu/drm/i915/i915_vma.h
> @@ -462,7 +462,7 @@ i915_vma_unpin_fence(struct i915_vma *vma)
> __i915_vma_unpin_fence(vma);
> }
>
> -void i915_vma_parked(struct drm_i915_private *i915);
> +void i915_vma_parked(struct intel_gt *gt);
>
> #define for_each_until(cond) if (cond) break; else
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915: Remove pm park/unpark notifications
2019-10-21 18:32 ` [PATCH 2/2] drm/i915: Remove pm park/unpark notifications Chris Wilson
@ 2019-10-21 19:10 ` Tvrtko Ursulin
0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2019-10-21 19:10 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 21/10/2019 19:32, Chris Wilson wrote:
> With the last user, i915_vma_parked(), retired, there are no more users
> of the per-gt pm notifications and we can remove the unused
> infrastructure.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_pm.c | 25 ------------------------
> drivers/gpu/drm/i915/gem/i915_gem_pm.h | 2 --
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 10 ----------
> drivers/gpu/drm/i915/gt/intel_gt_pm.h | 5 -----
> drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 --
> drivers/gpu/drm/i915/i915_gem.c | 1 -
> 6 files changed, 45 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> index 2aa7e9be088f..ee3279c76566 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
> @@ -11,24 +11,6 @@
>
> #include "i915_drv.h"
>
> -static int pm_notifier(struct notifier_block *nb,
> - unsigned long action,
> - void *data)
> -{
> - struct drm_i915_private *i915 =
> - container_of(nb, typeof(*i915), gem.pm_notifier);
> -
> - switch (action) {
> - case INTEL_GT_UNPARK:
> - break;
> -
> - case INTEL_GT_PARK:
> - break;
> - }
> -
> - return NOTIFY_OK;
> -}
> -
> static bool switch_to_kernel_context_sync(struct intel_gt *gt)
> {
> bool result = !intel_gt_is_wedged(gt);
> @@ -206,10 +188,3 @@ void i915_gem_resume(struct drm_i915_private *i915)
> }
> goto out_unlock;
> }
> -
> -void i915_gem_init__pm(struct drm_i915_private *i915)
> -{
> - i915->gem.pm_notifier.notifier_call = pm_notifier;
> - blocking_notifier_chain_register(&i915->gt.pm_notifications,
> - &i915->gem.pm_notifier);
> -}
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.h b/drivers/gpu/drm/i915/gem/i915_gem_pm.h
> index 6f7d5d11ac3b..a017572778d5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pm.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.h
> @@ -12,8 +12,6 @@
> struct drm_i915_private;
> struct work_struct;
>
> -void i915_gem_init__pm(struct drm_i915_private *i915);
> -
> bool i915_gem_load_power_context(struct drm_i915_private *i915);
> void i915_gem_resume(struct drm_i915_private *i915);
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index fde5112b6650..427aded512f2 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -16,11 +16,6 @@
> #include "intel_rc6.h"
> #include "intel_wakeref.h"
>
> -static void pm_notify(struct intel_gt *gt, int state)
> -{
> - blocking_notifier_call_chain(>->pm_notifications, state, gt->i915);
> -}
> -
> static int __gt_unpark(struct intel_wakeref *wf)
> {
> struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
> @@ -55,8 +50,6 @@ static int __gt_unpark(struct intel_wakeref *wf)
> intel_gt_queue_hangcheck(gt);
> intel_gt_unpark_requests(gt);
>
> - pm_notify(gt, INTEL_GT_UNPARK);
> -
> return 0;
> }
>
> @@ -68,7 +61,6 @@ static int __gt_park(struct intel_wakeref *wf)
>
> GEM_TRACE("\n");
>
> - pm_notify(gt, INTEL_GT_PARK);
> intel_gt_park_requests(gt);
>
> i915_vma_parked(gt);
> @@ -96,8 +88,6 @@ static const struct intel_wakeref_ops wf_ops = {
> void intel_gt_pm_init_early(struct intel_gt *gt)
> {
> intel_wakeref_init(>->wakeref, gt->uncore->rpm, &wf_ops);
> -
> - BLOCKING_INIT_NOTIFIER_HEAD(>->pm_notifications);
> }
>
> void intel_gt_pm_init(struct intel_gt *gt)
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.h b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> index 997770d3a968..0ed87da4bb68 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> @@ -12,11 +12,6 @@
> #include "intel_gt_types.h"
> #include "intel_wakeref.h"
>
> -enum {
> - INTEL_GT_UNPARK,
> - INTEL_GT_PARK,
> -};
> -
> static inline bool intel_gt_pm_is_awake(const struct intel_gt *gt)
> {
> return intel_wakeref_is_active(>->wakeref);
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> index ae4aaf75ac78..980973e66e7f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> @@ -83,8 +83,6 @@ struct intel_gt {
> struct intel_llc llc;
> struct intel_rc6 rc6;
>
> - struct blocking_notifier_head pm_notifications;
> -
> ktime_t last_init_time;
>
> struct i915_vma *scratch;
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index a2ba123f7b31..39cb0e246a88 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1435,7 +1435,6 @@ static void i915_gem_init__mm(struct drm_i915_private *i915)
> void i915_gem_init_early(struct drm_i915_private *dev_priv)
> {
> i915_gem_init__mm(dev_priv);
> - i915_gem_init__pm(dev_priv);
>
> spin_lock_init(&dev_priv->fb_tracking.lock);
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Lift i915_vma_parked() onto the gt
2019-10-21 18:32 [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Chris Wilson
2019-10-21 18:32 ` [PATCH 2/2] drm/i915: Remove pm park/unpark notifications Chris Wilson
2019-10-21 19:09 ` [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Tvrtko Ursulin
@ 2019-10-21 20:06 ` Patchwork
2019-10-22 2:21 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-21 20:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Lift i915_vma_parked() onto the gt
URL : https://patchwork.freedesktop.org/series/68329/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7142 -> Patchwork_14907
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/index.html
Known issues
------------
Here are the changes found in Patchwork_14907 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-read:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-icl-u3/igt@gem_mmap_gtt@basic-read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-icl-u3/igt@gem_mmap_gtt@basic-read.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([fdo#108511])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
#### Possible fixes ####
* igt@gem_basic@create-close:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-icl-u3/igt@gem_basic@create-close.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-icl-u3/igt@gem_basic@create-close.html
* igt@gem_ctx_create@basic-files:
- fi-bdw-gvtdvm: [DMESG-WARN][7] ([fdo#112064]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-bdw-gvtdvm/igt@gem_ctx_create@basic-files.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-bdw-gvtdvm/igt@gem_ctx_create@basic-files.html
- {fi-icl-guc}: [INCOMPLETE][9] ([fdo#107713] / [fdo#109100]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-icl-guc/igt@gem_ctx_create@basic-files.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-icl-guc/igt@gem_ctx_create@basic-files.html
* igt@gem_ctx_switch@rcs0:
- fi-cml-u: [INCOMPLETE][11] ([fdo#110566]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-cml-u/igt@gem_ctx_switch@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-cml-u/igt@gem_ctx_switch@rcs0.html
* igt@gem_exec_gttfill@basic:
- {fi-icl-dsi}: [DMESG-WARN][13] ([fdo#106107]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-icl-dsi/igt@gem_exec_gttfill@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-icl-dsi/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live_coherency:
- fi-cfl-8109u: [TIMEOUT][15] -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-cfl-8109u/igt@i915_selftest@live_coherency.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-cfl-8109u/igt@i915_selftest@live_coherency.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][17] ([fdo#111407]) -> [FAIL][18] ([fdo#111045] / [fdo#111096])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112064]: https://bugs.freedesktop.org/show_bug.cgi?id=112064
Participating hosts (52 -> 46)
------------------------------
Additional (1): fi-icl-u2
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7142 -> Patchwork_14907
CI-20190529: 20190529
CI_DRM_7142: 639c81d1ccbabfd8421709509bf5052213198307 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5235: da9abbab69be80dd00812a4607a4ea2dffcc4544 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14907: 4bdb0106a9dfb8e9abf147c649a0e5613b50a580 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4bdb0106a9df drm/i915: Remove pm park/unpark notifications
19318e772dcb drm/i915: Lift i915_vma_parked() onto the gt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Lift i915_vma_parked() onto the gt
2019-10-21 18:32 [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Chris Wilson
` (2 preceding siblings ...)
2019-10-21 20:06 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
@ 2019-10-22 2:21 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-22 2:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Lift i915_vma_parked() onto the gt
URL : https://patchwork.freedesktop.org/series/68329/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7142_full -> Patchwork_14907_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14907_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14907_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14907_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock_vma:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-skl7/igt@i915_selftest@mock_vma.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-skl8/igt@i915_selftest@mock_vma.html
* igt@perf@short-reads:
- shard-hsw: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-hsw7/igt@perf@short-reads.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-hsw6/igt@perf@short-reads.html
* igt@runner@aborted:
- shard-kbl: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl1/igt@runner@aborted.html
- shard-apl: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl7/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@mock_vma:
- {shard-tglb}: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-tglb6/igt@i915_selftest@mock_vma.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb2/igt@i915_selftest@mock_vma.html
* igt@runner@aborted:
- {shard-tglb}: NOTRUN -> [FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb2/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_14907_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#111325]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb7/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-snb: [PASS][12] -> [DMESG-WARN][13] ([fdo#111870])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_workarounds@suspend-resume:
- shard-skl: [PASS][16] -> [INCOMPLETE][17] ([fdo#104108])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-skl4/igt@gem_workarounds@suspend-resume.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-skl10/igt@gem_workarounds@suspend-resume.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: [PASS][20] -> [SKIP][21] ([fdo#109271])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@i915_selftest@mock_vma:
- shard-hsw: [PASS][22] -> [INCOMPLETE][23] ([fdo#103540]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-hsw5/igt@i915_selftest@mock_vma.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-hsw5/igt@i915_selftest@mock_vma.html
- shard-kbl: [PASS][24] -> [INCOMPLETE][25] ([fdo#103665])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-kbl7/igt@i915_selftest@mock_vma.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl1/igt@i915_selftest@mock_vma.html
- shard-apl: [PASS][26] -> [INCOMPLETE][27] ([fdo#103927]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl7/igt@i915_selftest@mock_vma.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl7/igt@i915_selftest@mock_vma.html
- shard-glk: [PASS][28] -> [INCOMPLETE][29] ([fdo#103359] / [k.org#198133])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-glk6/igt@i915_selftest@mock_vma.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-glk1/igt@i915_selftest@mock_vma.html
- shard-iclb: [PASS][30] -> [INCOMPLETE][31] ([fdo#107713])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb7/igt@i915_selftest@mock_vma.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@i915_selftest@mock_vma.html
- shard-snb: [PASS][32] -> [INCOMPLETE][33] ([fdo#105411])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-snb5/igt@i915_selftest@mock_vma.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-snb4/igt@i915_selftest@mock_vma.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [PASS][34] -> [DMESG-WARN][35] ([fdo#106107]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-skl3/igt@kms_color@pipe-b-ctm-0-5.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-skl5/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([fdo#110741])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [PASS][38] -> [FAIL][39] ([fdo#103167]) +4 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][40] -> [FAIL][41] ([fdo#108145])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][44] -> [FAIL][45] ([fdo#99912])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl7/igt@kms_setmode@basic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl8/igt@kms_setmode@basic.html
- shard-hsw: [PASS][46] -> [FAIL][47] ([fdo#99912])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-hsw6/igt@kms_setmode@basic.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-hsw4/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#112080]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb1/igt@perf_pmu@busy-vcs1.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb6/igt@perf_pmu@busy-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109276]) +9 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [SKIP][52] ([fdo#109276]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-snb: [FAIL][54] ([fdo#111925]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-snb4/igt@gem_eio@in-flight-contexts-immediate.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-snb6/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][56] ([fdo#111325]) -> [PASS][57] +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_ppgtt@blt-vs-render-ctxn:
- {shard-tglb}: [INCOMPLETE][58] ([fdo#111886]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-tglb6/igt@gem_ppgtt@blt-vs-render-ctxn.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb1/igt@gem_ppgtt@blt-vs-render-ctxn.html
* igt@gem_request_retire@retire-vma-not-inactive:
- shard-iclb: [INCOMPLETE][60] ([fdo#107713]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb7/igt@gem_request_retire@retire-vma-not-inactive.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb7/igt@gem_request_retire@retire-vma-not-inactive.html
* igt@gem_tiled_blits@interruptible:
- shard-glk: [DMESG-WARN][62] -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-glk4/igt@gem_tiled_blits@interruptible.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-glk7/igt@gem_tiled_blits@interruptible.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][64] ([fdo#111870]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][68] ([fdo#110548]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_flip@dpms-vs-vblank-race:
- shard-glk: [FAIL][70] ([fdo#111609]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-glk4/igt@kms_flip@dpms-vs-vblank-race.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-glk5/igt@kms_flip@dpms-vs-vblank-race.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- {shard-tglb}: [INCOMPLETE][72] ([fdo#111832] / [fdo#111850]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-tglb1/igt@kms_flip@flip-vs-suspend-interruptible.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-apl: [FAIL][74] ([fdo#111609]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl7/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl6/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: [DMESG-WARN][76] ([fdo#103313] / [fdo#103558]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][78] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][80] ([fdo#103167]) -> [PASS][81] +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- {shard-tglb}: [FAIL][82] ([fdo#103167]) -> [PASS][83] +10 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][84] ([fdo#108566]) -> [PASS][85] +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- shard-kbl: [DMESG-WARN][86] ([fdo#103313] / [fdo#103558] / [fdo#105602]) -> [PASS][87] +9 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-kbl4/igt@kms_plane_cursor@pipe-a-primary-size-256.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl1/igt@kms_plane_cursor@pipe-a-primary-size-256.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][88] ([fdo#103166]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_vblank@pipe-b-wait-idle-hang:
- shard-apl: [INCOMPLETE][90] ([fdo#103927]) -> [PASS][91] +4 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl7/igt@kms_vblank@pipe-b-wait-idle-hang.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl6/igt@kms_vblank@pipe-b-wait-idle-hang.html
* igt@perf_pmu@busy-no-semaphores-vecs0:
- shard-apl: [DMESG-WARN][92] ([fdo#111626]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-apl7/igt@perf_pmu@busy-no-semaphores-vecs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-apl8/igt@perf_pmu@busy-no-semaphores-vecs0.html
* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [SKIP][94] ([fdo#112080]) -> [PASS][95] +4 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb5/igt@perf_pmu@busy-start-vcs1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@perf_pmu@busy-start-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][96] ([fdo#109276] / [fdo#112080]) -> [FAIL][97] ([fdo#111329])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][98] ([fdo#109276]) -> [FAIL][99] ([fdo#111330])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb5/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][100] ([fdo#111330]) -> [SKIP][101] ([fdo#109276])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-iclb5/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_frontbuffer_tracking@psr-2p-pri-indfb-multidraw:
- shard-kbl: [SKIP][102] ([fdo#105602] / [fdo#109271]) -> [SKIP][103] ([fdo#109271]) +8 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7142/shard-kbl4/igt@kms_frontbuffer_tracking@psr-2p-pri-indfb-multidraw.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/shard-kbl1/igt@kms_frontbuffer_tracking@psr-2p-pri-indfb-multidraw.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14907/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-22 2:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 18:32 [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Chris Wilson
2019-10-21 18:32 ` [PATCH 2/2] drm/i915: Remove pm park/unpark notifications Chris Wilson
2019-10-21 19:10 ` Tvrtko Ursulin
2019-10-21 19:09 ` [PATCH 1/2] drm/i915: Lift i915_vma_parked() onto the gt Tvrtko Ursulin
2019-10-21 20:06 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-10-22 2:21 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.