* [PATCH] platform/surface: clean up a variable in surface_dtx_read()
@ 2021-03-26 12:28 Dan Carpenter
2021-03-26 14:06 ` Maximilian Luz
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2021-03-26 12:28 UTC (permalink / raw)
To: Maximilian Luz
Cc: Hans de Goede, Mark Gross, platform-driver-x86, linux-kernel,
kernel-janitors
The "&client->ddev->lock" and "&ddev->lock" are the same thing. Let's
use "&ddev->lock" consistently.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/platform/surface/surface_dtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
index 1fedacf74050..63ce587e79e3 100644
--- a/drivers/platform/surface/surface_dtx.c
+++ b/drivers/platform/surface/surface_dtx.c
@@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
if (status < 0)
return status;
- if (down_read_killable(&client->ddev->lock))
+ if (down_read_killable(&ddev->lock))
return -ERESTARTSYS;
/* Need to check that we're not shut down again. */
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()
2021-03-26 12:28 [PATCH] platform/surface: clean up a variable in surface_dtx_read() Dan Carpenter
@ 2021-03-26 14:06 ` Maximilian Luz
2021-04-07 11:25 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Maximilian Luz @ 2021-03-26 14:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hans de Goede, Mark Gross, platform-driver-x86, linux-kernel,
kernel-janitors
On 3/26/21 1:28 PM, Dan Carpenter wrote:
> The "&client->ddev->lock" and "&ddev->lock" are the same thing. Let's
> use "&ddev->lock" consistently.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks!
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/platform/surface/surface_dtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
> index 1fedacf74050..63ce587e79e3 100644
> --- a/drivers/platform/surface/surface_dtx.c
> +++ b/drivers/platform/surface/surface_dtx.c
> @@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
> if (status < 0)
> return status;
>
> - if (down_read_killable(&client->ddev->lock))
> + if (down_read_killable(&ddev->lock))
> return -ERESTARTSYS;
>
> /* Need to check that we're not shut down again. */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()
2021-03-26 14:06 ` Maximilian Luz
@ 2021-04-07 11:25 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-04-07 11:25 UTC (permalink / raw)
To: Maximilian Luz, Dan Carpenter
Cc: Mark Gross, platform-driver-x86, linux-kernel, kernel-janitors
Hi,
On 3/26/21 3:06 PM, Maximilian Luz wrote:
> On 3/26/21 1:28 PM, Dan Carpenter wrote:
>> The "&client->ddev->lock" and "&ddev->lock" are the same thing. Let's
>> use "&ddev->lock" consistently.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Good catch, thanks!
>
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Thank you for the review, I've merged this now:
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
>> ---
>> drivers/platform/surface/surface_dtx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
>> index 1fedacf74050..63ce587e79e3 100644
>> --- a/drivers/platform/surface/surface_dtx.c
>> +++ b/drivers/platform/surface/surface_dtx.c
>> @@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
>> if (status < 0)
>> return status;
>> - if (down_read_killable(&client->ddev->lock))
>> + if (down_read_killable(&ddev->lock))
>> return -ERESTARTSYS;
>> /* Need to check that we're not shut down again. */
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-07 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 12:28 [PATCH] platform/surface: clean up a variable in surface_dtx_read() Dan Carpenter
2021-03-26 14:06 ` Maximilian Luz
2021-04-07 11:25 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.