All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/3] board: Add support for LePotato
@ 2020-07-07  7:53 Mylène Josserand
  2020-07-07  7:53 ` [Buildroot] [PATCH 1/3] DEVELOPERS: Update Mylene's email Mylène Josserand
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Mylène Josserand @ 2020-07-07  7:53 UTC (permalink / raw)
  To: buildroot

Hello everyone,

Here is my first version of this series that adds the support of the
board LePotato SBC from LibreComputer [1].

This board uses FIP utilities [2][3] from AMLogic to sign u-boot.
The patch 02 is adding these FIP utilities as a host package. It is
available for different boards such as khadas-vim, some odroids, etc.
This package will copy the corresponding utilities, only for LePotato for
the moment, into the HOST_DIR/usr/bin. Currently, LePotato's ones are the
default ones. This should be updating once more boards are added.

The patch 03 is adding the support of this board from LibreComputer:
   - one defconfig including a u-boot, kernel and minimal rootfs.
   The configuration is also enabling the FIP package for LePotato.
   - one post-build script that is using the FIP utilities to sign
   u-boot binary.
   - one post-image script to generate a sd-card image and flashing the
   signed u-boot on it.
   - a readme file to explain how to configure, compile and flash image
   for this board.
   - a boot.scr file including booti commands to run.

Let me know if you have any comments on this series.

Best regards,

Myl?ne

[1]: https://libre.computer/products/boards/aml-s905x-cc/
[2]: https://github.com/LibreELEC/amlogic-boot-fip
[3]: https://github.com/BayLibre/u-boot

Myl?ne Josserand (3):
  DEVELOPERS: Update Mylene's email
  package: Add new fip package
  configs/lepotato: Add new defconfig

 .gitlab-ci.yml                             |  1 +
 DEVELOPERS                                 |  4 +-
 board/librecomputer/lepotato/boot.cmd      |  6 +++
 board/librecomputer/lepotato/genimage.cfg  | 28 ++++++++++
 board/librecomputer/lepotato/post-build.sh | 61 ++++++++++++++++++++++
 board/librecomputer/lepotato/post-image.sh | 17 ++++++
 board/librecomputer/lepotato/readme.txt    | 35 +++++++++++++
 configs/lepotato_defconfig                 | 29 ++++++++++
 package/Config.in.host                     |  1 +
 package/fip/Config.in.host                 | 17 ++++++
 package/fip/fip.hash                       |  2 +
 package/fip/fip.mk                         | 30 +++++++++++
 12 files changed, 230 insertions(+), 1 deletion(-)
 create mode 100644 board/librecomputer/lepotato/boot.cmd
 create mode 100644 board/librecomputer/lepotato/genimage.cfg
 create mode 100755 board/librecomputer/lepotato/post-build.sh
 create mode 100755 board/librecomputer/lepotato/post-image.sh
 create mode 100644 board/librecomputer/lepotato/readme.txt
 create mode 100644 configs/lepotato_defconfig
 create mode 100644 package/fip/Config.in.host
 create mode 100644 package/fip/fip.hash
 create mode 100644 package/fip/fip.mk

-- 
2.27.0

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/3] DEVELOPERS: Update Mylene's email
  2020-07-07  7:53 [Buildroot] [PATCH 0/3] board: Add support for LePotato Mylène Josserand
@ 2020-07-07  7:53 ` Mylène Josserand
  2020-07-07  7:53 ` [Buildroot] [PATCH 2/3] package: Add new fip package Mylène Josserand
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Mylène Josserand @ 2020-07-07  7:53 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
---
 DEVELOPERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DEVELOPERS b/DEVELOPERS
index f697c96ce4..f36ba64114 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1843,7 +1843,7 @@ N:	Murat Demirten <mdemirten@yh.com.tr>
 F:	package/jpeg-turbo/
 F:	package/libgeotiff/
 
-N:	Myl?ne Josserand <mylene.josserand@bootlin.com>
+N:	Myl?ne Josserand <mylene.josserand@collabora.com>
 F:	package/rtl8723bu/
 
 N:	Nathaniel Roach <nroach44@gmail.com>
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package: Add new fip package
  2020-07-07  7:53 [Buildroot] [PATCH 0/3] board: Add support for LePotato Mylène Josserand
  2020-07-07  7:53 ` [Buildroot] [PATCH 1/3] DEVELOPERS: Update Mylene's email Mylène Josserand
@ 2020-07-07  7:53 ` Mylène Josserand
  2020-07-07 12:37   ` Romain Naour
  2020-07-07  7:53 ` [Buildroot] [PATCH 3/3] configs/lepotato: Add new defconfig Mylène Josserand
  2020-07-07 19:51 ` [Buildroot] [PATCH 0/3] board: Add support for LePotato Yann E. MORIN
  3 siblings, 1 reply; 10+ messages in thread
From: Mylène Josserand @ 2020-07-07  7:53 UTC (permalink / raw)
  To: buildroot

Firmware Image Pacakge (FIP) is used to sign Amlogic u-boot binaries.
It is a host package as it is only binaries to call on u-boot image
to sign it. One tool is a python script that needs to be called with
'python' command, otherwise, it is not working. That is why there is
a dependency on host-python.

For the moment, only LePotato's board is supported. Other ones
may be added later, if needed.

Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
---
 package/Config.in.host     |  1 +
 package/fip/Config.in.host | 17 +++++++++++++++++
 package/fip/fip.hash       |  2 ++
 package/fip/fip.mk         | 30 ++++++++++++++++++++++++++++++
 4 files changed, 50 insertions(+)
 create mode 100644 package/fip/Config.in.host
 create mode 100644 package/fip/fip.hash
 create mode 100644 package/fip/fip.mk

diff --git a/package/Config.in.host b/package/Config.in.host
index f1246c708f..21d2bc4072 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -24,6 +24,7 @@ menu "Host utilities"
 	source "package/f2fs-tools/Config.in.host"
 	source "package/faketime/Config.in.host"
 	source "package/fatcat/Config.in.host"
+	source "package/fip/Config.in.host"
 	source "package/fwup/Config.in.host"
 	source "package/genext2fs/Config.in.host"
 	source "package/genimage/Config.in.host"
diff --git a/package/fip/Config.in.host b/package/fip/Config.in.host
new file mode 100644
index 0000000000..914020a1b3
--- /dev/null
+++ b/package/fip/Config.in.host
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_HOST_FIP
+	bool "host Amlogic FIP binaries"
+	help
+	  This package contains the FIP utilities, that is
+	  used to create U-Boot final binary.
+
+if BR2_PACKAGE_HOST_FIP
+
+config BR2_PACKAGE_HOST_FIP_LEPOTATO
+	bool "FIP lepotato version"
+	default y
+	select BR2_PACKAGE_HOST_PYTHON3
+	help
+	  This option will download the latest libretech-cc's version
+	  of the fip utility for the board "lepotato".
+
+endif
diff --git a/package/fip/fip.hash b/package/fip/fip.hash
new file mode 100644
index 0000000000..547fff8534
--- /dev/null
+++ b/package/fip/fip.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 7a59dc36c89b02c38f9b630b4abb7056869ff76ca6152b6c3ce797ddd1349a64  fip-bfdad4cc520b254813536ebfba8b9749386cd57c.tar.gz
diff --git a/package/fip/fip.mk b/package/fip/fip.mk
new file mode 100644
index 0000000000..d1fb43ad13
--- /dev/null
+++ b/package/fip/fip.mk
@@ -0,0 +1,30 @@
+################################################################################
+#
+# fip
+#
+################################################################################
+
+FIP_VERSION = bfdad4cc520b254813536ebfba8b9749386cd57c
+FIP_SITE = $(call github,LibreELEC,amlogic-boot-fip,$(FIP_VERSION))
+FIP_LICENSE = PROPRIETARY
+FIP_DEPENDENCIES = host-python3
+
+ifeq ($(BR2_PACKAGE_HOST_FIP_LEPOTATO),y)
+HOST_FIP_LEPOTATO_BINARIES += lepotato/bl2.bin lepotato/acs.bin \
+			lepotato/bl21.bin lepotato/bl30.bin \
+			lepotato/bl301.bin lepotato/bl31.img \
+			lepotato/blx_fix.sh lepotato/acs_tool.py lepotato/aml_encrypt_gxl
+endif
+
+define HOST_FIP_INSTALL_SUBDIR
+	$(INSTALL) -m 0755 -d $(HOST_DIR)/usr/bin/fip/
+endef
+
+define HOST_FIP_INSTALL_CMDS
+	$(foreach b,$(HOST_FIP_LEPOTATO_BINARIES),
+		$(INSTALL) -D -m 755 $(@D)/$(b) $(HOST_DIR)/usr/bin/fip/)
+endef
+
+HOST_FIP_PRE_INSTALL_HOOKS += HOST_FIP_INSTALL_SUBDIR
+
+$(eval $(host-generic-package))
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 3/3] configs/lepotato: Add new defconfig
  2020-07-07  7:53 [Buildroot] [PATCH 0/3] board: Add support for LePotato Mylène Josserand
  2020-07-07  7:53 ` [Buildroot] [PATCH 1/3] DEVELOPERS: Update Mylene's email Mylène Josserand
  2020-07-07  7:53 ` [Buildroot] [PATCH 2/3] package: Add new fip package Mylène Josserand
@ 2020-07-07  7:53 ` Mylène Josserand
  2020-07-07 19:51 ` [Buildroot] [PATCH 0/3] board: Add support for LePotato Yann E. MORIN
  3 siblings, 0 replies; 10+ messages in thread
From: Mylène Josserand @ 2020-07-07  7:53 UTC (permalink / raw)
  To: buildroot

Add a basic support for the Libre Computer board called "Le Potato".
One particularity is that this board is using FIP utilities to sign
a mainline u-boot. The defconfig reflects that.

The final image produced is a sd-card image.

Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
---
 .gitlab-ci.yml                             |  1 +
 DEVELOPERS                                 |  2 +
 board/librecomputer/lepotato/boot.cmd      |  6 +++
 board/librecomputer/lepotato/genimage.cfg  | 28 ++++++++++
 board/librecomputer/lepotato/post-build.sh | 61 ++++++++++++++++++++++
 board/librecomputer/lepotato/post-image.sh | 17 ++++++
 board/librecomputer/lepotato/readme.txt    | 35 +++++++++++++
 configs/lepotato_defconfig                 | 29 ++++++++++
 8 files changed, 179 insertions(+)
 create mode 100644 board/librecomputer/lepotato/boot.cmd
 create mode 100644 board/librecomputer/lepotato/genimage.cfg
 create mode 100755 board/librecomputer/lepotato/post-build.sh
 create mode 100755 board/librecomputer/lepotato/post-image.sh
 create mode 100644 board/librecomputer/lepotato/readme.txt
 create mode 100644 configs/lepotato_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 951f843cf2..01044ebd98 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -215,6 +215,7 @@ imx8mmpico_defconfig: { extends: .defconfig }
 imx8mpico_defconfig: { extends: .defconfig }
 lafrite_defconfig: { extends: .defconfig }
 lego_ev3_defconfig: { extends: .defconfig }
+lepotato_defconfig: { extends: .defconfig }
 licheepi_zero_defconfig: { extends: .defconfig }
 linksprite_pcduino_defconfig: { extends: .defconfig }
 minnowboard_max-graphical_defconfig: { extends: .defconfig }
diff --git a/DEVELOPERS b/DEVELOPERS
index f36ba64114..91cc080304 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1845,6 +1845,8 @@ F:	package/libgeotiff/
 
 N:	Myl?ne Josserand <mylene.josserand@collabora.com>
 F:	package/rtl8723bu/
+F:	board/librecomputer/lepotato/
+F:	configs/lepotato_defconfig
 
 N:	Nathaniel Roach <nroach44@gmail.com>
 F:	package/bandwidthd/
diff --git a/board/librecomputer/lepotato/boot.cmd b/board/librecomputer/lepotato/boot.cmd
new file mode 100644
index 0000000000..5e5ae2d727
--- /dev/null
+++ b/board/librecomputer/lepotato/boot.cmd
@@ -0,0 +1,6 @@
+setenv bootargs console=ttyAML0,115200 earlyprintk root=/dev/mmcblk1p2 rootwait
+
+fatload mmc 0 $kernel_addr_r Image
+fatload mmc 0 $fdt_addr_r meson-gxl-s905x-libretech-cc.dtb
+
+booti $kernel_addr_r - $fdt_addr_r
diff --git a/board/librecomputer/lepotato/genimage.cfg b/board/librecomputer/lepotato/genimage.cfg
new file mode 100644
index 0000000000..96a52e1b53
--- /dev/null
+++ b/board/librecomputer/lepotato/genimage.cfg
@@ -0,0 +1,28 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"meson-gxl-s905x-libretech-cc.dtb",
+			"boot.scr"
+		}
+	}
+	size = 64M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 1M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+		size = 512M
+	}
+}
\ No newline at end of file
diff --git a/board/librecomputer/lepotato/post-build.sh b/board/librecomputer/lepotato/post-build.sh
new file mode 100755
index 0000000000..d08face559
--- /dev/null
+++ b/board/librecomputer/lepotato/post-build.sh
@@ -0,0 +1,61 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+AML_BIN_DIR=${HOST_DIR}/usr/bin/fip/
+FIP_BUILD=${BINARIES_DIR}/fip/
+
+# Rename u-boot binary into bl33.bin and copy binaries
+install -m 0644 -D ${BINARIES_DIR}/u-boot.bin	${FIP_BUILD}/bl33.bin
+install -m 0644 ${AML_BIN_DIR}/bl2.bin		${FIP_BUILD}/
+install -m 0644 ${AML_BIN_DIR}/acs.bin		${FIP_BUILD}/
+install -m 0644 ${AML_BIN_DIR}/bl21.bin	${FIP_BUILD}/
+install -m 0644 ${AML_BIN_DIR}/bl30.bin	${FIP_BUILD}/
+install -m 0644 ${AML_BIN_DIR}/bl301.bin	${FIP_BUILD}/
+install -m 0644 ${AML_BIN_DIR}/bl31.img	${FIP_BUILD}/
+
+# Use Amlogic scripts
+${AML_BIN_DIR}/blx_fix.sh				\
+	      ${FIP_BUILD}/bl30.bin			\
+	      ${FIP_BUILD}/zero_tmp			\
+	      ${FIP_BUILD}/bl30_zero.bin		\
+	      ${FIP_BUILD}/bl301.bin			\
+	      ${FIP_BUILD}/bl301_zero.bin		\
+	      ${FIP_BUILD}/bl30_new.bin		\
+	      bl30
+
+${HOST_DIR}/bin/python3 ${AML_BIN_DIR}/acs_tool.py	\
+	   ${FIP_BUILD}/bl2.bin 			\
+	   ${FIP_BUILD}/bl2_acs.bin			\
+	   ${FIP_BUILD}/acs.bin 			\
+	   0
+
+${AML_BIN_DIR}/blx_fix.sh				\
+	      ${FIP_BUILD}/bl2_acs.bin			\
+	      ${FIP_BUILD}/zero_tmp			\
+	      ${FIP_BUILD}/bl2_zero.bin		\
+	      ${FIP_BUILD}/bl21.bin 			\
+	      ${FIP_BUILD}/bl21_zero.bin		\
+	      ${FIP_BUILD}/bl2_new.bin			\
+	      bl2
+
+# encrypt bootloader
+${AML_BIN_DIR}/aml_encrypt_gxl --bl3enc \
+	      --input ${FIP_BUILD}/bl30_new.bin
+
+${AML_BIN_DIR}/aml_encrypt_gxl --bl3enc \
+	      --input ${FIP_BUILD}/bl31.img
+
+${AML_BIN_DIR}/aml_encrypt_gxl --bl3enc \
+	      --input ${FIP_BUILD}/bl33.bin
+
+${AML_BIN_DIR}/aml_encrypt_gxl --bl2sig \
+	      --input ${FIP_BUILD}/bl2_new.bin \
+	      --output ${FIP_BUILD}/bl2.n.bin.sig
+
+# Generate last encryption to create u-boot binaries
+${AML_BIN_DIR}/aml_encrypt_gxl --bootmk		\
+	      --output ${BINARIES_DIR}/u-boot.bin	\
+	      --bl2    ${FIP_BUILD}/bl2.n.bin.sig	\
+	      --bl30   ${FIP_BUILD}/bl30_new.bin.enc	\
+	      --bl31   ${FIP_BUILD}/bl31.img.enc	\
+	      --bl33   ${FIP_BUILD}/bl33.bin.enc
diff --git a/board/librecomputer/lepotato/post-image.sh b/board/librecomputer/lepotato/post-image.sh
new file mode 100755
index 0000000000..8bc0d4efe7
--- /dev/null
+++ b/board/librecomputer/lepotato/post-image.sh
@@ -0,0 +1,17 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg"
+GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
+
+rm -rf "${GENIMAGE_TMP}"
+
+genimage                           \
+        --rootpath "${TARGET_DIR}"     \
+        --tmppath "${GENIMAGE_TMP}"    \
+        --inputpath "${BINARIES_DIR}"  \
+        --outputpath "${BINARIES_DIR}" \
+        --config "${GENIMAGE_CFG}"
+
+dd if=${BINARIES_DIR}/u-boot.bin.sd.bin of=${BINARIES_DIR}/sdcard.img conv=fsync,notrunc bs=1 count=442 status=progress
+dd if=${BINARIES_DIR}/u-boot.bin.sd.bin of=${BINARIES_DIR}/sdcard.img conv=fsync,notrunc bs=512 skip=1 seek=1 status=progress
diff --git a/board/librecomputer/lepotato/readme.txt b/board/librecomputer/lepotato/readme.txt
new file mode 100644
index 0000000000..b9e62b164e
--- /dev/null
+++ b/board/librecomputer/lepotato/readme.txt
@@ -0,0 +1,35 @@
+Intro
+=====
+
+Libre Computer "Le Potato" is a low cost SBC based around an Amlogic
+s905xcc SoC (quad Cortex-A53) including 2GB DDR3. To see its specification,
+look at the website:
+
+https://libre.computer/products/boards/aml-s905x-cc/
+
+How to build it
+===============
+
+Configure Buildroot:
+
+    $ make lepotato_defconfig
+
+Compile everything and build the SD-card image:
+
+    $ make
+
+How to write the SD-card image
+======================================
+
+Once the build process is finished you will have an image called "sdcard.img"
+in the output/images/ directory.
+
+Copy the image "sdcard.img" onto a SD-card with "dd":
+
+  $ sudo dd if=output/images/sdcard.img of=/dev/sdX status=progress
+
+How to boot
+===========
+
+Insert the SD-card in the slot and power up board. The system will boot
+automatically.
diff --git a/configs/lepotato_defconfig b/configs/lepotato_defconfig
new file mode 100644
index 0000000000..95934075ad
--- /dev/null
+++ b/configs/lepotato_defconfig
@@ -0,0 +1,29 @@
+BR2_aarch64=y
+BR2_cortex_a53=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/librecomputer/lepotato/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/librecomputer/lepotato/post-image.sh"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.2.14"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="amlogic/meson-gxl-s905x-libretech-cc"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="65M"
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="libretech-cc"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_BOOT_SCRIPT=y
+BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="board/librecomputer/lepotato/boot.cmd"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_FIP=y
+BR2_PACKAGE_HOST_FIP_LEPOTATO=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package: Add new fip package
  2020-07-07  7:53 ` [Buildroot] [PATCH 2/3] package: Add new fip package Mylène Josserand
@ 2020-07-07 12:37   ` Romain Naour
  2020-07-07 14:18     ` Mylene Josserand
  0 siblings, 1 reply; 10+ messages in thread
From: Romain Naour @ 2020-07-07 12:37 UTC (permalink / raw)
  To: buildroot

Hi Myl?ne,

Le 07/07/2020 ? 09:53, Myl?ne Josserand a ?crit?:
> Firmware Image Pacakge (FIP) is used to sign Amlogic u-boot binaries.
> It is a host package as it is only binaries to call on u-boot image
> to sign it. One tool is a python script that needs to be called with
> 'python' command, otherwise, it is not working. That is why there is
> a dependency on host-python.
> 
> For the moment, only LePotato's board is supported. Other ones
> may be added later, if needed.

We had a previous contribution about LePotato board from Baylibre [1].
There are several concerns about licensing, aml_encrypt_gxl and acs_tool.py.

What about gxlimg to replace aml_encrypt_gxl?

[1]
http://patchwork.ozlabs.org/project/buildroot/patch/1533545408-11248-2-git-send-email-narmstrong at baylibre.com/
[2] https://github.com/repk/gxlimg

Best regards,
Romain

> 
> Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
> ---
>  package/Config.in.host     |  1 +
>  package/fip/Config.in.host | 17 +++++++++++++++++
>  package/fip/fip.hash       |  2 ++
>  package/fip/fip.mk         | 30 ++++++++++++++++++++++++++++++
>  4 files changed, 50 insertions(+)
>  create mode 100644 package/fip/Config.in.host
>  create mode 100644 package/fip/fip.hash
>  create mode 100644 package/fip/fip.mk
> 
> diff --git a/package/Config.in.host b/package/Config.in.host
> index f1246c708f..21d2bc4072 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -24,6 +24,7 @@ menu "Host utilities"
>  	source "package/f2fs-tools/Config.in.host"
>  	source "package/faketime/Config.in.host"
>  	source "package/fatcat/Config.in.host"
> +	source "package/fip/Config.in.host"
>  	source "package/fwup/Config.in.host"
>  	source "package/genext2fs/Config.in.host"
>  	source "package/genimage/Config.in.host"
> diff --git a/package/fip/Config.in.host b/package/fip/Config.in.host
> new file mode 100644
> index 0000000000..914020a1b3
> --- /dev/null
> +++ b/package/fip/Config.in.host
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_HOST_FIP
> +	bool "host Amlogic FIP binaries"
> +	help
> +	  This package contains the FIP utilities, that is
> +	  used to create U-Boot final binary.
> +
> +if BR2_PACKAGE_HOST_FIP
> +
> +config BR2_PACKAGE_HOST_FIP_LEPOTATO
> +	bool "FIP lepotato version"
> +	default y
> +	select BR2_PACKAGE_HOST_PYTHON3
> +	help
> +	  This option will download the latest libretech-cc's version
> +	  of the fip utility for the board "lepotato".
> +
> +endif
> diff --git a/package/fip/fip.hash b/package/fip/fip.hash
> new file mode 100644
> index 0000000000..547fff8534
> --- /dev/null
> +++ b/package/fip/fip.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 7a59dc36c89b02c38f9b630b4abb7056869ff76ca6152b6c3ce797ddd1349a64  fip-bfdad4cc520b254813536ebfba8b9749386cd57c.tar.gz
> diff --git a/package/fip/fip.mk b/package/fip/fip.mk
> new file mode 100644
> index 0000000000..d1fb43ad13
> --- /dev/null
> +++ b/package/fip/fip.mk
> @@ -0,0 +1,30 @@
> +################################################################################
> +#
> +# fip
> +#
> +################################################################################
> +
> +FIP_VERSION = bfdad4cc520b254813536ebfba8b9749386cd57c
> +FIP_SITE = $(call github,LibreELEC,amlogic-boot-fip,$(FIP_VERSION))
> +FIP_LICENSE = PROPRIETARY
> +FIP_DEPENDENCIES = host-python3
> +
> +ifeq ($(BR2_PACKAGE_HOST_FIP_LEPOTATO),y)
> +HOST_FIP_LEPOTATO_BINARIES += lepotato/bl2.bin lepotato/acs.bin \
> +			lepotato/bl21.bin lepotato/bl30.bin \
> +			lepotato/bl301.bin lepotato/bl31.img \
> +			lepotato/blx_fix.sh lepotato/acs_tool.py lepotato/aml_encrypt_gxl
> +endif
> +
> +define HOST_FIP_INSTALL_SUBDIR
> +	$(INSTALL) -m 0755 -d $(HOST_DIR)/usr/bin/fip/
> +endef
> +
> +define HOST_FIP_INSTALL_CMDS
> +	$(foreach b,$(HOST_FIP_LEPOTATO_BINARIES),
> +		$(INSTALL) -D -m 755 $(@D)/$(b) $(HOST_DIR)/usr/bin/fip/)
> +endef
> +
> +HOST_FIP_PRE_INSTALL_HOOKS += HOST_FIP_INSTALL_SUBDIR
> +
> +$(eval $(host-generic-package))
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package: Add new fip package
  2020-07-07 12:37   ` Romain Naour
@ 2020-07-07 14:18     ` Mylene Josserand
  2020-07-07 14:29       ` Romain Naour
  0 siblings, 1 reply; 10+ messages in thread
From: Mylene Josserand @ 2020-07-07 14:18 UTC (permalink / raw)
  To: buildroot

Hi Romain,

Thank you for the review!

On 7/7/20 2:37 PM, Romain Naour wrote:
> Hi Myl?ne,
> 
> Le 07/07/2020 ? 09:53, Myl?ne Josserand a ?crit?:
>> Firmware Image Pacakge (FIP) is used to sign Amlogic u-boot binaries.
>> It is a host package as it is only binaries to call on u-boot image
>> to sign it. One tool is a python script that needs to be called with
>> 'python' command, otherwise, it is not working. That is why there is
>> a dependency on host-python.
>>
>> For the moment, only LePotato's board is supported. Other ones
>> may be added later, if needed.
> 
> We had a previous contribution about LePotato board from Baylibre [1].
> There are several concerns about licensing, aml_encrypt_gxl and acs_tool.py.

oh, indeed, I missed that one.

> 
> What about gxlimg to replace aml_encrypt_gxl?

Thanks for the link, I will try it, indeed but I guess my patches are 
lapsed because of these license issues, right?

> 
> [1]
> http://patchwork.ozlabs.org/project/buildroot/patch/1533545408-11248-2-git-send-email-narmstrong at baylibre.com/
> [2] https://github.com/repk/gxlimg
> 
> Best regards,
> Romain

Best regards,
Myl?ne

> 
>>
>> Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
>> ---
>>   package/Config.in.host     |  1 +
>>   package/fip/Config.in.host | 17 +++++++++++++++++
>>   package/fip/fip.hash       |  2 ++
>>   package/fip/fip.mk         | 30 ++++++++++++++++++++++++++++++
>>   4 files changed, 50 insertions(+)
>>   create mode 100644 package/fip/Config.in.host
>>   create mode 100644 package/fip/fip.hash
>>   create mode 100644 package/fip/fip.mk
>>
>> diff --git a/package/Config.in.host b/package/Config.in.host
>> index f1246c708f..21d2bc4072 100644
>> --- a/package/Config.in.host
>> +++ b/package/Config.in.host
>> @@ -24,6 +24,7 @@ menu "Host utilities"
>>   	source "package/f2fs-tools/Config.in.host"
>>   	source "package/faketime/Config.in.host"
>>   	source "package/fatcat/Config.in.host"
>> +	source "package/fip/Config.in.host"
>>   	source "package/fwup/Config.in.host"
>>   	source "package/genext2fs/Config.in.host"
>>   	source "package/genimage/Config.in.host"
>> diff --git a/package/fip/Config.in.host b/package/fip/Config.in.host
>> new file mode 100644
>> index 0000000000..914020a1b3
>> --- /dev/null
>> +++ b/package/fip/Config.in.host
>> @@ -0,0 +1,17 @@
>> +config BR2_PACKAGE_HOST_FIP
>> +	bool "host Amlogic FIP binaries"
>> +	help
>> +	  This package contains the FIP utilities, that is
>> +	  used to create U-Boot final binary.
>> +
>> +if BR2_PACKAGE_HOST_FIP
>> +
>> +config BR2_PACKAGE_HOST_FIP_LEPOTATO
>> +	bool "FIP lepotato version"
>> +	default y
>> +	select BR2_PACKAGE_HOST_PYTHON3
>> +	help
>> +	  This option will download the latest libretech-cc's version
>> +	  of the fip utility for the board "lepotato".
>> +
>> +endif
>> diff --git a/package/fip/fip.hash b/package/fip/fip.hash
>> new file mode 100644
>> index 0000000000..547fff8534
>> --- /dev/null
>> +++ b/package/fip/fip.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed
>> +sha256 7a59dc36c89b02c38f9b630b4abb7056869ff76ca6152b6c3ce797ddd1349a64  fip-bfdad4cc520b254813536ebfba8b9749386cd57c.tar.gz
>> diff --git a/package/fip/fip.mk b/package/fip/fip.mk
>> new file mode 100644
>> index 0000000000..d1fb43ad13
>> --- /dev/null
>> +++ b/package/fip/fip.mk
>> @@ -0,0 +1,30 @@
>> +################################################################################
>> +#
>> +# fip
>> +#
>> +################################################################################
>> +
>> +FIP_VERSION = bfdad4cc520b254813536ebfba8b9749386cd57c
>> +FIP_SITE = $(call github,LibreELEC,amlogic-boot-fip,$(FIP_VERSION))
>> +FIP_LICENSE = PROPRIETARY
>> +FIP_DEPENDENCIES = host-python3
>> +
>> +ifeq ($(BR2_PACKAGE_HOST_FIP_LEPOTATO),y)
>> +HOST_FIP_LEPOTATO_BINARIES += lepotato/bl2.bin lepotato/acs.bin \
>> +			lepotato/bl21.bin lepotato/bl30.bin \
>> +			lepotato/bl301.bin lepotato/bl31.img \
>> +			lepotato/blx_fix.sh lepotato/acs_tool.py lepotato/aml_encrypt_gxl
>> +endif
>> +
>> +define HOST_FIP_INSTALL_SUBDIR
>> +	$(INSTALL) -m 0755 -d $(HOST_DIR)/usr/bin/fip/
>> +endef
>> +
>> +define HOST_FIP_INSTALL_CMDS
>> +	$(foreach b,$(HOST_FIP_LEPOTATO_BINARIES),
>> +		$(INSTALL) -D -m 755 $(@D)/$(b) $(HOST_DIR)/usr/bin/fip/)
>> +endef
>> +
>> +HOST_FIP_PRE_INSTALL_HOOKS += HOST_FIP_INSTALL_SUBDIR
>> +
>> +$(eval $(host-generic-package))
>>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package: Add new fip package
  2020-07-07 14:18     ` Mylene Josserand
@ 2020-07-07 14:29       ` Romain Naour
  2020-07-09 11:51         ` Mylene Josserand
  0 siblings, 1 reply; 10+ messages in thread
From: Romain Naour @ 2020-07-07 14:29 UTC (permalink / raw)
  To: buildroot

Hi Myl?ne,

Le 07/07/2020 ? 16:18, Mylene Josserand a ?crit?:
> Hi Romain,
> 
> Thank you for the review!

You're welcome.

> 
> On 7/7/20 2:37 PM, Romain Naour wrote:
>> Hi Myl?ne,
>>
>> Le 07/07/2020 ? 09:53, Myl?ne Josserand a ?crit?:
>>> Firmware Image Pacakge (FIP) is used to sign Amlogic u-boot binaries.
>>> It is a host package as it is only binaries to call on u-boot image
>>> to sign it. One tool is a python script that needs to be called with
>>> 'python' command, otherwise, it is not working. That is why there is
>>> a dependency on host-python.
>>>
>>> For the moment, only LePotato's board is supported. Other ones
>>> may be added later, if needed.
>>
>> We had a previous contribution about LePotato board from Baylibre [1].
>> There are several concerns about licensing, aml_encrypt_gxl and acs_tool.py.
> 
> oh, indeed, I missed that one.

No problem, those patches date from August 2018.

> 
>>
>> What about gxlimg to replace aml_encrypt_gxl?
> 
> Thanks for the link, I will try it, indeed but I guess my patches are lapsed
> because of these license issues, right?

I'm afraid yes. LibreELEC doesn't provide any licensing information in their
repository. I'm not sure if we should use LibreELEC or Baylibre repository...

Best regards,
Romain

> 
>>
>> [1]
>> http://patchwork.ozlabs.org/project/buildroot/patch/1533545408-11248-2-git-send-email-narmstrong at baylibre.com/
>>
>> [2] https://github.com/repk/gxlimg
>>
>> Best regards,
>> Romain
> 
> Best regards,
> Myl?ne
> 
>>
>>>
>>> Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
>>> ---
>>> ? package/Config.in.host???? |? 1 +
>>> ? package/fip/Config.in.host | 17 +++++++++++++++++
>>> ? package/fip/fip.hash?????? |? 2 ++
>>> ? package/fip/fip.mk???????? | 30 ++++++++++++++++++++++++++++++
>>> ? 4 files changed, 50 insertions(+)
>>> ? create mode 100644 package/fip/Config.in.host
>>> ? create mode 100644 package/fip/fip.hash
>>> ? create mode 100644 package/fip/fip.mk
>>>
>>> diff --git a/package/Config.in.host b/package/Config.in.host
>>> index f1246c708f..21d2bc4072 100644
>>> --- a/package/Config.in.host
>>> +++ b/package/Config.in.host
>>> @@ -24,6 +24,7 @@ menu "Host utilities"
>>> ????? source "package/f2fs-tools/Config.in.host"
>>> ????? source "package/faketime/Config.in.host"
>>> ????? source "package/fatcat/Config.in.host"
>>> +??? source "package/fip/Config.in.host"
>>> ????? source "package/fwup/Config.in.host"
>>> ????? source "package/genext2fs/Config.in.host"
>>> ????? source "package/genimage/Config.in.host"
>>> diff --git a/package/fip/Config.in.host b/package/fip/Config.in.host
>>> new file mode 100644
>>> index 0000000000..914020a1b3
>>> --- /dev/null
>>> +++ b/package/fip/Config.in.host
>>> @@ -0,0 +1,17 @@
>>> +config BR2_PACKAGE_HOST_FIP
>>> +??? bool "host Amlogic FIP binaries"
>>> +??? help
>>> +????? This package contains the FIP utilities, that is
>>> +????? used to create U-Boot final binary.
>>> +
>>> +if BR2_PACKAGE_HOST_FIP
>>> +
>>> +config BR2_PACKAGE_HOST_FIP_LEPOTATO
>>> +??? bool "FIP lepotato version"
>>> +??? default y
>>> +??? select BR2_PACKAGE_HOST_PYTHON3
>>> +??? help
>>> +????? This option will download the latest libretech-cc's version
>>> +????? of the fip utility for the board "lepotato".
>>> +
>>> +endif
>>> diff --git a/package/fip/fip.hash b/package/fip/fip.hash
>>> new file mode 100644
>>> index 0000000000..547fff8534
>>> --- /dev/null
>>> +++ b/package/fip/fip.hash
>>> @@ -0,0 +1,2 @@
>>> +# Locally computed
>>> +sha256 7a59dc36c89b02c38f9b630b4abb7056869ff76ca6152b6c3ce797ddd1349a64?
>>> fip-bfdad4cc520b254813536ebfba8b9749386cd57c.tar.gz
>>> diff --git a/package/fip/fip.mk b/package/fip/fip.mk
>>> new file mode 100644
>>> index 0000000000..d1fb43ad13
>>> --- /dev/null
>>> +++ b/package/fip/fip.mk
>>> @@ -0,0 +1,30 @@
>>> +################################################################################
>>>
>>> +#
>>> +# fip
>>> +#
>>> +################################################################################
>>>
>>> +
>>> +FIP_VERSION = bfdad4cc520b254813536ebfba8b9749386cd57c
>>> +FIP_SITE = $(call github,LibreELEC,amlogic-boot-fip,$(FIP_VERSION))
>>> +FIP_LICENSE = PROPRIETARY
>>> +FIP_DEPENDENCIES = host-python3
>>> +
>>> +ifeq ($(BR2_PACKAGE_HOST_FIP_LEPOTATO),y)
>>> +HOST_FIP_LEPOTATO_BINARIES += lepotato/bl2.bin lepotato/acs.bin \
>>> +??????????? lepotato/bl21.bin lepotato/bl30.bin \
>>> +??????????? lepotato/bl301.bin lepotato/bl31.img \
>>> +??????????? lepotato/blx_fix.sh lepotato/acs_tool.py lepotato/aml_encrypt_gxl
>>> +endif
>>> +
>>> +define HOST_FIP_INSTALL_SUBDIR
>>> +??? $(INSTALL) -m 0755 -d $(HOST_DIR)/usr/bin/fip/
>>> +endef
>>> +
>>> +define HOST_FIP_INSTALL_CMDS
>>> +??? $(foreach b,$(HOST_FIP_LEPOTATO_BINARIES),
>>> +??????? $(INSTALL) -D -m 755 $(@D)/$(b) $(HOST_DIR)/usr/bin/fip/)
>>> +endef
>>> +
>>> +HOST_FIP_PRE_INSTALL_HOOKS += HOST_FIP_INSTALL_SUBDIR
>>> +
>>> +$(eval $(host-generic-package))
>>>
>>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 0/3] board: Add support for LePotato
  2020-07-07  7:53 [Buildroot] [PATCH 0/3] board: Add support for LePotato Mylène Josserand
                   ` (2 preceding siblings ...)
  2020-07-07  7:53 ` [Buildroot] [PATCH 3/3] configs/lepotato: Add new defconfig Mylène Josserand
@ 2020-07-07 19:51 ` Yann E. MORIN
  2020-07-09 11:58   ` Mylene Josserand
  3 siblings, 1 reply; 10+ messages in thread
From: Yann E. MORIN @ 2020-07-07 19:51 UTC (permalink / raw)
  To: buildroot

Myl?ne, All,

On 2020-07-07 09:53 +0200, Myl?ne Josserand spake thusly:
> Here is my first version of this series that adds the support of the
> board LePotato SBC from LibreComputer [1].
> 
> This board uses FIP utilities [2][3] from AMLogic to sign u-boot.

Following the issues raised by Romain, I've marked patches 2-3 as
"changes requested". Hopefully, gslimg is an interesting trail to follow
as a free/libre replacement for the vendor stuff.

I've applied patch 1 to master, thanks.

Regards,
Yann E. MORIN.

> The patch 02 is adding these FIP utilities as a host package. It is
> available for different boards such as khadas-vim, some odroids, etc.
> This package will copy the corresponding utilities, only for LePotato for
> the moment, into the HOST_DIR/usr/bin. Currently, LePotato's ones are the
> default ones. This should be updating once more boards are added.
> 
> The patch 03 is adding the support of this board from LibreComputer:
>    - one defconfig including a u-boot, kernel and minimal rootfs.
>    The configuration is also enabling the FIP package for LePotato.
>    - one post-build script that is using the FIP utilities to sign
>    u-boot binary.
>    - one post-image script to generate a sd-card image and flashing the
>    signed u-boot on it.
>    - a readme file to explain how to configure, compile and flash image
>    for this board.
>    - a boot.scr file including booti commands to run.
> 
> Let me know if you have any comments on this series.
> 
> Best regards,
> 
> Myl?ne
> 
> [1]: https://libre.computer/products/boards/aml-s905x-cc/
> [2]: https://github.com/LibreELEC/amlogic-boot-fip
> [3]: https://github.com/BayLibre/u-boot
> 
> Myl?ne Josserand (3):
>   DEVELOPERS: Update Mylene's email
>   package: Add new fip package
>   configs/lepotato: Add new defconfig
> 
>  .gitlab-ci.yml                             |  1 +
>  DEVELOPERS                                 |  4 +-
>  board/librecomputer/lepotato/boot.cmd      |  6 +++
>  board/librecomputer/lepotato/genimage.cfg  | 28 ++++++++++
>  board/librecomputer/lepotato/post-build.sh | 61 ++++++++++++++++++++++
>  board/librecomputer/lepotato/post-image.sh | 17 ++++++
>  board/librecomputer/lepotato/readme.txt    | 35 +++++++++++++
>  configs/lepotato_defconfig                 | 29 ++++++++++
>  package/Config.in.host                     |  1 +
>  package/fip/Config.in.host                 | 17 ++++++
>  package/fip/fip.hash                       |  2 +
>  package/fip/fip.mk                         | 30 +++++++++++
>  12 files changed, 230 insertions(+), 1 deletion(-)
>  create mode 100644 board/librecomputer/lepotato/boot.cmd
>  create mode 100644 board/librecomputer/lepotato/genimage.cfg
>  create mode 100755 board/librecomputer/lepotato/post-build.sh
>  create mode 100755 board/librecomputer/lepotato/post-image.sh
>  create mode 100644 board/librecomputer/lepotato/readme.txt
>  create mode 100644 configs/lepotato_defconfig
>  create mode 100644 package/fip/Config.in.host
>  create mode 100644 package/fip/fip.hash
>  create mode 100644 package/fip/fip.mk
> 
> -- 
> 2.27.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package: Add new fip package
  2020-07-07 14:29       ` Romain Naour
@ 2020-07-09 11:51         ` Mylene Josserand
  0 siblings, 0 replies; 10+ messages in thread
From: Mylene Josserand @ 2020-07-09 11:51 UTC (permalink / raw)
  To: buildroot

Hello,

On 7/7/20 4:29 PM, Romain Naour wrote:
> Hi Myl?ne,
> 
> Le 07/07/2020 ? 16:18, Mylene Josserand a ?crit?:
>> Hi Romain,
>>
>> Thank you for the review!
> 
> You're welcome.
> 
>>
>> On 7/7/20 2:37 PM, Romain Naour wrote:
>>> Hi Myl?ne,
>>>
>>> Le 07/07/2020 ? 09:53, Myl?ne Josserand a ?crit?:
>>>> Firmware Image Pacakge (FIP) is used to sign Amlogic u-boot binaries.
>>>> It is a host package as it is only binaries to call on u-boot image
>>>> to sign it. One tool is a python script that needs to be called with
>>>> 'python' command, otherwise, it is not working. That is why there is
>>>> a dependency on host-python.
>>>>
>>>> For the moment, only LePotato's board is supported. Other ones
>>>> may be added later, if needed.
>>>
>>> We had a previous contribution about LePotato board from Baylibre [1].
>>> There are several concerns about licensing, aml_encrypt_gxl and acs_tool.py.
>>
>> oh, indeed, I missed that one.
> 
> No problem, those patches date from August 2018.
> 
>>
>>>
>>> What about gxlimg to replace aml_encrypt_gxl?
>>
>> Thanks for the link, I will try it, indeed but I guess my patches are lapsed
>> because of these license issues, right?
> 
> I'm afraid yes. LibreELEC doesn't provide any licensing information in their
> repository. I'm not sure if we should use LibreELEC or Baylibre repository...

okay, thank you

Yes, I am not sure too, I thought that LibreElec was more appropriate 
but without any conviction :)

Best regards,
Myl?ne

> 
> Best regards,
> Romain
> 
>>
>>>
>>> [1]
>>> http://patchwork.ozlabs.org/project/buildroot/patch/1533545408-11248-2-git-send-email-narmstrong at baylibre.com/
>>>
>>> [2] https://github.com/repk/gxlimg
>>>
>>> Best regards,
>>> Romain
>>
>> Best regards,
>> Myl?ne
>>
>>>
>>>>
>>>> Signed-off-by: Myl?ne Josserand <mylene.josserand@collabora.com>
>>>> ---
>>>>  ? package/Config.in.host???? |? 1 +
>>>>  ? package/fip/Config.in.host | 17 +++++++++++++++++
>>>>  ? package/fip/fip.hash?????? |? 2 ++
>>>>  ? package/fip/fip.mk???????? | 30 ++++++++++++++++++++++++++++++
>>>>  ? 4 files changed, 50 insertions(+)
>>>>  ? create mode 100644 package/fip/Config.in.host
>>>>  ? create mode 100644 package/fip/fip.hash
>>>>  ? create mode 100644 package/fip/fip.mk
>>>>
>>>> diff --git a/package/Config.in.host b/package/Config.in.host
>>>> index f1246c708f..21d2bc4072 100644
>>>> --- a/package/Config.in.host
>>>> +++ b/package/Config.in.host
>>>> @@ -24,6 +24,7 @@ menu "Host utilities"
>>>>  ????? source "package/f2fs-tools/Config.in.host"
>>>>  ????? source "package/faketime/Config.in.host"
>>>>  ????? source "package/fatcat/Config.in.host"
>>>> +??? source "package/fip/Config.in.host"
>>>>  ????? source "package/fwup/Config.in.host"
>>>>  ????? source "package/genext2fs/Config.in.host"
>>>>  ????? source "package/genimage/Config.in.host"
>>>> diff --git a/package/fip/Config.in.host b/package/fip/Config.in.host
>>>> new file mode 100644
>>>> index 0000000000..914020a1b3
>>>> --- /dev/null
>>>> +++ b/package/fip/Config.in.host
>>>> @@ -0,0 +1,17 @@
>>>> +config BR2_PACKAGE_HOST_FIP
>>>> +??? bool "host Amlogic FIP binaries"
>>>> +??? help
>>>> +????? This package contains the FIP utilities, that is
>>>> +????? used to create U-Boot final binary.
>>>> +
>>>> +if BR2_PACKAGE_HOST_FIP
>>>> +
>>>> +config BR2_PACKAGE_HOST_FIP_LEPOTATO
>>>> +??? bool "FIP lepotato version"
>>>> +??? default y
>>>> +??? select BR2_PACKAGE_HOST_PYTHON3
>>>> +??? help
>>>> +????? This option will download the latest libretech-cc's version
>>>> +????? of the fip utility for the board "lepotato".
>>>> +
>>>> +endif
>>>> diff --git a/package/fip/fip.hash b/package/fip/fip.hash
>>>> new file mode 100644
>>>> index 0000000000..547fff8534
>>>> --- /dev/null
>>>> +++ b/package/fip/fip.hash
>>>> @@ -0,0 +1,2 @@
>>>> +# Locally computed
>>>> +sha256 7a59dc36c89b02c38f9b630b4abb7056869ff76ca6152b6c3ce797ddd1349a64
>>>> fip-bfdad4cc520b254813536ebfba8b9749386cd57c.tar.gz
>>>> diff --git a/package/fip/fip.mk b/package/fip/fip.mk
>>>> new file mode 100644
>>>> index 0000000000..d1fb43ad13
>>>> --- /dev/null
>>>> +++ b/package/fip/fip.mk
>>>> @@ -0,0 +1,30 @@
>>>> +################################################################################
>>>>
>>>> +#
>>>> +# fip
>>>> +#
>>>> +################################################################################
>>>>
>>>> +
>>>> +FIP_VERSION = bfdad4cc520b254813536ebfba8b9749386cd57c
>>>> +FIP_SITE = $(call github,LibreELEC,amlogic-boot-fip,$(FIP_VERSION))
>>>> +FIP_LICENSE = PROPRIETARY
>>>> +FIP_DEPENDENCIES = host-python3
>>>> +
>>>> +ifeq ($(BR2_PACKAGE_HOST_FIP_LEPOTATO),y)
>>>> +HOST_FIP_LEPOTATO_BINARIES += lepotato/bl2.bin lepotato/acs.bin \
>>>> +??????????? lepotato/bl21.bin lepotato/bl30.bin \
>>>> +??????????? lepotato/bl301.bin lepotato/bl31.img \
>>>> +??????????? lepotato/blx_fix.sh lepotato/acs_tool.py lepotato/aml_encrypt_gxl
>>>> +endif
>>>> +
>>>> +define HOST_FIP_INSTALL_SUBDIR
>>>> +??? $(INSTALL) -m 0755 -d $(HOST_DIR)/usr/bin/fip/
>>>> +endef
>>>> +
>>>> +define HOST_FIP_INSTALL_CMDS
>>>> +??? $(foreach b,$(HOST_FIP_LEPOTATO_BINARIES),
>>>> +??????? $(INSTALL) -D -m 755 $(@D)/$(b) $(HOST_DIR)/usr/bin/fip/)
>>>> +endef
>>>> +
>>>> +HOST_FIP_PRE_INSTALL_HOOKS += HOST_FIP_INSTALL_SUBDIR
>>>> +
>>>> +$(eval $(host-generic-package))
>>>>
>>>
>>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 0/3] board: Add support for LePotato
  2020-07-07 19:51 ` [Buildroot] [PATCH 0/3] board: Add support for LePotato Yann E. MORIN
@ 2020-07-09 11:58   ` Mylene Josserand
  0 siblings, 0 replies; 10+ messages in thread
From: Mylene Josserand @ 2020-07-09 11:58 UTC (permalink / raw)
  To: buildroot

Hello,

On 7/7/20 9:51 PM, Yann E. MORIN wrote:
> Myl?ne, All,
> 
> On 2020-07-07 09:53 +0200, Myl?ne Josserand spake thusly:
>> Here is my first version of this series that adds the support of the
>> board LePotato SBC from LibreComputer [1].
>>
>> This board uses FIP utilities [2][3] from AMLogic to sign u-boot.
> 
> Following the issues raised by Romain, I've marked patches 2-3 as
> "changes requested". Hopefully, gslimg is an interesting trail to follow
> as a free/libre replacement for the vendor stuff.

Sure, make sense, thanks!

> 
> I've applied patch 1 to master, thanks.

Thank you,

Best regards,
Myl?ne

> 
> Regards,
> Yann E. MORIN.
> 
>> The patch 02 is adding these FIP utilities as a host package. It is
>> available for different boards such as khadas-vim, some odroids, etc.
>> This package will copy the corresponding utilities, only for LePotato for
>> the moment, into the HOST_DIR/usr/bin. Currently, LePotato's ones are the
>> default ones. This should be updating once more boards are added.
>>
>> The patch 03 is adding the support of this board from LibreComputer:
>>     - one defconfig including a u-boot, kernel and minimal rootfs.
>>     The configuration is also enabling the FIP package for LePotato.
>>     - one post-build script that is using the FIP utilities to sign
>>     u-boot binary.
>>     - one post-image script to generate a sd-card image and flashing the
>>     signed u-boot on it.
>>     - a readme file to explain how to configure, compile and flash image
>>     for this board.
>>     - a boot.scr file including booti commands to run.
>>
>> Let me know if you have any comments on this series.
>>
>> Best regards,
>>
>> Myl?ne
>>
>> [1]: https://libre.computer/products/boards/aml-s905x-cc/
>> [2]: https://github.com/LibreELEC/amlogic-boot-fip
>> [3]: https://github.com/BayLibre/u-boot
>>
>> Myl?ne Josserand (3):
>>    DEVELOPERS: Update Mylene's email
>>    package: Add new fip package
>>    configs/lepotato: Add new defconfig
>>
>>   .gitlab-ci.yml                             |  1 +
>>   DEVELOPERS                                 |  4 +-
>>   board/librecomputer/lepotato/boot.cmd      |  6 +++
>>   board/librecomputer/lepotato/genimage.cfg  | 28 ++++++++++
>>   board/librecomputer/lepotato/post-build.sh | 61 ++++++++++++++++++++++
>>   board/librecomputer/lepotato/post-image.sh | 17 ++++++
>>   board/librecomputer/lepotato/readme.txt    | 35 +++++++++++++
>>   configs/lepotato_defconfig                 | 29 ++++++++++
>>   package/Config.in.host                     |  1 +
>>   package/fip/Config.in.host                 | 17 ++++++
>>   package/fip/fip.hash                       |  2 +
>>   package/fip/fip.mk                         | 30 +++++++++++
>>   12 files changed, 230 insertions(+), 1 deletion(-)
>>   create mode 100644 board/librecomputer/lepotato/boot.cmd
>>   create mode 100644 board/librecomputer/lepotato/genimage.cfg
>>   create mode 100755 board/librecomputer/lepotato/post-build.sh
>>   create mode 100755 board/librecomputer/lepotato/post-image.sh
>>   create mode 100644 board/librecomputer/lepotato/readme.txt
>>   create mode 100644 configs/lepotato_defconfig
>>   create mode 100644 package/fip/Config.in.host
>>   create mode 100644 package/fip/fip.hash
>>   create mode 100644 package/fip/fip.mk
>>
>> -- 
>> 2.27.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-07-09 11:58 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07  7:53 [Buildroot] [PATCH 0/3] board: Add support for LePotato Mylène Josserand
2020-07-07  7:53 ` [Buildroot] [PATCH 1/3] DEVELOPERS: Update Mylene's email Mylène Josserand
2020-07-07  7:53 ` [Buildroot] [PATCH 2/3] package: Add new fip package Mylène Josserand
2020-07-07 12:37   ` Romain Naour
2020-07-07 14:18     ` Mylene Josserand
2020-07-07 14:29       ` Romain Naour
2020-07-09 11:51         ` Mylene Josserand
2020-07-07  7:53 ` [Buildroot] [PATCH 3/3] configs/lepotato: Add new defconfig Mylène Josserand
2020-07-07 19:51 ` [Buildroot] [PATCH 0/3] board: Add support for LePotato Yann E. MORIN
2020-07-09 11:58   ` Mylene Josserand

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.