From: Harshvardhan Jha <harshvardhan.jha@oracle.com>
To: asmadeus@codewreck.org, Stefano Stabellini <sstabellini@kernel.org>
Cc: ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
kuba@kernel.org, v9fs-developer@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry
Date: Tue, 27 Jul 2021 05:31:13 +0530 [thread overview]
Message-ID: <e635a380-0954-2de3-838a-0e353f756b87@oracle.com> (raw)
In-Reply-To: <YP9MeeqOKcyYRxjK@codewreck.org>
On 27/07/21 5:29 am, asmadeus@codewreck.org wrote:
> Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700:
>>>> Yes, I did test it successfully. Aside from the commit messaged to be
>>>> reworded:
>>> How's this?
>>> ===========================BEGIN========================================
>>> 9p/xen: Fix end of loop tests for list_for_each_entry
>>>
>>> This patch addresses the following problems:
>>> - priv can never be NULL, so this part of the check is useless
>>> - if the loop ran through the whole list, priv->client is invalid and
>>> it is more appropriate and sufficient to check for the end of
>>> list_for_each_entry loop condition.
>>>
>>> Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
>
> Will take the patch with this text as commit message later tonight
If you want I can resend the patch with this commit message
>
>
>>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>>> Tested-by: Stefano Stabellini <sstabellini@kernel.org>
>
> Thanks for the test!
>
next prev parent reply other threads:[~2021-07-27 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 17:51 [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry Harshvardhan Jha
2021-07-25 20:46 ` asmadeus
2021-07-26 21:30 ` Stefano Stabellini
2021-07-26 22:23 ` [External] : " Harshvardhan Jha
2021-07-26 23:54 ` Stefano Stabellini
2021-07-26 23:59 ` asmadeus
2021-07-27 0:01 ` Harshvardhan Jha [this message]
2021-07-27 0:07 ` Harshvardhan Jha
2021-07-27 14:07 ` asmadeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e635a380-0954-2de3-838a-0e353f756b87@oracle.com \
--to=harshvardhan.jha@oracle.com \
--cc=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.