All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, alastair@d-silva.org
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh@kernel.org>,
	"Anton Blanchard" <anton@ozlabs.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
	"Madhavan Srinivasan" <maddy@linux.vnet.ibm.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Anju T Sudhakar" <anju@linux.vnet.ibm.com>,
	"Hari Bathini" <hbathini@linux.ibm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Greg Kurz" <groug@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 24/27] powerpc/powernv/pmem: Expose SMART data via ndctl
Date: Thu, 5 Mar 2020 14:36:13 +1100	[thread overview]
Message-ID: <e68c9064-cb7f-2b5e-9a7b-70fd5367270a@linux.ibm.com> (raw)
In-Reply-To: <20200221032720.33893-25-alastair@au1.ibm.com>

On 21/2/20 2:27 pm, Alastair D'Silva wrote:
> +static int ndctl_smart(struct ocxlpmem *ocxlpmem, struct nd_cmd_pkg *pkg)
> +{
> +	u32 length, i;
> +	struct nd_ocxl_smart *out;
> +	int rc;
> +
> +	mutex_lock(&ocxlpmem->admin_command.lock);
> +
> +	rc = admin_command_request(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_execute(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_complete_timeout(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc < 0) {
> +		dev_err(&ocxlpmem->dev, "SMART timeout\n");
> +		goto out;
> +	}
> +
> +	rc = admin_response(ocxlpmem);
> +	if (rc < 0)
> +		goto out;
> +	if (rc != STATUS_SUCCESS) {
> +		warn_status(ocxlpmem, "Unexpected status from SMART", rc);
> +		goto out;
> +	}
> +
> +	rc = smart_header_parse(ocxlpmem, &length);
> +	if (rc)
> +		goto out;
> +
> +	pkg->nd_fw_size = length;
> +
> +	length = min(length, pkg->nd_size_out); // bytes
> +	out = (struct nd_ocxl_smart *)pkg->nd_payload;
> +	// Each SMART attribute is 2 * 64 bits
> +	out->count = length / (2 * sizeof(u64)); // attributes

 From what I can tell - 8 bytes of nd_ocxl_smart are taken up for the 
count + reserved bytes, so this is going to potentially overrun the user 
buffer.

> +
> +	for (i = 0; i < length; i += sizeof(u64)) {

It might be neater to make i count up by 1 and then multiply by 
sizeof(u64) later.

> +		rc = ocxl_global_mmio_read64(ocxlpmem->ocxl_afu,
> +					     ocxlpmem->admin_command.data_offset + sizeof(u64) + i,

+ 0x08 rather than + sizeof(u64) for consistency.

> +					     OCXL_LITTLE_ENDIAN,
> +					     &out->attribs[i/sizeof(u64)]);
> +		if (rc)
> +			goto out;
> +	}
> +
> +	rc = admin_response_handled(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = 0;
> +	goto out;
> +
> +out:
> +	mutex_unlock(&ocxlpmem->admin_command.lock);
> +	return rc;
> +}
> +
> +static int ndctl_call(struct ocxlpmem *ocxlpmem, void *buf, unsigned int buf_len)
> +{
> +	struct nd_cmd_pkg *pkg = buf;
> +
> +	if (buf_len < sizeof(struct nd_cmd_pkg)) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL size=%u\n", buf_len);
> +		return -EINVAL;
> +	}
> +
> +	if (pkg->nd_family != NVDIMM_FAMILY_OCXL) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL family=0x%llx\n", pkg->nd_family);
> +		return -EINVAL;
> +	}
> +
> +	switch (pkg->nd_command) {
> +	case ND_CMD_OCXL_SMART:
> +		ndctl_smart(ocxlpmem, pkg);

Did you intend to dispose of the return code here?

> +		break;
> +
> +	default:
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL command=0x%llx\n", pkg->nd_command);
> +		return -EINVAL;
> +	}
> +
> +
> +	return 0;
> +}
> +
>   static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   		 struct nvdimm *nvdimm,
>   		 unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc)
> @@ -88,6 +211,10 @@ static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   	struct ocxlpmem *ocxlpmem = container_of(nd_desc, struct ocxlpmem, bus_desc);
>   
>   	switch (cmd) {
> +	case ND_CMD_CALL:
> +		*cmd_rc = ndctl_call(ocxlpmem, buf, buf_len);
> +		return 0;
> +
>   	case ND_CMD_GET_CONFIG_SIZE:
>   		*cmd_rc = ndctl_config_size(buf);
>   		return 0;
> @@ -171,6 +298,7 @@ static int register_lpc_mem(struct ocxlpmem *ocxlpmem)
>   	set_bit(ND_CMD_GET_CONFIG_SIZE, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_GET_CONFIG_DATA, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_SET_CONFIG_DATA, &nvdimm_cmd_mask);
> +	set_bit(ND_CMD_CALL, &nvdimm_cmd_mask);
>   
>   	set_bit(NDD_ALIASING, &nvdimm_flags);
>   
> diff --git a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> index 927690f4888f..0eb7a35d24ae 100644
> --- a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> +++ b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> @@ -7,6 +7,7 @@
>   #include <linux/libnvdimm.h>
>   #include <uapi/nvdimm/ocxl-pmem.h>
>   #include <linux/mm.h>
> +#include <linux/ndctl.h>
>   
>   #define LABEL_AREA_SIZE	(1UL << PA_SECTION_SHIFT)
>   #define DEFAULT_TIMEOUT 100
> @@ -98,6 +99,23 @@ struct ocxlpmem_function0 {
>   	struct ocxl_fn *ocxl_fn;
>   };
>   
> +struct nd_ocxl_smart {
> +	__u8 count;
> +	__u8 reserved[7];
> +	__u64 attribs[0];
> +} __packed;
> +
> +struct nd_pkg_ocxl {
> +	struct nd_cmd_pkg gen;
> +	union {
> +		struct nd_ocxl_smart smart;
> +	};
> +};
> +
> +enum nd_cmd_ocxl {
> +	ND_CMD_OCXL_SMART = 1,
> +};
> +
>   struct ocxlpmem {
>   	struct device dev;
>   	struct pci_dev *pdev;
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index de5d90212409..2885052e7f40 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -244,6 +244,7 @@ struct nd_cmd_pkg {
>   #define NVDIMM_FAMILY_HPE2 2
>   #define NVDIMM_FAMILY_MSFT 3
>   #define NVDIMM_FAMILY_HYPERV 4
> +#define NVDIMM_FAMILY_OCXL 6
>   
>   #define ND_IOCTL_CALL			_IOWR(ND_IOCTL, ND_CMD_CALL,\
>   					struct nd_cmd_pkg)
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, alastair@d-silva.org
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh@kernel.org>,
	"Anton Blanchard" <anton@ozlabs.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
	"Madhavan Srinivasan" <maddy@linux.vnet.ibm.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Anju T Sudhakar" <anju@linux.vnet.ibm.com>,
	"Hari Bathini" <hbathini@linux.ibm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Greg Kurz" <groug@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-nvdimm@lists.01.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 24/27] powerpc/powernv/pmem: Expose SMART data via ndctl
Date: Thu, 5 Mar 2020 14:36:13 +1100	[thread overview]
Message-ID: <e68c9064-cb7f-2b5e-9a7b-70fd5367270a@linux.ibm.com> (raw)
In-Reply-To: <20200221032720.33893-25-alastair@au1.ibm.com>

On 21/2/20 2:27 pm, Alastair D'Silva wrote:
> +static int ndctl_smart(struct ocxlpmem *ocxlpmem, struct nd_cmd_pkg *pkg)
> +{
> +	u32 length, i;
> +	struct nd_ocxl_smart *out;
> +	int rc;
> +
> +	mutex_lock(&ocxlpmem->admin_command.lock);
> +
> +	rc = admin_command_request(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_execute(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_complete_timeout(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc < 0) {
> +		dev_err(&ocxlpmem->dev, "SMART timeout\n");
> +		goto out;
> +	}
> +
> +	rc = admin_response(ocxlpmem);
> +	if (rc < 0)
> +		goto out;
> +	if (rc != STATUS_SUCCESS) {
> +		warn_status(ocxlpmem, "Unexpected status from SMART", rc);
> +		goto out;
> +	}
> +
> +	rc = smart_header_parse(ocxlpmem, &length);
> +	if (rc)
> +		goto out;
> +
> +	pkg->nd_fw_size = length;
> +
> +	length = min(length, pkg->nd_size_out); // bytes
> +	out = (struct nd_ocxl_smart *)pkg->nd_payload;
> +	// Each SMART attribute is 2 * 64 bits
> +	out->count = length / (2 * sizeof(u64)); // attributes

 From what I can tell - 8 bytes of nd_ocxl_smart are taken up for the 
count + reserved bytes, so this is going to potentially overrun the user 
buffer.

> +
> +	for (i = 0; i < length; i += sizeof(u64)) {

It might be neater to make i count up by 1 and then multiply by 
sizeof(u64) later.

> +		rc = ocxl_global_mmio_read64(ocxlpmem->ocxl_afu,
> +					     ocxlpmem->admin_command.data_offset + sizeof(u64) + i,

+ 0x08 rather than + sizeof(u64) for consistency.

> +					     OCXL_LITTLE_ENDIAN,
> +					     &out->attribs[i/sizeof(u64)]);
> +		if (rc)
> +			goto out;
> +	}
> +
> +	rc = admin_response_handled(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = 0;
> +	goto out;
> +
> +out:
> +	mutex_unlock(&ocxlpmem->admin_command.lock);
> +	return rc;
> +}
> +
> +static int ndctl_call(struct ocxlpmem *ocxlpmem, void *buf, unsigned int buf_len)
> +{
> +	struct nd_cmd_pkg *pkg = buf;
> +
> +	if (buf_len < sizeof(struct nd_cmd_pkg)) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL size=%u\n", buf_len);
> +		return -EINVAL;
> +	}
> +
> +	if (pkg->nd_family != NVDIMM_FAMILY_OCXL) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL family=0x%llx\n", pkg->nd_family);
> +		return -EINVAL;
> +	}
> +
> +	switch (pkg->nd_command) {
> +	case ND_CMD_OCXL_SMART:
> +		ndctl_smart(ocxlpmem, pkg);

Did you intend to dispose of the return code here?

> +		break;
> +
> +	default:
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL command=0x%llx\n", pkg->nd_command);
> +		return -EINVAL;
> +	}
> +
> +
> +	return 0;
> +}
> +
>   static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   		 struct nvdimm *nvdimm,
>   		 unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc)
> @@ -88,6 +211,10 @@ static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   	struct ocxlpmem *ocxlpmem = container_of(nd_desc, struct ocxlpmem, bus_desc);
>   
>   	switch (cmd) {
> +	case ND_CMD_CALL:
> +		*cmd_rc = ndctl_call(ocxlpmem, buf, buf_len);
> +		return 0;
> +
>   	case ND_CMD_GET_CONFIG_SIZE:
>   		*cmd_rc = ndctl_config_size(buf);
>   		return 0;
> @@ -171,6 +298,7 @@ static int register_lpc_mem(struct ocxlpmem *ocxlpmem)
>   	set_bit(ND_CMD_GET_CONFIG_SIZE, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_GET_CONFIG_DATA, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_SET_CONFIG_DATA, &nvdimm_cmd_mask);
> +	set_bit(ND_CMD_CALL, &nvdimm_cmd_mask);
>   
>   	set_bit(NDD_ALIASING, &nvdimm_flags);
>   
> diff --git a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> index 927690f4888f..0eb7a35d24ae 100644
> --- a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> +++ b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> @@ -7,6 +7,7 @@
>   #include <linux/libnvdimm.h>
>   #include <uapi/nvdimm/ocxl-pmem.h>
>   #include <linux/mm.h>
> +#include <linux/ndctl.h>
>   
>   #define LABEL_AREA_SIZE	(1UL << PA_SECTION_SHIFT)
>   #define DEFAULT_TIMEOUT 100
> @@ -98,6 +99,23 @@ struct ocxlpmem_function0 {
>   	struct ocxl_fn *ocxl_fn;
>   };
>   
> +struct nd_ocxl_smart {
> +	__u8 count;
> +	__u8 reserved[7];
> +	__u64 attribs[0];
> +} __packed;
> +
> +struct nd_pkg_ocxl {
> +	struct nd_cmd_pkg gen;
> +	union {
> +		struct nd_ocxl_smart smart;
> +	};
> +};
> +
> +enum nd_cmd_ocxl {
> +	ND_CMD_OCXL_SMART = 1,
> +};
> +
>   struct ocxlpmem {
>   	struct device dev;
>   	struct pci_dev *pdev;
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index de5d90212409..2885052e7f40 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -244,6 +244,7 @@ struct nd_cmd_pkg {
>   #define NVDIMM_FAMILY_HPE2 2
>   #define NVDIMM_FAMILY_MSFT 3
>   #define NVDIMM_FAMILY_HYPERV 4
> +#define NVDIMM_FAMILY_OCXL 6
>   
>   #define ND_IOCTL_CALL			_IOWR(ND_IOCTL, ND_CMD_CALL,\
>   					struct nd_cmd_pkg)
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, alastair@d-silva.org
Cc: "Madhavan Srinivasan" <maddy@linux.vnet.ibm.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Dave Jiang" <dave.jiang@intel.com>,
	linux-nvdimm@lists.01.org,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Anju T Sudhakar" <anju@linux.vnet.ibm.com>,
	"Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
	"Arnd Bergmann" <arnd@arndb.de>, "Greg Kurz" <groug@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Hari Bathini" <hbathini@linux.ibm.com>,
	linux-mm@kvack.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Vishal Verma" <vishal.l.verma@intel.com>,
	"Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 24/27] powerpc/powernv/pmem: Expose SMART data via ndctl
Date: Thu, 5 Mar 2020 14:36:13 +1100	[thread overview]
Message-ID: <e68c9064-cb7f-2b5e-9a7b-70fd5367270a@linux.ibm.com> (raw)
In-Reply-To: <20200221032720.33893-25-alastair@au1.ibm.com>

On 21/2/20 2:27 pm, Alastair D'Silva wrote:
> +static int ndctl_smart(struct ocxlpmem *ocxlpmem, struct nd_cmd_pkg *pkg)
> +{
> +	u32 length, i;
> +	struct nd_ocxl_smart *out;
> +	int rc;
> +
> +	mutex_lock(&ocxlpmem->admin_command.lock);
> +
> +	rc = admin_command_request(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_execute(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = admin_command_complete_timeout(ocxlpmem, ADMIN_COMMAND_SMART);
> +	if (rc < 0) {
> +		dev_err(&ocxlpmem->dev, "SMART timeout\n");
> +		goto out;
> +	}
> +
> +	rc = admin_response(ocxlpmem);
> +	if (rc < 0)
> +		goto out;
> +	if (rc != STATUS_SUCCESS) {
> +		warn_status(ocxlpmem, "Unexpected status from SMART", rc);
> +		goto out;
> +	}
> +
> +	rc = smart_header_parse(ocxlpmem, &length);
> +	if (rc)
> +		goto out;
> +
> +	pkg->nd_fw_size = length;
> +
> +	length = min(length, pkg->nd_size_out); // bytes
> +	out = (struct nd_ocxl_smart *)pkg->nd_payload;
> +	// Each SMART attribute is 2 * 64 bits
> +	out->count = length / (2 * sizeof(u64)); // attributes

 From what I can tell - 8 bytes of nd_ocxl_smart are taken up for the 
count + reserved bytes, so this is going to potentially overrun the user 
buffer.

> +
> +	for (i = 0; i < length; i += sizeof(u64)) {

It might be neater to make i count up by 1 and then multiply by 
sizeof(u64) later.

> +		rc = ocxl_global_mmio_read64(ocxlpmem->ocxl_afu,
> +					     ocxlpmem->admin_command.data_offset + sizeof(u64) + i,

+ 0x08 rather than + sizeof(u64) for consistency.

> +					     OCXL_LITTLE_ENDIAN,
> +					     &out->attribs[i/sizeof(u64)]);
> +		if (rc)
> +			goto out;
> +	}
> +
> +	rc = admin_response_handled(ocxlpmem);
> +	if (rc)
> +		goto out;
> +
> +	rc = 0;
> +	goto out;
> +
> +out:
> +	mutex_unlock(&ocxlpmem->admin_command.lock);
> +	return rc;
> +}
> +
> +static int ndctl_call(struct ocxlpmem *ocxlpmem, void *buf, unsigned int buf_len)
> +{
> +	struct nd_cmd_pkg *pkg = buf;
> +
> +	if (buf_len < sizeof(struct nd_cmd_pkg)) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL size=%u\n", buf_len);
> +		return -EINVAL;
> +	}
> +
> +	if (pkg->nd_family != NVDIMM_FAMILY_OCXL) {
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL family=0x%llx\n", pkg->nd_family);
> +		return -EINVAL;
> +	}
> +
> +	switch (pkg->nd_command) {
> +	case ND_CMD_OCXL_SMART:
> +		ndctl_smart(ocxlpmem, pkg);

Did you intend to dispose of the return code here?

> +		break;
> +
> +	default:
> +		dev_err(&ocxlpmem->dev, "Invalid ND_CALL command=0x%llx\n", pkg->nd_command);
> +		return -EINVAL;
> +	}
> +
> +
> +	return 0;
> +}
> +
>   static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   		 struct nvdimm *nvdimm,
>   		 unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc)
> @@ -88,6 +211,10 @@ static int ndctl(struct nvdimm_bus_descriptor *nd_desc,
>   	struct ocxlpmem *ocxlpmem = container_of(nd_desc, struct ocxlpmem, bus_desc);
>   
>   	switch (cmd) {
> +	case ND_CMD_CALL:
> +		*cmd_rc = ndctl_call(ocxlpmem, buf, buf_len);
> +		return 0;
> +
>   	case ND_CMD_GET_CONFIG_SIZE:
>   		*cmd_rc = ndctl_config_size(buf);
>   		return 0;
> @@ -171,6 +298,7 @@ static int register_lpc_mem(struct ocxlpmem *ocxlpmem)
>   	set_bit(ND_CMD_GET_CONFIG_SIZE, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_GET_CONFIG_DATA, &nvdimm_cmd_mask);
>   	set_bit(ND_CMD_SET_CONFIG_DATA, &nvdimm_cmd_mask);
> +	set_bit(ND_CMD_CALL, &nvdimm_cmd_mask);
>   
>   	set_bit(NDD_ALIASING, &nvdimm_flags);
>   
> diff --git a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> index 927690f4888f..0eb7a35d24ae 100644
> --- a/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> +++ b/arch/powerpc/platforms/powernv/pmem/ocxl_internal.h
> @@ -7,6 +7,7 @@
>   #include <linux/libnvdimm.h>
>   #include <uapi/nvdimm/ocxl-pmem.h>
>   #include <linux/mm.h>
> +#include <linux/ndctl.h>
>   
>   #define LABEL_AREA_SIZE	(1UL << PA_SECTION_SHIFT)
>   #define DEFAULT_TIMEOUT 100
> @@ -98,6 +99,23 @@ struct ocxlpmem_function0 {
>   	struct ocxl_fn *ocxl_fn;
>   };
>   
> +struct nd_ocxl_smart {
> +	__u8 count;
> +	__u8 reserved[7];
> +	__u64 attribs[0];
> +} __packed;
> +
> +struct nd_pkg_ocxl {
> +	struct nd_cmd_pkg gen;
> +	union {
> +		struct nd_ocxl_smart smart;
> +	};
> +};
> +
> +enum nd_cmd_ocxl {
> +	ND_CMD_OCXL_SMART = 1,
> +};
> +
>   struct ocxlpmem {
>   	struct device dev;
>   	struct pci_dev *pdev;
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index de5d90212409..2885052e7f40 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -244,6 +244,7 @@ struct nd_cmd_pkg {
>   #define NVDIMM_FAMILY_HPE2 2
>   #define NVDIMM_FAMILY_MSFT 3
>   #define NVDIMM_FAMILY_HYPERV 4
> +#define NVDIMM_FAMILY_OCXL 6
>   
>   #define ND_IOCTL_CALL			_IOWR(ND_IOCTL, ND_CMD_CALL,\
>   					struct nd_cmd_pkg)
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited


  parent reply	other threads:[~2020-03-05  3:36 UTC|newest]

Thread overview: 391+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21  3:26 [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices Alastair D'Silva
2020-02-21  3:26 ` Alastair D'Silva
2020-02-21  3:26 ` Alastair D'Silva
2020-02-21  3:26 ` [PATCH v3 01/27] powerpc: Add OPAL calls for LPC memory alloc/release Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-24  5:49   ` Andrew Donnellan
2020-02-24  5:49     ` Andrew Donnellan
2020-02-24  5:49     ` Andrew Donnellan
2020-02-24  5:50     ` Alastair D'Silva
2020-02-24  5:50       ` Alastair D'Silva
2020-02-24  5:50       ` Alastair D'Silva
2020-02-21  3:26 ` [PATCH v3 02/27] mm/memory_hotplug: Allow check_hotplug_memory_addressable to be called from drivers Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  7:03   ` Andrew Donnellan
2020-02-21  7:03     ` Andrew Donnellan
2020-02-21  7:03     ` Andrew Donnellan
2020-02-21  3:26 ` [PATCH v3 03/27] powerpc: Map & release OpenCAPI LPC memory Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-24  2:51   ` Andrew Donnellan
2020-02-24  2:51     ` Andrew Donnellan
2020-02-24  2:51     ` Andrew Donnellan
2020-02-24  5:49     ` Andrew Donnellan
2020-02-24  5:49       ` Andrew Donnellan
2020-02-24  5:49       ` Andrew Donnellan
2020-02-25 10:02   ` Frederic Barrat
2020-02-25 10:02     ` Frederic Barrat
2020-02-25 10:02     ` Frederic Barrat
2020-02-26  0:19     ` Alastair D'Silva
2020-02-26  0:19       ` Alastair D'Silva
2020-02-26  0:19       ` Alastair D'Silva
2020-03-03  6:10   ` Andrew Donnellan
2020-03-03  6:10     ` Andrew Donnellan
2020-03-03  6:10     ` Andrew Donnellan
2020-03-04  5:33     ` Alastair D'Silva
2020-03-04  5:33       ` Alastair D'Silva
2020-03-04  5:33       ` Alastair D'Silva
2020-02-21  3:26 ` [PATCH v3 04/27] ocxl: Remove unnecessary externs Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  6:06   ` Andrew Donnellan
2020-02-21  6:06     ` Andrew Donnellan
2020-02-21  6:06     ` Andrew Donnellan
2020-02-25 13:23   ` Frederic Barrat
2020-02-25 13:23     ` Frederic Barrat
2020-02-25 13:23     ` Frederic Barrat
2020-02-26  8:14   ` Baoquan He
2020-02-26  8:14     ` Baoquan He
2020-02-26  8:14     ` Baoquan He
2020-02-26  8:26     ` Alastair D'Silva
2020-02-26  8:26       ` Alastair D'Silva
2020-02-26  8:26       ` Alastair D'Silva
2020-02-26  9:01       ` Greg Kurz
2020-02-26  9:01         ` Greg Kurz
2020-02-26  9:01         ` Greg Kurz
2020-02-26 14:15         ` 'Baoquan He'
2020-02-26 14:15           ` 'Baoquan He'
2020-02-26 14:15           ` 'Baoquan He'
2020-02-26 14:20           ` Greg Kurz
2020-02-26 14:20             ` Greg Kurz
2020-02-26 14:20             ` Greg Kurz
2020-02-26 14:54             ` 'Baoquan He'
2020-02-26 14:54               ` 'Baoquan He'
2020-02-26 14:54               ` 'Baoquan He'
2020-02-21  3:26 ` [PATCH v3 05/27] ocxl: Address kernel doc errors & warnings Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-24  2:11   ` Andrew Donnellan
2020-02-24  2:11     ` Andrew Donnellan
2020-02-24  2:11     ` Andrew Donnellan
2020-02-21  3:26 ` [PATCH v3 06/27] ocxl: Tally up the LPC memory on a link & allow it to be mapped Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-21  3:26   ` Alastair D'Silva
2020-02-24  5:25   ` Andrew Donnellan
2020-02-24  5:25     ` Andrew Donnellan
2020-02-24  5:25     ` Andrew Donnellan
2020-02-24  5:36     ` Alastair D'Silva
2020-02-24  5:36       ` Alastair D'Silva
2020-02-24  5:36       ` Alastair D'Silva
2020-02-25 16:30   ` Frederic Barrat
2020-02-25 16:30     ` Frederic Barrat
2020-02-25 16:30     ` Frederic Barrat
2020-02-26  0:29     ` Alastair D'Silva
2020-02-26  0:29       ` Alastair D'Silva
2020-02-26  0:29       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 07/27] ocxl: Add functions to map/unmap LPC memory Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-24  6:02   ` Andrew Donnellan
2020-02-24  6:02     ` Andrew Donnellan
2020-02-24  6:02     ` Andrew Donnellan
2020-02-24  6:08     ` Alastair D'Silva
2020-02-24  6:08       ` Alastair D'Silva
2020-02-24  6:08       ` Alastair D'Silva
2020-02-25 17:01   ` Frederic Barrat
2020-02-25 17:01     ` Frederic Barrat
2020-02-25 17:01     ` Frederic Barrat
2020-02-21  3:27 ` [PATCH v3 08/27] ocxl: Emit a log message showing how much LPC memory was detected Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-24  6:06   ` Andrew Donnellan
2020-02-24  6:06     ` Andrew Donnellan
2020-02-24  6:06     ` Andrew Donnellan
2020-02-24  6:10     ` Alastair D'Silva
2020-02-24  6:10       ` Alastair D'Silva
2020-02-24  6:10       ` Alastair D'Silva
2020-02-24  6:13       ` Andrew Donnellan
2020-02-24  6:13         ` Andrew Donnellan
2020-02-24  6:13         ` Andrew Donnellan
2020-02-25 17:03   ` Frederic Barrat
2020-02-25 17:03     ` Frederic Barrat
2020-02-25 17:03     ` Frederic Barrat
2020-02-21  3:27 ` [PATCH v3 09/27] ocxl: Save the device serial number in ocxl_fn Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 10/27] powerpc: Add driver for OpenCAPI Persistent Memory Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-26  5:07   ` Andrew Donnellan
2020-02-26  5:07     ` Andrew Donnellan
2020-02-26  5:07     ` Andrew Donnellan
2020-02-26  5:49     ` Alastair D'Silva
2020-02-26  5:49       ` Alastair D'Silva
2020-02-26  5:49       ` Alastair D'Silva
2020-02-27 20:44   ` Frederic Barrat
2020-02-27 20:44     ` Frederic Barrat
2020-02-27 20:44     ` Frederic Barrat
2020-02-28  0:54     ` Alastair D'Silva
2020-02-28  0:54       ` Alastair D'Silva
2020-02-28  0:54       ` Alastair D'Silva
2020-02-28 18:32   ` Frederic Barrat
2020-02-28 18:32     ` Frederic Barrat
2020-02-28 18:32     ` Frederic Barrat
2020-02-21  3:27 ` [PATCH v3 11/27] powerpc: Enable the OpenCAPI Persistent Memory driver for powernv_defconfig Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-25  3:01   ` Andrew Donnellan
2020-02-25  3:01     ` Andrew Donnellan
2020-02-25  3:01     ` Andrew Donnellan
2020-02-21  3:27 ` [PATCH v3 12/27] powerpc/powernv/pmem: Add register addresses & status values to the header Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-27  5:08   ` Andrew Donnellan
2020-02-27  5:08     ` Andrew Donnellan
2020-02-27  5:08     ` Andrew Donnellan
2020-02-27  5:16     ` Alastair D'Silva
2020-02-27  5:16       ` Alastair D'Silva
2020-02-27  5:16       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 13/27] powerpc/powernv/pmem: Read the capability registers & wait for device ready Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-27  3:54   ` Andrew Donnellan
2020-02-27  3:54     ` Andrew Donnellan
2020-02-27  3:54     ` Andrew Donnellan
2020-02-27  3:58     ` Alastair D'Silva
2020-02-27  3:58       ` Alastair D'Silva
2020-02-27  3:58       ` Alastair D'Silva
2020-03-02 17:51   ` Frederic Barrat
2020-03-02 17:51     ` Frederic Barrat
2020-03-02 17:51     ` Frederic Barrat
2020-03-04  4:15     ` Alastair D'Silva
2020-03-04  4:15       ` Alastair D'Silva
2020-03-04  4:15       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 14/27] powerpc/powernv/pmem: Add support for Admin commands Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-27  8:22   ` Andrew Donnellan
2020-02-27  8:22     ` Andrew Donnellan
2020-02-27  8:22     ` Andrew Donnellan
2020-02-27  8:27     ` Andrew Donnellan
2020-02-27  8:27       ` Andrew Donnellan
2020-02-27  8:27       ` Andrew Donnellan
2020-02-27 23:54       ` Alastair D'Silva
2020-02-27 23:54         ` Alastair D'Silva
2020-02-27 23:54         ` Alastair D'Silva
2020-02-27 23:51     ` Alastair D'Silva
2020-02-27 23:51       ` Alastair D'Silva
2020-02-27 23:51       ` Alastair D'Silva
2020-02-27 17:01   ` Dan Williams
2020-02-27 17:01     ` Dan Williams
2020-02-27 17:01     ` Dan Williams
2020-02-27 23:57     ` Alastair D'Silva
2020-02-27 23:57       ` Alastair D'Silva
2020-02-27 23:57       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 15/27] powerpc/powernv/pmem: Add support for near storage commands Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-27  8:30   ` Andrew Donnellan
2020-02-27  8:30     ` Andrew Donnellan
2020-02-27  8:30     ` Andrew Donnellan
2020-02-27 23:56     ` Alastair D'Silva
2020-02-27 23:56       ` Alastair D'Silva
2020-02-27 23:56       ` Alastair D'Silva
2020-02-27 17:02   ` Dan Williams
2020-02-27 17:02     ` Dan Williams
2020-02-27 17:02     ` Dan Williams
2020-03-02 17:58   ` Frederic Barrat
2020-03-02 17:58     ` Frederic Barrat
2020-03-02 17:58     ` Frederic Barrat
2020-03-02 18:42     ` Dan Williams
2020-03-02 18:42       ` Dan Williams
2020-03-02 18:42       ` Dan Williams
2020-03-04  4:42       ` Alastair D'Silva
2020-03-04  4:42         ` Alastair D'Silva
2020-03-04  4:42         ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 16/27] powerpc/powernv/pmem: Register a character device for userspace to interact with Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-02  5:34   ` Andrew Donnellan
2020-03-02  5:34     ` Andrew Donnellan
2020-03-02  5:34     ` Andrew Donnellan
2020-03-02  6:05     ` Alastair D'Silva
2020-03-02  6:05       ` Alastair D'Silva
2020-03-02  6:05       ` Alastair D'Silva
2020-03-03  9:28   ` Frederic Barrat
2020-03-03  9:28     ` Frederic Barrat
2020-03-03  9:28     ` Frederic Barrat
2020-03-05  3:38     ` Alastair D'Silva
2020-03-05  3:38       ` Alastair D'Silva
2020-03-05  3:38       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 17/27] powerpc/powernv/pmem: Implement the Read Error Log command Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-03 10:36   ` Frederic Barrat
2020-03-03 10:36     ` Frederic Barrat
2020-03-03 10:36     ` Frederic Barrat
2020-03-05  4:31     ` Alastair D'Silva
2020-03-05  4:31       ` Alastair D'Silva
2020-03-05  4:31       ` Alastair D'Silva
2020-03-05  9:33       ` Frederic Barrat
2020-03-05  9:33         ` Frederic Barrat
2020-03-05  9:33         ` Frederic Barrat
2020-03-04  5:58   ` Andrew Donnellan
2020-03-04  5:58     ` Andrew Donnellan
2020-03-04  5:58     ` Andrew Donnellan
2020-02-21  3:27 ` [PATCH v3 18/27] powerpc/powernv/pmem: Add controller dump IOCTLs Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-03 18:04   ` Frederic Barrat
2020-03-03 18:04     ` Frederic Barrat
2020-03-03 18:04     ` Frederic Barrat
2020-03-05 23:37     ` Alastair D'Silva
2020-03-05 23:37       ` Alastair D'Silva
2020-03-05 23:37       ` Alastair D'Silva
2020-03-04  6:53   ` Andrew Donnellan
2020-03-04  6:53     ` Andrew Donnellan
2020-03-04  6:53     ` Andrew Donnellan
2020-03-06  3:34     ` Alastair D'Silva
2020-03-06  3:34       ` Alastair D'Silva
2020-03-06  3:34       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 19/27] powerpc/powernv/pmem: Add an IOCTL to report controller statistics Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-04  9:25   ` Frederic Barrat
2020-03-04  9:25     ` Frederic Barrat
2020-03-04  9:25     ` Frederic Barrat
2020-03-12  0:15     ` Alastair D'Silva
2020-03-12  0:15       ` Alastair D'Silva
2020-03-12  0:15       ` Alastair D'Silva
2020-03-05  0:46   ` Andrew Donnellan
2020-03-05  0:46     ` Andrew Donnellan
2020-03-05  0:46     ` Andrew Donnellan
2020-03-12  4:47     ` Alastair D'Silva
2020-03-12  4:47       ` Alastair D'Silva
2020-03-12  4:47       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 20/27] powerpc/powernv/pmem: Forward events to userspace Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-03  7:02   ` Andrew Donnellan
2020-03-03  7:02     ` Andrew Donnellan
2020-03-03  7:02     ` Andrew Donnellan
2020-03-04  5:48     ` Alastair D'Silva
2020-03-04  5:48       ` Alastair D'Silva
2020-03-04  5:48       ` Alastair D'Silva
2020-03-04 11:00   ` Frederic Barrat
2020-03-04 11:00     ` Frederic Barrat
2020-03-04 11:00     ` Frederic Barrat
2020-03-11  3:32     ` Alastair D'Silva
2020-03-11  3:32       ` Alastair D'Silva
2020-03-11  3:32       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 21/27] powerpc/powernv/pmem: Add an IOCTL to request controller health & perf data Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-28  6:12   ` Andrew Donnellan
2020-02-28  6:12     ` Andrew Donnellan
2020-02-28  6:12     ` Andrew Donnellan
2020-03-02  5:40     ` Alastair D'Silva
2020-03-02  5:40       ` Alastair D'Silva
2020-03-02  5:40       ` Alastair D'Silva
2020-03-04 11:06     ` Frederic Barrat
2020-03-04 11:06       ` Frederic Barrat
2020-03-04 11:06       ` Frederic Barrat
2020-03-11  3:38       ` Alastair D'Silva
2020-03-11  3:38         ` Alastair D'Silva
2020-03-11  3:38         ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 22/27] powerpc/powernv/pmem: Implement the heartbeat command Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-28  6:20   ` Andrew Donnellan
2020-02-28  6:20     ` Andrew Donnellan
2020-02-28  6:20     ` Andrew Donnellan
2020-03-04 14:25   ` Frederic Barrat
2020-03-04 14:25     ` Frederic Barrat
2020-03-04 14:25     ` Frederic Barrat
2020-02-21  3:27 ` [PATCH v3 23/27] powerpc/powernv/pmem: Add debug IOCTLs Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-01 22:01   ` kbuild test robot
2020-03-04 15:21   ` Frederic Barrat
2020-03-04 15:21     ` Frederic Barrat
2020-03-04 15:21     ` Frederic Barrat
2020-03-12  4:24     ` Alastair D'Silva
2020-03-12  4:24       ` Alastair D'Silva
2020-03-12  4:24       ` Alastair D'Silva
2020-03-05  3:11   ` Andrew Donnellan
2020-03-05  3:11     ` Andrew Donnellan
2020-03-05  3:11     ` Andrew Donnellan
2020-03-12  4:58     ` Alastair D'Silva
2020-03-12  4:58       ` Alastair D'Silva
2020-03-12  4:58       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 24/27] powerpc/powernv/pmem: Expose SMART data via ndctl Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-04 15:40   ` Frederic Barrat
2020-03-04 15:40     ` Frederic Barrat
2020-03-04 15:40     ` Frederic Barrat
2020-03-05  3:36   ` Andrew Donnellan [this message]
2020-03-05  3:36     ` Andrew Donnellan
2020-03-05  3:36     ` Andrew Donnellan
2020-03-12 23:14     ` Alastair D'Silva
2020-03-12 23:14       ` Alastair D'Silva
2020-03-12 23:14       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 25/27] powerpc/powernv/pmem: Expose the serial number in sysfs Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-28  6:25   ` Andrew Donnellan
2020-02-28  6:25     ` Andrew Donnellan
2020-02-28  6:25     ` Andrew Donnellan
2020-02-28  7:15     ` Greg Kroah-Hartman
2020-02-28  7:15       ` Greg Kroah-Hartman
2020-02-28  7:15       ` Greg Kroah-Hartman
2020-03-01 23:42       ` Alastair D'Silva
2020-03-01 23:42         ` Alastair D'Silva
2020-03-01 23:42         ` Alastair D'Silva
2020-03-02  5:38         ` Alastair D'Silva
2020-03-02  5:38           ` Alastair D'Silva
2020-03-02  5:38           ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 26/27] powerpc/powernv/pmem: Expose the firmware version " Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-03-02  7:35   ` Andrew Donnellan
2020-03-02  7:35     ` Andrew Donnellan
2020-03-02  7:35     ` Andrew Donnellan
2020-03-04  4:11     ` Alastair D'Silva
2020-03-04  4:11       ` Alastair D'Silva
2020-03-04  4:11       ` Alastair D'Silva
2020-02-21  3:27 ` [PATCH v3 27/27] MAINTAINERS: Add myself & nvdimm/ocxl to ocxl Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  3:27   ` Alastair D'Silva
2020-02-21  5:35   ` Andrew Donnellan
2020-02-21  5:35     ` Andrew Donnellan
2020-02-21  5:35     ` Andrew Donnellan
2020-02-21 16:21 ` [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices Dan Williams
2020-02-21 16:21   ` Dan Williams
2020-02-21 16:21   ` Dan Williams
2020-02-21 16:24   ` Dan Williams
2020-02-21 16:24     ` Dan Williams
2020-02-21 16:24     ` Dan Williams
2020-02-24  4:34   ` Alastair D'Silva
2020-02-24  4:34     ` Alastair D'Silva
2020-02-24  4:34     ` Alastair D'Silva
2020-02-24  4:37     ` Matthew Wilcox
2020-02-24  4:37       ` Matthew Wilcox
2020-02-24  4:37       ` Matthew Wilcox
2020-02-24  4:42       ` Alastair D'Silva
2020-02-24  4:42         ` Alastair D'Silva
2020-02-24  4:42         ` Alastair D'Silva
2020-02-24  6:51         ` Oliver O'Halloran
2020-02-24  6:51           ` Oliver O'Halloran
2020-02-24  6:51           ` Oliver O'Halloran
2020-02-26  0:13           ` Alastair D'Silva
2020-02-26  0:13             ` Alastair D'Silva
2020-02-26  0:13             ` Alastair D'Silva
2020-02-26  0:32             ` Dan Williams
2020-02-26  0:32               ` Dan Williams
2020-02-26  0:32               ` Dan Williams
2020-02-26  0:35               ` Alastair D'Silva
2020-02-26  0:35                 ` Alastair D'Silva
2020-02-26  0:35                 ` Alastair D'Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e68c9064-cb7f-2b5e-9a7b-70fd5367270a@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=aik@ozlabs.ru \
    --cc=akpm@linux-foundation.org \
    --cc=alastair@au1.ibm.com \
    --cc=alastair@d-silva.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=anju@linux.vnet.ibm.com \
    --cc=anton@ozlabs.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=clg@kaod.org \
    --cc=davem@davemloft.net \
    --cc=fbarrat@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groug@kaod.org \
    --cc=hbathini@linux.ibm.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.