* [PATCH] gnttab: silence table expansion message
@ 2018-06-26 7:22 Jan Beulich
2018-06-26 7:31 ` Wei Liu
2018-06-26 11:14 ` Andrew Cooper
0 siblings, 2 replies; 5+ messages in thread
From: Jan Beulich @ 2018-06-26 7:22 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Julien Grall
This currently shows up for basically every domain, when originally it
was logged only when going beyond the default table size. Restore that
behavior.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
req_nr_frames = INITIAL_NR_GRANT_FRAMES;
ASSERT(req_nr_frames <= gt->max_grant_frames);
- gdprintk(XENLOG_INFO,
- "Expanding d%d grant table from %u to %u frames\n",
- d->domain_id, nr_grant_frames(gt), req_nr_frames);
+ if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
+ gdprintk(XENLOG_INFO,
+ "Expanding d%d grant table from %u to %u frames\n",
+ d->domain_id, nr_grant_frames(gt), req_nr_frames);
/* Active */
for ( i = nr_active_grant_frames(gt);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gnttab: silence table expansion message
2018-06-26 7:22 [PATCH] gnttab: silence table expansion message Jan Beulich
@ 2018-06-26 7:31 ` Wei Liu
2018-06-26 11:14 ` Andrew Cooper
1 sibling, 0 replies; 5+ messages in thread
From: Wei Liu @ 2018-06-26 7:31 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Julien Grall, xen-devel
On Tue, Jun 26, 2018 at 01:22:01AM -0600, Jan Beulich wrote:
> This currently shows up for basically every domain, when originally it
> was logged only when going beyond the default table size. Restore that
> behavior.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnttab: silence table expansion message
2018-06-26 7:22 [PATCH] gnttab: silence table expansion message Jan Beulich
2018-06-26 7:31 ` Wei Liu
@ 2018-06-26 11:14 ` Andrew Cooper
2018-06-26 11:22 ` Paul Durrant
2018-06-26 11:44 ` Jan Beulich
1 sibling, 2 replies; 5+ messages in thread
From: Andrew Cooper @ 2018-06-26 11:14 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan,
Ian Jackson, Julien Grall
On 26/06/18 08:22, Jan Beulich wrote:
> This currently shows up for basically every domain, when originally it
> was logged only when going beyond the default table size. Restore that
> behavior.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
> req_nr_frames = INITIAL_NR_GRANT_FRAMES;
> ASSERT(req_nr_frames <= gt->max_grant_frames);
>
> - gdprintk(XENLOG_INFO,
> - "Expanding d%d grant table from %u to %u frames\n",
> - d->domain_id, nr_grant_frames(gt), req_nr_frames);
> + if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
> + gdprintk(XENLOG_INFO,
> + "Expanding d%d grant table from %u to %u frames\n",
> + d->domain_id, nr_grant_frames(gt), req_nr_frames);
This has been on my todo list for a while, but I'd go one stage further
and delete it fully.
Domains either never trigger it, or expand to max. It doesn't provide
any useful information at all.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnttab: silence table expansion message
2018-06-26 11:14 ` Andrew Cooper
@ 2018-06-26 11:22 ` Paul Durrant
2018-06-26 11:44 ` Jan Beulich
1 sibling, 0 replies; 5+ messages in thread
From: Paul Durrant @ 2018-06-26 11:22 UTC (permalink / raw)
To: Andrew Cooper, Jan Beulich, xen-devel
Cc: Stefano Stabellini, Wei Liu, Tim (Xen.org),
George Dunlap, Julien Grall, Ian Jackson
> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf
> Of Andrew Cooper
> Sent: 26 June 2018 12:15
> To: Jan Beulich <JBeulich@suse.com>; xen-devel <xen-
> devel@lists.xenproject.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>; Wei Liu
> <wei.liu2@citrix.com>; George Dunlap <George.Dunlap@citrix.com>; Tim
> (Xen.org) <tim@xen.org>; Ian Jackson <Ian.Jackson@citrix.com>; Julien Grall
> <julien.grall@arm.com>
> Subject: Re: [Xen-devel] [PATCH] gnttab: silence table expansion message
>
> On 26/06/18 08:22, Jan Beulich wrote:
> > This currently shows up for basically every domain, when originally it
> > was logged only when going beyond the default table size. Restore that
> > behavior.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > --- a/xen/common/grant_table.c
> > +++ b/xen/common/grant_table.c
> > @@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
> > req_nr_frames = INITIAL_NR_GRANT_FRAMES;
> > ASSERT(req_nr_frames <= gt->max_grant_frames);
> >
> > - gdprintk(XENLOG_INFO,
> > - "Expanding d%d grant table from %u to %u frames\n",
> > - d->domain_id, nr_grant_frames(gt), req_nr_frames);
> > + if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
> > + gdprintk(XENLOG_INFO,
> > + "Expanding d%d grant table from %u to %u frames\n",
> > + d->domain_id, nr_grant_frames(gt), req_nr_frames);
>
> This has been on my todo list for a while, but I'd go one stage further
> and delete it fully.
>
> Domains either never trigger it, or expand to max. It doesn't provide
> any useful information at all.
That's not entirely true. Windows PV drivers expand the grant table on demand, not straight to max. Having said that, they do their own logging so the extra noise from Xen is not useful.
Paul
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnttab: silence table expansion message
2018-06-26 11:14 ` Andrew Cooper
2018-06-26 11:22 ` Paul Durrant
@ 2018-06-26 11:44 ` Jan Beulich
1 sibling, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2018-06-26 11:44 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan,
Ian Jackson, Julien Grall, xen-devel
>>> On 26.06.18 at 13:14, <andrew.cooper3@citrix.com> wrote:
> On 26/06/18 08:22, Jan Beulich wrote:
>> This currently shows up for basically every domain, when originally it
>> was logged only when going beyond the default table size. Restore that
>> behavior.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
>> req_nr_frames = INITIAL_NR_GRANT_FRAMES;
>> ASSERT(req_nr_frames <= gt->max_grant_frames);
>>
>> - gdprintk(XENLOG_INFO,
>> - "Expanding d%d grant table from %u to %u frames\n",
>> - d->domain_id, nr_grant_frames(gt), req_nr_frames);
>> + if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
>> + gdprintk(XENLOG_INFO,
>> + "Expanding d%d grant table from %u to %u frames\n",
>> + d->domain_id, nr_grant_frames(gt), req_nr_frames);
>
> This has been on my todo list for a while, but I'd go one stage further
> and delete it fully.
>
> Domains either never trigger it, or expand to max. It doesn't provide
> any useful information at all.
I disagree - domains don't normally use all or nothing of grant tables.
And this (being a debug message only) may be a useful hint if a
domain not expected to use all of its grant table suddenly grows its
size significantly.
My main goal here really is to get rid of the 0 -> 1 transition message
(when starting a guest).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-26 11:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-26 7:22 [PATCH] gnttab: silence table expansion message Jan Beulich
2018-06-26 7:31 ` Wei Liu
2018-06-26 11:14 ` Andrew Cooper
2018-06-26 11:22 ` Paul Durrant
2018-06-26 11:44 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.