[Devel] NACK: [PATCH] Remove redundant assignment to ObjectType

[Devel] NACK: [PATCH] Remove redundant assignment to ObjectType

[Colin Ian King]

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

On 18/04/17 22:13, Colin King wrote:
> From: Colin Ian King <colin.king(a)canonical.com>
> 
> There are several occurrances of ObjectType being assigned
> twice successively and the first assignment is clearly
> unncessary and can hence be removed.  Remove the redundant
> assignments.
> 
> Signed-off-by: Colin Ian King <colin.king(a)canonical.com>
> ---
>  source/common/adwalk.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/source/common/adwalk.c b/source/common/adwalk.c
> index 22fbfe416..1841772a7 100644
> --- a/source/common/adwalk.c
> +++ b/source/common/adwalk.c
> @@ -747,7 +747,6 @@ AcpiDmLoadDescendingOp (
>  
>      WalkState = Info->WalkState;
>      OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      /* Only interested in operators that create new names */
> @@ -885,7 +884,6 @@ AcpiDmXrefDescendingOp (
>  
>      WalkState = Info->WalkState;
>      OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      if ((!(OpInfo->Flags & AML_NAMED)) &&
> @@ -1189,7 +1187,6 @@ AcpiDmCommonAscendingOp (
>      /* Close scope if necessary */
>  
>      OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      if (AcpiNsOpensScope (ObjectType))
> 
NACK this patch.  This causes a build warning on newer tool chains, I'll
send and updated patch that addresses the fix to remove a redundant
OpInfo to go with this change.

Colin