* [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)
@ 2021-06-30 11:52 Marcel Apfelbaum
2021-06-30 13:56 ` Yuval Shaia
2021-06-30 14:32 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2021-06-30 11:52 UTC (permalink / raw)
To: qemu-devel; +Cc: marcel, vv474172261, mcascell, pj.pandit, yuval.shaia.ml
Do not unmap uninitialized dma addresses.
Fixes: CVE-2021-3608
Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c
index 074ac59b84..42130667a7 100644
--- a/hw/rdma/vmw/pvrdma_dev_ring.c
+++ b/hw/rdma/vmw/pvrdma_dev_ring.c
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,
qatomic_set(&ring->ring_state->cons_head, 0);
*/
ring->npages = npages;
- ring->pages = g_malloc(npages * sizeof(void *));
+ ring->pages = g_malloc0(npages * sizeof(void *));
for (i = 0; i < npages; i++) {
if (!tbl[i]) {
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)
2021-06-30 11:52 [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608) Marcel Apfelbaum
@ 2021-06-30 13:56 ` Yuval Shaia
2021-06-30 14:32 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Shaia @ 2021-06-30 13:56 UTC (permalink / raw)
To: Marcel Apfelbaum
Cc: marcel, vv474172261, mcascell, pj.pandit, QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
On Wed, 30 Jun 2021 at 14:52, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
wrote:
> Do not unmap uninitialized dma addresses.
>
> Fixes: CVE-2021-3608
> Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
> Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c
> index 074ac59b84..42130667a7 100644
> --- a/hw/rdma/vmw/pvrdma_dev_ring.c
> +++ b/hw/rdma/vmw/pvrdma_dev_ring.c
> @@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name,
> PCIDevice *dev,
> qatomic_set(&ring->ring_state->cons_head, 0);
> */
> ring->npages = npages;
> - ring->pages = g_malloc(npages * sizeof(void *));
> + ring->pages = g_malloc0(npages * sizeof(void *));
>
>
Reviewed-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
Tested-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> for (i = 0; i < npages; i++) {
> if (!tbl[i]) {
> --
> 2.31.1
>
>
[-- Attachment #2: Type: text/html, Size: 2043 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)
2021-06-30 11:52 [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608) Marcel Apfelbaum
2021-06-30 13:56 ` Yuval Shaia
@ 2021-06-30 14:32 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-30 14:32 UTC (permalink / raw)
To: Marcel Apfelbaum, qemu-devel
Cc: marcel, vv474172261, mcascell, pj.pandit, yuval.shaia.ml
On 6/30/21 1:52 PM, Marcel Apfelbaum wrote:
> Do not unmap uninitialized dma addresses.
>
> Fixes: CVE-2021-3608
> Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
> Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-30 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 11:52 [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608) Marcel Apfelbaum
2021-06-30 13:56 ` Yuval Shaia
2021-06-30 14:32 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.