* [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir
@ 2019-09-25 12:37 Yunfeng Ye
2019-09-25 16:32 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Yunfeng Ye @ 2019-09-25 12:37 UTC (permalink / raw)
To: apw, mingo, joe; +Cc: linux-kernel
After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
the files"), we met some error messages:
./scripts/checkpatch.pl:
"Must be run from the top-level dir. of a kernel tree"
./scripts/get_maintainer.pl:
"The current directory does not appear to be a linux kernel source tree.
Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
scripts/checkpatch.pl | 2 +-
scripts/get_maintainer.pl | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 93a7edf..6117d0e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
my @tree_check = (
"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
"README", "Documentation", "arch", "include", "drivers",
- "fs", "init", "ipc", "kernel", "lib", "scripts",
+ "fs", "init", "kernel", "lib", "scripts",
);
foreach my $check (@tree_check) {
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 5ef5921..2e42aeb 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
&& (-d "${lk_path}drivers")
&& (-d "${lk_path}fs")
&& (-d "${lk_path}init")
- && (-d "${lk_path}ipc")
&& (-d "${lk_path}kernel")
&& (-d "${lk_path}lib")
&& (-d "${lk_path}scripts")) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir
2019-09-25 12:37 [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir Yunfeng Ye
@ 2019-09-25 16:32 ` Joe Perches
2019-09-26 1:18 ` Yunfeng Ye
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2019-09-25 16:32 UTC (permalink / raw)
To: Yunfeng Ye, apw, mingo, Andrew Morton; +Cc: linux-kernel
On Wed, 2019-09-25 at 20:37 +0800, Yunfeng Ye wrote:
> After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
> the files"), we met some error messages:
>
> ./scripts/checkpatch.pl:
> "Must be run from the top-level dir. of a kernel tree"
>
> ./scripts/get_maintainer.pl:
> "The current directory does not appear to be a linux kernel source tree.
>
> Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.
Thanks.
Maybe the commit subject could use "scripts:"
or something similar and not "toplevel:".
Trivially, it one day it'd be good to use the
same routine and output message too.
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
> scripts/checkpatch.pl | 2 +-
> scripts/get_maintainer.pl | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 93a7edf..6117d0e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> - "fs", "init", "ipc", "kernel", "lib", "scripts",
> + "fs", "init", "kernel", "lib", "scripts",
> );
>
> foreach my $check (@tree_check) {
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 5ef5921..2e42aeb 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
> && (-d "${lk_path}drivers")
> && (-d "${lk_path}fs")
> && (-d "${lk_path}init")
> - && (-d "${lk_path}ipc")
> && (-d "${lk_path}kernel")
> && (-d "${lk_path}lib")
> && (-d "${lk_path}scripts")) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir
2019-09-25 16:32 ` Joe Perches
@ 2019-09-26 1:18 ` Yunfeng Ye
0 siblings, 0 replies; 3+ messages in thread
From: Yunfeng Ye @ 2019-09-26 1:18 UTC (permalink / raw)
To: Joe Perches, apw, mingo, Andrew Morton; +Cc: linux-kernel
On 2019/9/26 0:32, Joe Perches wrote:
> On Wed, 2019-09-25 at 20:37 +0800, Yunfeng Ye wrote:
>> After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
>> the files"), we met some error messages:
>>
>> ./scripts/checkpatch.pl:
>> "Must be run from the top-level dir. of a kernel tree"
>>
>> ./scripts/get_maintainer.pl:
>> "The current directory does not appear to be a linux kernel source tree.
>>
>> Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.
>
> Thanks.
>
> Maybe the commit subject could use "scripts:"
> or something similar and not "toplevel:".
>The purpose of subject "toplevel" is to maintain consistency with previous
modification patches. ok, I will modify it, thanks.
> Trivially, it one day it'd be good to use the
> same routine and output message too.
>
>> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>> ---
>> scripts/checkpatch.pl | 2 +-
>> scripts/get_maintainer.pl | 1 -
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 93a7edf..6117d0e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
>> my @tree_check = (
>> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>> "README", "Documentation", "arch", "include", "drivers",
>> - "fs", "init", "ipc", "kernel", "lib", "scripts",
>> + "fs", "init", "kernel", "lib", "scripts",
>> );
>>
>> foreach my $check (@tree_check) {
>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
>> index 5ef5921..2e42aeb 100755
>> --- a/scripts/get_maintainer.pl
>> +++ b/scripts/get_maintainer.pl
>> @@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
>> && (-d "${lk_path}drivers")
>> && (-d "${lk_path}fs")
>> && (-d "${lk_path}init")
>> - && (-d "${lk_path}ipc")
>> && (-d "${lk_path}kernel")
>> && (-d "${lk_path}lib")
>> && (-d "${lk_path}scripts")) {
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-26 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 12:37 [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir Yunfeng Ye
2019-09-25 16:32 ` Joe Perches
2019-09-26 1:18 ` Yunfeng Ye
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.