All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] git-send-email.perl: Fixed sending of many changes/patches
@ 2015-09-29 15:00 Lars Wendler
  2015-09-29 15:43 ` Johannes Schindelin
  0 siblings, 1 reply; 2+ messages in thread
From: Lars Wendler @ 2015-09-29 15:00 UTC (permalink / raw)
  To: git; +Cc: juston.h.li, Stefan Agner, Lars Wendler

From: Stefan Agner <stefan@agner.ch>

See http://permalink.gmane.org/gmane.comp.version-control.git/274569

Reported-by: Juston Li <juston.h.li@gmail.com>
Tested-by: Markos Chandras <hwoarang@gentoo.org>
Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
---
 git-send-email.perl | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index e3ff44b..e907e0ea 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1365,7 +1365,11 @@ Message-Id: $message_id
 		$smtp->mail( $raw_from ) or die $smtp->message;
 		$smtp->to( @recipients ) or die $smtp->message;
 		$smtp->data or die $smtp->message;
-		$smtp->datasend("$header\n$message") or die $smtp->message;
+		$smtp->datasend("$header\n") or die $smtp->message;
+		my @lines = split /^/, $message;
+		foreach my $line (@lines) {
+			$smtp->datasend("$line") or die $smtp->message;
+		}
 		$smtp->dataend() or die $smtp->message;
 		$smtp->code =~ /250|200/ or die "Failed to send $subject\n".$smtp->message;
 	}
-- 
2.6.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] git-send-email.perl: Fixed sending of many changes/patches
  2015-09-29 15:00 [PATCH] git-send-email.perl: Fixed sending of many changes/patches Lars Wendler
@ 2015-09-29 15:43 ` Johannes Schindelin
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2015-09-29 15:43 UTC (permalink / raw)
  To: Lars Wendler; +Cc: git, juston.h.li, Stefan Agner

Hi Lars,

On 2015-09-29 17:00, Lars Wendler wrote:
> From: Stefan Agner <stefan@agner.ch>
> 
> See http://permalink.gmane.org/gmane.comp.version-control.git/274569

Please summarize the linked discussion in the commit message, as it is the convention here in the Git project to make commit messages self-sufficient, with links thrown in only to provide more context when desired.

Ciao,
Johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-29 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-29 15:00 [PATCH] git-send-email.perl: Fixed sending of many changes/patches Lars Wendler
2015-09-29 15:43 ` Johannes Schindelin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.