* [PATCH] Fix user-facing typo with an incorrect use of "it's"
@ 2021-03-23 1:30 Aru Sahni
2021-03-23 1:49 ` Mihai Moldovan
2021-03-26 17:05 ` Daniel Kiper
0 siblings, 2 replies; 4+ messages in thread
From: Aru Sahni @ 2021-03-23 1:30 UTC (permalink / raw)
To: grub-devel
This is my first attempted contribution to Grub. Please let me know if I need to
make any revisions or updates.
This patch does the following:
- Since the possessive form of "it" is being used, the apostrophe must be
omitted.
Signed-off-by: Aru Sahni <aru@arusahni.net>
---
util/grub.d/30_os-prober.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
index 946224812..5984e92d2 100644
--- a/util/grub.d/30_os-prober.in
+++ b/util/grub.d/30_os-prober.in
@@ -36,7 +36,7 @@ if ! command -v os-prober > /dev/null || ! command -v linux-boot-prober > /dev/n
exit 0
fi
-grub_warn "$(gettext_printf "os-prober will be executed to detect other bootable partitions.\nIt's output will be used to detect bootable binaries on them and create new boot entries.")"
+grub_warn "$(gettext_printf "os-prober will be executed to detect other bootable partitions.\nIts output will be used to detect bootable binaries on them and create new boot entries.")"
OSPROBED="`os-prober | tr ' ' '^' | paste -s -d ' '`"
if [ -z "${OSPROBED}" ] ; then
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix user-facing typo with an incorrect use of "it's"
2021-03-23 1:30 [PATCH] Fix user-facing typo with an incorrect use of "it's" Aru Sahni
@ 2021-03-23 1:49 ` Mihai Moldovan
2021-03-26 17:05 ` Daniel Kiper
1 sibling, 0 replies; 4+ messages in thread
From: Mihai Moldovan @ 2021-03-23 1:49 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1.1: Type: text/plain, Size: 291 bytes --]
* On 3/23/21 2:30 AM, Aru Sahni wrote:
> This is my first attempted contribution to Grub. Please let me know if I need to
> make any revisions or updates.
SOB, git-patch format, correct list and the bug is still around on the master
branch... everything looks good. :)
Mihai
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix user-facing typo with an incorrect use of "it's"
2021-03-23 1:30 [PATCH] Fix user-facing typo with an incorrect use of "it's" Aru Sahni
2021-03-23 1:49 ` Mihai Moldovan
@ 2021-03-26 17:05 ` Daniel Kiper
2021-03-27 1:26 ` Aru Sahni
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Kiper @ 2021-03-26 17:05 UTC (permalink / raw)
To: Aru Sahni; +Cc: grub-devel
On Mon, Mar 22, 2021 at 09:30:40PM -0400, Aru Sahni wrote:
> This is my first attempted contribution to Grub. Please let me know if I need to
> make any revisions or updates.
Except commit message, which I will fix for you, patch LGTM. Thank you.
> This patch does the following:
> - Since the possessive form of "it" is being used, the apostrophe must be
> omitted.
>
> Signed-off-by: Aru Sahni <aru@arusahni.net>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix user-facing typo with an incorrect use of "it's"
2021-03-26 17:05 ` Daniel Kiper
@ 2021-03-27 1:26 ` Aru Sahni
0 siblings, 0 replies; 4+ messages in thread
From: Aru Sahni @ 2021-03-27 1:26 UTC (permalink / raw)
To: Michael Chang via Grub-devel
Thank you!
~A
On Fri, Mar 26, 2021, at 1:05 PM, Daniel Kiper wrote:
> On Mon, Mar 22, 2021 at 09:30:40PM -0400, Aru Sahni wrote:
> > This is my first attempted contribution to Grub. Please let me know if I need to
> > make any revisions or updates.
>
> Except commit message, which I will fix for you, patch LGTM. Thank you.
>
> > This patch does the following:
> > - Since the possessive form of "it" is being used, the apostrophe must be
> > omitted.
> >
> > Signed-off-by: Aru Sahni <aru@arusahni.net <mailto:aru%40arusahni.net>>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com <mailto:daniel.kiper%40oracle.com>>
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org <mailto:Grub-devel%40gnu.org>
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-27 1:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 1:30 [PATCH] Fix user-facing typo with an incorrect use of "it's" Aru Sahni
2021-03-23 1:49 ` Mihai Moldovan
2021-03-26 17:05 ` Daniel Kiper
2021-03-27 1:26 ` Aru Sahni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.