[PATCH] drm/amd/pm: Enhanced reporting also for a stuck command

[PATCH] drm/amd/pm: Enhanced reporting also for a stuck command

[Luben Tuikov]

Also print the message index, parameter and message
type on a stuck command.

Cc: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 843d2cbfc71d4c..63cab6173206e2 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -141,7 +141,8 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
 	switch (reg_c2pmsg_90) {
 	case SMU_RESP_NONE:
 		dev_err_ratelimited(adev->dev,
-				    "SMU: I'm not done with your previous command!");
+				    "SMU: I'm not done with your previous command! Index:%d param:0x%08X message:%s",
+				    msg_index, param, message);
 		break;
 	case SMU_RESP_OK:
 		/* The SMU executed the command. It completed with a

base-commit: 14271bc7f5e7ec276c58927ea87af9e81d97fdf3
-- 
2.33.1.558.g2bd2f258f4

Re: [PATCH] drm/amd/pm: Enhanced reporting also for a stuck command

[Luben Tuikov]

Never mind--the index and param are for the new command we want to submit not the last.
Ignore.

Regards,
Luben

On 2021-11-10 15:12, Luben Tuikov wrote:
> Also print the message index, parameter and message
> type on a stuck command.
>
> Cc: Alex Deucher <Alexander.Deucher@amd.com>
> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 843d2cbfc71d4c..63cab6173206e2 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -141,7 +141,8 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
>  	switch (reg_c2pmsg_90) {
>  	case SMU_RESP_NONE:
>  		dev_err_ratelimited(adev->dev,
> -				    "SMU: I'm not done with your previous command!");
> +				    "SMU: I'm not done with your previous command! Index:%d param:0x%08X message:%s",
> +				    msg_index, param, message);
>  		break;
>  	case SMU_RESP_OK:
>  		/* The SMU executed the command. It completed with a
>
> base-commit: 14271bc7f5e7ec276c58927ea87af9e81d97fdf3

Re: [PATCH] drm/amd/pm: Enhanced reporting also for a stuck command

[Alex Deucher]

On Wed, Nov 10, 2021 at 4:02 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Also print the message index and parameter of the stuck command.
>
> Cc: Alex Deucher <Alexander.Deucher@amd.com>
> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 843d2cbfc71d4c..ea6f50c08c5f3b 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -139,9 +139,13 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
>         const char *message = smu_get_message_name(smu, msg);
>
>         switch (reg_c2pmsg_90) {
> -       case SMU_RESP_NONE:
> +       case SMU_RESP_NONE: {
> +               u32 msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> +               u32 prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
>                 dev_err_ratelimited(adev->dev,
> -                                   "SMU: I'm not done with your previous command!");
> +                                   "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
> +                                   msg_idx, prm);
> +       }
>                 break;
>         case SMU_RESP_OK:
>                 /* The SMU executed the command. It completed with a
>
> base-commit: 14271bc7f5e7ec276c58927ea87af9e81d97fdf3
> --
> 2.33.1.558.g2bd2f258f4
>

[PATCH] drm/amd/pm: Enhanced reporting also for a stuck command

[Luben Tuikov]

Also print the message index and parameter of the stuck command.

Cc: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 843d2cbfc71d4c..ea6f50c08c5f3b 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -139,9 +139,13 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
 	const char *message = smu_get_message_name(smu, msg);
 
 	switch (reg_c2pmsg_90) {
-	case SMU_RESP_NONE:
+	case SMU_RESP_NONE: {
+		u32 msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
+		u32 prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
 		dev_err_ratelimited(adev->dev,
-				    "SMU: I'm not done with your previous command!");
+				    "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
+				    msg_idx, prm);
+	}
 		break;
 	case SMU_RESP_OK:
 		/* The SMU executed the command. It completed with a

base-commit: 14271bc7f5e7ec276c58927ea87af9e81d97fdf3
-- 
2.33.1.558.g2bd2f258f4