From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> To: Rob Herring <robh@kernel.org> Cc: Bjorn Helgaas <bhelgaas@google.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Jingoo Han <jingoohan1@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu <masami.hiramatsu@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org> Subject: Re: [PATCH v2 4/5] PCI: uniphier: Add iATU register support Date: Tue, 2 Jun 2020 18:07:42 +0900 [thread overview] Message-ID: <e6e7de73-6a89-b0e9-a9b0-de353c4e3218@socionext.com> (raw) In-Reply-To: <20200601213215.GA1521885@bogus> Hi Rob, On 2020/06/02 6:32, Rob Herring wrote: > On Fri, May 15, 2020 at 06:59:02PM +0900, Kunihiko Hayashi wrote: >> This gets iATU register area from reg property. In Synopsis DWC version >> 4.80 or later, since iATU register area is separated from core register >> area, this area is necessary to get from DT independently. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c >> index a8dda39..493f105 100644 >> --- a/drivers/pci/controller/dwc/pcie-uniphier.c >> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c >> @@ -447,6 +447,13 @@ static int uniphier_pcie_probe(struct platform_device *pdev) >> if (IS_ERR(priv->pci.dbi_base)) >> return PTR_ERR(priv->pci.dbi_base); >> >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu"); >> + if (res) { >> + priv->pci.atu_base = devm_pci_remap_cfg_resource(dev, res); > > This isn't config space, so this function shouldn't be used. > > Use devm_platform_ioremap_resource_byname(). Indeed. I'll replace with it. >> + if (IS_ERR(priv->pci.atu_base)) >> + priv->pci.atu_base = NULL; >> + } >> + >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link"); >> priv->base = devm_ioremap_resource(dev, res); > > Feel free to convert this one too. This should be replaced as well. Thank you, --- Best Regards Kunihiko Hayashi
WARNING: multiple messages have this Message-ID (diff)
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Masami Hiramatsu <masami.hiramatsu@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org>, Jingoo Han <jingoohan1@gmail.com>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/5] PCI: uniphier: Add iATU register support Date: Tue, 2 Jun 2020 18:07:42 +0900 [thread overview] Message-ID: <e6e7de73-6a89-b0e9-a9b0-de353c4e3218@socionext.com> (raw) In-Reply-To: <20200601213215.GA1521885@bogus> Hi Rob, On 2020/06/02 6:32, Rob Herring wrote: > On Fri, May 15, 2020 at 06:59:02PM +0900, Kunihiko Hayashi wrote: >> This gets iATU register area from reg property. In Synopsis DWC version >> 4.80 or later, since iATU register area is separated from core register >> area, this area is necessary to get from DT independently. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c >> index a8dda39..493f105 100644 >> --- a/drivers/pci/controller/dwc/pcie-uniphier.c >> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c >> @@ -447,6 +447,13 @@ static int uniphier_pcie_probe(struct platform_device *pdev) >> if (IS_ERR(priv->pci.dbi_base)) >> return PTR_ERR(priv->pci.dbi_base); >> >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu"); >> + if (res) { >> + priv->pci.atu_base = devm_pci_remap_cfg_resource(dev, res); > > This isn't config space, so this function shouldn't be used. > > Use devm_platform_ioremap_resource_byname(). Indeed. I'll replace with it. >> + if (IS_ERR(priv->pci.atu_base)) >> + priv->pci.atu_base = NULL; >> + } >> + >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link"); >> priv->base = devm_ioremap_resource(dev, res); > > Feel free to convert this one too. This should be replaced as well. Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-02 9:07 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-15 9:58 [PATCH v2 0/5] PCI: uniphier: Add features for UniPhier PCIe host controller Kunihiko Hayashi 2020-05-15 9:58 ` Kunihiko Hayashi 2020-05-15 9:58 ` [PATCH v2 1/5] PCI: dwc: Add msi_host_isr() callback Kunihiko Hayashi 2020-05-15 9:58 ` Kunihiko Hayashi 2020-05-15 13:20 ` Gustavo Pimentel 2020-05-15 13:20 ` Gustavo Pimentel 2020-05-15 9:59 ` [PATCH v2 2/5] PCI: uniphier: Add misc interrupt handler to invoke PME and AER Kunihiko Hayashi 2020-05-15 9:59 ` Kunihiko Hayashi 2020-05-15 13:21 ` Gustavo Pimentel 2020-05-15 13:21 ` Gustavo Pimentel 2020-05-15 9:59 ` [PATCH v2 3/5] dt-bindings: PCI: uniphier: Add iATU register description Kunihiko Hayashi 2020-05-15 9:59 ` Kunihiko Hayashi 2020-05-28 19:25 ` Rob Herring 2020-05-28 19:25 ` Rob Herring 2020-05-15 9:59 ` [PATCH v2 4/5] PCI: uniphier: Add iATU register support Kunihiko Hayashi 2020-05-15 9:59 ` Kunihiko Hayashi 2020-05-15 13:16 ` Gustavo Pimentel 2020-05-15 13:16 ` Gustavo Pimentel 2020-05-18 10:05 ` Kunihiko Hayashi 2020-05-18 10:05 ` Kunihiko Hayashi 2020-06-01 21:32 ` Rob Herring 2020-06-01 21:32 ` Rob Herring 2020-06-02 9:07 ` Kunihiko Hayashi [this message] 2020-06-02 9:07 ` Kunihiko Hayashi 2020-05-15 9:59 ` [PATCH v2 5/5] PCI: uniphier: Add error message when failed to get phy Kunihiko Hayashi 2020-05-15 9:59 ` Kunihiko Hayashi 2020-06-01 21:43 ` Rob Herring 2020-06-01 21:43 ` Rob Herring 2020-06-02 9:07 ` Kunihiko Hayashi 2020-06-02 9:07 ` Kunihiko Hayashi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e6e7de73-6a89-b0e9-a9b0-de353c4e3218@socionext.com \ --to=hayashi.kunihiko@socionext.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gustavo.pimentel@synopsys.com \ --cc=jaswinder.singh@linaro.org \ --cc=jingoohan1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=masami.hiramatsu@linaro.org \ --cc=robh@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.