All of lore.kernel.org
 help / color / mirror / Atom feed
* Questions about commit f2fs: fix to avoid broken of dnode block list
@ 2018-07-04  4:34 Xu, Wen
  2018-07-04  6:58 ` Chao Yu
  0 siblings, 1 reply; 2+ messages in thread
From: Xu, Wen @ 2018-07-04  4:34 UTC (permalink / raw)
  To: Chao Yu; +Cc: linux-f2fs-devel

Hi Chao,

https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=f2fs-dev&id=0ac2890156ab517a8ac79849ee5abab7ad60310b

In this patch: f2fs: fix to avoid broken of dnode block list
-int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
+int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi)

You modify f2fs_wait_on_node_pages_writeback() in file.c but seems not modifying the declaration in f2fs.h? Which makes compilation failed…

Thanks,
-Wen
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Questions about commit f2fs: fix to avoid broken of dnode block list
  2018-07-04  4:34 Questions about commit f2fs: fix to avoid broken of dnode block list Xu, Wen
@ 2018-07-04  6:58 ` Chao Yu
  0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-07-04  6:58 UTC (permalink / raw)
  To: Xu, Wen; +Cc: linux-f2fs-devel

Hi Wen,

On 2018/7/4 12:34, Xu, Wen wrote:
> Hi Chao,
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=f2fs-dev&id=0ac2890156ab517a8ac79849ee5abab7ad60310b
> 
> In this patch: f2fs: fix to avoid broken of dnode block list
> -int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
> +int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi)
> 
> You modify f2fs_wait_on_node_pages_writeback() in file.c but seems not modifying the declaration in f2fs.h? Which makes compilation failed…

Sorry, my mistake, it added definition change located in f2fs.h into incorrect
patch when I split one patch to below two:

f2fs: let checkpoint flush dnode page of regular
f2fs: fix to avoid broken of dnode block list

I will update them, thanks for your report. :)

Thanks,

> 
> Thanks,
> -Wen
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-04  6:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04  4:34 Questions about commit f2fs: fix to avoid broken of dnode block list Xu, Wen
2018-07-04  6:58 ` Chao Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.