* [PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init
@ 2022-05-12 12:19 Miaoqian Lin
2022-05-12 13:59 ` Akhil P Oommen
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-12 12:19 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Abhinav Kumar, David Airlie, Daniel Vetter,
Akhil P Oommen, Dmitry Baryshkov, Jonathan Marek, Jordan Crouse,
linux-arm-msm, dri-devel, freedreno, linux-kernel
Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
a6xx_gmu_init() passes the node to of_find_device_by_node()
and of_dma_configure(), of_find_device_by_node() will takes its
reference, of_dma_configure() doesn't need the node after usage.
Add missing of_node_put() to avoid refcount leak.
Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index ccc4fcf7a630..a8f6d73197b1 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1919,6 +1919,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
BUG_ON(!node);
ret = a6xx_gmu_init(a6xx_gpu, node);
+ of_node_put(node);
if (ret) {
a6xx_destroy(&(a6xx_gpu->base.base));
return ERR_PTR(ret);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init
2022-05-12 12:19 [PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init Miaoqian Lin
@ 2022-05-12 13:59 ` Akhil P Oommen
0 siblings, 0 replies; 2+ messages in thread
From: Akhil P Oommen @ 2022-05-12 13:59 UTC (permalink / raw)
To: Miaoqian Lin, Rob Clark, Sean Paul, Abhinav Kumar, David Airlie,
Daniel Vetter, Dmitry Baryshkov, Jonathan Marek, Jordan Crouse,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 5/12/2022 5:49 PM, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
>
> a6xx_gmu_init() passes the node to of_find_device_by_node()
> and of_dma_configure(), of_find_device_by_node() will takes its
> reference, of_dma_configure() doesn't need the node after usage.
>
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index ccc4fcf7a630..a8f6d73197b1 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1919,6 +1919,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
> BUG_ON(!node);
>
> ret = a6xx_gmu_init(a6xx_gpu, node);
> + of_node_put(node);
> if (ret) {
> a6xx_destroy(&(a6xx_gpu->base.base));
> return ERR_PTR(ret);
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
-Akhil.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-12 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 12:19 [PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init Miaoqian Lin
2022-05-12 13:59 ` Akhil P Oommen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.