* [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-19 15:54 ` Tvrtko Ursulin
0 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-19 15:54 UTC (permalink / raw)
To: igt-dev, Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Avoid trying to dereference null engines on exit when there are either
none which are supported, or kernel does not have i915 PMU support.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7aa233570463..517dc2995d26 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
};
unsigned int i;
+ if (!engines)
+ return;
+
for (pmu = &free_list[0]; *pmu; pmu++) {
if ((*pmu)->present)
free((char *)(*pmu)->units);
@@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
"Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
strerror(errno));
ret = EXIT_FAILURE;
- goto err;
+ goto err_engines;
}
ret = pmu_init(engines);
@@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
"More information can be found at 'Perf events and tool security' document:\n"
"https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
ret = EXIT_FAILURE;
- goto err;
+ goto err_pmu;
}
ret = EXIT_SUCCESS;
@@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
free_clients(clients);
free(codename);
-err:
+err_pmu:
free_engines(engines);
+err_engines:
free(pmu_device);
exit:
igt_devices_free();
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-19 15:54 ` Tvrtko Ursulin
0 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-19 15:54 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Avoid trying to dereference null engines on exit when there are either
none which are supported, or kernel does not have i915 PMU support.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7aa233570463..517dc2995d26 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
};
unsigned int i;
+ if (!engines)
+ return;
+
for (pmu = &free_list[0]; *pmu; pmu++) {
if ((*pmu)->present)
free((char *)(*pmu)->units);
@@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
"Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
strerror(errno));
ret = EXIT_FAILURE;
- goto err;
+ goto err_engines;
}
ret = pmu_init(engines);
@@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
"More information can be found at 'Perf events and tool security' document:\n"
"https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
ret = EXIT_FAILURE;
- goto err;
+ goto err_pmu;
}
ret = EXIT_SUCCESS;
@@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
free_clients(clients);
free(codename);
-err:
+err_pmu:
free_engines(engines);
+err_engines:
free(pmu_device);
exit:
igt_devices_free();
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
(?)
@ 2023-01-19 16:18 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-01-19 16:18 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4333 bytes --]
== Series Details ==
Series: intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
URL : https://patchwork.freedesktop.org/series/113096/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613 -> IGTPW_8375
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
Participating hosts (38 -> 36)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8375 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/fi-apl-guc/igt@gem_lmem_swapping@basic.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-apl-guc: NOTRUN -> [SKIP][2] ([fdo#109271]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/fi-apl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- {bat-adlp-6}: [DMESG-FAIL][3] ([i915#7699]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-adlp-6/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][5] ([i915#6367]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-rpls-1/igt@i915_selftest@live@slpc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-n3050: [FAIL][7] ([i915#6298]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3:
- {bat-dg2-9}: [FAIL][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-apl-guc: [DMESG-WARN][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/fi-apl-guc/igt@prime_self_import@basic-with_one_bo_two_files.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/fi-apl-guc/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7126 -> IGTPW_8375
CI-20190529: 20190529
CI_DRM_12613: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8375: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
IGT_7126: 3aa9364a1e478010aba0d3dfe9183486560ecc60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
[-- Attachment #2: Type: text/html, Size: 4839 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
(?)
(?)
@ 2023-01-20 13:53 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-01-20 13:53 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 18507 bytes --]
== Series Details ==
Series: intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
URL : https://patchwork.freedesktop.org/series/113096/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613_full -> IGTPW_8375_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
Participating hosts (12 -> 7)
------------------------------
Missing (5): pig-kbl-iris shard-tglu shard-tglu-10 shard-tglu-9 pig-skl-6260u
Known issues
------------
Here are the changes found in IGTPW_8375_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][5] -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#79])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
* igt@perf@oa-exponents:
- shard-glk: [PASS][13] -> [INCOMPLETE][14] ([i915#5213])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk9/igt@perf@oa-exponents.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk8/igt@perf@oa-exponents.html
* igt@runner@aborted:
- shard-glk: NOTRUN -> [FAIL][15] ([i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk8/igt@runner@aborted.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#7742]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@fbdev@pan:
- {shard-rkl}: [SKIP][18] ([i915#2582]) -> [PASS][19] +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-2/igt@fbdev@pan.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@fbdev@pan.html
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][20] ([i915#7052]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@gem_eio@suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-5/igt@gem_eio@suspend.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23] +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk5/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][24] ([i915#3281]) -> [PASS][25] +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@gem_exec_reloc@basic-write-read-active.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gem_pread@bench:
- {shard-rkl}: [SKIP][26] ([i915#3282]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@gem_pread@bench.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-5/igt@gem_pread@bench.html
* igt@gen9_exec_parse@basic-rejected:
- {shard-rkl}: [SKIP][28] ([i915#2527]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-6/igt@gen9_exec_parse@basic-rejected.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-5/igt@gen9_exec_parse@basic-rejected.html
* igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: [SKIP][30] ([i915#658]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@i915_pm_dc@dc5-psr.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][32] ([i915#6537]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-apl7/igt@i915_pm_rps@engine-order.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][34] ([i915#5334]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk2/igt@i915_selftest@live@gt_heartbeat.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-glk1/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@fence-restore-untiled:
- {shard-rkl}: [FAIL][36] ([fdo#103375]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@i915_suspend@fence-restore-untiled.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-1/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_atomic@plane-overlay-legacy:
- {shard-rkl}: [SKIP][38] ([i915#1845] / [i915#4098]) -> [PASS][39] +24 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-5/igt@kms_atomic@plane-overlay-legacy.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@kms_atomic@plane-overlay-legacy.html
* igt@kms_fbcon_fbt@psr:
- {shard-rkl}: [SKIP][40] ([fdo#110189] / [i915#3955]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-5/igt@kms_fbcon_fbt@psr.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@kms_fbcon_fbt@psr.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][42] ([i915#1849] / [i915#4098]) -> [PASS][43] +10 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-badstride.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][44] ([i915#1072]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-4/igt@kms_psr@sprite_plane_onoff.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- {shard-rkl}: [SKIP][46] ([i915#4098]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][48] ([fdo#109289]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-rkl-4/igt@perf@gen12-oa-tlb-invalidate.html
* igt@sysfs_timeslice_duration@timeout@bcs0:
- {shard-dg1}: [FAIL][50] ([i915#1755]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-dg1-14/igt@sysfs_timeslice_duration@timeout@bcs0.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/shard-dg1-16/igt@sysfs_timeslice_duration@timeout@bcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7126 -> IGTPW_8375
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12613: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8375: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
IGT_7126: 3aa9364a1e478010aba0d3dfe9183486560ecc60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8375/index.html
[-- Attachment #2: Type: text/html, Size: 13440 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
@ 2023-01-20 14:29 ` Das, Nirmoy
-1 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-20 14:29 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
Hi Tvrtko,
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Avoid trying to dereference null engines on exit when there are either
> none which are supported, or kernel does not have i915 PMU support.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/intel_gpu_top.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 7aa233570463..517dc2995d26 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
> };
> unsigned int i;
>
> + if (!engines)
> + return;
> +
This check should happen before the struct pmu_counter free_list
generation.
Regards,
Nirmoy
> for (pmu = &free_list[0]; *pmu; pmu++) {
> if ((*pmu)->present)
> free((char *)(*pmu)->units);
> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
> strerror(errno));
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_engines;
> }
>
> ret = pmu_init(engines);
> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
> "More information can be found at 'Perf events and tool security' document:\n"
> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_pmu;
> }
>
> ret = EXIT_SUCCESS;
> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
> free_clients(clients);
>
> free(codename);
> -err:
> +err_pmu:
> free_engines(engines);
> +err_engines:
> free(pmu_device);
> exit:
> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-20 14:29 ` Das, Nirmoy
0 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-20 14:29 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
Hi Tvrtko,
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Avoid trying to dereference null engines on exit when there are either
> none which are supported, or kernel does not have i915 PMU support.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/intel_gpu_top.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 7aa233570463..517dc2995d26 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
> };
> unsigned int i;
>
> + if (!engines)
> + return;
> +
This check should happen before the struct pmu_counter free_list
generation.
Regards,
Nirmoy
> for (pmu = &free_list[0]; *pmu; pmu++) {
> if ((*pmu)->present)
> free((char *)(*pmu)->units);
> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
> strerror(errno));
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_engines;
> }
>
> ret = pmu_init(engines);
> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
> "More information can be found at 'Perf events and tool security' document:\n"
> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_pmu;
> }
>
> ret = EXIT_SUCCESS;
> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
> free_clients(clients);
>
> free(codename);
> -err:
> +err_pmu:
> free_engines(engines);
> +err_engines:
> free(pmu_device);
> exit:
> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-20 14:29 ` [igt-dev] " Das, Nirmoy
@ 2023-01-23 10:24 ` Tvrtko Ursulin
-1 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-23 10:24 UTC (permalink / raw)
To: Das, Nirmoy, igt-dev, Intel-gfx
On 20/01/2023 14:29, Das, Nirmoy wrote:
> Hi Tvrtko,
>
> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Avoid trying to dereference null engines on exit when there are either
>> none which are supported, or kernel does not have i915 PMU support.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>> tools/intel_gpu_top.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 7aa233570463..517dc2995d26 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>> };
>> unsigned int i;
>> + if (!engines)
>> + return;
>> +
>
>
> This check should happen before the struct pmu_counter free_list
> generation.
I could, but it doesn't have to, not sure what reasons for should you
have in mind?
Regards,
Tvrtko
>
> Regards,
>
> Nirmoy
>
>> for (pmu = &free_list[0]; *pmu; pmu++) {
>> if ((*pmu)->present)
>> free((char *)(*pmu)->units);
>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer
>> is required for i915 PMU support.)\n",
>> strerror(errno));
>> ret = EXIT_FAILURE;
>> - goto err;
>> + goto err_engines;
>> }
>> ret = pmu_init(engines);
>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>> "More information can be found at 'Perf events and tool security'
>> document:\n"
>>
>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>> ret = EXIT_FAILURE;
>> - goto err;
>> + goto err_pmu;
>> }
>> ret = EXIT_SUCCESS;
>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>> free_clients(clients);
>> free(codename);
>> -err:
>> +err_pmu:
>> free_engines(engines);
>> +err_engines:
>> free(pmu_device);
>> exit:
>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-23 10:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-23 10:24 UTC (permalink / raw)
To: Das, Nirmoy, igt-dev, Intel-gfx
On 20/01/2023 14:29, Das, Nirmoy wrote:
> Hi Tvrtko,
>
> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Avoid trying to dereference null engines on exit when there are either
>> none which are supported, or kernel does not have i915 PMU support.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>> tools/intel_gpu_top.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 7aa233570463..517dc2995d26 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>> };
>> unsigned int i;
>> + if (!engines)
>> + return;
>> +
>
>
> This check should happen before the struct pmu_counter free_list
> generation.
I could, but it doesn't have to, not sure what reasons for should you
have in mind?
Regards,
Tvrtko
>
> Regards,
>
> Nirmoy
>
>> for (pmu = &free_list[0]; *pmu; pmu++) {
>> if ((*pmu)->present)
>> free((char *)(*pmu)->units);
>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer
>> is required for i915 PMU support.)\n",
>> strerror(errno));
>> ret = EXIT_FAILURE;
>> - goto err;
>> + goto err_engines;
>> }
>> ret = pmu_init(engines);
>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>> "More information can be found at 'Perf events and tool security'
>> document:\n"
>>
>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>> ret = EXIT_FAILURE;
>> - goto err;
>> + goto err_pmu;
>> }
>> ret = EXIT_SUCCESS;
>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>> free_clients(clients);
>> free(codename);
>> -err:
>> +err_pmu:
>> free_engines(engines);
>> +err_engines:
>> free(pmu_device);
>> exit:
>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-23 10:24 ` [igt-dev] " Tvrtko Ursulin
@ 2023-01-23 11:09 ` Das, Nirmoy
-1 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:09 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
Hi Tvrtko,
On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote:
>
> On 20/01/2023 14:29, Das, Nirmoy wrote:
>> Hi Tvrtko,
>>
>> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Avoid trying to dereference null engines on exit when there are either
>>> none which are supported, or kernel does not have i915 PMU support.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> ---
>>> tools/intel_gpu_top.c | 10 +++++++---
>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>>> index 7aa233570463..517dc2995d26 100644
>>> --- a/tools/intel_gpu_top.c
>>> +++ b/tools/intel_gpu_top.c
>>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>>> };
>>> unsigned int i;
>>> + if (!engines)
>>> + return;
>>> +
>>
>>
>> This check should happen before the struct pmu_counter free_list
>> generation.
>
> I could, but it doesn't have to, not sure what reasons for should you
> have in mind?
In my tree, I see:
"
static void free_engines(struct engines *engines)
{
struct pmu_counter **pmu, *free_list[] = {
&engines->r_gpu,
&engines->r_pkg,
&engines->imc_reads,
&engines->imc_writes,
NULL
};
unsigned int i;
"
Maybe I am missing something here, wouldn't those dereferences of
"engines" segfault if the engines is NULL.
Regards,
Nirmoy
>
> Regards,
>
> Tvrtko
>
>>
>> Regards,
>>
>> Nirmoy
>>
>>> for (pmu = &free_list[0]; *pmu; pmu++) {
>>> if ((*pmu)->present)
>>> free((char *)(*pmu)->units);
>>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>>> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer
>>> is required for i915 PMU support.)\n",
>>> strerror(errno));
>>> ret = EXIT_FAILURE;
>>> - goto err;
>>> + goto err_engines;
>>> }
>>> ret = pmu_init(engines);
>>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>>> "More information can be found at 'Perf events and tool security'
>>> document:\n"
>>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>>> ret = EXIT_FAILURE;
>>> - goto err;
>>> + goto err_pmu;
>>> }
>>> ret = EXIT_SUCCESS;
>>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>>> free_clients(clients);
>>> free(codename);
>>> -err:
>>> +err_pmu:
>>> free_engines(engines);
>>> +err_engines:
>>> free(pmu_device);
>>> exit:
>>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-23 11:09 ` Das, Nirmoy
0 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:09 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
Hi Tvrtko,
On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote:
>
> On 20/01/2023 14:29, Das, Nirmoy wrote:
>> Hi Tvrtko,
>>
>> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Avoid trying to dereference null engines on exit when there are either
>>> none which are supported, or kernel does not have i915 PMU support.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> ---
>>> tools/intel_gpu_top.c | 10 +++++++---
>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>>> index 7aa233570463..517dc2995d26 100644
>>> --- a/tools/intel_gpu_top.c
>>> +++ b/tools/intel_gpu_top.c
>>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>>> };
>>> unsigned int i;
>>> + if (!engines)
>>> + return;
>>> +
>>
>>
>> This check should happen before the struct pmu_counter free_list
>> generation.
>
> I could, but it doesn't have to, not sure what reasons for should you
> have in mind?
In my tree, I see:
"
static void free_engines(struct engines *engines)
{
struct pmu_counter **pmu, *free_list[] = {
&engines->r_gpu,
&engines->r_pkg,
&engines->imc_reads,
&engines->imc_writes,
NULL
};
unsigned int i;
"
Maybe I am missing something here, wouldn't those dereferences of
"engines" segfault if the engines is NULL.
Regards,
Nirmoy
>
> Regards,
>
> Tvrtko
>
>>
>> Regards,
>>
>> Nirmoy
>>
>>> for (pmu = &free_list[0]; *pmu; pmu++) {
>>> if ((*pmu)->present)
>>> free((char *)(*pmu)->units);
>>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>>> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer
>>> is required for i915 PMU support.)\n",
>>> strerror(errno));
>>> ret = EXIT_FAILURE;
>>> - goto err;
>>> + goto err_engines;
>>> }
>>> ret = pmu_init(engines);
>>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>>> "More information can be found at 'Perf events and tool security'
>>> document:\n"
>>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>>> ret = EXIT_FAILURE;
>>> - goto err;
>>> + goto err_pmu;
>>> }
>>> ret = EXIT_SUCCESS;
>>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>>> free_clients(clients);
>>> free(codename);
>>> -err:
>>> +err_pmu:
>>> free_engines(engines);
>>> +err_engines:
>>> free(pmu_device);
>>> exit:
>>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-23 11:09 ` [igt-dev] " Das, Nirmoy
@ 2023-01-23 11:13 ` Das, Nirmoy
-1 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:13 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
On 1/23/2023 12:09 PM, Das, Nirmoy wrote:
> Hi Tvrtko,
>
> On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote:
>>
>> On 20/01/2023 14:29, Das, Nirmoy wrote:
>>> Hi Tvrtko,
>>>
>>> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Avoid trying to dereference null engines on exit when there are either
>>>> none which are supported, or kernel does not have i915 PMU support.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> ---
>>>> tools/intel_gpu_top.c | 10 +++++++---
>>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>>>> index 7aa233570463..517dc2995d26 100644
>>>> --- a/tools/intel_gpu_top.c
>>>> +++ b/tools/intel_gpu_top.c
>>>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>>>> };
>>>> unsigned int i;
>>>> + if (!engines)
>>>> + return;
>>>> +
>>>
>>>
>>> This check should happen before the struct pmu_counter free_list
>>> generation.
>>
>> I could, but it doesn't have to, not sure what reasons for should you
>> have in mind?
>
> In my tree, I see:
>
> "
>
> static void free_engines(struct engines *engines)
>
> {
> struct pmu_counter **pmu, *free_list[] = {
> &engines->r_gpu,
> &engines->r_pkg,
> &engines->imc_reads,
> &engines->imc_writes,
> NULL
> };
>
> unsigned int i;
>
> "
>
> Maybe I am missing something here, wouldn't those dereferences of
> "engines" segfault if the engines is NULL.
Ah never mind it shouldn't matter.
>
>
> Regards,
>
> Nirmoy
>
>>
>> Regards,
>>
>> Tvrtko
>>
>>>
>>> Regards,
>>>
>>> Nirmoy
>>>
>>>> for (pmu = &free_list[0]; *pmu; pmu++) {
>>>> if ((*pmu)->present)
>>>> free((char *)(*pmu)->units);
>>>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>>>> "Failed to detect engines! (%s)\n(Kernel 4.16 or
>>>> newer is required for i915 PMU support.)\n",
>>>> strerror(errno));
>>>> ret = EXIT_FAILURE;
>>>> - goto err;
>>>> + goto err_engines;
>>>> }
>>>> ret = pmu_init(engines);
>>>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>>>> "More information can be found at 'Perf events and tool security'
>>>> document:\n"
>>>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>>>>
>>>> ret = EXIT_FAILURE;
>>>> - goto err;
>>>> + goto err_pmu;
>>>> }
>>>> ret = EXIT_SUCCESS;
>>>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>>>> free_clients(clients);
>>>> free(codename);
>>>> -err:
>>>> +err_pmu:
>>>> free_engines(engines);
>>>> +err_engines:
>>>> free(pmu_device);
>>>> exit:
>>>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-23 11:13 ` Das, Nirmoy
0 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:13 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
On 1/23/2023 12:09 PM, Das, Nirmoy wrote:
> Hi Tvrtko,
>
> On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote:
>>
>> On 20/01/2023 14:29, Das, Nirmoy wrote:
>>> Hi Tvrtko,
>>>
>>> On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Avoid trying to dereference null engines on exit when there are either
>>>> none which are supported, or kernel does not have i915 PMU support.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> ---
>>>> tools/intel_gpu_top.c | 10 +++++++---
>>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>>>> index 7aa233570463..517dc2995d26 100644
>>>> --- a/tools/intel_gpu_top.c
>>>> +++ b/tools/intel_gpu_top.c
>>>> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
>>>> };
>>>> unsigned int i;
>>>> + if (!engines)
>>>> + return;
>>>> +
>>>
>>>
>>> This check should happen before the struct pmu_counter free_list
>>> generation.
>>
>> I could, but it doesn't have to, not sure what reasons for should you
>> have in mind?
>
> In my tree, I see:
>
> "
>
> static void free_engines(struct engines *engines)
>
> {
> struct pmu_counter **pmu, *free_list[] = {
> &engines->r_gpu,
> &engines->r_pkg,
> &engines->imc_reads,
> &engines->imc_writes,
> NULL
> };
>
> unsigned int i;
>
> "
>
> Maybe I am missing something here, wouldn't those dereferences of
> "engines" segfault if the engines is NULL.
Ah never mind it shouldn't matter.
>
>
> Regards,
>
> Nirmoy
>
>>
>> Regards,
>>
>> Tvrtko
>>
>>>
>>> Regards,
>>>
>>> Nirmoy
>>>
>>>> for (pmu = &free_list[0]; *pmu; pmu++) {
>>>> if ((*pmu)->present)
>>>> free((char *)(*pmu)->units);
>>>> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
>>>> "Failed to detect engines! (%s)\n(Kernel 4.16 or
>>>> newer is required for i915 PMU support.)\n",
>>>> strerror(errno));
>>>> ret = EXIT_FAILURE;
>>>> - goto err;
>>>> + goto err_engines;
>>>> }
>>>> ret = pmu_init(engines);
>>>> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
>>>> "More information can be found at 'Perf events and tool security'
>>>> document:\n"
>>>> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
>>>>
>>>> ret = EXIT_FAILURE;
>>>> - goto err;
>>>> + goto err_pmu;
>>>> }
>>>> ret = EXIT_SUCCESS;
>>>> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
>>>> free_clients(clients);
>>>> free(codename);
>>>> -err:
>>>> +err_pmu:
>>>> free_engines(engines);
>>>> +err_engines:
>>>> free(pmu_device);
>>>> exit:
>>>> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
@ 2023-01-23 11:15 ` Das, Nirmoy
-1 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:15 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Avoid trying to dereference null engines on exit when there are either
> none which are supported, or kernel does not have i915 PMU support.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tools/intel_gpu_top.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 7aa233570463..517dc2995d26 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
> };
> unsigned int i;
>
> + if (!engines)
> + return;
> +
> for (pmu = &free_list[0]; *pmu; pmu++) {
> if ((*pmu)->present)
> free((char *)(*pmu)->units);
> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
> strerror(errno));
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_engines;
> }
>
> ret = pmu_init(engines);
> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
> "More information can be found at 'Perf events and tool security' document:\n"
> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_pmu;
> }
>
> ret = EXIT_SUCCESS;
> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
> free_clients(clients);
>
> free(codename);
> -err:
> +err_pmu:
> free_engines(engines);
> +err_engines:
> free(pmu_device);
> exit:
> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-23 11:15 ` Das, Nirmoy
0 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-01-23 11:15 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev, Intel-gfx
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Avoid trying to dereference null engines on exit when there are either
> none which are supported, or kernel does not have i915 PMU support.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tools/intel_gpu_top.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 7aa233570463..517dc2995d26 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -448,6 +448,9 @@ static void free_engines(struct engines *engines)
> };
> unsigned int i;
>
> + if (!engines)
> + return;
> +
> for (pmu = &free_list[0]; *pmu; pmu++) {
> if ((*pmu)->present)
> free((char *)(*pmu)->units);
> @@ -2568,7 +2571,7 @@ int main(int argc, char **argv)
> "Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
> strerror(errno));
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_engines;
> }
>
> ret = pmu_init(engines);
> @@ -2585,7 +2588,7 @@ int main(int argc, char **argv)
> "More information can be found at 'Perf events and tool security' document:\n"
> "https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
> ret = EXIT_FAILURE;
> - goto err;
> + goto err_pmu;
> }
>
> ret = EXIT_SUCCESS;
> @@ -2699,8 +2702,9 @@ int main(int argc, char **argv)
> free_clients(clients);
>
> free(codename);
> -err:
> +err_pmu:
> free_engines(engines);
> +err_engines:
> free(pmu_device);
> exit:
> igt_devices_free();
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH i-g-t v2] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
@ 2023-01-23 11:31 ` Tvrtko Ursulin
-1 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-23 11:31 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Nirmoy Das
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Avoid trying to dereference null engines on exit when there are either
none which are supported, or kernel does not have i915 PMU support.
Also fix a memory leak on the same failure path just so Valgrind runs are
quite.
v2:
* Fix a memory leak in the same failure mode too.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com> # v1
---
tools/intel_gpu_top.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7aa233570463..0a1de41b3374 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -340,7 +340,7 @@ static struct engines *discover_engines(char *device)
d = opendir(sysfs_root);
if (!d)
- return NULL;
+ goto err;
while ((dent = readdir(d)) != NULL) {
const char *endswith = "-busy";
@@ -423,10 +423,8 @@ static struct engines *discover_engines(char *device)
}
if (ret) {
- free(engines);
errno = ret;
-
- return NULL;
+ goto err;
}
qsort(engine_ptr(engines, 0), engines->num_engines,
@@ -435,6 +433,11 @@ static struct engines *discover_engines(char *device)
engines->root = d;
return engines;
+
+err:
+ free(engines);
+
+ return NULL;
}
static void free_engines(struct engines *engines)
@@ -448,6 +451,9 @@ static void free_engines(struct engines *engines)
};
unsigned int i;
+ if (!engines)
+ return;
+
for (pmu = &free_list[0]; *pmu; pmu++) {
if ((*pmu)->present)
free((char *)(*pmu)->units);
@@ -2568,7 +2574,7 @@ int main(int argc, char **argv)
"Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
strerror(errno));
ret = EXIT_FAILURE;
- goto err;
+ goto err_engines;
}
ret = pmu_init(engines);
@@ -2585,7 +2591,7 @@ int main(int argc, char **argv)
"More information can be found at 'Perf events and tool security' document:\n"
"https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
ret = EXIT_FAILURE;
- goto err;
+ goto err_pmu;
}
ret = EXIT_SUCCESS;
@@ -2699,8 +2705,9 @@ int main(int argc, char **argv)
free_clients(clients);
free(codename);
-err:
+err_pmu:
free_engines(engines);
+err_engines:
free(pmu_device);
exit:
igt_devices_free();
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU
@ 2023-01-23 11:31 ` Tvrtko Ursulin
0 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2023-01-23 11:31 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Nirmoy Das, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Avoid trying to dereference null engines on exit when there are either
none which are supported, or kernel does not have i915 PMU support.
Also fix a memory leak on the same failure path just so Valgrind runs are
quite.
v2:
* Fix a memory leak in the same failure mode too.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com> # v1
---
tools/intel_gpu_top.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7aa233570463..0a1de41b3374 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -340,7 +340,7 @@ static struct engines *discover_engines(char *device)
d = opendir(sysfs_root);
if (!d)
- return NULL;
+ goto err;
while ((dent = readdir(d)) != NULL) {
const char *endswith = "-busy";
@@ -423,10 +423,8 @@ static struct engines *discover_engines(char *device)
}
if (ret) {
- free(engines);
errno = ret;
-
- return NULL;
+ goto err;
}
qsort(engine_ptr(engines, 0), engines->num_engines,
@@ -435,6 +433,11 @@ static struct engines *discover_engines(char *device)
engines->root = d;
return engines;
+
+err:
+ free(engines);
+
+ return NULL;
}
static void free_engines(struct engines *engines)
@@ -448,6 +451,9 @@ static void free_engines(struct engines *engines)
};
unsigned int i;
+ if (!engines)
+ return;
+
for (pmu = &free_list[0]; *pmu; pmu++) {
if ((*pmu)->present)
free((char *)(*pmu)->units);
@@ -2568,7 +2574,7 @@ int main(int argc, char **argv)
"Failed to detect engines! (%s)\n(Kernel 4.16 or newer is required for i915 PMU support.)\n",
strerror(errno));
ret = EXIT_FAILURE;
- goto err;
+ goto err_engines;
}
ret = pmu_init(engines);
@@ -2585,7 +2591,7 @@ int main(int argc, char **argv)
"More information can be found at 'Perf events and tool security' document:\n"
"https://www.kernel.org/doc/html/latest/admin-guide/perf-security.html\n");
ret = EXIT_FAILURE;
- goto err;
+ goto err_pmu;
}
ret = EXIT_SUCCESS;
@@ -2699,8 +2705,9 @@ int main(int argc, char **argv)
free_clients(clients);
free(codename);
-err:
+err_pmu:
free_engines(engines);
+err_engines:
free(pmu_device);
exit:
igt_devices_free();
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top: Fix cleanup on old kernels / unsupported GPU (rev2)
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
` (5 preceding siblings ...)
(?)
@ 2023-01-23 14:48 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-01-23 14:48 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4011 bytes --]
== Series Details ==
Series: intel_gpu_top: Fix cleanup on old kernels / unsupported GPU (rev2)
URL : https://patchwork.freedesktop.org/series/113096/
State : success
== Summary ==
CI Bug Log - changes from IGT_7133 -> IGTPW_8393
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
Participating hosts (39 -> 37)
------------------------------
Missing (2): fi-rkl-11600 fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8393 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([i915#4817])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/fi-bsw-kefka/igt@i915_suspend@basic-s2idle-without-i915.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/fi-bsw-kefka/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic:
- fi-bsw-kefka: [PASS][5] -> [FAIL][6] ([i915#2346])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/fi-bsw-kefka/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/fi-bsw-kefka/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][7] ([i915#4983]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/bat-rpls-2/igt@i915_selftest@live@reset.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-n3050: [FAIL][9] ([i915#6298]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7834]: https://gitlab.freedesktop.org/drm/intel/issues/7834
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7133 -> IGTPW_8393
CI-20190529: 20190529
CI_DRM_12622: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8393: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
IGT_7133: e2d9f472e7a1dd0de43d25e15588dd43e28bb2de @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
[-- Attachment #2: Type: text/html, Size: 4260 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for intel_gpu_top: Fix cleanup on old kernels / unsupported GPU (rev2)
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
` (6 preceding siblings ...)
(?)
@ 2023-01-24 2:53 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-01-24 2:53 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 22917 bytes --]
== Series Details ==
Series: intel_gpu_top: Fix cleanup on old kernels / unsupported GPU (rev2)
URL : https://patchwork.freedesktop.org/series/113096/
State : success
== Summary ==
CI Bug Log - changes from IGT_7133_full -> IGTPW_8393_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8393_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_ccs@block-copy-inplace:
- {shard-rkl}: [SKIP][1] ([i915#3555] / [i915#5325]) -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-2/igt@gem_ccs@block-copy-inplace.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gem_ccs@block-copy-inplace.html
Known issues
------------
Here are the changes found in IGTPW_8393_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-glk9/igt@gem_exec_fair@basic-none@vecs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-glk4/igt@gem_exec_fair@basic-none@vecs0.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-glk1/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][6] ([i915#7742]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-1/igt@drm_fdinfo@virtual-idle.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
* igt@fbdev@write:
- {shard-rkl}: [SKIP][8] ([i915#2582]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-3/igt@fbdev@write.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@fbdev@write.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][10] ([i915#2846]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][12] ([i915#2842]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- {shard-rkl}: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@gem_exec_fair@basic-none-vip@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- {shard-rkl}: [SKIP][16] ([i915#3281]) -> [PASS][17] +9 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-3/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}: [SKIP][18] ([i915#7276]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@gem_exec_schedule@semaphore-power.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_flink_race@flink_close:
- shard-apl: [FAIL][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-apl6/igt@gem_flink_race@flink_close.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-apl2/igt@gem_flink_race@flink_close.html
* igt@gem_partial_pwrite_pread@write-uncached:
- {shard-rkl}: [SKIP][22] ([i915#3282]) -> [PASS][23] +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@gem_partial_pwrite_pread@write-uncached.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gem_partial_pwrite_pread@write-uncached.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][24] ([i915#5566] / [i915#716]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-glk7/igt@gen9_exec_parse@allowed-single.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-glk6/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@valid-registers:
- {shard-rkl}: [SKIP][26] ([i915#2527]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-1/igt@gen9_exec_parse@valid-registers.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@gen9_exec_parse@valid-registers.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][28] ([i915#4281]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-3/igt@i915_pm_dc@dc9-dpms.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
- shard-apl: [SKIP][30] ([fdo#109271]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][32] ([i915#1849]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@i915_pm_rpm@cursor.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@i915_pm_rpm@cursor.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][34] ([i915#6537]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-apl3/igt@i915_pm_rps@engine-order.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-rkl}: [SKIP][36] ([i915#1845] / [i915#4098]) -> [PASS][37] +17 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@kms_big_fb@linear-32bpp-rotate-0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][38] ([i915#2346]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
- {shard-tglu}: [SKIP][40] ([i915#1849]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-tglu-2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- {shard-rkl}: [SKIP][42] ([i915#1849] / [i915#4098]) -> [PASS][43] +14 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][44] ([i915#1072]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@kms_psr@sprite_mmap_gtt.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- {shard-rkl}: [SKIP][46] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-1/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- {shard-tglu}: [SKIP][48] ([fdo#109274]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-tglu-2/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
* igt@kms_vblank@pipe-a-wait-forked-busy-hang:
- {shard-tglu}: [SKIP][50] ([i915#1845] / [i915#7651]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-tglu-6/igt@kms_vblank@pipe-a-wait-forked-busy-hang.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-tglu-7/igt@kms_vblank@pipe-a-wait-forked-busy-hang.html
* igt@kms_vblank@pipe-c-query-forked-busy:
- {shard-tglu}: [SKIP][52] ([i915#7651]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-tglu-6/igt@kms_vblank@pipe-c-query-forked-busy.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-tglu-4/igt@kms_vblank@pipe-c-query-forked-busy.html
* igt@perf@gen12-mi-rpc:
- {shard-rkl}: [SKIP][54] ([fdo#109289]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-5/igt@perf@gen12-mi-rpc.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-2/igt@perf@gen12-mi-rpc.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][56] ([i915#1722]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-4/igt@perf@polling-small-buf.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@perf@polling-small-buf.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][58] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-5/igt@prime_vgem@basic-fence-flip.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][60] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-3/igt@prime_vgem@coherency-gtt.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][62] ([i915#4098]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7133/shard-rkl-3/igt@testdisplay.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5507]: https://gitlab.freedesktop.org/drm/intel/issues/5507
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7133 -> IGTPW_8393
CI-20190529: 20190529
CI_DRM_12622: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8393: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
IGT_7133: e2d9f472e7a1dd0de43d25e15588dd43e28bb2de @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8393/index.html
[-- Attachment #2: Type: text/html, Size: 16805 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-01-24 2:53 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 15:54 [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU Tvrtko Ursulin
2023-01-19 15:54 ` [igt-dev] " Tvrtko Ursulin
2023-01-19 16:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-01-20 13:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-01-20 14:29 ` [Intel-gfx] [PATCH i-g-t] " Das, Nirmoy
2023-01-20 14:29 ` [igt-dev] " Das, Nirmoy
2023-01-23 10:24 ` Tvrtko Ursulin
2023-01-23 10:24 ` [igt-dev] " Tvrtko Ursulin
2023-01-23 11:09 ` Das, Nirmoy
2023-01-23 11:09 ` [igt-dev] " Das, Nirmoy
2023-01-23 11:13 ` Das, Nirmoy
2023-01-23 11:13 ` [igt-dev] " Das, Nirmoy
2023-01-23 11:15 ` Das, Nirmoy
2023-01-23 11:15 ` [igt-dev] " Das, Nirmoy
2023-01-23 11:31 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
2023-01-23 11:31 ` [igt-dev] " Tvrtko Ursulin
2023-01-23 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top: Fix cleanup on old kernels / unsupported GPU (rev2) Patchwork
2023-01-24 2:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.