* [PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual
@ 2020-03-04 4:06 Parav Pandit
2020-03-04 4:06 ` [PATCH net-next iproute2 1/2] Update devlink kernel header Parav Pandit
2020-03-04 4:06 ` [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual Parav Pandit
0 siblings, 2 replies; 8+ messages in thread
From: Parav Pandit @ 2020-03-04 4:06 UTC (permalink / raw)
To: netdev; +Cc: stephen, dsahern, jiri, parav
Currently PCI PF and VF devlink devices register their ports as
physical port in non-representors mode.
Introduce a new port flavour as virtual so that virtual devices can
register 'virtual' flavour to make it more clear to users.
An example of one PCI PF and 2 PCI virtual functions, each having
one devlink port.
$ devlink port show
pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0
Parav Pandit (2):
Update devlink kernel header
devlink: Introduce devlink port flavour virtual
devlink/devlink.c | 2 ++
include/uapi/linux/devlink.h | 3 +++
2 files changed, 5 insertions(+)
--
2.19.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next iproute2 1/2] Update devlink kernel header
2020-03-04 4:06 [PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual Parav Pandit
@ 2020-03-04 4:06 ` Parav Pandit
2020-03-06 0:42 ` Jacob Keller
2020-03-04 4:06 ` [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual Parav Pandit
1 sibling, 1 reply; 8+ messages in thread
From: Parav Pandit @ 2020-03-04 4:06 UTC (permalink / raw)
To: netdev; +Cc: stephen, dsahern, jiri, parav
Update devlink kernel header to commit:
acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")
Signed-off-by: Parav Pandit <parav@mellanox.com>
---
include/uapi/linux/devlink.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 3f82dedd..1b412281 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -187,6 +187,7 @@ enum devlink_port_flavour {
* for the PCI VF. It is an internal
* port that faces the PCI VF.
*/
+ DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
};
enum devlink_param_cmode {
@@ -252,6 +253,8 @@ enum devlink_trap_type {
enum {
/* Trap can report input port as metadata */
DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
+ /* Trap can report flow action cookie as metadata */
+ DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
};
enum devlink_attr {
--
2.19.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual
2020-03-04 4:06 [PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual Parav Pandit
2020-03-04 4:06 ` [PATCH net-next iproute2 1/2] Update devlink kernel header Parav Pandit
@ 2020-03-04 4:06 ` Parav Pandit
2020-03-04 19:48 ` David Ahern
1 sibling, 1 reply; 8+ messages in thread
From: Parav Pandit @ 2020-03-04 4:06 UTC (permalink / raw)
To: netdev; +Cc: stephen, dsahern, jiri, parav
Currently PCI PF and VF devlink devices register their ports as
physical port in non-representors mode.
Introduce a new port flavour as virtual so that virtual devices can
register 'virtual' flavour to make it more clear to users.
An example of one PCI PF and 2 PCI virtual functions, each having
one devlink port.
$ devlink port show
pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
---
devlink/devlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 6e2115b6..ea9f54c9 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -3150,6 +3150,8 @@ static const char *port_flavour_name(uint16_t flavour)
return "pcipf";
case DEVLINK_PORT_FLAVOUR_PCI_VF:
return "pcivf";
+ case DEVLINK_PORT_FLAVOUR_VIRTUAL:
+ return "virtual";
default:
return "<unknown flavour>";
}
--
2.19.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual
2020-03-04 4:06 ` [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual Parav Pandit
@ 2020-03-04 19:48 ` David Ahern
0 siblings, 0 replies; 8+ messages in thread
From: David Ahern @ 2020-03-04 19:48 UTC (permalink / raw)
To: Parav Pandit, netdev; +Cc: stephen, dsahern, jiri
On 3/3/20 9:06 PM, Parav Pandit wrote:
> Currently PCI PF and VF devlink devices register their ports as
> physical port in non-representors mode.
>
> Introduce a new port flavour as virtual so that virtual devices can
> register 'virtual' flavour to make it more clear to users.
>
> An example of one PCI PF and 2 PCI virtual functions, each having
> one devlink port.
>
> $ devlink port show
> pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0
> pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0
> pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0
>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> ---
> devlink/devlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
applied to iproute2-next. Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next iproute2 1/2] Update devlink kernel header
2020-03-04 4:06 ` [PATCH net-next iproute2 1/2] Update devlink kernel header Parav Pandit
@ 2020-03-06 0:42 ` Jacob Keller
2020-03-06 0:43 ` David Ahern
2020-03-06 0:44 ` Jacob Keller
0 siblings, 2 replies; 8+ messages in thread
From: Jacob Keller @ 2020-03-06 0:42 UTC (permalink / raw)
To: Parav Pandit, netdev; +Cc: stephen, dsahern, jiri
On 3/3/2020 8:06 PM, Parav Pandit wrote:
> Update devlink kernel header to commit:
> acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")
>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> ---
> include/uapi/linux/devlink.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index 3f82dedd..1b412281 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -187,6 +187,7 @@ enum devlink_port_flavour {
> * for the PCI VF. It is an internal
> * port that faces the PCI VF.
> */
> + DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
> };
>
> enum devlink_param_cmode {
> @@ -252,6 +253,8 @@ enum devlink_trap_type {
> enum {
> /* Trap can report input port as metadata */
> DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
> + /* Trap can report flow action cookie as metadata */
> + DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
> };
>
This hunk doesn't seem relevant to the patch and isn't mentioned in the
subject or description.
Thanks,
Jake
> enum devlink_attr {
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next iproute2 1/2] Update devlink kernel header
2020-03-06 0:42 ` Jacob Keller
@ 2020-03-06 0:43 ` David Ahern
2020-03-06 0:55 ` Jacob Keller
2020-03-06 0:44 ` Jacob Keller
1 sibling, 1 reply; 8+ messages in thread
From: David Ahern @ 2020-03-06 0:43 UTC (permalink / raw)
To: Jacob Keller, Parav Pandit, netdev; +Cc: stephen, dsahern, jiri
On 3/5/20 5:42 PM, Jacob Keller wrote:
> This hunk doesn't seem relevant to the patch and isn't mentioned in the
> subject or description.
it was a sync of the header file. I drop those changes and do full uapi
sync for iproute2 and then apply patches.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next iproute2 1/2] Update devlink kernel header
2020-03-06 0:42 ` Jacob Keller
2020-03-06 0:43 ` David Ahern
@ 2020-03-06 0:44 ` Jacob Keller
1 sibling, 0 replies; 8+ messages in thread
From: Jacob Keller @ 2020-03-06 0:44 UTC (permalink / raw)
To: Parav Pandit, netdev; +Cc: stephen, dsahern, jiri
On 3/5/2020 4:42 PM, Jacob Keller wrote:
>
>
> On 3/3/2020 8:06 PM, Parav Pandit wrote:
>> Update devlink kernel header to commit:
>> acf1ee44ca5d ("devlink: Introduce devlink port flavour virtual")
>>
>> Signed-off-by: Parav Pandit <parav@mellanox.com>
>> ---
>> include/uapi/linux/devlink.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>> index 3f82dedd..1b412281 100644
>> --- a/include/uapi/linux/devlink.h
>> +++ b/include/uapi/linux/devlink.h
>> @@ -187,6 +187,7 @@ enum devlink_port_flavour {
>> * for the PCI VF. It is an internal
>> * port that faces the PCI VF.
>> */
>> + DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
>> };
>>
>> enum devlink_param_cmode {
>> @@ -252,6 +253,8 @@ enum devlink_trap_type {
>> enum {
>> /* Trap can report input port as metadata */
>> DEVLINK_ATTR_TRAP_METADATA_TYPE_IN_PORT,
>> + /* Trap can report flow action cookie as metadata */
>> + DEVLINK_ATTR_TRAP_METADATA_TYPE_FA_COOKIE,
>> };
>>
>
> This hunk doesn't seem relevant to the patch and isn't mentioned in the
> subject or description.
>
> Thanks,
> Jake
Oops, disregard this. This is just the kernel header update, which is
fine. Just hadn't expected to see it, and it didn't grok the first time
I looked at this.
Thanks,
Jake
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next iproute2 1/2] Update devlink kernel header
2020-03-06 0:43 ` David Ahern
@ 2020-03-06 0:55 ` Jacob Keller
0 siblings, 0 replies; 8+ messages in thread
From: Jacob Keller @ 2020-03-06 0:55 UTC (permalink / raw)
To: David Ahern, Parav Pandit, netdev; +Cc: stephen, dsahern, jiri
On 3/5/2020 4:43 PM, David Ahern wrote:
> On 3/5/20 5:42 PM, Jacob Keller wrote:
>> This hunk doesn't seem relevant to the patch and isn't mentioned in the
>> subject or description.
>
> it was a sync of the header file. I drop those changes and do full uapi
> sync for iproute2 and then apply patches.
>
Makes sense. Thanks for the explanation.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-06 0:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 4:06 [PATCH net-next iproute2 0/2] devlink: Introduce devlink port flavour virtual Parav Pandit
2020-03-04 4:06 ` [PATCH net-next iproute2 1/2] Update devlink kernel header Parav Pandit
2020-03-06 0:42 ` Jacob Keller
2020-03-06 0:43 ` David Ahern
2020-03-06 0:55 ` Jacob Keller
2020-03-06 0:44 ` Jacob Keller
2020-03-04 4:06 ` [PATCH net-next iproute2 2/2] devlink: Introduce devlink port flavour virtual Parav Pandit
2020-03-04 19:48 ` David Ahern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.